)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"b6fe8d864a3fa0bca2ccc70d1f6050c13608a38c","unresolved":false,"context_lines":[{"line_number":10,"context_line":"returning \u0027context.project_id\u0027 specific consistency groups from"},{"line_number":11,"context_line":"cinder.groups instead of required project specific groups i.e."},{"line_number":12,"context_line":"irrespective of filters (\u0027all_tenants\u0027,\u0027project_id\u0027) being passed"},{"line_number":13,"context_line":"it is returning context.project_id groups."},{"line_number":14,"context_line":"Closes-Bug: #1671220"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I553aab33c01f1e5b0053172e86d276ccfabf4952"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1a1ced50_3959895b","line":13,"updated":"2017-03-17 19:11:12.000000000","message":"Need a blank line before the bug number please.","commit_id":"110f7a31d2976943e01d36635372e552f9fc63a2"}],"cinder/api/contrib/consistencygroups.py":[{"author":{"_account_id":20191,"name":"Dinesh Bhor","email":"bhordinesh07@gmail.com","username":"dineshbhor"},"change_message_id":"d3ce74396f0d632665f4cf5bf726c27f24145ce2","unresolved":false,"context_lines":[{"line_number":134,"context_line":""},{"line_number":135,"context_line":"        # make another copy of filters, since it is being modified in"},{"line_number":136,"context_line":"        # consistencygroup_api while getting consistencygroups"},{"line_number":137,"context_line":"        group_filters \u003d req.params.copy()"},{"line_number":138,"context_line":"        marker, limit, offset \u003d common.get_pagination_params(filters)"},{"line_number":139,"context_line":"        sort_keys, sort_dirs \u003d common.get_sort_params(filters)"},{"line_number":140,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a1ced50_fa5a5682","line":137,"range":{"start_line":137,"start_character":34,"end_line":137,"end_character":41},"updated":"2017-03-20 13:18:31.000000000","message":"I think this is what you mean to say here: \n\ncopy.deepcopy(req.params)","commit_id":"1a6518d4b3d3e5ea6b7e46c2c53f2e1c32669a71"},{"author":{"_account_id":24005,"name":"prashkre","email":"prashkre@in.ibm.com","username":"prashkre"},"change_message_id":"5fb7be742bb00da48ef22237cfe89b89d8d518b7","unresolved":false,"context_lines":[{"line_number":134,"context_line":""},{"line_number":135,"context_line":"        # make another copy of filters, since it is being modified in"},{"line_number":136,"context_line":"        # consistencygroup_api while getting consistencygroups"},{"line_number":137,"context_line":"        group_filters \u003d req.params.copy()"},{"line_number":138,"context_line":"        marker, limit, offset \u003d common.get_pagination_params(filters)"},{"line_number":139,"context_line":"        sort_keys, sort_dirs \u003d common.get_sort_params(filters)"},{"line_number":140,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a1ced50_58aa8d71","line":137,"range":{"start_line":137,"start_character":34,"end_line":137,"end_character":41},"in_reply_to":"1a1ced50_fa5a5682","updated":"2017-03-20 15:39:30.000000000","message":"Thanks Dinesh for pointing this. Here it is shallow copy of req.params(of dict type) because I don\u0027t see need for deep copy of req.params. If there is a need for copy of compound objects in req.pramas we need deep copy but I believe we always get params only in key value pairs of simple objects.","commit_id":"1a6518d4b3d3e5ea6b7e46c2c53f2e1c32669a71"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"afd93e66cb0013893e53a64a23a9ecbef59c3991","unresolved":false,"context_lines":[{"line_number":134,"context_line":""},{"line_number":135,"context_line":"        # make another copy of filters, since it is being modified in"},{"line_number":136,"context_line":"        # consistencygroup_api while getting consistencygroups"},{"line_number":137,"context_line":"        group_filters \u003d req.params.copy()"},{"line_number":138,"context_line":"        marker, limit, offset \u003d common.get_pagination_params(filters)"},{"line_number":139,"context_line":"        sort_keys, sort_dirs \u003d common.get_sort_params(filters)"},{"line_number":140,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1a1ced50_181f3060","line":137,"updated":"2017-03-20 17:06:15.000000000","message":"The call to consistencygroup_api will be removed by the following patch:\n\nhttps://review.openstack.org/#/c/446018/5/cinder/api/contrib/consistencygroups.py","commit_id":"e1d4e5f295b9e1586ee80f548843fe8788a7b950"}],"releasenotes/notes/bug-1671220-4d521be71d0b8aa4.yaml":[{"author":{"_account_id":20191,"name":"Dinesh Bhor","email":"bhordinesh07@gmail.com","username":"dineshbhor"},"change_message_id":"d3ce74396f0d632665f4cf5bf726c27f24145ce2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    This fixes issue with consistency groups API which is always"},{"line_number":5,"context_line":"    returning \u0027context.project_id\u0027 specific consistency groups from"},{"line_number":6,"context_line":"    cinder.groups instead of required project specific groups i.e."},{"line_number":7,"context_line":"    irrespective of filters (\u0027all_tenants\u0027,\u0027project_id\u0027) being passed"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1a1ced50_fae8967e","line":4,"range":{"start_line":4,"start_character":55,"end_line":4,"end_character":57},"updated":"2017-03-20 13:18:31.000000000","message":"s/is/was","commit_id":"1a6518d4b3d3e5ea6b7e46c2c53f2e1c32669a71"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"fc83883ce7b02eb2f37b575585227e18ddba0c88","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    This fixes issue with consistency groups API which was always"},{"line_number":5,"context_line":"    returning \u0027context.project_id\u0027 specific consistency groups from"},{"line_number":6,"context_line":"    cinder.groups instead of required project specific groups i.e."},{"line_number":7,"context_line":"    irrespective of filters (\u0027all_tenants\u0027,\u0027project_id\u0027) being passed"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1a1ced50_2a1d69bd","line":4,"updated":"2017-03-20 21:44:32.000000000","message":"I think the patch looks fine, but this release note needs to be updated I think. This is discussing internal details and it is phrased in the context of this patchset. Release notes are for operators and/or API consumers, so discussing things like \"this returns context.project_id\" is just confusing and will have no meaning to that audience. It also should not be phrased as \"This fixes issue\".\n\nI think it needs to be reworded to something along the lines of \"Fixed issue where the incorrect project ID was being returned when filtering\", or similar.","commit_id":"e1d4e5f295b9e1586ee80f548843fe8788a7b950"},{"author":{"_account_id":24005,"name":"prashkre","email":"prashkre@in.ibm.com","username":"prashkre"},"change_message_id":"b8878167962105dcb0b6e98bf8191874fe836919","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    This fixes issue with consistency groups API which was always"},{"line_number":5,"context_line":"    returning \u0027context.project_id\u0027 specific consistency groups from"},{"line_number":6,"context_line":"    cinder.groups instead of required project specific groups i.e."},{"line_number":7,"context_line":"    irrespective of filters (\u0027all_tenants\u0027,\u0027project_id\u0027) being passed"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1a1ced50_cf077a1a","line":4,"in_reply_to":"1a1ced50_2a1d69bd","updated":"2017-03-21 06:50:59.000000000","message":"Sean McGinnis: Thanks for your comment. I have updated on this please review it again.","commit_id":"e1d4e5f295b9e1586ee80f548843fe8788a7b950"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"28c7bd9c0fdcccf2b883a935baa610872e371ae2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixed consistency groups API to filter groups based on the input"},{"line_number":5,"context_line":"    project_id."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"1a1ced50_44ac358c","line":5,"range":{"start_line":4,"start_character":0,"end_line":5,"end_character":15},"updated":"2017-03-21 15:57:16.000000000","message":"This is closer to what a user would need to know.  I think, however, it would help to explain what functionality the user currently sees versus what they will see when the fix is applied.","commit_id":"15da0ee1c2218c5fed27b7f89b3d636e594e4bf1"}]}