)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"bc3dc77755a7bbb96626719c68a44eb0bc52b81c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"ScaleIO: Fixing support for SIO 1.3x"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"A few changes necessary to make driver compatible with"},{"line_number":10,"context_line":"Scale version 1.3x"},{"line_number":11,"context_line":"- refactored SIO REST calls to go through common code"},{"line_number":12,"context_line":"- obtain REST API version number dynamically"},{"line_number":13,"context_line":"- allow conifuration to override what API version to use"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ffe62b97_77062489","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":5},"updated":"2017-03-27 04:27:12.000000000","message":"ScaleIO","commit_id":"ee03d7603f4f4853a9962d2dbea645d259187633"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"bc3dc77755a7bbb96626719c68a44eb0bc52b81c","unresolved":false,"context_lines":[{"line_number":10,"context_line":"Scale version 1.3x"},{"line_number":11,"context_line":"- refactored SIO REST calls to go through common code"},{"line_number":12,"context_line":"- obtain REST API version number dynamically"},{"line_number":13,"context_line":"- allow conifuration to override what API version to use"},{"line_number":14,"context_line":"- Make API calls based upon API version"},{"line_number":15,"context_line":"- Add unit tests to validate calls to retrieve version"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ffe62b97_17035875","line":13,"range":{"start_line":13,"start_character":8,"end_line":13,"end_character":20},"updated":"2017-03-27 04:27:12.000000000","message":"configuration","commit_id":"ee03d7603f4f4853a9962d2dbea645d259187633"}],"cinder/tests/unit/volume/drivers/dell_emc/scaleio/test_versions.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"bc3dc77755a7bbb96626719c68a44eb0bc52b81c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2013 - 2015 EMC Corporation."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":3,"id":"ffe62b97_b7482ccc","line":1,"range":{"start_line":1,"start_character":2,"end_line":1,"end_character":44},"updated":"2017-03-27 04:27:12.000000000","message":"Please use the following copyright header for new files:\n\nCopyright (C) 2017 Dell Inc. or its subsidiaries.","commit_id":"ee03d7603f4f4853a9962d2dbea645d259187633"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"bc3dc77755a7bbb96626719c68a44eb0bc52b81c","unresolved":false,"context_lines":[{"line_number":33,"context_line":"                    \u0027.6\u0027"},{"line_number":34,"context_line":"                    ]"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    \"\"\"Test cases for ``ScaleIODriver._get_server_api_version()``\"\"\""},{"line_number":37,"context_line":"    def setUp(self):"},{"line_number":38,"context_line":"        \"\"\"Setup a test case environment."},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ffe62b97_577c40ea","line":36,"range":{"start_line":36,"start_character":4,"end_line":36,"end_character":68},"updated":"2017-03-27 04:27:12.000000000","message":"# Test cases for ``ScaleIODriver._get_server_api_version()``","commit_id":"ee03d7603f4f4853a9962d2dbea645d259187633"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"bc3dc77755a7bbb96626719c68a44eb0bc52b81c","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    \"\"\"Test cases for ``ScaleIODriver._get_server_api_version()``\"\"\""},{"line_number":37,"context_line":"    def setUp(self):"},{"line_number":38,"context_line":"        \"\"\"Setup a test case environment."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        \"\"\""},{"line_number":41,"context_line":"        super(TestMultipleVersions, self).setUp()"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        self.HTTPS_MOCK_RESPONSES \u003d {"}],"source_content_type":"text/x-python","patch_set":3,"id":"ffe62b97_777984fa","line":40,"range":{"start_line":38,"start_character":0,"end_line":40,"end_character":11},"updated":"2017-03-27 04:27:12.000000000","message":"\"\"\"Setup a test case environment.\"\"\"","commit_id":"ee03d7603f4f4853a9962d2dbea645d259187633"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"bc3dc77755a7bbb96626719c68a44eb0bc52b81c","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        }"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def test_version_api_fails(self):"},{"line_number":56,"context_line":"        \"\"\"version api returns a non-200 response\"\"\""},{"line_number":57,"context_line":"        self.set_https_response_mode(self.RESPONSE_MODE.Invalid)"},{"line_number":58,"context_line":"        self.assertRaises(exception.VolumeBackendAPIException,"},{"line_number":59,"context_line":"                          self.test_version)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ffe62b97_3783fcce","line":56,"updated":"2017-03-27 04:27:12.000000000","message":"Please add a period.","commit_id":"ee03d7603f4f4853a9962d2dbea645d259187633"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"bc3dc77755a7bbb96626719c68a44eb0bc52b81c","unresolved":false,"context_lines":[{"line_number":59,"context_line":"                          self.test_version)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def test_version(self):"},{"line_number":62,"context_line":"        \"\"\"Valid version request\"\"\""},{"line_number":63,"context_line":"        self.driver._get_server_api_version(False)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def test_version_badstatus_response(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ffe62b97_d7673051","line":62,"updated":"2017-03-27 04:27:12.000000000","message":"Period please.","commit_id":"ee03d7603f4f4853a9962d2dbea645d259187633"}],"cinder/volume/drivers/dell_emc/scaleio/driver.py":[{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"e8dec9d7412349354309e960e9705b87c1f7329d","unresolved":false,"context_lines":[{"line_number":70,"context_line":"               help\u003d\u0027Storage Pool name.\u0027),"},{"line_number":71,"context_line":"    cfg.StrOpt(\u0027sio_storage_pool_id\u0027,"},{"line_number":72,"context_line":"               help\u003d\u0027Storage Pool ID.\u0027),"},{"line_number":73,"context_line":"    cfg.StrOpt(\u0027server_api_version\u0027,"},{"line_number":74,"context_line":"               help\u003d\u0027ScaleIO API version.\u0027),"},{"line_number":75,"context_line":"    cfg.FloatOpt(\u0027sio_max_over_subscription_ratio\u0027,"},{"line_number":76,"context_line":"                 # This option exists to provide a default value for the"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a1ced50_a94d599b","line":73,"updated":"2017-03-23 16:05:29.000000000","message":"Suggest we change server_api_version to sio_server_api_version to align with the other attributes that have the sio prefix","commit_id":"bcd95d40769c9b17b362d0cf518a0356540bfd0b"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"e8dec9d7412349354309e960e9705b87c1f7329d","unresolved":false,"context_lines":[{"line_number":114,"context_line":"class ScaleIODriver(driver.VolumeDriver):"},{"line_number":115,"context_line":"    \"\"\"Dell EMC ScaleIO Driver.\"\"\""},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    VERSION \u003d \"2.0\""},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    # ThirdPartySystems wiki"},{"line_number":120,"context_line":"    CI_WIKI_NAME \u003d \"EMC_ScaleIO_CI\""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a1ced50_a998f91c","line":117,"updated":"2017-03-23 16:05:29.000000000","message":"Can you update the version of the driver and track the changes please?","commit_id":"bcd95d40769c9b17b362d0cf518a0356540bfd0b"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"f2844071babbbceacdab1cb9763d0c512f039161","unresolved":false,"context_lines":[{"line_number":450,"context_line":"                  \u0027storagePoolId\u0027: pool_id}"},{"line_number":451,"context_line":""},{"line_number":452,"context_line":"        LOG.info(\"Params for add volume request: %s.\", params)"},{"line_number":453,"context_line":"        request \u003d \"https://\" + \\"},{"line_number":454,"context_line":"                  self.server_ip + \\"},{"line_number":455,"context_line":"                  \":\" + \\"},{"line_number":456,"context_line":"                  self.server_port + \\"}],"source_content_type":"text/x-python","patch_set":5,"id":"ffe62b97_cae83bb4","line":453,"range":{"start_line":453,"start_character":31,"end_line":453,"end_character":32},"updated":"2017-03-29 00:32:43.000000000","message":"Please wrap in () to avoid the need for \\","commit_id":"6d6ea0eb91ac68526e6c6d6e1d6254a08fba7d20"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"f2844071babbbceacdab1cb9763d0c512f039161","unresolved":false,"context_lines":[{"line_number":573,"context_line":"                LOG.info(\"REST API Version: %(api_version)s\","},{"line_number":574,"context_line":"                         {\u0027api_version\u0027: self.server_api_version})"},{"line_number":575,"context_line":"            else:"},{"line_number":576,"context_line":"                msg \u003d (_(\"Error calling version api\""},{"line_number":577,"context_line":"                         \"status code: %d\") % r.status_code)"},{"line_number":578,"context_line":"                raise exception.VolumeBackendAPIException(data\u003dmsg)"},{"line_number":579,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ffe62b97_8aceb357","line":576,"range":{"start_line":576,"start_character":51,"end_line":576,"end_character":52},"updated":"2017-03-29 00:32:43.000000000","message":"Need trailing space so it doesn\u0027t end up \"apistatus\"","commit_id":"6d6ea0eb91ac68526e6c6d6e1d6254a08fba7d20"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"f2844071babbbceacdab1cb9763d0c512f039161","unresolved":false,"context_lines":[{"line_number":580,"context_line":"            # make sure the response was valid"},{"line_number":581,"context_line":"            pattern \u003d re.compile(\"^\\d+(\\.\\d+)*$\")"},{"line_number":582,"context_line":"            if not pattern.match(self.server_api_version):"},{"line_number":583,"context_line":"                msg \u003d (_(\"Error calling version api\""},{"line_number":584,"context_line":"                         \"response: %s\") % r.text)"},{"line_number":585,"context_line":"                raise exception.VolumeBackendAPIException(data\u003dmsg)"},{"line_number":586,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ffe62b97_6ad92f20","line":583,"range":{"start_line":583,"start_character":51,"end_line":583,"end_character":52},"updated":"2017-03-29 00:32:43.000000000","message":"Needs trailing space.","commit_id":"6d6ea0eb91ac68526e6c6d6e1d6254a08fba7d20"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"164d1c81d2cb3d1c50da7cd8cddc027a4b76e9a8","unresolved":false,"context_lines":[{"line_number":572,"context_line":"                LOG.info(\"REST API Version: %(api_version)s\","},{"line_number":573,"context_line":"                         {\u0027api_version\u0027: self.server_api_version})"},{"line_number":574,"context_line":"            else:"},{"line_number":575,"context_line":"                msg \u003d (_(\"Error calling version api \""},{"line_number":576,"context_line":"                         \"status code: %d\") % r.status_code)"},{"line_number":577,"context_line":"                raise exception.VolumeBackendAPIException(data\u003dmsg)"},{"line_number":578,"context_line":""},{"line_number":579,"context_line":"            # make sure the response was valid"}],"source_content_type":"text/x-python","patch_set":6,"id":"ffe62b97_24d45de8","line":576,"range":{"start_line":575,"start_character":26,"end_line":576,"end_character":41},"updated":"2017-03-29 14:55:23.000000000","message":"Suggest \"Error calling version api.  Status code: %d\"","commit_id":"1fe40e361a46c211190c5e20bd0ce3eb1459e2b5"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"164d1c81d2cb3d1c50da7cd8cddc027a4b76e9a8","unresolved":false,"context_lines":[{"line_number":579,"context_line":"            # make sure the response was valid"},{"line_number":580,"context_line":"            pattern \u003d re.compile(\"^\\d+(\\.\\d+)*$\")"},{"line_number":581,"context_line":"            if not pattern.match(self.server_api_version):"},{"line_number":582,"context_line":"                msg \u003d (_(\"Error calling version api \""},{"line_number":583,"context_line":"                         \"response: %s\") % r.text)"},{"line_number":584,"context_line":"                raise exception.VolumeBackendAPIException(data\u003dmsg)"},{"line_number":585,"context_line":""},{"line_number":586,"context_line":"        return self.server_api_version"}],"source_content_type":"text/x-python","patch_set":6,"id":"ffe62b97_24ed7db6","line":583,"range":{"start_line":582,"start_character":26,"end_line":583,"end_character":38},"updated":"2017-03-29 14:55:23.000000000","message":"Suggest \"Error calling version api.  Response: %s\"","commit_id":"1fe40e361a46c211190c5e20bd0ce3eb1459e2b5"}]}