)]}'
{"cinder/db/sqlalchemy/migrate_repo/versions/098_message_add_expire_at_index.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"cfc9707ea811a66ab1dd8f58f1886217731d9979","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    meta \u003d MetaData(migrate_engine)"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    messages \u003d Table(\u0027messages\u0027, meta, autoload\u003dTrue)"},{"line_number":20,"context_line":"    return Index(\u0027messages_expire_at_idx\u0027, messages.c.expires_at)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7ffa3b31_95832805","line":20,"updated":"2017-04-14 13:48:38.000000000","message":"Do we need to add a default expire time for any existing messages in the db?","commit_id":"c5c275d8c81f1ca2cf8a50da1e534c6e5057b6a1"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"cd38a99ad0aade0da50ea16d0db5a59431a026ce","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    meta \u003d MetaData(migrate_engine)"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    messages \u003d Table(\u0027messages\u0027, meta, autoload\u003dTrue)"},{"line_number":20,"context_line":"    return Index(\u0027messages_expire_at_idx\u0027, messages.c.expires_at)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7ffa3b31_ac45a819","line":20,"in_reply_to":"7ffa3b31_95832805","updated":"2017-04-17 01:39:45.000000000","message":"The \u0027expired_at\u0027 column exists [1] since we introduced this feature. So I reckon we don\u0027t need to add the default expire time.\n\n[1] https://github.com/openstack/cinder/blob/master/cinder/message/api.py#L46","commit_id":"c5c275d8c81f1ca2cf8a50da1e534c6e5057b6a1"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"a7c6bdf5ac280cbdc9ef971bb45fea3c634953d0","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    meta \u003d MetaData(migrate_engine)"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    messages \u003d Table(\u0027messages\u0027, meta, autoload\u003dTrue)"},{"line_number":20,"context_line":"    return Index(\u0027messages_expire_at_idx\u0027, messages.c.expires_at)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7ffa3b31_aa1c5d6a","line":20,"in_reply_to":"7ffa3b31_ac45a819","updated":"2017-04-17 13:31:16.000000000","message":"Sorry, I read through too quickly. I see now this is just adding an index for the existing column, so my comment does not make sense. Thanks!","commit_id":"c5c275d8c81f1ca2cf8a50da1e534c6e5057b6a1"}],"cinder/message/api.py":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"54a06ca25f619e566e47dbb784520d949538a4ff","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    cfg.IntOpt(\u0027message_ttl\u0027, default\u003d2592000,"},{"line_number":27,"context_line":"               help\u003d\u0027message minimum life in seconds.\u0027),"},{"line_number":28,"context_line":"    cfg.IntOpt(\u0027message_reap_interval\u0027, default\u003d86400,"},{"line_number":29,"context_line":"               help\u003d\u0027interval between period task to clean expired messages.\u0027)"},{"line_number":30,"context_line":"]"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a1ced50_44c85155","line":29,"range":{"start_line":29,"start_character":21,"end_line":29,"end_character":29},"updated":"2017-03-23 14:42:00.000000000","message":"\"Interval\"","commit_id":"5098b54224e6234ec43d298b559a7832dc982a18"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"54a06ca25f619e566e47dbb784520d949538a4ff","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    def cleanup_expired_messages(self, context):"},{"line_number":102,"context_line":"        ctx \u003d context.elevated()"},{"line_number":103,"context_line":"        count \u003d self.db.cleanup_expired_messages(ctx)"},{"line_number":104,"context_line":"        LOG.info(\"Soft deleted %s expired messages\", count)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a1ced50_04e9f9b6","line":104,"range":{"start_line":104,"start_character":18,"end_line":104,"end_character":50},"updated":"2017-03-23 14:42:00.000000000","message":"\u0027.\u0027 at EOL please","commit_id":"5098b54224e6234ec43d298b559a7832dc982a18"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"cfc9707ea811a66ab1dd8f58f1886217731d9979","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    cfg.IntOpt(\u0027message_ttl\u0027, default\u003d2592000,"},{"line_number":27,"context_line":"               help\u003d\u0027message minimum life in seconds.\u0027),"},{"line_number":28,"context_line":"    cfg.IntOpt(\u0027message_reap_interval\u0027, default\u003d86400,"},{"line_number":29,"context_line":"               help\u003d\u0027interval between period task to clean expired messages.\u0027)"},{"line_number":30,"context_line":"]"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7ffa3b31_35e33408","line":29,"range":{"start_line":29,"start_character":75,"end_line":29,"end_character":77},"updated":"2017-04-14 13:48:38.000000000","message":"In seconds?","commit_id":"c5c275d8c81f1ca2cf8a50da1e534c6e5057b6a1"}],"releasenotes/notes/add-periodic-task-to-clean-expired-messages-84f47gxc88hda035.yaml":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"cfc9707ea811a66ab1dd8f58f1886217731d9979","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  -  Added perodic task to clean expired messages in"},{"line_number":4,"context_line":"     cinder scheduler."},{"line_number":5,"context_line":"  -  Added new configuration option \u0027message_reap_interval\u0027"},{"line_number":6,"context_line":"     to set interval between perodic tasks."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7ffa3b31_55cfe07e","line":5,"range":{"start_line":5,"start_character":36,"end_line":5,"end_character":37},"updated":"2017-04-14 13:48:38.000000000","message":"Please use `message_reap_interval` so it gets formatted in the output.","commit_id":"c5c275d8c81f1ca2cf8a50da1e534c6e5057b6a1"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"cd38a99ad0aade0da50ea16d0db5a59431a026ce","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  -  Added perodic task to clean expired messages in"},{"line_number":4,"context_line":"     cinder scheduler."},{"line_number":5,"context_line":"  -  Added new configuration option \u0027message_reap_interval\u0027"},{"line_number":6,"context_line":"     to set interval between perodic tasks."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7ffa3b31_cc5914ff","line":5,"range":{"start_line":5,"start_character":36,"end_line":5,"end_character":37},"in_reply_to":"7ffa3b31_55cfe07e","updated":"2017-04-17 01:39:45.000000000","message":"Done","commit_id":"c5c275d8c81f1ca2cf8a50da1e534c6e5057b6a1"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"cfc9707ea811a66ab1dd8f58f1886217731d9979","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  -  Added perodic task to clean expired messages in"},{"line_number":4,"context_line":"     cinder scheduler."},{"line_number":5,"context_line":"  -  Added new configuration option \u0027message_reap_interval\u0027"},{"line_number":6,"context_line":"     to set interval between perodic tasks."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7ffa3b31_95aa0883","line":6,"range":{"start_line":6,"start_character":29,"end_line":6,"end_character":36},"updated":"2017-04-14 13:48:38.000000000","message":"periodic\n\nThis line may or may not appear after the previous one in this file when the release notes are generated. Can you expand on this so it\u0027s clear by stating something like \"between periodic message cleanup tasks.","commit_id":"c5c275d8c81f1ca2cf8a50da1e534c6e5057b6a1"}]}