)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"5275df66594092e551867c18679488ef1d293ba0","unresolved":false,"context_lines":[{"line_number":7,"context_line":"[Optimise] Simplify model filter validations in db layer."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We currently have redundant model filter validations at db layer,"},{"line_number":10,"context_line":"clean it up."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I4c920fdcfc1a0e93b7d838f27be7e3808d65c385"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ffe62b97_3d8bcc1f","line":10,"updated":"2017-03-27 12:17:36.000000000","message":"Can you point out in the commit message where this filter validation is already being performed? Just looking at the change itself, it appears filter checking is just being removed completely.","commit_id":"074ed104d12631001b056918e194da1e0a744b8d"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"4a406c0337c8c4f545408d0f63c5b4d2f553fa09","unresolved":false,"context_lines":[{"line_number":7,"context_line":"[Optimise] Simplify model filter validations in db layer."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We currently have redundant model filter validations at db layer,"},{"line_number":10,"context_line":"clean it up. Take these two [1], [2] for example, they validate"},{"line_number":11,"context_line":"the filters of attachment model successively."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"[1] https://github.com/openstack/cinder/blob/master/cinder/db/sqlalchemy/api.py#L1782"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ffe62b97_628d277a","line":10,"range":{"start_line":10,"start_character":28,"end_line":10,"end_character":36},"updated":"2017-03-27 14:27:54.000000000","message":"These two aren\u0027t part of the same call sequence.","commit_id":"642e26e0d1088621f8706a5da6b120ecd771bbe6"}],"cinder/db/sqlalchemy/api.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"4a406c0337c8c4f545408d0f63c5b4d2f553fa09","unresolved":false,"context_lines":[{"line_number":1779,"context_line":"                        offset\u003dNone, sort_keys\u003dNone, sort_dirs\u003dNone):"},{"line_number":1780,"context_line":""},{"line_number":1781,"context_line":"    project_id \u003d filters.pop(\u0027project_id\u0027, None) if filters else None"},{"line_number":1782,"context_line":"    if filters and not is_valid_model_filters(models.VolumeAttachment,"},{"line_number":1783,"context_line":"                                              filters):"},{"line_number":1784,"context_line":"        return []"},{"line_number":1785,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_87083d2c","side":"PARENT","line":1782,"updated":"2017-03-27 14:27:54.000000000","message":"This will validate the filters inside of _generate_paginate_query, but that\u0027s after it gets the data and does other processing. It\u0027s better to have the check here up front so it just returns the empty list right away rather than doing a bunch of work, then throwing it out.","commit_id":"1205ec79cd0338d17aad5d05e9388f3659104e23"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"4a406c0337c8c4f545408d0f63c5b4d2f553fa09","unresolved":false,"context_lines":[{"line_number":2870,"context_line":"                      paired with corresponding item in sort_keys"},{"line_number":2871,"context_line":"    :returns: list of matching snapshots"},{"line_number":2872,"context_line":"    \"\"\""},{"line_number":2873,"context_line":"    if filters and not is_valid_model_filters(models.Snapshot, filters,"},{"line_number":2874,"context_line":"                                              exclude_list\u003d(\u0027host\u0027,"},{"line_number":2875,"context_line":"                                                            \u0027cluster_name\u0027)):"},{"line_number":2876,"context_line":"        return []"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_e2a817dc","side":"PARENT","line":2873,"updated":"2017-03-27 14:27:54.000000000","message":"Same here.","commit_id":"1205ec79cd0338d17aad5d05e9388f3659104e23"}]}