)]}'
{"cinder/volume/drivers/dell_emc/vmax/common.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"67cea9089c56ab9d8a238fdd5c1e73e70126cbbb","unresolved":false,"context_lines":[{"line_number":749,"context_line":"        \"\"\"Get the storage group from the existing masking view."},{"line_number":750,"context_line":""},{"line_number":751,"context_line":"        :params deviceInfoDict: the device info dictionary"},{"line_number":752,"context_line":"        :params storageSystemName: storage system name"},{"line_number":753,"context_line":"        :returns: storage group instance"},{"line_number":754,"context_line":"        \"\"\""},{"line_number":755,"context_line":"        storageGroupInstanceName \u003d None"}],"source_content_type":"text/x-python","patch_set":3,"id":"ffe62b97_891c4b78","line":752,"range":{"start_line":752,"start_character":9,"end_line":752,"end_character":54},"updated":"2017-03-30 02:55:25.000000000","message":"This is not an input param.","commit_id":"33c305309087f3e70e15f9e68bc42e1afa5eed04"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"3dfdceb8d2cd2ae59f87fe69683fa0db8c834aac","unresolved":false,"context_lines":[{"line_number":749,"context_line":"        \"\"\"Get the storage group from the existing masking view."},{"line_number":750,"context_line":""},{"line_number":751,"context_line":"        :params deviceInfoDict: the device info dictionary"},{"line_number":752,"context_line":"        :params storageSystemName: storage system name"},{"line_number":753,"context_line":"        :returns: storage group instance"},{"line_number":754,"context_line":"        \"\"\""},{"line_number":755,"context_line":"        storageGroupInstanceName \u003d None"}],"source_content_type":"text/x-python","patch_set":3,"id":"ffe62b97_25b558ce","line":752,"range":{"start_line":752,"start_character":9,"end_line":752,"end_character":54},"in_reply_to":"ffe62b97_891c4b78","updated":"2017-03-30 08:54:34.000000000","message":"Thanks Xing, I will remove it","commit_id":"33c305309087f3e70e15f9e68bc42e1afa5eed04"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"67cea9089c56ab9d8a238fdd5c1e73e70126cbbb","unresolved":false,"context_lines":[{"line_number":773,"context_line":"        \"\"\"Get the port group from the existing masking view."},{"line_number":774,"context_line":""},{"line_number":775,"context_line":"        :params deviceInfoDict: the device info dictionary"},{"line_number":776,"context_line":"        :params storageSystemName: storage system name"},{"line_number":777,"context_line":"        :returns: port group instance"},{"line_number":778,"context_line":"        \"\"\""},{"line_number":779,"context_line":"        portGroupInstanceName \u003d None"}],"source_content_type":"text/x-python","patch_set":3,"id":"ffe62b97_e92197b5","line":776,"range":{"start_line":776,"start_character":9,"end_line":776,"end_character":54},"updated":"2017-03-30 02:55:25.000000000","message":"This is not an input param.","commit_id":"33c305309087f3e70e15f9e68bc42e1afa5eed04"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"3dfdceb8d2cd2ae59f87fe69683fa0db8c834aac","unresolved":false,"context_lines":[{"line_number":773,"context_line":"        \"\"\"Get the port group from the existing masking view."},{"line_number":774,"context_line":""},{"line_number":775,"context_line":"        :params deviceInfoDict: the device info dictionary"},{"line_number":776,"context_line":"        :params storageSystemName: storage system name"},{"line_number":777,"context_line":"        :returns: port group instance"},{"line_number":778,"context_line":"        \"\"\""},{"line_number":779,"context_line":"        portGroupInstanceName \u003d None"}],"source_content_type":"text/x-python","patch_set":3,"id":"ffe62b97_e5c6504a","line":776,"range":{"start_line":776,"start_character":9,"end_line":776,"end_character":54},"in_reply_to":"ffe62b97_e92197b5","updated":"2017-03-30 08:54:34.000000000","message":"Will remove it.  Thanks","commit_id":"33c305309087f3e70e15f9e68bc42e1afa5eed04"}],"cinder/volume/drivers/dell_emc/vmax/masking.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"5977dfcf71cffebd580c1681cde9183898a706ab","unresolved":false,"context_lines":[{"line_number":420,"context_line":"                conn, maskingViewInstanceName))"},{"line_number":421,"context_line":""},{"line_number":422,"context_line":"        if sgFromMvInstanceName is None:"},{"line_number":423,"context_line":"            # This may be used in exception hence _ instead of _LE."},{"line_number":424,"context_line":"            msg \u003d (_("},{"line_number":425,"context_line":"                \"Cannot get storage group from masking view \""},{"line_number":426,"context_line":"                \"%(maskingViewInstanceName)s. \") %"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffe62b97_fed9b656","line":423,"range":{"start_line":423,"start_character":62,"end_line":423,"end_character":66},"updated":"2017-03-28 04:53:18.000000000","message":"There\u0027s no _LE any more.\n\nInfo, error, and warning messages don\u0027t need translation any more.","commit_id":"ee6e591677543e6e18c7644efaf48128bb693254"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"5977dfcf71cffebd580c1681cde9183898a706ab","unresolved":false,"context_lines":[{"line_number":425,"context_line":"                \"Cannot get storage group from masking view \""},{"line_number":426,"context_line":"                \"%(maskingViewInstanceName)s. \") %"},{"line_number":427,"context_line":"                {\u0027maskingViewInstanceName\u0027: maskingViewInstanceName})"},{"line_number":428,"context_line":"            LOG.error(msg)"},{"line_number":429,"context_line":"        return sgFromMvInstanceName, msg"},{"line_number":430,"context_line":""},{"line_number":431,"context_line":"    def _check_port_group(self, conn,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffe62b97_de96f23e","line":428,"updated":"2017-03-28 04:53:18.000000000","message":"LOG.error here should not use _().  You should use _() on the msg where you throw the exception.","commit_id":"ee6e591677543e6e18c7644efaf48128bb693254"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"af2d7ce9c814dfe374e435523667c3cb519dd6d9","unresolved":false,"context_lines":[{"line_number":425,"context_line":"                \"Cannot get storage group from masking view \""},{"line_number":426,"context_line":"                \"%(maskingViewInstanceName)s. \") %"},{"line_number":427,"context_line":"                {\u0027maskingViewInstanceName\u0027: maskingViewInstanceName})"},{"line_number":428,"context_line":"            LOG.error(msg)"},{"line_number":429,"context_line":"        return sgFromMvInstanceName, msg"},{"line_number":430,"context_line":""},{"line_number":431,"context_line":"    def _check_port_group(self, conn,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffe62b97_3df71a62","line":428,"in_reply_to":"ffe62b97_7eca464e","updated":"2017-03-28 09:54:13.000000000","message":"Thanks Xing, we can change it later, we are more concerned with Ocata and Newton backport for this fix","commit_id":"ee6e591677543e6e18c7644efaf48128bb693254"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"8a6d2490f50363620b266831ff0a84991779d72a","unresolved":false,"context_lines":[{"line_number":425,"context_line":"                \"Cannot get storage group from masking view \""},{"line_number":426,"context_line":"                \"%(maskingViewInstanceName)s. \") %"},{"line_number":427,"context_line":"                {\u0027maskingViewInstanceName\u0027: maskingViewInstanceName})"},{"line_number":428,"context_line":"            LOG.error(msg)"},{"line_number":429,"context_line":"        return sgFromMvInstanceName, msg"},{"line_number":430,"context_line":""},{"line_number":431,"context_line":"    def _check_port_group(self, conn,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffe62b97_7eca464e","line":428,"in_reply_to":"ffe62b97_de96f23e","updated":"2017-03-28 04:55:58.000000000","message":"Are you planning to backport this fix?  In that case, it\u0027s better not to make this change now and do it in a later patch.\n\nDon\u0027t change the comments on line# 423.","commit_id":"ee6e591677543e6e18c7644efaf48128bb693254"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"3e33f86e0eccafee9fc656edebb9882549e5d048","unresolved":false,"context_lines":[{"line_number":420,"context_line":"                conn, maskingViewInstanceName))"},{"line_number":421,"context_line":""},{"line_number":422,"context_line":"        if sgFromMvInstanceName is None:"},{"line_number":423,"context_line":"            # This may be used in exception hence _ instead of _LE."},{"line_number":424,"context_line":"            msg \u003d (_("},{"line_number":425,"context_line":"                \"Cannot get storage group from masking view \""},{"line_number":426,"context_line":"                \"%(maskingViewInstanceName)s. \") %"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_78921059","line":423,"range":{"start_line":423,"start_character":50,"end_line":423,"end_character":67},"updated":"2017-03-29 13:42:37.000000000","message":"Please don\u0027t change the comments here.  _LE is no longer used and therefore should not be mentioned.","commit_id":"4a3b337c6637335030b9bec022294740a545bfdb"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"722d2cf1ab604b1b0c1529b6ffd7f6edef68d028","unresolved":false,"context_lines":[{"line_number":420,"context_line":"                conn, maskingViewInstanceName))"},{"line_number":421,"context_line":""},{"line_number":422,"context_line":"        if sgFromMvInstanceName is None:"},{"line_number":423,"context_line":"            # This may be used in exception hence _ instead of _LE."},{"line_number":424,"context_line":"            msg \u003d (_("},{"line_number":425,"context_line":"                \"Cannot get storage group from masking view \""},{"line_number":426,"context_line":"                \"%(maskingViewInstanceName)s. \") %"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_24445d46","line":423,"range":{"start_line":423,"start_character":50,"end_line":423,"end_character":67},"in_reply_to":"ffe62b97_78921059","updated":"2017-03-29 14:47:15.000000000","message":"Ok, I will revert to the old comment\n# This may be used in exception hence the use of _","commit_id":"4a3b337c6637335030b9bec022294740a545bfdb"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"3e33f86e0eccafee9fc656edebb9882549e5d048","unresolved":false,"context_lines":[{"line_number":1879,"context_line":"        \"\"\""},{"line_number":1880,"context_line":"        storageGroupInstanceName \u003d None"},{"line_number":1881,"context_line":"        if extraSpecs[ISV3]:"},{"line_number":1882,"context_line":"            # extraSpecs[\u0027connector\u0027] \u003d connector"},{"line_number":1883,"context_line":"            self._cleanup_deletion_v3("},{"line_number":1884,"context_line":"                conn, controllerConfigService, volumeInstance, extraSpecs)"},{"line_number":1885,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_d8e59cdd","line":1882,"range":{"start_line":1882,"start_character":12,"end_line":1882,"end_character":49},"updated":"2017-03-29 13:42:37.000000000","message":"Remove this comment.","commit_id":"4a3b337c6637335030b9bec022294740a545bfdb"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"722d2cf1ab604b1b0c1529b6ffd7f6edef68d028","unresolved":false,"context_lines":[{"line_number":1879,"context_line":"        \"\"\""},{"line_number":1880,"context_line":"        storageGroupInstanceName \u003d None"},{"line_number":1881,"context_line":"        if extraSpecs[ISV3]:"},{"line_number":1882,"context_line":"            # extraSpecs[\u0027connector\u0027] \u003d connector"},{"line_number":1883,"context_line":"            self._cleanup_deletion_v3("},{"line_number":1884,"context_line":"                conn, controllerConfigService, volumeInstance, extraSpecs)"},{"line_number":1885,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_245d7d14","line":1882,"range":{"start_line":1882,"start_character":12,"end_line":1882,"end_character":49},"in_reply_to":"ffe62b97_d8e59cdd","updated":"2017-03-29 14:47:15.000000000","message":"Will do.  Thanks","commit_id":"4a3b337c6637335030b9bec022294740a545bfdb"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"67cea9089c56ab9d8a238fdd5c1e73e70126cbbb","unresolved":false,"context_lines":[{"line_number":409,"context_line":"        \"\"\"Check that we can get the existing storage group."},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"        :param conn: the ecom connection"},{"line_number":412,"context_line":"        :param sgGroupName: the storage group name"},{"line_number":413,"context_line":"        :param maskingViewInstanceName: the masking view instance name"},{"line_number":414,"context_line":"        :returns: storageGroupInstanceName"},{"line_number":415,"context_line":"        :returns: string -- msg, the error message"}],"source_content_type":"text/x-python","patch_set":3,"id":"ffe62b97_c9a93324","line":412,"range":{"start_line":412,"start_character":9,"end_line":412,"end_character":50},"updated":"2017-03-30 02:55:25.000000000","message":"This is also removed.","commit_id":"33c305309087f3e70e15f9e68bc42e1afa5eed04"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"3dfdceb8d2cd2ae59f87fe69683fa0db8c834aac","unresolved":false,"context_lines":[{"line_number":409,"context_line":"        \"\"\"Check that we can get the existing storage group."},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"        :param conn: the ecom connection"},{"line_number":412,"context_line":"        :param sgGroupName: the storage group name"},{"line_number":413,"context_line":"        :param maskingViewInstanceName: the masking view instance name"},{"line_number":414,"context_line":"        :returns: storageGroupInstanceName"},{"line_number":415,"context_line":"        :returns: string -- msg, the error message"}],"source_content_type":"text/x-python","patch_set":3,"id":"ffe62b97_c5d8ec1f","line":412,"range":{"start_line":412,"start_character":9,"end_line":412,"end_character":50},"in_reply_to":"ffe62b97_c9a93324","updated":"2017-03-30 08:54:34.000000000","message":"Sure. Will remove it","commit_id":"33c305309087f3e70e15f9e68bc42e1afa5eed04"}]}