)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"aa39f759c61cb1aa5cbbbff1a4315f5c9fb095d0","unresolved":false,"context_lines":[{"line_number":9,"context_line":"In the implementation of the creation or deletion snapshot, the function will"},{"line_number":10,"context_line":"check whether the nfs snapshot function is enabled, but the function"},{"line_number":11,"context_line":"check_snapshot_support there is a default parameter setup_checking, the"},{"line_number":12,"context_line":"default value is False.In the function set_checking if the set_checking alue"},{"line_number":13,"context_line":"of setup_checking is False, it will fail to create or delete the snapshot,"},{"line_number":14,"context_line":"even if the nfs configuration supports snapshots."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"dfeb2761_8e14ff4f","line":12,"range":{"start_line":12,"start_character":17,"end_line":12,"end_character":25},"updated":"2017-04-03 00:54:47.000000000","message":"Missing space here.","commit_id":"289516a1870f388c5568e59397ae33474ec2e4c6"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"aa39f759c61cb1aa5cbbbff1a4315f5c9fb095d0","unresolved":false,"context_lines":[{"line_number":9,"context_line":"In the implementation of the creation or deletion snapshot, the function will"},{"line_number":10,"context_line":"check whether the nfs snapshot function is enabled, but the function"},{"line_number":11,"context_line":"check_snapshot_support there is a default parameter setup_checking, the"},{"line_number":12,"context_line":"default value is False.In the function set_checking if the set_checking alue"},{"line_number":13,"context_line":"of setup_checking is False, it will fail to create or delete the snapshot,"},{"line_number":14,"context_line":"even if the nfs configuration supports snapshots."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"dfeb2761_ee294b9b","line":12,"range":{"start_line":12,"start_character":72,"end_line":12,"end_character":76},"updated":"2017-04-03 00:54:47.000000000","message":"value","commit_id":"289516a1870f388c5568e59397ae33474ec2e4c6"},{"author":{"_account_id":21135,"name":"zhangdaolong","email":"zhangdaolong@fiberhome.com","username":"zhangdaolong"},"change_message_id":"2dc2b8c193855c943502466c2ddd0a44f12fce9c","unresolved":false,"context_lines":[{"line_number":9,"context_line":"In the implementation of the creation or deletion snapshot, the function will"},{"line_number":10,"context_line":"check whether the nfs snapshot function is enabled, but the function"},{"line_number":11,"context_line":"check_snapshot_support there is a default parameter setup_checking, the"},{"line_number":12,"context_line":"default value is False.In the function set_checking if the set_checking alue"},{"line_number":13,"context_line":"of setup_checking is False, it will fail to create or delete the snapshot,"},{"line_number":14,"context_line":"even if the nfs configuration supports snapshots."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"dfeb2761_8634d5fc","line":12,"range":{"start_line":12,"start_character":17,"end_line":12,"end_character":25},"in_reply_to":"dfeb2761_8e14ff4f","updated":"2017-04-03 13:55:46.000000000","message":"thank you ,i will fix it","commit_id":"289516a1870f388c5568e59397ae33474ec2e4c6"},{"author":{"_account_id":21135,"name":"zhangdaolong","email":"zhangdaolong@fiberhome.com","username":"zhangdaolong"},"change_message_id":"2dc2b8c193855c943502466c2ddd0a44f12fce9c","unresolved":false,"context_lines":[{"line_number":9,"context_line":"In the implementation of the creation or deletion snapshot, the function will"},{"line_number":10,"context_line":"check whether the nfs snapshot function is enabled, but the function"},{"line_number":11,"context_line":"check_snapshot_support there is a default parameter setup_checking, the"},{"line_number":12,"context_line":"default value is False.In the function set_checking if the set_checking alue"},{"line_number":13,"context_line":"of setup_checking is False, it will fail to create or delete the snapshot,"},{"line_number":14,"context_line":"even if the nfs configuration supports snapshots."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"dfeb2761_262509c3","line":12,"range":{"start_line":12,"start_character":72,"end_line":12,"end_character":76},"in_reply_to":"dfeb2761_ee294b9b","updated":"2017-04-03 13:55:46.000000000","message":"thank you ,i will fix it","commit_id":"289516a1870f388c5568e59397ae33474ec2e4c6"}],"cinder/volume/drivers/nfs.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"fd149477cbc6175bc771646f1c374e2ce1e05006","unresolved":false,"context_lines":[{"line_number":554,"context_line":"    def create_snapshot(self, snapshot):"},{"line_number":555,"context_line":"        \"\"\"Apply locking to the create snapshot operation.\"\"\""},{"line_number":556,"context_line":""},{"line_number":557,"context_line":"        self._check_snapshot_support(setup_checking\u003dTrue)"},{"line_number":558,"context_line":"        return self._create_snapshot(snapshot)"},{"line_number":559,"context_line":""},{"line_number":560,"context_line":"    @locked_volume_id_operation"}],"source_content_type":"text/x-python","patch_set":4,"id":"dfeb2761_a61a397a","line":557,"updated":"2017-04-03 13:56:26.000000000","message":"setup_checking\u003dTrue is for issuing a specific message at setup time.  Your change is now running the \"setup\" check for all calls.\n\nI believe the current behavior is correct -- your commit message and bug report don\u0027t explain why this is changed.\n\nSnapshot creation is _supposed_ to fail if nas_secure_file_operations is set to \"true\".","commit_id":"8ae3378ba6d7172e329158dea05f8e468126bd66"},{"author":{"_account_id":21135,"name":"zhangdaolong","email":"zhangdaolong@fiberhome.com","username":"zhangdaolong"},"change_message_id":"3c0a5bb3bf0cb9f16b1d80e7bed71cb97cdf05bf","unresolved":false,"context_lines":[{"line_number":554,"context_line":"    def create_snapshot(self, snapshot):"},{"line_number":555,"context_line":"        \"\"\"Apply locking to the create snapshot operation.\"\"\""},{"line_number":556,"context_line":""},{"line_number":557,"context_line":"        self._check_snapshot_support(setup_checking\u003dTrue)"},{"line_number":558,"context_line":"        return self._create_snapshot(snapshot)"},{"line_number":559,"context_line":""},{"line_number":560,"context_line":"    @locked_volume_id_operation"}],"source_content_type":"text/x-python","patch_set":4,"id":"dfeb2761_2925dac2","line":557,"in_reply_to":"dfeb2761_a61a397a","updated":"2017-04-03 14:13:59.000000000","message":"oh i am wrong,thank you ,i will abandon","commit_id":"8ae3378ba6d7172e329158dea05f8e468126bd66"}]}
