)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"858bc4b253afbd10bc7c9fe61fb62a4e1d6e168e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     nidhimittalhada \u003cnidhimittal19@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-04-13 17:47:33 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Cinder quota doesn\u0027t check non int properly"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This fix corrects the integer type checking"},{"line_number":10,"context_line":"by replacing int() by isinstance()."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7ffa3b31_d03be235","line":7,"updated":"2017-04-17 08:29:48.000000000","message":"The code change doesn\u0027t seem to related to Cinder quota directly even the bug was reported via quota update API.","commit_id":"c7e161d9f5f9a2dd244f6e17babe9b333b77ec96"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"97587a3cc8c9e52a9292112b31b9d2efc1910541","unresolved":false,"context_lines":[{"line_number":7,"context_line":"validate_integer doesn\u0027t check non int properly"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This fix corrects the integer type checking"},{"line_number":10,"context_line":"by replacing int() by isinstance()."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ib3979d35e165800cae2b97a7ce2b89f4113b0a79"},{"line_number":13,"context_line":"Closes-Bug: #1666529"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7ffa3b31_a6d30a60","line":10,"updated":"2017-04-20 13:00:19.000000000","message":"This needs to be updated to match what the patch does.","commit_id":"fb4e1c760d64bb6cbb1c8053175e8b40ae4a15de"}],"cinder/utils.py":[{"author":{"_account_id":20191,"name":"Dinesh Bhor","email":"bhordinesh07@gmail.com","username":"dineshbhor"},"change_message_id":"3e0a56cb5e028a09eb7ec83e82cb5c843fe96e0b","unresolved":false,"context_lines":[{"line_number":1035,"context_line":"    :param max_length: the max_length of the integer"},{"line_number":1036,"context_line":"    :returns: integer"},{"line_number":1037,"context_line":"    \"\"\""},{"line_number":1038,"context_line":"    if isinstance(value, str):"},{"line_number":1039,"context_line":"        if not value.isdigit():"},{"line_number":1040,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003d("},{"line_number":1041,"context_line":"                _(\u0027%s must be an integer.\u0027) % name))"}],"source_content_type":"text/x-python","patch_set":1,"id":"bff0334d_717654a7","line":1038,"range":{"start_line":1038,"start_character":25,"end_line":1038,"end_character":29},"updated":"2017-04-06 12:17:24.000000000","message":"You should use six.string_types instead of \u0027str\u0027 otherwise it fails to handle unicodes.","commit_id":"40fa5b0b0f1287d92af5ebd0437a00fb69a72650"},{"author":{"_account_id":20191,"name":"Dinesh Bhor","email":"bhordinesh07@gmail.com","username":"dineshbhor"},"change_message_id":"3e0a56cb5e028a09eb7ec83e82cb5c843fe96e0b","unresolved":false,"context_lines":[{"line_number":1041,"context_line":"                _(\u0027%s must be an integer.\u0027) % name))"},{"line_number":1042,"context_line":"        else:"},{"line_number":1043,"context_line":"            value \u003d int(value)"},{"line_number":1044,"context_line":"    elif not isinstance(value, int):"},{"line_number":1045,"context_line":"        raise webob.exc.HTTPBadRequest(explanation\u003d("},{"line_number":1046,"context_line":"            _(\u0027%s must be an integer.\u0027) % name))"},{"line_number":1047,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bff0334d_9160b8d0","line":1044,"range":{"start_line":1044,"start_character":31,"end_line":1044,"end_character":34},"updated":"2017-04-06 12:17:24.000000000","message":"ditto. You should use six.integer_types.","commit_id":"40fa5b0b0f1287d92af5ebd0437a00fb69a72650"},{"author":{"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},"change_message_id":"0d08b576ab1262002ca98cab98a659bcad2d7b16","unresolved":false,"context_lines":[{"line_number":1035,"context_line":"    :param max_length: the max_length of the integer"},{"line_number":1036,"context_line":"    :returns: integer"},{"line_number":1037,"context_line":"    \"\"\""},{"line_number":1038,"context_line":"    if isinstance(value, six.string_types):"},{"line_number":1039,"context_line":"        if not strutils.is_int_like(value):"},{"line_number":1040,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003d("},{"line_number":1041,"context_line":"                _(\u0027%s must be an integer.\u0027) % name))"},{"line_number":1042,"context_line":"        else:"},{"line_number":1043,"context_line":"            value \u003d int(value)"},{"line_number":1044,"context_line":"    elif not isinstance(value, six.integer_types):"},{"line_number":1045,"context_line":"        raise webob.exc.HTTPBadRequest(explanation\u003d("},{"line_number":1046,"context_line":"            _(\u0027%s must be an integer.\u0027) % name))"},{"line_number":1047,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bff0334d_d1b7cef4","line":1044,"range":{"start_line":1038,"start_character":0,"end_line":1044,"end_character":50},"updated":"2017-04-11 13:58:14.000000000","message":"Why we actually need it, if strutils.is_int_like makes the same?\nhttps://github.com/openstack/oslo.utils/blob/master/oslo_utils/strutils.py#L394","commit_id":"a7a4de5475695201e88c082c6a9168a55142ff6d"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"97587a3cc8c9e52a9292112b31b9d2efc1910541","unresolved":false,"context_lines":[{"line_number":1038,"context_line":"    if not strutils.is_int_like(value):"},{"line_number":1039,"context_line":"        raise webob.exc.HTTPBadRequest(explanation\u003d("},{"line_number":1040,"context_line":"            _(\u0027%s must be an integer.\u0027) % name))"},{"line_number":1041,"context_line":"    else:"},{"line_number":1042,"context_line":"        value \u003d int(value)"},{"line_number":1043,"context_line":""},{"line_number":1044,"context_line":"    if min_value is not None and value \u003c min_value:"}],"source_content_type":"text/x-python","patch_set":5,"id":"7ffa3b31_46f566ec","line":1041,"updated":"2017-04-20 13:00:19.000000000","message":"No need to have this in an \"else\".","commit_id":"fb4e1c760d64bb6cbb1c8053175e8b40ae4a15de"}]}