)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"ca60eda7e925fd242ffd376f15a506a3a2fab4a7","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Satyajeet Shahane \u003csatyajeet.shahane@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-04-06 22:15:48 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"A new column \u0027revision_number\u0027 is added  to the \u0027transfers\u0027 table"},{"line_number":8,"context_line":"and queries which update this table need to need to be modified to"},{"line_number":9,"context_line":"account for this change."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Implements: blueprint ha-db-object-version-counter"},{"line_number":12,"context_line":"Co-Authored-By: Szymon Wroblewski \u003cszymon.wroblewski@intel.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bff0334d_d3e4e4ae","line":9,"range":{"start_line":7,"start_character":0,"end_line":9,"end_character":24},"updated":"2017-04-07 06:05:30.000000000","message":"Blank line is needed after your header","commit_id":"881c00c2869d72f8b8448a725ab796a45d488478"},{"author":{"_account_id":25233,"name":"Satyajeet Shahane","email":"satyajeet.shahane@intel.com","username":"satya1304"},"change_message_id":"83b0f76773ccb0cd7721fa8c6906a206f070f8c6","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Satyajeet Shahane \u003csatyajeet.shahane@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-04-06 22:15:48 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"A new column \u0027revision_number\u0027 is added  to the \u0027transfers\u0027 table"},{"line_number":8,"context_line":"and queries which update this table need to need to be modified to"},{"line_number":9,"context_line":"account for this change."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Implements: blueprint ha-db-object-version-counter"},{"line_number":12,"context_line":"Co-Authored-By: Szymon Wroblewski \u003cszymon.wroblewski@intel.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bff0334d_264df499","line":9,"range":{"start_line":7,"start_character":0,"end_line":9,"end_character":24},"in_reply_to":"bff0334d_d3e4e4ae","updated":"2017-04-07 18:19:12.000000000","message":"Done","commit_id":"881c00c2869d72f8b8448a725ab796a45d488478"},{"author":{"_account_id":20191,"name":"Dinesh Bhor","email":"bhordinesh07@gmail.com","username":"dineshbhor"},"change_message_id":"33dae20ac0a4fb48ac86fc3326d55da578ffdeb7","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update \u0027update\u0027 queries for transfers table"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"A new column \u0027revision_number\u0027 is added  to the \u0027transfers\u0027 table"},{"line_number":10,"context_line":"and queries which update this table need to need to be modified to"},{"line_number":11,"context_line":"account for this change."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"df140735_20c37e5f","line":9,"range":{"start_line":9,"start_character":40,"end_line":9,"end_character":41},"updated":"2017-06-02 07:23:22.000000000","message":"nit: extra space.","commit_id":"914edf714397c89c4271ee0f5ef625a593e4a52a"},{"author":{"_account_id":20191,"name":"Dinesh Bhor","email":"bhordinesh07@gmail.com","username":"dineshbhor"},"change_message_id":"33dae20ac0a4fb48ac86fc3326d55da578ffdeb7","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Update \u0027update\u0027 queries for transfers table"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"A new column \u0027revision_number\u0027 is added  to the \u0027transfers\u0027 table"},{"line_number":10,"context_line":"and queries which update this table need to need to be modified to"},{"line_number":11,"context_line":"account for this change."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Implements: blueprint ha-db-object-version-counter"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"df140735_a0ce6e7f","line":10,"range":{"start_line":10,"start_character":36,"end_line":10,"end_character":51},"updated":"2017-06-02 07:23:22.000000000","message":"s/need to need to/need to","commit_id":"914edf714397c89c4271ee0f5ef625a593e4a52a"}],"cinder/api/contrib/volume_transfer.py":[{"author":{"_account_id":20191,"name":"Dinesh Bhor","email":"bhordinesh07@gmail.com","username":"dineshbhor"},"change_message_id":"33dae20ac0a4fb48ac86fc3326d55da578ffdeb7","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        except exception.InvalidVolume as error:"},{"line_number":136,"context_line":"            raise exc.HTTPBadRequest(explanation\u003derror.msg)"},{"line_number":137,"context_line":"        except exception.TransferRevisionMismatch as error:"},{"line_number":138,"context_line":"            raise exc.HTTPInternalServerError(explanation\u003derror.msg)"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"        transfer \u003d \\"},{"line_number":141,"context_line":"            self._view_builder.summary(req,"}],"source_content_type":"text/x-python","patch_set":5,"id":"df140735_200dbea0","line":138,"range":{"start_line":138,"start_character":18,"end_line":138,"end_character":45},"updated":"2017-06-02 07:23:22.000000000","message":"Not sure whether we should return 500 for both the cases.","commit_id":"914edf714397c89c4271ee0f5ef625a593e4a52a"}],"cinder/db/sqlalchemy/api.py":[{"author":{"_account_id":20191,"name":"Dinesh Bhor","email":"bhordinesh07@gmail.com","username":"dineshbhor"},"change_message_id":"33dae20ac0a4fb48ac86fc3326d55da578ffdeb7","unresolved":false,"context_lines":[{"line_number":5165,"context_line":"        if not conditional_update(context, models.Transfer,"},{"line_number":5166,"context_line":"                                  update_t, expected_t, session\u003dsession):"},{"line_number":5167,"context_line":"            msg \u003d (_(\u0027Transfer %(transfer_id)s: Volume id %(volume_id)s \u0027"},{"line_number":5168,"context_line":"                     \u0027accept overriden by some other operation on this \u0027"},{"line_number":5169,"context_line":"                     \u0027transfer\u0027)"},{"line_number":5170,"context_line":"                   % {\u0027transfer_id\u0027: transfer_id, \u0027volume_id\u0027: volume_id})"},{"line_number":5171,"context_line":"            LOG.error(msg)"}],"source_content_type":"text/x-python","patch_set":5,"id":"df140735_c0cde266","line":5168,"range":{"start_line":5168,"start_character":29,"end_line":5168,"end_character":38},"updated":"2017-06-02 07:23:22.000000000","message":"s/overriden/overridden","commit_id":"914edf714397c89c4271ee0f5ef625a593e4a52a"}],"cinder/tests/unit/api/contrib/test_volume_transfer.py":[{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"97de17a330f3245f376a6bc13b400e2f1e20a9b8","unresolved":false,"context_lines":[{"line_number":339,"context_line":"    def test_delete_transfer_InternalServerError(self):"},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"        def fake_throw_InternalServerError(self, context, transfer_id):"},{"line_number":342,"context_line":"            raise exc.HTTPInternalServerError(\"Hello worl\")"},{"line_number":343,"context_line":""},{"line_number":344,"context_line":"        self.mock_object("},{"line_number":345,"context_line":"            cinder.transfer.API,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7ffa3b31_4bfec3ae","line":342,"range":{"start_line":342,"start_character":46,"end_line":342,"end_character":59},"updated":"2017-04-19 07:32:32.000000000","message":"Hello world? Suggest to use some worlds more meaningful here.","commit_id":"914edf714397c89c4271ee0f5ef625a593e4a52a"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"97de17a330f3245f376a6bc13b400e2f1e20a9b8","unresolved":false,"context_lines":[{"line_number":341,"context_line":"        def fake_throw_InternalServerError(self, context, transfer_id):"},{"line_number":342,"context_line":"            raise exc.HTTPInternalServerError(\"Hello worl\")"},{"line_number":343,"context_line":""},{"line_number":344,"context_line":"        self.mock_object("},{"line_number":345,"context_line":"            cinder.transfer.API,"},{"line_number":346,"context_line":"            \u0027delete\u0027,"},{"line_number":347,"context_line":"            fake_throw_InternalServerError)"},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"        volume_id \u003d self._create_volume()"},{"line_number":350,"context_line":"        transfer \u003d self._create_transfer(volume_id)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7ffa3b31_4e5ff10d","line":347,"range":{"start_line":344,"start_character":6,"end_line":347,"end_character":43},"updated":"2017-04-19 07:32:32.000000000","message":"We don\u0027t need to define a method and raise a exception inside, side_effect is enough for your case.","commit_id":"914edf714397c89c4271ee0f5ef625a593e4a52a"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"97de17a330f3245f376a6bc13b400e2f1e20a9b8","unresolved":false,"context_lines":[{"line_number":541,"context_line":"                         \"allowed (1) exceeded for quota \u0027volumes\u0027.\","},{"line_number":542,"context_line":"                         res_dict[\u0027overLimit\u0027][\u0027message\u0027])"},{"line_number":543,"context_line":""},{"line_number":544,"context_line":"    def test_accept_transfer_InternalServerError(self):"},{"line_number":545,"context_line":""},{"line_number":546,"context_line":"        def fake_throw_InternalServerError(self, context,"},{"line_number":547,"context_line":"                                           transfer_id, auth_key):"},{"line_number":548,"context_line":"            raise exc.HTTPInternalServerError(\"Hello worl\")"},{"line_number":549,"context_line":""},{"line_number":550,"context_line":"        self.mock_object("},{"line_number":551,"context_line":"            cinder.transfer.API,"},{"line_number":552,"context_line":"            \u0027accept\u0027,"},{"line_number":553,"context_line":"            fake_throw_InternalServerError)"},{"line_number":554,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7ffa3b31_0ed68950","line":551,"range":{"start_line":544,"start_character":3,"end_line":551,"end_character":32},"updated":"2017-04-19 07:32:32.000000000","message":"These two testcases below can be combined with ddt.","commit_id":"914edf714397c89c4271ee0f5ef625a593e4a52a"}]}