)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"02029c65a4964aed1d5762f1b2ade4017fc91e34","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Eric Young \u003ceric@aceshome.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-04-02 09:54:00 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"ScaleIO: Adding Generic Group support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adding support for generic groups by proxying requests"},{"line_number":10,"context_line":"through to the existing consistency group support"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dfeb2761_c687660f","line":7,"updated":"2017-04-04 01:34:14.000000000","message":"ScaleIO: Adding CG support to groups","commit_id":"774bf0db0595e8303deeae3bd0a84dd6b55fa608"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"02029c65a4964aed1d5762f1b2ade4017fc91e34","unresolved":false,"context_lines":[{"line_number":7,"context_line":"ScaleIO: Adding Generic Group support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adding support for generic groups by proxying requests"},{"line_number":10,"context_line":"through to the existing consistency group support"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Iae4dc241137a78db74b8f29b3df540fb3eb89008"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dfeb2761_e684aa0e","line":10,"updated":"2017-04-04 01:34:14.000000000","message":"Generic volume groups is already supported by every driver by default.  Can you change to the following:\n\nAdding consistency group support to generic volume groups in the ScaleIO driver.","commit_id":"774bf0db0595e8303deeae3bd0a84dd6b55fa608"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"02029c65a4964aed1d5762f1b2ade4017fc91e34","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adding support for generic groups by proxying requests"},{"line_number":10,"context_line":"through to the existing consistency group support"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Iae4dc241137a78db74b8f29b3df540fb3eb89008"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dfeb2761_86903e50","line":11,"updated":"2017-04-04 01:34:14.000000000","message":"Please register a blueprint and reference here.","commit_id":"774bf0db0595e8303deeae3bd0a84dd6b55fa608"}],"cinder/tests/unit/volume/drivers/dell_emc/scaleio/test_groups.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"02029c65a4964aed1d5762f1b2ade4017fc91e34","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class TestGroups(scaleio.TestScaleIODriver):"},{"line_number":29,"context_line":"    \"\"\"Test cases for ``ScaleIODriver consistency groups support``\"\"\""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def setUp(self):"},{"line_number":32,"context_line":"        \"\"\"Setup a test case environment."}],"source_content_type":"text/x-python","patch_set":1,"id":"dfeb2761_46c1162e","line":29,"range":{"start_line":29,"start_character":38,"end_line":29,"end_character":56},"updated":"2017-04-04 01:34:14.000000000","message":"groups","commit_id":"774bf0db0595e8303deeae3bd0a84dd6b55fa608"},{"author":{"_account_id":25033,"name":"Eric Young","email":"eric.young@dell.com","username":"tssgery"},"change_message_id":"51195be1c54549614ed855404e6fd9409863e59c","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class TestGroups(scaleio.TestScaleIODriver):"},{"line_number":29,"context_line":"    \"\"\"Test cases for ``ScaleIODriver consistency groups support``\"\"\""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def setUp(self):"},{"line_number":32,"context_line":"        \"\"\"Setup a test case environment."}],"source_content_type":"text/x-python","patch_set":1,"id":"dfeb2761_5179c52c","line":29,"range":{"start_line":29,"start_character":38,"end_line":29,"end_character":56},"in_reply_to":"dfeb2761_46c1162e","updated":"2017-04-04 15:32:17.000000000","message":"Done","commit_id":"774bf0db0595e8303deeae3bd0a84dd6b55fa608"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"fcd90f3cf53c0e46f63455792887d44a9628b89e","unresolved":false,"context_lines":[{"line_number":103,"context_line":"            },"},{"line_number":104,"context_line":"        }"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    def _fake_cgsnapshot(self):"},{"line_number":107,"context_line":"        cgsnap \u003d {\u0027id\u0027: \u0027cgsid\u0027, \u0027name\u0027: \u0027testsnap\u0027,"},{"line_number":108,"context_line":"                  \u0027consistencygroup_id\u0027: fake.GROUP_ID,"},{"line_number":109,"context_line":"                  \u0027status\u0027: \u0027available\u0027}"}],"source_content_type":"text/x-python","patch_set":2,"id":"dfeb2761_41967741","line":106,"updated":"2017-04-05 01:31:05.000000000","message":"This is not used.  Change it to _fake_group_snapshot when you add tests for group_snapshots.","commit_id":"28293acd4e72172b21f5d0df3bf94fc1c3eb936b"},{"author":{"_account_id":25033,"name":"Eric Young","email":"eric.young@dell.com","username":"tssgery"},"change_message_id":"5316d18618a529592752aa72718b2fcfae6533b4","unresolved":false,"context_lines":[{"line_number":103,"context_line":"            },"},{"line_number":104,"context_line":"        }"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    def _fake_cgsnapshot(self):"},{"line_number":107,"context_line":"        cgsnap \u003d {\u0027id\u0027: \u0027cgsid\u0027, \u0027name\u0027: \u0027testsnap\u0027,"},{"line_number":108,"context_line":"                  \u0027consistencygroup_id\u0027: fake.GROUP_ID,"},{"line_number":109,"context_line":"                  \u0027status\u0027: \u0027available\u0027}"}],"source_content_type":"text/x-python","patch_set":2,"id":"bff0334d_c1c68e17","line":106,"in_reply_to":"dfeb2761_41967741","updated":"2017-04-05 21:34:20.000000000","message":"this was actually un-needed. Removed.","commit_id":"28293acd4e72172b21f5d0df3bf94fc1c3eb936b"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"fcd90f3cf53c0e46f63455792887d44a9628b89e","unresolved":false,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    def _fake_cgsnapshot(self):"},{"line_number":107,"context_line":"        cgsnap \u003d {\u0027id\u0027: \u0027cgsid\u0027, \u0027name\u0027: \u0027testsnap\u0027,"},{"line_number":108,"context_line":"                  \u0027consistencygroup_id\u0027: fake.GROUP_ID,"},{"line_number":109,"context_line":"                  \u0027status\u0027: \u0027available\u0027}"},{"line_number":110,"context_line":"        return cgsnap"},{"line_number":111,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"dfeb2761_c17cc720","line":108,"range":{"start_line":108,"start_character":19,"end_line":108,"end_character":38},"updated":"2017-04-05 01:31:05.000000000","message":"Use group_id","commit_id":"28293acd4e72172b21f5d0df3bf94fc1c3eb936b"},{"author":{"_account_id":25033,"name":"Eric Young","email":"eric.young@dell.com","username":"tssgery"},"change_message_id":"5316d18618a529592752aa72718b2fcfae6533b4","unresolved":false,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    def _fake_cgsnapshot(self):"},{"line_number":107,"context_line":"        cgsnap \u003d {\u0027id\u0027: \u0027cgsid\u0027, \u0027name\u0027: \u0027testsnap\u0027,"},{"line_number":108,"context_line":"                  \u0027consistencygroup_id\u0027: fake.GROUP_ID,"},{"line_number":109,"context_line":"                  \u0027status\u0027: \u0027available\u0027}"},{"line_number":110,"context_line":"        return cgsnap"},{"line_number":111,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bff0334d_e14bd2ad","line":108,"range":{"start_line":108,"start_character":19,"end_line":108,"end_character":38},"in_reply_to":"dfeb2761_c17cc720","updated":"2017-04-05 21:34:20.000000000","message":"n/a","commit_id":"28293acd4e72172b21f5d0df3bf94fc1c3eb936b"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"fcd90f3cf53c0e46f63455792887d44a9628b89e","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        self.assertEqual(\u0027available\u0027, result_model_update[\u0027status\u0027])"},{"line_number":147,"context_line":"        get_pid \u003d lambda snapshot: snapshot[\u0027provider_id\u0027]"},{"line_number":148,"context_line":"        volume_provider_list \u003d list(map(get_pid, result_volumes_model_update))"},{"line_number":149,"context_line":"        self.assertListEqual(volume_provider_list, [\u0027sid1\u0027, \u0027sid2\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"dfeb2761_01874f11","line":149,"updated":"2017-04-05 01:31:05.000000000","message":"Please add tests for create_group_snapshot, delete_group_snapshot, update_group, and create_group_from_src with group_snapshot as source.","commit_id":"28293acd4e72172b21f5d0df3bf94fc1c3eb936b"},{"author":{"_account_id":25033,"name":"Eric Young","email":"eric.young@dell.com","username":"tssgery"},"change_message_id":"5316d18618a529592752aa72718b2fcfae6533b4","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        self.assertEqual(\u0027available\u0027, result_model_update[\u0027status\u0027])"},{"line_number":147,"context_line":"        get_pid \u003d lambda snapshot: snapshot[\u0027provider_id\u0027]"},{"line_number":148,"context_line":"        volume_provider_list \u003d list(map(get_pid, result_volumes_model_update))"},{"line_number":149,"context_line":"        self.assertListEqual(volume_provider_list, [\u0027sid1\u0027, \u0027sid2\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"bff0334d_e1e07299","line":149,"in_reply_to":"dfeb2761_01874f11","updated":"2017-04-05 21:34:20.000000000","message":"Done.","commit_id":"28293acd4e72172b21f5d0df3bf94fc1c3eb936b"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"60b706e99bd2259399c8879ac33c519ecba606fb","unresolved":false,"context_lines":[{"line_number":182,"context_line":"                         result_model_update[\u0027status\u0027])"},{"line_number":183,"context_line":"        get_pid \u003d lambda snapshot: snapshot[\u0027provider_id\u0027]"},{"line_number":184,"context_line":"        volume_provider_list \u003d list(map(get_pid, result_volumes_model_update))"},{"line_number":185,"context_line":"        self.assertListEqual(volume_provider_list, [\u0027sid1\u0027, \u0027sid2\u0027])"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"    @mock.patch(\u0027cinder.volume.utils.is_group_a_cg_snapshot_type\u0027)"},{"line_number":188,"context_line":"    def test_delete_group_snapshot(self, is_group_a_cg_snapshot_type):"}],"source_content_type":"text/x-python","patch_set":4,"id":"bff0334d_45e095cd","line":185,"updated":"2017-04-11 17:14:22.000000000","message":"Can you add a test for create group from a group_snapshot?","commit_id":"03cc754f96b302469ea1e81395e0c8a4ac992b48"},{"author":{"_account_id":25033,"name":"Eric Young","email":"eric.young@dell.com","username":"tssgery"},"change_message_id":"0887a7ec5d7d3f541762dff86be219ea569fb715","unresolved":false,"context_lines":[{"line_number":182,"context_line":"                         result_model_update[\u0027status\u0027])"},{"line_number":183,"context_line":"        get_pid \u003d lambda snapshot: snapshot[\u0027provider_id\u0027]"},{"line_number":184,"context_line":"        volume_provider_list \u003d list(map(get_pid, result_volumes_model_update))"},{"line_number":185,"context_line":"        self.assertListEqual(volume_provider_list, [\u0027sid1\u0027, \u0027sid2\u0027])"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"    @mock.patch(\u0027cinder.volume.utils.is_group_a_cg_snapshot_type\u0027)"},{"line_number":188,"context_line":"    def test_delete_group_snapshot(self, is_group_a_cg_snapshot_type):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ff52f3f_1d8e1478","line":185,"in_reply_to":"bff0334d_45e095cd","updated":"2017-04-13 14:30:25.000000000","message":"Added","commit_id":"03cc754f96b302469ea1e81395e0c8a4ac992b48"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"60b706e99bd2259399c8879ac33c519ecba606fb","unresolved":false,"context_lines":[{"line_number":211,"context_line":"                self.group,"},{"line_number":212,"context_line":"                self.snapshots"},{"line_number":213,"context_line":"            ))"},{"line_number":214,"context_line":"        self.assertEqual(fields.GroupStatus.DELETED,"},{"line_number":215,"context_line":"                         result_model_update[\u0027status\u0027])"},{"line_number":216,"context_line":"        self.assertTrue(all(snapshot[\u0027status\u0027] \u003d\u003d \u0027deleted\u0027 for snapshot in"},{"line_number":217,"context_line":"                            result_snapshot_model_update))"}],"source_content_type":"text/x-python","patch_set":4,"id":"bff0334d_458d3530","line":214,"range":{"start_line":214,"start_character":32,"end_line":214,"end_character":43},"updated":"2017-04-11 17:14:22.000000000","message":"GroupSnapshotStatus","commit_id":"03cc754f96b302469ea1e81395e0c8a4ac992b48"},{"author":{"_account_id":25033,"name":"Eric Young","email":"eric.young@dell.com","username":"tssgery"},"change_message_id":"0887a7ec5d7d3f541762dff86be219ea569fb715","unresolved":false,"context_lines":[{"line_number":211,"context_line":"                self.group,"},{"line_number":212,"context_line":"                self.snapshots"},{"line_number":213,"context_line":"            ))"},{"line_number":214,"context_line":"        self.assertEqual(fields.GroupStatus.DELETED,"},{"line_number":215,"context_line":"                         result_model_update[\u0027status\u0027])"},{"line_number":216,"context_line":"        self.assertTrue(all(snapshot[\u0027status\u0027] \u003d\u003d \u0027deleted\u0027 for snapshot in"},{"line_number":217,"context_line":"                            result_snapshot_model_update))"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ff52f3f_dded4c26","line":214,"range":{"start_line":214,"start_character":32,"end_line":214,"end_character":43},"in_reply_to":"bff0334d_458d3530","updated":"2017-04-13 14:30:25.000000000","message":"Done","commit_id":"03cc754f96b302469ea1e81395e0c8a4ac992b48"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"60b706e99bd2259399c8879ac33c519ecba606fb","unresolved":false,"context_lines":[{"line_number":238,"context_line":"                self.group,"},{"line_number":239,"context_line":"                self.snapshots"},{"line_number":240,"context_line":"            ))"},{"line_number":241,"context_line":"        self.assertEqual(fields.GroupStatus.AVAILABLE,"},{"line_number":242,"context_line":"                         result_model_update[\u0027status\u0027])"},{"line_number":243,"context_line":"        self.assertTrue(all(snapshot[\u0027status\u0027] \u003d\u003d \u0027available\u0027 for snapshot in"},{"line_number":244,"context_line":"                            result_snapshot_model_update))"}],"source_content_type":"text/x-python","patch_set":4,"id":"bff0334d_a592c155","line":241,"range":{"start_line":241,"start_character":32,"end_line":241,"end_character":43},"updated":"2017-04-11 17:14:22.000000000","message":"GroupSnapshotStatus","commit_id":"03cc754f96b302469ea1e81395e0c8a4ac992b48"},{"author":{"_account_id":25033,"name":"Eric Young","email":"eric.young@dell.com","username":"tssgery"},"change_message_id":"0887a7ec5d7d3f541762dff86be219ea569fb715","unresolved":false,"context_lines":[{"line_number":238,"context_line":"                self.group,"},{"line_number":239,"context_line":"                self.snapshots"},{"line_number":240,"context_line":"            ))"},{"line_number":241,"context_line":"        self.assertEqual(fields.GroupStatus.AVAILABLE,"},{"line_number":242,"context_line":"                         result_model_update[\u0027status\u0027])"},{"line_number":243,"context_line":"        self.assertTrue(all(snapshot[\u0027status\u0027] \u003d\u003d \u0027available\u0027 for snapshot in"},{"line_number":244,"context_line":"                            result_snapshot_model_update))"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ff52f3f_bdf28805","line":241,"range":{"start_line":241,"start_character":32,"end_line":241,"end_character":43},"in_reply_to":"bff0334d_a592c155","updated":"2017-04-13 14:30:25.000000000","message":"Done","commit_id":"03cc754f96b302469ea1e81395e0c8a4ac992b48"}],"cinder/volume/drivers/dell_emc/scaleio/driver.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"02029c65a4964aed1d5762f1b2ade4017fc91e34","unresolved":false,"context_lines":[{"line_number":1251,"context_line":"                reason\u003dreason"},{"line_number":1252,"context_line":"            )"},{"line_number":1253,"context_line":""},{"line_number":1254,"context_line":"    def create_consistencygroup(self, context, group):"},{"line_number":1255,"context_line":"        \"\"\"Creates a consistency group."},{"line_number":1256,"context_line":""},{"line_number":1257,"context_line":"        ScaleIO won\u0027t create CG until cg-snapshot creation,"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfeb2761_464476b7","line":1254,"range":{"start_line":1254,"start_character":8,"end_line":1254,"end_character":31},"updated":"2017-04-04 01:34:14.000000000","message":"There\u0027s no need to keep consistency group interfaces in driver any more because users will be forced to migrate data from consistencygroups to the new groups tables in Pike.  Most of the CG code are already removed by this patch: https://review.openstack.org/#/c/446018/\n\nYou can just change this to create_group.","commit_id":"774bf0db0595e8303deeae3bd0a84dd6b55fa608"},{"author":{"_account_id":25033,"name":"Eric Young","email":"eric.young@dell.com","username":"tssgery"},"change_message_id":"51195be1c54549614ed855404e6fd9409863e59c","unresolved":false,"context_lines":[{"line_number":1251,"context_line":"                reason\u003dreason"},{"line_number":1252,"context_line":"            )"},{"line_number":1253,"context_line":""},{"line_number":1254,"context_line":"    def create_consistencygroup(self, context, group):"},{"line_number":1255,"context_line":"        \"\"\"Creates a consistency group."},{"line_number":1256,"context_line":""},{"line_number":1257,"context_line":"        ScaleIO won\u0027t create CG until cg-snapshot creation,"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfeb2761_519e6554","line":1254,"range":{"start_line":1254,"start_character":8,"end_line":1254,"end_character":31},"in_reply_to":"dfeb2761_464476b7","updated":"2017-04-04 15:32:17.000000000","message":"Done","commit_id":"774bf0db0595e8303deeae3bd0a84dd6b55fa608"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"02029c65a4964aed1d5762f1b2ade4017fc91e34","unresolved":false,"context_lines":[{"line_number":1261,"context_line":"        model_update \u003d {\u0027status\u0027: \u0027available\u0027}"},{"line_number":1262,"context_line":"        return model_update"},{"line_number":1263,"context_line":""},{"line_number":1264,"context_line":"    def delete_consistencygroup(self, context, group, volumes):"},{"line_number":1265,"context_line":"        \"\"\"Deletes a consistency group."},{"line_number":1266,"context_line":""},{"line_number":1267,"context_line":"        ScaleIO will delete the volumes of the CG."}],"source_content_type":"text/x-python","patch_set":1,"id":"dfeb2761_2615f29c","line":1264,"range":{"start_line":1264,"start_character":8,"end_line":1264,"end_character":31},"updated":"2017-04-04 01:34:14.000000000","message":"Replace it with delete_group","commit_id":"774bf0db0595e8303deeae3bd0a84dd6b55fa608"},{"author":{"_account_id":25033,"name":"Eric Young","email":"eric.young@dell.com","username":"tssgery"},"change_message_id":"51195be1c54549614ed855404e6fd9409863e59c","unresolved":false,"context_lines":[{"line_number":1261,"context_line":"        model_update \u003d {\u0027status\u0027: \u0027available\u0027}"},{"line_number":1262,"context_line":"        return model_update"},{"line_number":1263,"context_line":""},{"line_number":1264,"context_line":"    def delete_consistencygroup(self, context, group, volumes):"},{"line_number":1265,"context_line":"        \"\"\"Deletes a consistency group."},{"line_number":1266,"context_line":""},{"line_number":1267,"context_line":"        ScaleIO will delete the volumes of the CG."}],"source_content_type":"text/x-python","patch_set":1,"id":"dfeb2761_11a8dd74","line":1264,"range":{"start_line":1264,"start_character":8,"end_line":1264,"end_character":31},"in_reply_to":"dfeb2761_2615f29c","updated":"2017-04-04 15:32:17.000000000","message":"Done","commit_id":"774bf0db0595e8303deeae3bd0a84dd6b55fa608"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"02029c65a4964aed1d5762f1b2ade4017fc91e34","unresolved":false,"context_lines":[{"line_number":1287,"context_line":"                          {\u0027vol\u0027: volume[\u0027name\u0027], \u0027exception\u0027: err})"},{"line_number":1288,"context_line":"        return model_update, volumes_model_update"},{"line_number":1289,"context_line":""},{"line_number":1290,"context_line":"    def create_cgsnapshot(self, context, cgsnapshot, snapshots):"},{"line_number":1291,"context_line":"        \"\"\"Creates a cgsnapshot.\"\"\""},{"line_number":1292,"context_line":"        get_scaleio_snapshot_params \u003d lambda snapshot: {"},{"line_number":1293,"context_line":"            \u0027volumeId\u0027: snapshot.volume[\u0027provider_id\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfeb2761_e60eea8b","line":1290,"range":{"start_line":1290,"start_character":8,"end_line":1290,"end_character":25},"updated":"2017-04-04 01:34:14.000000000","message":"create_group_snapshot","commit_id":"774bf0db0595e8303deeae3bd0a84dd6b55fa608"},{"author":{"_account_id":25033,"name":"Eric Young","email":"eric.young@dell.com","username":"tssgery"},"change_message_id":"51195be1c54549614ed855404e6fd9409863e59c","unresolved":false,"context_lines":[{"line_number":1287,"context_line":"                          {\u0027vol\u0027: volume[\u0027name\u0027], \u0027exception\u0027: err})"},{"line_number":1288,"context_line":"        return model_update, volumes_model_update"},{"line_number":1289,"context_line":""},{"line_number":1290,"context_line":"    def create_cgsnapshot(self, context, cgsnapshot, snapshots):"},{"line_number":1291,"context_line":"        \"\"\"Creates a cgsnapshot.\"\"\""},{"line_number":1292,"context_line":"        get_scaleio_snapshot_params \u003d lambda snapshot: {"},{"line_number":1293,"context_line":"            \u0027volumeId\u0027: snapshot.volume[\u0027provider_id\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfeb2761_f1b8d9c8","line":1290,"range":{"start_line":1290,"start_character":8,"end_line":1290,"end_character":25},"in_reply_to":"dfeb2761_e60eea8b","updated":"2017-04-04 15:32:17.000000000","message":"Done","commit_id":"774bf0db0595e8303deeae3bd0a84dd6b55fa608"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"02029c65a4964aed1d5762f1b2ade4017fc91e34","unresolved":false,"context_lines":[{"line_number":1310,"context_line":"        model_update \u003d {\u0027status\u0027: \u0027available\u0027}"},{"line_number":1311,"context_line":"        return model_update, snapshot_model_update"},{"line_number":1312,"context_line":""},{"line_number":1313,"context_line":"    def delete_cgsnapshot(self, context, cgsnapshot, snapshots):"},{"line_number":1314,"context_line":"        \"\"\"Deletes a cgsnapshot.\"\"\""},{"line_number":1315,"context_line":"        error_statuses \u003d [\u0027error\u0027, \u0027error_deleting\u0027]"},{"line_number":1316,"context_line":"        model_update \u003d {\u0027status\u0027: cgsnapshot[\u0027status\u0027]}"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfeb2761_c611a6ae","line":1313,"range":{"start_line":1313,"start_character":8,"end_line":1313,"end_character":25},"updated":"2017-04-04 01:34:14.000000000","message":"delete_group_snapshot","commit_id":"774bf0db0595e8303deeae3bd0a84dd6b55fa608"},{"author":{"_account_id":25033,"name":"Eric Young","email":"eric.young@dell.com","username":"tssgery"},"change_message_id":"51195be1c54549614ed855404e6fd9409863e59c","unresolved":false,"context_lines":[{"line_number":1310,"context_line":"        model_update \u003d {\u0027status\u0027: \u0027available\u0027}"},{"line_number":1311,"context_line":"        return model_update, snapshot_model_update"},{"line_number":1312,"context_line":""},{"line_number":1313,"context_line":"    def delete_cgsnapshot(self, context, cgsnapshot, snapshots):"},{"line_number":1314,"context_line":"        \"\"\"Deletes a cgsnapshot.\"\"\""},{"line_number":1315,"context_line":"        error_statuses \u003d [\u0027error\u0027, \u0027error_deleting\u0027]"},{"line_number":1316,"context_line":"        model_update \u003d {\u0027status\u0027: cgsnapshot[\u0027status\u0027]}"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfeb2761_b1b251e5","line":1313,"range":{"start_line":1313,"start_character":8,"end_line":1313,"end_character":25},"in_reply_to":"dfeb2761_c611a6ae","updated":"2017-04-04 15:32:17.000000000","message":"Done","commit_id":"774bf0db0595e8303deeae3bd0a84dd6b55fa608"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"02029c65a4964aed1d5762f1b2ade4017fc91e34","unresolved":false,"context_lines":[{"line_number":1336,"context_line":"        model_update[\u0027status\u0027] \u003d \u0027deleted\u0027"},{"line_number":1337,"context_line":"        return model_update, snapshot_model_update"},{"line_number":1338,"context_line":""},{"line_number":1339,"context_line":"    def create_consistencygroup_from_src(self, context, group, volumes,"},{"line_number":1340,"context_line":"                                         cgsnapshot\u003dNone, snapshots\u003dNone,"},{"line_number":1341,"context_line":"                                         source_cg\u003dNone, source_vols\u003dNone):"},{"line_number":1342,"context_line":"        \"\"\"Creates a consistency group from a source.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"dfeb2761_86239e05","line":1339,"range":{"start_line":1339,"start_character":8,"end_line":1339,"end_character":40},"updated":"2017-04-04 01:34:14.000000000","message":"create_group_from_src","commit_id":"774bf0db0595e8303deeae3bd0a84dd6b55fa608"},{"author":{"_account_id":25033,"name":"Eric Young","email":"eric.young@dell.com","username":"tssgery"},"change_message_id":"51195be1c54549614ed855404e6fd9409863e59c","unresolved":false,"context_lines":[{"line_number":1336,"context_line":"        model_update[\u0027status\u0027] \u003d \u0027deleted\u0027"},{"line_number":1337,"context_line":"        return model_update, snapshot_model_update"},{"line_number":1338,"context_line":""},{"line_number":1339,"context_line":"    def create_consistencygroup_from_src(self, context, group, volumes,"},{"line_number":1340,"context_line":"                                         cgsnapshot\u003dNone, snapshots\u003dNone,"},{"line_number":1341,"context_line":"                                         source_cg\u003dNone, source_vols\u003dNone):"},{"line_number":1342,"context_line":"        \"\"\"Creates a consistency group from a source.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"dfeb2761_91b50dd0","line":1339,"range":{"start_line":1339,"start_character":8,"end_line":1339,"end_character":40},"in_reply_to":"dfeb2761_86239e05","updated":"2017-04-04 15:32:17.000000000","message":"Done","commit_id":"774bf0db0595e8303deeae3bd0a84dd6b55fa608"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"02029c65a4964aed1d5762f1b2ade4017fc91e34","unresolved":false,"context_lines":[{"line_number":1368,"context_line":"        model_update \u003d {\u0027status\u0027: \u0027available\u0027}"},{"line_number":1369,"context_line":"        return model_update, volumes_model_update"},{"line_number":1370,"context_line":""},{"line_number":1371,"context_line":"    def update_consistencygroup(self, context, group,"},{"line_number":1372,"context_line":"                                add_volumes\u003dNone, remove_volumes\u003dNone):"},{"line_number":1373,"context_line":"        \"\"\"Update a consistency group."},{"line_number":1374,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dfeb2761_461d96bb","line":1371,"range":{"start_line":1371,"start_character":8,"end_line":1371,"end_character":31},"updated":"2017-04-04 01:34:14.000000000","message":"update_group","commit_id":"774bf0db0595e8303deeae3bd0a84dd6b55fa608"},{"author":{"_account_id":25033,"name":"Eric Young","email":"eric.young@dell.com","username":"tssgery"},"change_message_id":"51195be1c54549614ed855404e6fd9409863e59c","unresolved":false,"context_lines":[{"line_number":1368,"context_line":"        model_update \u003d {\u0027status\u0027: \u0027available\u0027}"},{"line_number":1369,"context_line":"        return model_update, volumes_model_update"},{"line_number":1370,"context_line":""},{"line_number":1371,"context_line":"    def update_consistencygroup(self, context, group,"},{"line_number":1372,"context_line":"                                add_volumes\u003dNone, remove_volumes\u003dNone):"},{"line_number":1373,"context_line":"        \"\"\"Update a consistency group."},{"line_number":1374,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dfeb2761_d192754b","line":1371,"range":{"start_line":1371,"start_character":8,"end_line":1371,"end_character":31},"in_reply_to":"dfeb2761_461d96bb","updated":"2017-04-04 15:32:17.000000000","message":"Done","commit_id":"774bf0db0595e8303deeae3bd0a84dd6b55fa608"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"02029c65a4964aed1d5762f1b2ade4017fc91e34","unresolved":false,"context_lines":[{"line_number":1412,"context_line":""},{"line_number":1413,"context_line":"        # the driver treats a group as a CG internally."},{"line_number":1414,"context_line":"        # We proxy the calls to the CG api."},{"line_number":1415,"context_line":"        return self.create_consistencygroup(context, group)"},{"line_number":1416,"context_line":""},{"line_number":1417,"context_line":"    def delete_group(self, context, group, volumes):"},{"line_number":1418,"context_line":"        \"\"\"Deletes a group."}],"source_content_type":"text/x-python","patch_set":1,"id":"dfeb2761_a66d8233","line":1415,"updated":"2017-04-04 01:34:14.000000000","message":"Some other drivers check if the group is a consistent group snapshot type and decide whether to create a CG by the driver or let the default generic volume group implementation handles it.  See example here:\nhttps://review.openstack.org/#/c/444802/8/cinder/volume/drivers/ibm/storwize_svc/storwize_svc_common.py Line#3504\n\n        if utils.is_group_a_cg_snapshot_type(group):\n            return {\u0027status\u0027: fields.GroupStatus.AVAILABLE}\n        raise NotImplementedError()\n\nIf you want to always create CG, that is fine too.  VMAX driver chose to always create a CG.","commit_id":"774bf0db0595e8303deeae3bd0a84dd6b55fa608"},{"author":{"_account_id":25033,"name":"Eric Young","email":"eric.young@dell.com","username":"tssgery"},"change_message_id":"51195be1c54549614ed855404e6fd9409863e59c","unresolved":false,"context_lines":[{"line_number":1412,"context_line":""},{"line_number":1413,"context_line":"        # the driver treats a group as a CG internally."},{"line_number":1414,"context_line":"        # We proxy the calls to the CG api."},{"line_number":1415,"context_line":"        return self.create_consistencygroup(context, group)"},{"line_number":1416,"context_line":""},{"line_number":1417,"context_line":"    def delete_group(self, context, group, volumes):"},{"line_number":1418,"context_line":"        \"\"\"Deletes a group."}],"source_content_type":"text/x-python","patch_set":1,"id":"dfeb2761_b759208f","line":1415,"in_reply_to":"dfeb2761_a66d8233","updated":"2017-04-04 15:32:17.000000000","message":"Good catch, thanks. ScaleIO should let the generic volume group support handle this","commit_id":"774bf0db0595e8303deeae3bd0a84dd6b55fa608"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"fcd90f3cf53c0e46f63455792887d44a9628b89e","unresolved":false,"context_lines":[{"line_number":1263,"context_line":"        db will maintain the volumes and CG relationship."},{"line_number":1264,"context_line":"        \"\"\""},{"line_number":1265,"context_line":"        LOG.info(\"Creating Group\")"},{"line_number":1266,"context_line":"        model_update \u003d {\u0027status\u0027: \u0027available\u0027}"},{"line_number":1267,"context_line":"        return model_update"},{"line_number":1268,"context_line":""},{"line_number":1269,"context_line":"    def delete_group(self, context, group, volumes):"}],"source_content_type":"text/x-python","patch_set":2,"id":"dfeb2761_015d0fe8","line":1266,"range":{"start_line":1266,"start_character":34,"end_line":1266,"end_character":45},"updated":"2017-04-05 01:31:05.000000000","message":"fields.GroupStatus.AVAILABLE","commit_id":"28293acd4e72172b21f5d0df3bf94fc1c3eb936b"},{"author":{"_account_id":25033,"name":"Eric Young","email":"eric.young@dell.com","username":"tssgery"},"change_message_id":"5316d18618a529592752aa72718b2fcfae6533b4","unresolved":false,"context_lines":[{"line_number":1263,"context_line":"        db will maintain the volumes and CG relationship."},{"line_number":1264,"context_line":"        \"\"\""},{"line_number":1265,"context_line":"        LOG.info(\"Creating Group\")"},{"line_number":1266,"context_line":"        model_update \u003d {\u0027status\u0027: \u0027available\u0027}"},{"line_number":1267,"context_line":"        return model_update"},{"line_number":1268,"context_line":""},{"line_number":1269,"context_line":"    def delete_group(self, context, group, volumes):"}],"source_content_type":"text/x-python","patch_set":2,"id":"bff0334d_00dc8672","line":1266,"range":{"start_line":1266,"start_character":34,"end_line":1266,"end_character":45},"in_reply_to":"dfeb2761_015d0fe8","updated":"2017-04-05 21:34:20.000000000","message":"Done","commit_id":"28293acd4e72172b21f5d0df3bf94fc1c3eb936b"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"fcd90f3cf53c0e46f63455792887d44a9628b89e","unresolved":false,"context_lines":[{"line_number":1277,"context_line":"        ScaleIO will delete the volumes of the CG."},{"line_number":1278,"context_line":"        \"\"\""},{"line_number":1279,"context_line":"        LOG.info(\"Deleting Group\")"},{"line_number":1280,"context_line":"        model_update \u003d {\u0027status\u0027: \u0027deleted\u0027}"},{"line_number":1281,"context_line":"        error_statuses \u003d [\u0027error\u0027, \u0027error_deleting\u0027]"},{"line_number":1282,"context_line":"        volumes_model_update \u003d []"},{"line_number":1283,"context_line":"        for volume in volumes:"}],"source_content_type":"text/x-python","patch_set":2,"id":"dfeb2761_217c9370","line":1280,"range":{"start_line":1280,"start_character":34,"end_line":1280,"end_character":43},"updated":"2017-04-05 01:31:05.000000000","message":"from cinder.objects import fields\n\nThen use fields.GroupStatus.DELETED for \u0027deleted\u0027.  \n\nThis comment applies to all other group statuses.","commit_id":"28293acd4e72172b21f5d0df3bf94fc1c3eb936b"},{"author":{"_account_id":25033,"name":"Eric Young","email":"eric.young@dell.com","username":"tssgery"},"change_message_id":"5316d18618a529592752aa72718b2fcfae6533b4","unresolved":false,"context_lines":[{"line_number":1277,"context_line":"        ScaleIO will delete the volumes of the CG."},{"line_number":1278,"context_line":"        \"\"\""},{"line_number":1279,"context_line":"        LOG.info(\"Deleting Group\")"},{"line_number":1280,"context_line":"        model_update \u003d {\u0027status\u0027: \u0027deleted\u0027}"},{"line_number":1281,"context_line":"        error_statuses \u003d [\u0027error\u0027, \u0027error_deleting\u0027]"},{"line_number":1282,"context_line":"        volumes_model_update \u003d []"},{"line_number":1283,"context_line":"        for volume in volumes:"}],"source_content_type":"text/x-python","patch_set":2,"id":"bff0334d_e0d88280","line":1280,"range":{"start_line":1280,"start_character":34,"end_line":1280,"end_character":43},"in_reply_to":"dfeb2761_217c9370","updated":"2017-04-05 21:34:20.000000000","message":"Done","commit_id":"28293acd4e72172b21f5d0df3bf94fc1c3eb936b"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"fcd90f3cf53c0e46f63455792887d44a9628b89e","unresolved":false,"context_lines":[{"line_number":1320,"context_line":"        snapshot_model_update \u003d []"},{"line_number":1321,"context_line":"        for snapshot, scaleio_id in zip(snapshots, response[\u0027volumeIdList\u0027]):"},{"line_number":1322,"context_line":"            update_item \u003d {\u0027id\u0027: snapshot[\u0027id\u0027],"},{"line_number":1323,"context_line":"                           \u0027status\u0027: \u0027available\u0027,"},{"line_number":1324,"context_line":"                           \u0027provider_id\u0027: scaleio_id}"},{"line_number":1325,"context_line":"            snapshot_model_update.append(update_item)"},{"line_number":1326,"context_line":"        model_update \u003d {\u0027status\u0027: \u0027available\u0027}"}],"source_content_type":"text/x-python","patch_set":2,"id":"dfeb2761_41f0b7fe","line":1323,"range":{"start_line":1323,"start_character":37,"end_line":1323,"end_character":48},"updated":"2017-04-05 01:31:05.000000000","message":"Use fields.SnapshotStatus.AVAILABLE","commit_id":"28293acd4e72172b21f5d0df3bf94fc1c3eb936b"},{"author":{"_account_id":25033,"name":"Eric Young","email":"eric.young@dell.com","username":"tssgery"},"change_message_id":"5316d18618a529592752aa72718b2fcfae6533b4","unresolved":false,"context_lines":[{"line_number":1320,"context_line":"        snapshot_model_update \u003d []"},{"line_number":1321,"context_line":"        for snapshot, scaleio_id in zip(snapshots, response[\u0027volumeIdList\u0027]):"},{"line_number":1322,"context_line":"            update_item \u003d {\u0027id\u0027: snapshot[\u0027id\u0027],"},{"line_number":1323,"context_line":"                           \u0027status\u0027: \u0027available\u0027,"},{"line_number":1324,"context_line":"                           \u0027provider_id\u0027: scaleio_id}"},{"line_number":1325,"context_line":"            snapshot_model_update.append(update_item)"},{"line_number":1326,"context_line":"        model_update \u003d {\u0027status\u0027: \u0027available\u0027}"}],"source_content_type":"text/x-python","patch_set":2,"id":"bff0334d_c0e57e3a","line":1323,"range":{"start_line":1323,"start_character":37,"end_line":1323,"end_character":48},"in_reply_to":"dfeb2761_41f0b7fe","updated":"2017-04-05 21:34:20.000000000","message":"Done","commit_id":"28293acd4e72172b21f5d0df3bf94fc1c3eb936b"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"fcd90f3cf53c0e46f63455792887d44a9628b89e","unresolved":false,"context_lines":[{"line_number":1323,"context_line":"                           \u0027status\u0027: \u0027available\u0027,"},{"line_number":1324,"context_line":"                           \u0027provider_id\u0027: scaleio_id}"},{"line_number":1325,"context_line":"            snapshot_model_update.append(update_item)"},{"line_number":1326,"context_line":"        model_update \u003d {\u0027status\u0027: \u0027available\u0027}"},{"line_number":1327,"context_line":"        return model_update, snapshot_model_update"},{"line_number":1328,"context_line":""},{"line_number":1329,"context_line":"    def delete_group_snapshot(self, context, group_snapshot, snapshots):"}],"source_content_type":"text/x-python","patch_set":2,"id":"dfeb2761_01f62ffa","line":1326,"updated":"2017-04-05 01:31:05.000000000","message":"fields.GroupSnapshotStatus.AVAILABLE","commit_id":"28293acd4e72172b21f5d0df3bf94fc1c3eb936b"},{"author":{"_account_id":25033,"name":"Eric Young","email":"eric.young@dell.com","username":"tssgery"},"change_message_id":"5316d18618a529592752aa72718b2fcfae6533b4","unresolved":false,"context_lines":[{"line_number":1323,"context_line":"                           \u0027status\u0027: \u0027available\u0027,"},{"line_number":1324,"context_line":"                           \u0027provider_id\u0027: scaleio_id}"},{"line_number":1325,"context_line":"            snapshot_model_update.append(update_item)"},{"line_number":1326,"context_line":"        model_update \u003d {\u0027status\u0027: \u0027available\u0027}"},{"line_number":1327,"context_line":"        return model_update, snapshot_model_update"},{"line_number":1328,"context_line":""},{"line_number":1329,"context_line":"    def delete_group_snapshot(self, context, group_snapshot, snapshots):"}],"source_content_type":"text/x-python","patch_set":2,"id":"bff0334d_60d6b252","line":1326,"in_reply_to":"dfeb2761_01f62ffa","updated":"2017-04-05 21:34:20.000000000","message":"Done","commit_id":"28293acd4e72172b21f5d0df3bf94fc1c3eb936b"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"fcd90f3cf53c0e46f63455792887d44a9628b89e","unresolved":false,"context_lines":[{"line_number":1341,"context_line":"            try:"},{"line_number":1342,"context_line":"                self._delete_volume(snapshot.provider_id)"},{"line_number":1343,"context_line":"                update_item \u003d {\u0027id\u0027: snapshot[\u0027id\u0027],"},{"line_number":1344,"context_line":"                               \u0027status\u0027: \u0027deleted\u0027}"},{"line_number":1345,"context_line":"                snapshot_model_update.append(update_item)"},{"line_number":1346,"context_line":"            except exception.VolumeBackendAPIException as err:"},{"line_number":1347,"context_line":"                update_item \u003d {\u0027id\u0027: snapshot[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"dfeb2761_a1bd4303","line":1344,"updated":"2017-04-05 01:31:05.000000000","message":"fields.SnapshotStatus","commit_id":"28293acd4e72172b21f5d0df3bf94fc1c3eb936b"},{"author":{"_account_id":25033,"name":"Eric Young","email":"eric.young@dell.com","username":"tssgery"},"change_message_id":"5316d18618a529592752aa72718b2fcfae6533b4","unresolved":false,"context_lines":[{"line_number":1341,"context_line":"            try:"},{"line_number":1342,"context_line":"                self._delete_volume(snapshot.provider_id)"},{"line_number":1343,"context_line":"                update_item \u003d {\u0027id\u0027: snapshot[\u0027id\u0027],"},{"line_number":1344,"context_line":"                               \u0027status\u0027: \u0027deleted\u0027}"},{"line_number":1345,"context_line":"                snapshot_model_update.append(update_item)"},{"line_number":1346,"context_line":"            except exception.VolumeBackendAPIException as err:"},{"line_number":1347,"context_line":"                update_item \u003d {\u0027id\u0027: snapshot[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"bff0334d_40cbaea4","line":1344,"in_reply_to":"dfeb2761_a1bd4303","updated":"2017-04-05 21:34:20.000000000","message":"Done","commit_id":"28293acd4e72172b21f5d0df3bf94fc1c3eb936b"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"fcd90f3cf53c0e46f63455792887d44a9628b89e","unresolved":false,"context_lines":[{"line_number":1345,"context_line":"                snapshot_model_update.append(update_item)"},{"line_number":1346,"context_line":"            except exception.VolumeBackendAPIException as err:"},{"line_number":1347,"context_line":"                update_item \u003d {\u0027id\u0027: snapshot[\u0027id\u0027],"},{"line_number":1348,"context_line":"                               \u0027status\u0027: \u0027error_deleting\u0027}"},{"line_number":1349,"context_line":"                snapshot_model_update.append(update_item)"},{"line_number":1350,"context_line":"                if model_update[\u0027status\u0027] not in error_statuses:"},{"line_number":1351,"context_line":"                    model_update[\u0027status\u0027] \u003d \u0027error_deleting\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"dfeb2761_410c37ec","line":1348,"range":{"start_line":1348,"start_character":41,"end_line":1348,"end_character":57},"updated":"2017-04-05 01:31:05.000000000","message":"fields.SnapshotStatus","commit_id":"28293acd4e72172b21f5d0df3bf94fc1c3eb936b"},{"author":{"_account_id":25033,"name":"Eric Young","email":"eric.young@dell.com","username":"tssgery"},"change_message_id":"5316d18618a529592752aa72718b2fcfae6533b4","unresolved":false,"context_lines":[{"line_number":1345,"context_line":"                snapshot_model_update.append(update_item)"},{"line_number":1346,"context_line":"            except exception.VolumeBackendAPIException as err:"},{"line_number":1347,"context_line":"                update_item \u003d {\u0027id\u0027: snapshot[\u0027id\u0027],"},{"line_number":1348,"context_line":"                               \u0027status\u0027: \u0027error_deleting\u0027}"},{"line_number":1349,"context_line":"                snapshot_model_update.append(update_item)"},{"line_number":1350,"context_line":"                if model_update[\u0027status\u0027] not in error_statuses:"},{"line_number":1351,"context_line":"                    model_update[\u0027status\u0027] \u003d \u0027error_deleting\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"bff0334d_20d0aa50","line":1348,"range":{"start_line":1348,"start_character":41,"end_line":1348,"end_character":57},"in_reply_to":"dfeb2761_410c37ec","updated":"2017-04-05 21:34:20.000000000","message":"Done","commit_id":"28293acd4e72172b21f5d0df3bf94fc1c3eb936b"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"fcd90f3cf53c0e46f63455792887d44a9628b89e","unresolved":false,"context_lines":[{"line_number":1348,"context_line":"                               \u0027status\u0027: \u0027error_deleting\u0027}"},{"line_number":1349,"context_line":"                snapshot_model_update.append(update_item)"},{"line_number":1350,"context_line":"                if model_update[\u0027status\u0027] not in error_statuses:"},{"line_number":1351,"context_line":"                    model_update[\u0027status\u0027] \u003d \u0027error_deleting\u0027"},{"line_number":1352,"context_line":"                LOG.error(\"Failed to delete the snapshot %(snap)s \""},{"line_number":1353,"context_line":"                          \"of snapshot: %(snapshot_id)s. \""},{"line_number":1354,"context_line":"                          \"Exception: %(exception)s.\","}],"source_content_type":"text/x-python","patch_set":2,"id":"dfeb2761_0112af09","line":1351,"range":{"start_line":1351,"start_character":45,"end_line":1351,"end_character":61},"updated":"2017-04-05 01:31:05.000000000","message":"fields.GroupSnapshotStatus","commit_id":"28293acd4e72172b21f5d0df3bf94fc1c3eb936b"},{"author":{"_account_id":25033,"name":"Eric Young","email":"eric.young@dell.com","username":"tssgery"},"change_message_id":"5316d18618a529592752aa72718b2fcfae6533b4","unresolved":false,"context_lines":[{"line_number":1348,"context_line":"                               \u0027status\u0027: \u0027error_deleting\u0027}"},{"line_number":1349,"context_line":"                snapshot_model_update.append(update_item)"},{"line_number":1350,"context_line":"                if model_update[\u0027status\u0027] not in error_statuses:"},{"line_number":1351,"context_line":"                    model_update[\u0027status\u0027] \u003d \u0027error_deleting\u0027"},{"line_number":1352,"context_line":"                LOG.error(\"Failed to delete the snapshot %(snap)s \""},{"line_number":1353,"context_line":"                          \"of snapshot: %(snapshot_id)s. \""},{"line_number":1354,"context_line":"                          \"Exception: %(exception)s.\","}],"source_content_type":"text/x-python","patch_set":2,"id":"bff0334d_e0c1a282","line":1351,"range":{"start_line":1351,"start_character":45,"end_line":1351,"end_character":61},"in_reply_to":"dfeb2761_0112af09","updated":"2017-04-05 21:34:20.000000000","message":"Done","commit_id":"28293acd4e72172b21f5d0df3bf94fc1c3eb936b"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"fcd90f3cf53c0e46f63455792887d44a9628b89e","unresolved":false,"context_lines":[{"line_number":1355,"context_line":"                          {\u0027snap\u0027: snapshot[\u0027name\u0027],"},{"line_number":1356,"context_line":"                           \u0027exception\u0027: err,"},{"line_number":1357,"context_line":"                           \u0027snapshot_id\u0027: group_snapshot.id})"},{"line_number":1358,"context_line":"        model_update[\u0027status\u0027] \u003d \u0027deleted\u0027"},{"line_number":1359,"context_line":"        return model_update, snapshot_model_update"},{"line_number":1360,"context_line":""},{"line_number":1361,"context_line":"    def create_group_from_src(self, context, group, volumes,"}],"source_content_type":"text/x-python","patch_set":2,"id":"dfeb2761_e1c7cb95","line":1358,"updated":"2017-04-05 01:31:05.000000000","message":"fields.GroupSnapshotStatus","commit_id":"28293acd4e72172b21f5d0df3bf94fc1c3eb936b"},{"author":{"_account_id":25033,"name":"Eric Young","email":"eric.young@dell.com","username":"tssgery"},"change_message_id":"5316d18618a529592752aa72718b2fcfae6533b4","unresolved":false,"context_lines":[{"line_number":1355,"context_line":"                          {\u0027snap\u0027: snapshot[\u0027name\u0027],"},{"line_number":1356,"context_line":"                           \u0027exception\u0027: err,"},{"line_number":1357,"context_line":"                           \u0027snapshot_id\u0027: group_snapshot.id})"},{"line_number":1358,"context_line":"        model_update[\u0027status\u0027] \u003d \u0027deleted\u0027"},{"line_number":1359,"context_line":"        return model_update, snapshot_model_update"},{"line_number":1360,"context_line":""},{"line_number":1361,"context_line":"    def create_group_from_src(self, context, group, volumes,"}],"source_content_type":"text/x-python","patch_set":2,"id":"bff0334d_c0be9efe","line":1358,"in_reply_to":"dfeb2761_e1c7cb95","updated":"2017-04-05 21:34:20.000000000","message":"Done","commit_id":"28293acd4e72172b21f5d0df3bf94fc1c3eb936b"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"fcd90f3cf53c0e46f63455792887d44a9628b89e","unresolved":false,"context_lines":[{"line_number":1397,"context_line":"                           \u0027status\u0027: \u0027available\u0027,"},{"line_number":1398,"context_line":"                           \u0027provider_id\u0027: scaleio_id}"},{"line_number":1399,"context_line":"            volumes_model_update.append(update_item)"},{"line_number":1400,"context_line":"        model_update \u003d {\u0027status\u0027: \u0027available\u0027}"},{"line_number":1401,"context_line":"        return model_update, volumes_model_update"},{"line_number":1402,"context_line":""},{"line_number":1403,"context_line":"    def update_group(self, context, group,"}],"source_content_type":"text/x-python","patch_set":2,"id":"dfeb2761_c1f727d3","line":1400,"range":{"start_line":1400,"start_character":34,"end_line":1400,"end_character":45},"updated":"2017-04-05 01:31:05.000000000","message":"fields.GroupStatus","commit_id":"28293acd4e72172b21f5d0df3bf94fc1c3eb936b"},{"author":{"_account_id":25033,"name":"Eric Young","email":"eric.young@dell.com","username":"tssgery"},"change_message_id":"5316d18618a529592752aa72718b2fcfae6533b4","unresolved":false,"context_lines":[{"line_number":1397,"context_line":"                           \u0027status\u0027: \u0027available\u0027,"},{"line_number":1398,"context_line":"                           \u0027provider_id\u0027: scaleio_id}"},{"line_number":1399,"context_line":"            volumes_model_update.append(update_item)"},{"line_number":1400,"context_line":"        model_update \u003d {\u0027status\u0027: \u0027available\u0027}"},{"line_number":1401,"context_line":"        return model_update, volumes_model_update"},{"line_number":1402,"context_line":""},{"line_number":1403,"context_line":"    def update_group(self, context, group,"}],"source_content_type":"text/x-python","patch_set":2,"id":"bff0334d_603b529c","line":1400,"range":{"start_line":1400,"start_character":34,"end_line":1400,"end_character":45},"in_reply_to":"dfeb2761_c1f727d3","updated":"2017-04-05 21:34:20.000000000","message":"Done","commit_id":"28293acd4e72172b21f5d0df3bf94fc1c3eb936b"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"fcd90f3cf53c0e46f63455792887d44a9628b89e","unresolved":false,"context_lines":[{"line_number":1414,"context_line":"        Cinder maintains volumes and CG relationship."},{"line_number":1415,"context_line":"        \"\"\""},{"line_number":1416,"context_line":""},{"line_number":1417,"context_line":"        if volume_utils.is_group_a_cg_snapshot_type(group):"},{"line_number":1418,"context_line":"            return None, None, None"},{"line_number":1419,"context_line":""},{"line_number":1420,"context_line":"        # we\u0027ll rely on the generic group implementation if it is not a"},{"line_number":1421,"context_line":"        # consistency group request."}],"source_content_type":"text/x-python","patch_set":2,"id":"dfeb2761_c1e5e70a","line":1418,"range":{"start_line":1417,"start_character":0,"end_line":1418,"end_character":35},"updated":"2017-04-05 01:31:05.000000000","message":"Looks like you only applied this logic to update_group.  Please also use this in create_group, create_group_from_src, delete_group, create_group_snapshot, and delete_group_snapshot.","commit_id":"28293acd4e72172b21f5d0df3bf94fc1c3eb936b"},{"author":{"_account_id":25033,"name":"Eric Young","email":"eric.young@dell.com","username":"tssgery"},"change_message_id":"5316d18618a529592752aa72718b2fcfae6533b4","unresolved":false,"context_lines":[{"line_number":1414,"context_line":"        Cinder maintains volumes and CG relationship."},{"line_number":1415,"context_line":"        \"\"\""},{"line_number":1416,"context_line":""},{"line_number":1417,"context_line":"        if volume_utils.is_group_a_cg_snapshot_type(group):"},{"line_number":1418,"context_line":"            return None, None, None"},{"line_number":1419,"context_line":""},{"line_number":1420,"context_line":"        # we\u0027ll rely on the generic group implementation if it is not a"},{"line_number":1421,"context_line":"        # consistency group request."}],"source_content_type":"text/x-python","patch_set":2,"id":"bff0334d_004a4626","line":1418,"range":{"start_line":1417,"start_character":0,"end_line":1418,"end_character":35},"in_reply_to":"dfeb2761_c1e5e70a","updated":"2017-04-05 21:34:20.000000000","message":"Thanks for catching that. Done","commit_id":"28293acd4e72172b21f5d0df3bf94fc1c3eb936b"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"952bce54555a83fd09443e55e8cd784826e1a83e","unresolved":false,"context_lines":[{"line_number":1297,"context_line":"            try:"},{"line_number":1298,"context_line":"                self._delete_volume(volume[\u0027provider_id\u0027])"},{"line_number":1299,"context_line":"                update_item \u003d {\u0027id\u0027: volume[\u0027id\u0027],"},{"line_number":1300,"context_line":"                               \u0027status\u0027: fields.GroupStatus.DELETED}"},{"line_number":1301,"context_line":"                volumes_model_update.append(update_item)"},{"line_number":1302,"context_line":"            except exception.VolumeBackendAPIException as err:"},{"line_number":1303,"context_line":"                update_item \u003d {\u0027id\u0027: volume[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"bff0334d_9e6f6e91","line":1300,"range":{"start_line":1300,"start_character":41,"end_line":1300,"end_character":67},"updated":"2017-04-07 14:58:39.000000000","message":"There\u0027s no VolumeStatus in fields.py yet.  So please just use \u0027deleted\u0027 for now.","commit_id":"398bd4cbae74afff2f99ca8191e5e2bc97638dff"},{"author":{"_account_id":25033,"name":"Eric Young","email":"eric.young@dell.com","username":"tssgery"},"change_message_id":"dbfb7d36df4cecc53a2d17d9c795e49433c9de12","unresolved":false,"context_lines":[{"line_number":1297,"context_line":"            try:"},{"line_number":1298,"context_line":"                self._delete_volume(volume[\u0027provider_id\u0027])"},{"line_number":1299,"context_line":"                update_item \u003d {\u0027id\u0027: volume[\u0027id\u0027],"},{"line_number":1300,"context_line":"                               \u0027status\u0027: fields.GroupStatus.DELETED}"},{"line_number":1301,"context_line":"                volumes_model_update.append(update_item)"},{"line_number":1302,"context_line":"            except exception.VolumeBackendAPIException as err:"},{"line_number":1303,"context_line":"                update_item \u003d {\u0027id\u0027: volume[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"bff0334d_e00c933c","line":1300,"range":{"start_line":1300,"start_character":41,"end_line":1300,"end_character":67},"in_reply_to":"bff0334d_9e6f6e91","updated":"2017-04-07 17:48:33.000000000","message":"Done","commit_id":"398bd4cbae74afff2f99ca8191e5e2bc97638dff"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"952bce54555a83fd09443e55e8cd784826e1a83e","unresolved":false,"context_lines":[{"line_number":1301,"context_line":"                volumes_model_update.append(update_item)"},{"line_number":1302,"context_line":"            except exception.VolumeBackendAPIException as err:"},{"line_number":1303,"context_line":"                update_item \u003d {\u0027id\u0027: volume[\u0027id\u0027],"},{"line_number":1304,"context_line":"                               \u0027status\u0027: fields.GroupStatus.ERROR_DELETING}"},{"line_number":1305,"context_line":"                volumes_model_update.append(update_item)"},{"line_number":1306,"context_line":"                if model_update[\u0027status\u0027] not in error_statuses:"},{"line_number":1307,"context_line":"                    model_update[\u0027status\u0027] \u003d fields.GroupStatus.ERROR_DELETING"}],"source_content_type":"text/x-python","patch_set":3,"id":"bff0334d_3e0622d0","line":1304,"range":{"start_line":1304,"start_character":41,"end_line":1304,"end_character":73},"updated":"2017-04-07 14:58:39.000000000","message":"same","commit_id":"398bd4cbae74afff2f99ca8191e5e2bc97638dff"},{"author":{"_account_id":25033,"name":"Eric Young","email":"eric.young@dell.com","username":"tssgery"},"change_message_id":"dbfb7d36df4cecc53a2d17d9c795e49433c9de12","unresolved":false,"context_lines":[{"line_number":1301,"context_line":"                volumes_model_update.append(update_item)"},{"line_number":1302,"context_line":"            except exception.VolumeBackendAPIException as err:"},{"line_number":1303,"context_line":"                update_item \u003d {\u0027id\u0027: volume[\u0027id\u0027],"},{"line_number":1304,"context_line":"                               \u0027status\u0027: fields.GroupStatus.ERROR_DELETING}"},{"line_number":1305,"context_line":"                volumes_model_update.append(update_item)"},{"line_number":1306,"context_line":"                if model_update[\u0027status\u0027] not in error_statuses:"},{"line_number":1307,"context_line":"                    model_update[\u0027status\u0027] \u003d fields.GroupStatus.ERROR_DELETING"}],"source_content_type":"text/x-python","patch_set":3,"id":"bff0334d_a00e8b2f","line":1304,"range":{"start_line":1304,"start_character":41,"end_line":1304,"end_character":73},"in_reply_to":"bff0334d_3e0622d0","updated":"2017-04-07 17:48:33.000000000","message":"Done","commit_id":"398bd4cbae74afff2f99ca8191e5e2bc97638dff"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"952bce54555a83fd09443e55e8cd784826e1a83e","unresolved":false,"context_lines":[{"line_number":1304,"context_line":"                               \u0027status\u0027: fields.GroupStatus.ERROR_DELETING}"},{"line_number":1305,"context_line":"                volumes_model_update.append(update_item)"},{"line_number":1306,"context_line":"                if model_update[\u0027status\u0027] not in error_statuses:"},{"line_number":1307,"context_line":"                    model_update[\u0027status\u0027] \u003d fields.GroupStatus.ERROR_DELETING"},{"line_number":1308,"context_line":"                LOG.error(\"Failed to delete the volume %(vol)s of group. \""},{"line_number":1309,"context_line":"                          \"Exception: %(exception)s.\","},{"line_number":1310,"context_line":"                          {\u0027vol\u0027: volume[\u0027name\u0027], \u0027exception\u0027: err})"}],"source_content_type":"text/x-python","patch_set":3,"id":"bff0334d_bef912c9","line":1307,"updated":"2017-04-07 14:58:39.000000000","message":"same","commit_id":"398bd4cbae74afff2f99ca8191e5e2bc97638dff"},{"author":{"_account_id":25033,"name":"Eric Young","email":"eric.young@dell.com","username":"tssgery"},"change_message_id":"dbfb7d36df4cecc53a2d17d9c795e49433c9de12","unresolved":false,"context_lines":[{"line_number":1304,"context_line":"                               \u0027status\u0027: fields.GroupStatus.ERROR_DELETING}"},{"line_number":1305,"context_line":"                volumes_model_update.append(update_item)"},{"line_number":1306,"context_line":"                if model_update[\u0027status\u0027] not in error_statuses:"},{"line_number":1307,"context_line":"                    model_update[\u0027status\u0027] \u003d fields.GroupStatus.ERROR_DELETING"},{"line_number":1308,"context_line":"                LOG.error(\"Failed to delete the volume %(vol)s of group. \""},{"line_number":1309,"context_line":"                          \"Exception: %(exception)s.\","},{"line_number":1310,"context_line":"                          {\u0027vol\u0027: volume[\u0027name\u0027], \u0027exception\u0027: err})"}],"source_content_type":"text/x-python","patch_set":3,"id":"bff0334d_801dc767","line":1307,"in_reply_to":"bff0334d_bef912c9","updated":"2017-04-07 17:48:33.000000000","message":"Done","commit_id":"398bd4cbae74afff2f99ca8191e5e2bc97638dff"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"952bce54555a83fd09443e55e8cd784826e1a83e","unresolved":false,"context_lines":[{"line_number":1338,"context_line":"        snapshot_model_update \u003d []"},{"line_number":1339,"context_line":"        for snapshot, scaleio_id in zip(snapshots, response[\u0027volumeIdList\u0027]):"},{"line_number":1340,"context_line":"            update_item \u003d {\u0027id\u0027: snapshot[\u0027id\u0027],"},{"line_number":1341,"context_line":"                           \u0027status\u0027: fields.GroupStatus.AVAILABLE,"},{"line_number":1342,"context_line":"                           \u0027provider_id\u0027: scaleio_id}"},{"line_number":1343,"context_line":"            snapshot_model_update.append(update_item)"},{"line_number":1344,"context_line":"        model_update \u003d {\u0027status\u0027: fields.GroupStatus.AVAILABLE}"}],"source_content_type":"text/x-python","patch_set":3,"id":"bff0334d_9e464e21","line":1341,"range":{"start_line":1341,"start_character":44,"end_line":1341,"end_character":55},"updated":"2017-04-07 14:58:39.000000000","message":"SnapshotStatus","commit_id":"398bd4cbae74afff2f99ca8191e5e2bc97638dff"},{"author":{"_account_id":25033,"name":"Eric Young","email":"eric.young@dell.com","username":"tssgery"},"change_message_id":"dbfb7d36df4cecc53a2d17d9c795e49433c9de12","unresolved":false,"context_lines":[{"line_number":1338,"context_line":"        snapshot_model_update \u003d []"},{"line_number":1339,"context_line":"        for snapshot, scaleio_id in zip(snapshots, response[\u0027volumeIdList\u0027]):"},{"line_number":1340,"context_line":"            update_item \u003d {\u0027id\u0027: snapshot[\u0027id\u0027],"},{"line_number":1341,"context_line":"                           \u0027status\u0027: fields.GroupStatus.AVAILABLE,"},{"line_number":1342,"context_line":"                           \u0027provider_id\u0027: scaleio_id}"},{"line_number":1343,"context_line":"            snapshot_model_update.append(update_item)"},{"line_number":1344,"context_line":"        model_update \u003d {\u0027status\u0027: fields.GroupStatus.AVAILABLE}"}],"source_content_type":"text/x-python","patch_set":3,"id":"bff0334d_4029ff87","line":1341,"range":{"start_line":1341,"start_character":44,"end_line":1341,"end_character":55},"in_reply_to":"bff0334d_9e464e21","updated":"2017-04-07 17:48:33.000000000","message":"Done","commit_id":"398bd4cbae74afff2f99ca8191e5e2bc97638dff"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"952bce54555a83fd09443e55e8cd784826e1a83e","unresolved":false,"context_lines":[{"line_number":1357,"context_line":"        if not volume_utils.is_group_a_cg_snapshot_type(group_snapshot):"},{"line_number":1358,"context_line":"            raise NotImplementedError()"},{"line_number":1359,"context_line":""},{"line_number":1360,"context_line":"        error_statuses \u003d [\u0027error\u0027, \u0027error_deleting\u0027]"},{"line_number":1361,"context_line":"        model_update \u003d {\u0027status\u0027: group_snapshot[\u0027status\u0027]}"},{"line_number":1362,"context_line":"        snapshot_model_update \u003d []"},{"line_number":1363,"context_line":"        for snapshot in snapshots:"}],"source_content_type":"text/x-python","patch_set":3,"id":"bff0334d_1ed7de25","line":1360,"updated":"2017-04-07 14:58:39.000000000","message":"fields.SnapshotStatus.DELETED, fields.SnapshotStatus.ERROR_DELETING","commit_id":"398bd4cbae74afff2f99ca8191e5e2bc97638dff"},{"author":{"_account_id":25033,"name":"Eric Young","email":"eric.young@dell.com","username":"tssgery"},"change_message_id":"dbfb7d36df4cecc53a2d17d9c795e49433c9de12","unresolved":false,"context_lines":[{"line_number":1357,"context_line":"        if not volume_utils.is_group_a_cg_snapshot_type(group_snapshot):"},{"line_number":1358,"context_line":"            raise NotImplementedError()"},{"line_number":1359,"context_line":""},{"line_number":1360,"context_line":"        error_statuses \u003d [\u0027error\u0027, \u0027error_deleting\u0027]"},{"line_number":1361,"context_line":"        model_update \u003d {\u0027status\u0027: group_snapshot[\u0027status\u0027]}"},{"line_number":1362,"context_line":"        snapshot_model_update \u003d []"},{"line_number":1363,"context_line":"        for snapshot in snapshots:"}],"source_content_type":"text/x-python","patch_set":3,"id":"bff0334d_60464352","line":1360,"in_reply_to":"bff0334d_1ed7de25","updated":"2017-04-07 17:48:33.000000000","message":"Done, should be ERROR and ERROR_DELETING","commit_id":"398bd4cbae74afff2f99ca8191e5e2bc97638dff"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"952bce54555a83fd09443e55e8cd784826e1a83e","unresolved":false,"context_lines":[{"line_number":1371,"context_line":"                               \u0027status\u0027: fields.SnapshotStatus.ERROR_DELETING}"},{"line_number":1372,"context_line":"                snapshot_model_update.append(update_item)"},{"line_number":1373,"context_line":"                if model_update[\u0027status\u0027] not in error_statuses:"},{"line_number":1374,"context_line":"                    model_update[\u0027status\u0027] \u003d \\"},{"line_number":1375,"context_line":"                        fields.SnapshotStatus.ERROR_DELETING"},{"line_number":1376,"context_line":"                LOG.error(\"Failed to delete the snapshot %(snap)s \""},{"line_number":1377,"context_line":"                          \"of snapshot: %(snapshot_id)s. \""}],"source_content_type":"text/x-python","patch_set":3,"id":"bff0334d_5efe86ae","line":1374,"range":{"start_line":1374,"start_character":45,"end_line":1374,"end_character":46},"updated":"2017-04-07 14:58:39.000000000","message":"Please use () instead of \\","commit_id":"398bd4cbae74afff2f99ca8191e5e2bc97638dff"},{"author":{"_account_id":25033,"name":"Eric Young","email":"eric.young@dell.com","username":"tssgery"},"change_message_id":"dbfb7d36df4cecc53a2d17d9c795e49433c9de12","unresolved":false,"context_lines":[{"line_number":1371,"context_line":"                               \u0027status\u0027: fields.SnapshotStatus.ERROR_DELETING}"},{"line_number":1372,"context_line":"                snapshot_model_update.append(update_item)"},{"line_number":1373,"context_line":"                if model_update[\u0027status\u0027] not in error_statuses:"},{"line_number":1374,"context_line":"                    model_update[\u0027status\u0027] \u003d \\"},{"line_number":1375,"context_line":"                        fields.SnapshotStatus.ERROR_DELETING"},{"line_number":1376,"context_line":"                LOG.error(\"Failed to delete the snapshot %(snap)s \""},{"line_number":1377,"context_line":"                          \"of snapshot: %(snapshot_id)s. \""}],"source_content_type":"text/x-python","patch_set":3,"id":"bff0334d_80b9472f","line":1374,"range":{"start_line":1374,"start_character":45,"end_line":1374,"end_character":46},"in_reply_to":"bff0334d_5efe86ae","updated":"2017-04-07 17:48:33.000000000","message":"Done","commit_id":"398bd4cbae74afff2f99ca8191e5e2bc97638dff"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"952bce54555a83fd09443e55e8cd784826e1a83e","unresolved":false,"context_lines":[{"line_number":1379,"context_line":"                          {\u0027snap\u0027: snapshot[\u0027name\u0027],"},{"line_number":1380,"context_line":"                           \u0027exception\u0027: err,"},{"line_number":1381,"context_line":"                           \u0027snapshot_id\u0027: group_snapshot.id})"},{"line_number":1382,"context_line":"        model_update[\u0027status\u0027] \u003d fields.SnapshotStatus.DELETED"},{"line_number":1383,"context_line":"        return model_update, snapshot_model_update"},{"line_number":1384,"context_line":""},{"line_number":1385,"context_line":"    def create_group_from_src(self, context, group, volumes,"}],"source_content_type":"text/x-python","patch_set":3,"id":"bff0334d_de2bb62d","line":1382,"range":{"start_line":1382,"start_character":40,"end_line":1382,"end_character":54},"updated":"2017-04-07 14:58:39.000000000","message":"GroupSnapshotStatus","commit_id":"398bd4cbae74afff2f99ca8191e5e2bc97638dff"},{"author":{"_account_id":25033,"name":"Eric Young","email":"eric.young@dell.com","username":"tssgery"},"change_message_id":"dbfb7d36df4cecc53a2d17d9c795e49433c9de12","unresolved":false,"context_lines":[{"line_number":1379,"context_line":"                          {\u0027snap\u0027: snapshot[\u0027name\u0027],"},{"line_number":1380,"context_line":"                           \u0027exception\u0027: err,"},{"line_number":1381,"context_line":"                           \u0027snapshot_id\u0027: group_snapshot.id})"},{"line_number":1382,"context_line":"        model_update[\u0027status\u0027] \u003d fields.SnapshotStatus.DELETED"},{"line_number":1383,"context_line":"        return model_update, snapshot_model_update"},{"line_number":1384,"context_line":""},{"line_number":1385,"context_line":"    def create_group_from_src(self, context, group, volumes,"}],"source_content_type":"text/x-python","patch_set":3,"id":"bff0334d_e07373b0","line":1382,"range":{"start_line":1382,"start_character":40,"end_line":1382,"end_character":54},"in_reply_to":"bff0334d_de2bb62d","updated":"2017-04-07 17:48:33.000000000","message":"Done","commit_id":"398bd4cbae74afff2f99ca8191e5e2bc97638dff"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"952bce54555a83fd09443e55e8cd784826e1a83e","unresolved":false,"context_lines":[{"line_number":1423,"context_line":"        volumes_model_update \u003d []"},{"line_number":1424,"context_line":"        for volume, scaleio_id in zip(volumes, response[\u0027volumeIdList\u0027]):"},{"line_number":1425,"context_line":"            update_item \u003d {\u0027id\u0027: volume[\u0027id\u0027],"},{"line_number":1426,"context_line":"                           \u0027status\u0027: fields.GroupStatus.AVAILABLE,"},{"line_number":1427,"context_line":"                           \u0027provider_id\u0027: scaleio_id}"},{"line_number":1428,"context_line":"            volumes_model_update.append(update_item)"},{"line_number":1429,"context_line":"        model_update \u003d {\u0027status\u0027: fields.GroupStatus.AVAILABLE}"}],"source_content_type":"text/x-python","patch_set":3,"id":"bff0334d_dee056fd","line":1426,"range":{"start_line":1426,"start_character":37,"end_line":1426,"end_character":65},"updated":"2017-04-07 14:58:39.000000000","message":"Same here.  VolumeStatus is not in fields.py yet.  So don\u0027t change this.","commit_id":"398bd4cbae74afff2f99ca8191e5e2bc97638dff"},{"author":{"_account_id":25033,"name":"Eric Young","email":"eric.young@dell.com","username":"tssgery"},"change_message_id":"dbfb7d36df4cecc53a2d17d9c795e49433c9de12","unresolved":false,"context_lines":[{"line_number":1423,"context_line":"        volumes_model_update \u003d []"},{"line_number":1424,"context_line":"        for volume, scaleio_id in zip(volumes, response[\u0027volumeIdList\u0027]):"},{"line_number":1425,"context_line":"            update_item \u003d {\u0027id\u0027: volume[\u0027id\u0027],"},{"line_number":1426,"context_line":"                           \u0027status\u0027: fields.GroupStatus.AVAILABLE,"},{"line_number":1427,"context_line":"                           \u0027provider_id\u0027: scaleio_id}"},{"line_number":1428,"context_line":"            volumes_model_update.append(update_item)"},{"line_number":1429,"context_line":"        model_update \u003d {\u0027status\u0027: fields.GroupStatus.AVAILABLE}"}],"source_content_type":"text/x-python","patch_set":3,"id":"bff0334d_c06aafb1","line":1426,"range":{"start_line":1426,"start_character":37,"end_line":1426,"end_character":65},"in_reply_to":"bff0334d_dee056fd","updated":"2017-04-07 17:48:33.000000000","message":"Done","commit_id":"398bd4cbae74afff2f99ca8191e5e2bc97638dff"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"64e1c0fa8d07a36b9196d240d104ba96700c4ec7","unresolved":false,"context_lines":[{"line_number":830,"context_line":"        stats[\u0027storage_protocol\u0027] \u003d \u0027scaleio\u0027"},{"line_number":831,"context_line":"        stats[\u0027reserved_percentage\u0027] \u003d 0"},{"line_number":832,"context_line":"        stats[\u0027QoS_support\u0027] \u003d True"},{"line_number":833,"context_line":"        stats[\u0027consistencygroup_support\u0027] \u003d True"},{"line_number":834,"context_line":"        stats[\u0027thick_provisioning_support\u0027] \u003d True"},{"line_number":835,"context_line":"        stats[\u0027thin_provisioning_support\u0027] \u003d True"},{"line_number":836,"context_line":"        pools \u003d []"}],"source_content_type":"text/x-python","patch_set":5,"id":"7ffa3b31_55736081","line":833,"range":{"start_line":833,"start_character":15,"end_line":833,"end_character":39},"updated":"2017-04-14 13:44:50.000000000","message":"Please change this to consistent_group_snapshot_enabled.","commit_id":"10e7ce11186724217a59957d62628a97a3accfd2"},{"author":{"_account_id":25033,"name":"Eric Young","email":"eric.young@dell.com","username":"tssgery"},"change_message_id":"b6bb23d78f0904468143310c0e5f2495b897d7cb","unresolved":false,"context_lines":[{"line_number":830,"context_line":"        stats[\u0027storage_protocol\u0027] \u003d \u0027scaleio\u0027"},{"line_number":831,"context_line":"        stats[\u0027reserved_percentage\u0027] \u003d 0"},{"line_number":832,"context_line":"        stats[\u0027QoS_support\u0027] \u003d True"},{"line_number":833,"context_line":"        stats[\u0027consistencygroup_support\u0027] \u003d True"},{"line_number":834,"context_line":"        stats[\u0027thick_provisioning_support\u0027] \u003d True"},{"line_number":835,"context_line":"        stats[\u0027thin_provisioning_support\u0027] \u003d True"},{"line_number":836,"context_line":"        pools \u003d []"}],"source_content_type":"text/x-python","patch_set":5,"id":"7ffa3b31_1b698924","line":833,"range":{"start_line":833,"start_character":15,"end_line":833,"end_character":39},"in_reply_to":"7ffa3b31_55736081","updated":"2017-04-14 15:55:22.000000000","message":"good catch","commit_id":"10e7ce11186724217a59957d62628a97a3accfd2"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"64e1c0fa8d07a36b9196d240d104ba96700c4ec7","unresolved":false,"context_lines":[{"line_number":955,"context_line":"                    \u0027total_capacity_gb\u0027: total_capacity_gb,"},{"line_number":956,"context_line":"                    \u0027free_capacity_gb\u0027: free_capacity_gb,"},{"line_number":957,"context_line":"                    \u0027QoS_support\u0027: True,"},{"line_number":958,"context_line":"                    \u0027consistencygroup_support\u0027: True,"},{"line_number":959,"context_line":"                    \u0027reserved_percentage\u0027: 0,"},{"line_number":960,"context_line":"                    \u0027thin_provisioning_support\u0027: True,"},{"line_number":961,"context_line":"                    \u0027thick_provisioning_support\u0027: True,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7ffa3b31_f5694c8b","line":958,"range":{"start_line":958,"start_character":21,"end_line":958,"end_character":45},"updated":"2017-04-14 13:44:50.000000000","message":"Please change this to consistent_group_snapshot_enabled.","commit_id":"10e7ce11186724217a59957d62628a97a3accfd2"},{"author":{"_account_id":25033,"name":"Eric Young","email":"eric.young@dell.com","username":"tssgery"},"change_message_id":"b6bb23d78f0904468143310c0e5f2495b897d7cb","unresolved":false,"context_lines":[{"line_number":955,"context_line":"                    \u0027total_capacity_gb\u0027: total_capacity_gb,"},{"line_number":956,"context_line":"                    \u0027free_capacity_gb\u0027: free_capacity_gb,"},{"line_number":957,"context_line":"                    \u0027QoS_support\u0027: True,"},{"line_number":958,"context_line":"                    \u0027consistencygroup_support\u0027: True,"},{"line_number":959,"context_line":"                    \u0027reserved_percentage\u0027: 0,"},{"line_number":960,"context_line":"                    \u0027thin_provisioning_support\u0027: True,"},{"line_number":961,"context_line":"                    \u0027thick_provisioning_support\u0027: True,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7ffa3b31_3b6c4535","line":958,"range":{"start_line":958,"start_character":21,"end_line":958,"end_character":45},"in_reply_to":"7ffa3b31_f5694c8b","updated":"2017-04-14 15:55:22.000000000","message":"good catch","commit_id":"10e7ce11186724217a59957d62628a97a3accfd2"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"aef3925083d9e00fec85ff62612f8e61ba119599","unresolved":false,"context_lines":[{"line_number":830,"context_line":"        stats[\u0027storage_protocol\u0027] \u003d \u0027scaleio\u0027"},{"line_number":831,"context_line":"        stats[\u0027reserved_percentage\u0027] \u003d 0"},{"line_number":832,"context_line":"        stats[\u0027QoS_support\u0027] \u003d True"},{"line_number":833,"context_line":"        stats[\u0027consistent_group_snapshot_enabled\u0027] \u003d True"},{"line_number":834,"context_line":"        stats[\u0027thick_provisioning_support\u0027] \u003d True"},{"line_number":835,"context_line":"        stats[\u0027thin_provisioning_support\u0027] \u003d True"},{"line_number":836,"context_line":"        pools \u003d []"}],"source_content_type":"text/x-python","patch_set":6,"id":"7ffa3b31_e5cbb650","line":833,"updated":"2017-04-17 14:35:27.000000000","message":"This will break things upon upgrade for anyone who has specified \"consistencygroup_support\" in the spec.  This should at least be noted in the release note.","commit_id":"fcbd762d9d7923ac403324c8aafa6731cb52632a"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"588293161427af43f74fa57d924f54a59c227b91","unresolved":false,"context_lines":[{"line_number":830,"context_line":"        stats[\u0027storage_protocol\u0027] \u003d \u0027scaleio\u0027"},{"line_number":831,"context_line":"        stats[\u0027reserved_percentage\u0027] \u003d 0"},{"line_number":832,"context_line":"        stats[\u0027QoS_support\u0027] \u003d True"},{"line_number":833,"context_line":"        stats[\u0027consistent_group_snapshot_enabled\u0027] \u003d True"},{"line_number":834,"context_line":"        stats[\u0027thick_provisioning_support\u0027] \u003d True"},{"line_number":835,"context_line":"        stats[\u0027thin_provisioning_support\u0027] \u003d True"},{"line_number":836,"context_line":"        pools \u003d []"}],"source_content_type":"text/x-python","patch_set":6,"id":"7ffa3b31_776abd80","line":833,"in_reply_to":"7ffa3b31_e5cbb650","updated":"2017-04-17 15:00:50.000000000","message":"Hi Eric,\n\nLet me add a general release note about this for all drivers.  Thanks.","commit_id":"fcbd762d9d7923ac403324c8aafa6731cb52632a"}],"releasenotes/notes/scaleio-generic-volume-group-ee36e4dba8893422.yaml":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"fcd90f3cf53c0e46f63455792887d44a9628b89e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Added consistency group support to generic volume groups in ScaleIO Driver "}],"source_content_type":"text/x-yaml","patch_set":2,"id":"dfeb2761_e1d10b25","line":3,"updated":"2017-04-05 01:31:05.000000000","message":"Please remove the trailing white space and add a period.","commit_id":"28293acd4e72172b21f5d0df3bf94fc1c3eb936b"},{"author":{"_account_id":25033,"name":"Eric Young","email":"eric.young@dell.com","username":"tssgery"},"change_message_id":"5316d18618a529592752aa72718b2fcfae6533b4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Added consistency group support to generic volume groups in ScaleIO Driver "}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bff0334d_805f76e4","line":3,"in_reply_to":"dfeb2761_e1d10b25","updated":"2017-04-05 21:34:20.000000000","message":"Done","commit_id":"28293acd4e72172b21f5d0df3bf94fc1c3eb936b"}]}