)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":20191,"name":"Dinesh Bhor","email":"bhordinesh07@gmail.com","username":"dineshbhor"},"change_message_id":"b109ad854d101a4222242618354b0cb551bd6e34","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[BugFix] Add method policy in attachment APIs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There are some issues around new attach/detach API/CLI,"},{"line_number":10,"context_line":"fix them step by step. This patch adds policy in attachment"},{"line_number":11,"context_line":"APIs, also add related testcases in API unit testcases."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bff0334d_8b7ee7ac","line":9,"range":{"start_line":9,"start_character":10,"end_line":9,"end_character":21},"updated":"2017-04-10 11:11:45.000000000","message":"It\u0027s better to specify which are those issues in summary. There is no information about them neither in the commit message nor in the bug description.","commit_id":"87982a56771cf66f6ae4beec92e4de9d27388fc9"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"5cdf7d7de182c5e91d5055ebdd00feb0d3be393d","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There are some issues around new attach/detach API/CLI,"},{"line_number":10,"context_line":"fix them step by step. This patch adds policy in attachment"},{"line_number":11,"context_line":"APIs, also add related testcases in API unit testcases."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: #1680836"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bff0334d_c53ee5bf","line":11,"updated":"2017-04-11 17:00:51.000000000","message":"This sentence \"There are some issues around new attach/detach API/CLI, fix them step by step\" is confusing.  Actually you explained better in the bug report itself.  I suggest remove the \"some issues\" sentence and instead explain the specific issue you are trying to fix in this patch.","commit_id":"87982a56771cf66f6ae4beec92e4de9d27388fc9"}],"cinder/tests/unit/api/v3/test_attachments.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"5cdf7d7de182c5e91d5055ebdd00feb0d3be393d","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        self.assertEqual(self.volume1.id,"},{"line_number":97,"context_line":"                         attachment[\u0027attachment\u0027][\u0027volume_id\u0027])"},{"line_number":98,"context_line":"        self.assertEqual(fake.UUID1,"},{"line_number":99,"context_line":"                         attachment[\u0027attachment\u0027][\u0027instance\u0027])"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    @mock.patch.object(volume_rpcapi.VolumeAPI, \u0027attachment_update\u0027)"},{"line_number":102,"context_line":"    def test_update_attachment(self, mock_update):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bff0334d_8549fd60","line":99,"updated":"2017-04-11 17:00:51.000000000","message":"Please add an assertion that check_policy is called.","commit_id":"87982a56771cf66f6ae4beec92e4de9d27388fc9"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"5cdf7d7de182c5e91d5055ebdd00feb0d3be393d","unresolved":false,"context_lines":[{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        self.assertEqual(fake_connector,"},{"line_number":119,"context_line":"                         attachment[\u0027attachment\u0027][\u0027connection_info\u0027])"},{"line_number":120,"context_line":"        self.assertEqual(fake.UUID1, attachment[\u0027attachment\u0027][\u0027instance\u0027])"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    @ddt.data(\u0027reserved\u0027, \u0027attached\u0027)"},{"line_number":123,"context_line":"    @mock.patch.object(volume_rpcapi.VolumeAPI, \u0027attachment_delete\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bff0334d_6544b947","line":120,"updated":"2017-04-11 17:00:51.000000000","message":"Please add an assertion that check_policy is called.","commit_id":"87982a56771cf66f6ae4beec92e4de9d27388fc9"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"5cdf7d7de182c5e91d5055ebdd00feb0d3be393d","unresolved":false,"context_lines":[{"line_number":144,"context_line":"            self.assertEqual(\u0027attached\u0027, volume2.attach_status)"},{"line_number":145,"context_line":"            mock_delete.assert_called_once_with(req.environ[\u0027cinder.context\u0027],"},{"line_number":146,"context_line":"                                                attachment.id, mock.ANY)"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    def _create_attachement(self, ctxt\u003dNone, volume_uuid\u003dNone,"},{"line_number":149,"context_line":"                            instance_uuid\u003dNone, mountpoint\u003dNone,"},{"line_number":150,"context_line":"                            attach_time\u003dNone, detach_time\u003dNone,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bff0334d_c56ca5cf","line":147,"updated":"2017-04-11 17:00:51.000000000","message":"Please add an assertion that check_policy is called.","commit_id":"87982a56771cf66f6ae4beec92e4de9d27388fc9"}],"cinder/tests/unit/policy.json":[{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"92712f7ddfe117c8b45109bfd06673da5deef0f9","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    \"backup:update\": \"rule:admin_or_owner\","},{"line_number":104,"context_line":"    \"backup:backup_project_attribute\": \"rule:admin_api\","},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    \"volume:attachment_create\": \"\","},{"line_number":107,"context_line":"    \"volume:attachment_update\": \"rule:admin_or_owner\","},{"line_number":108,"context_line":"    \"volume:attachment_delete\": \"rule:admin_or_owner\","},{"line_number":109,"context_line":""}],"source_content_type":"application/json","patch_set":1,"id":"bff0334d_63af0a2a","line":106,"range":{"start_line":106,"start_character":5,"end_line":106,"end_character":11},"updated":"2017-04-11 22:53:10.000000000","message":"This should be \"attachments\" here and below.","commit_id":"87982a56771cf66f6ae4beec92e4de9d27388fc9"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"92712f7ddfe117c8b45109bfd06673da5deef0f9","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    \"backup:update\": \"rule:admin_or_owner\","},{"line_number":104,"context_line":"    \"backup:backup_project_attribute\": \"rule:admin_api\","},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    \"volume:attachment_create\": \"\","},{"line_number":107,"context_line":"    \"volume:attachment_update\": \"rule:admin_or_owner\","},{"line_number":108,"context_line":"    \"volume:attachment_delete\": \"rule:admin_or_owner\","},{"line_number":109,"context_line":""}],"source_content_type":"application/json","patch_set":1,"id":"bff0334d_636a6a1a","line":106,"range":{"start_line":106,"start_character":32,"end_line":106,"end_character":34},"updated":"2017-04-11 22:53:10.000000000","message":"Why does create have a different setting?","commit_id":"87982a56771cf66f6ae4beec92e4de9d27388fc9"}],"etc/cinder/policy.json":[{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"c0494d5a4ca2ae68cf917d313662dfbe9577dfa2","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    \"backup:update\": \"rule:admin_or_owner\","},{"line_number":94,"context_line":"    \"backup:backup_project_attribute\": \"rule:admin_api\","},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    \"volume:attachment_create\": \"\","},{"line_number":97,"context_line":"    \"volume:attachment_update\": \"rule:admin_or_owner\","},{"line_number":98,"context_line":"    \"volume:attachment_delete\": \"rule:admin_or_owner\","},{"line_number":99,"context_line":""}],"source_content_type":"application/json","patch_set":1,"id":"bff0334d_03c15ee5","line":96,"range":{"start_line":96,"start_character":0,"end_line":96,"end_character":35},"updated":"2017-04-11 22:48:45.000000000","message":"Shouldn\u0027t these be of the form:\n\"attachments:create / update / delete\" ?","commit_id":"87982a56771cf66f6ae4beec92e4de9d27388fc9"}]}