)]}'
{"cinder/db/sqlalchemy/migrate_repo/versions/098_add_connection_info_to_attachment.py":[{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"63c50315d01d182f54291a55fedff17eabd5c1f3","unresolved":false,"context_lines":[{"line_number":13,"context_line":"from sqlalchemy import MetaData, Table, Column, Text"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"def upgrade(migrate_engine):"},{"line_number":17,"context_line":"    meta \u003d MetaData(migrate_engine)"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    # Add connection_info column to attachment table"}],"source_content_type":"text/x-python","patch_set":4,"id":"7ffa3b31_d39f6c4e","line":16,"updated":"2017-04-17 09:21:35.000000000","message":"What about existing attachment records?  Should migration script populate connection_info to those?","commit_id":"f71c133371ebf1e365f85658d42d6107cd872bb0"}],"cinder/objects/volume_attachment.py":[{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"63c50315d01d182f54291a55fedff17eabd5c1f3","unresolved":false,"context_lines":[{"line_number":79,"context_line":"            if name \u003d\u003d \u0027connection_info\u0027:"},{"line_number":80,"context_line":"                connection_info \u003d db_attachment.get(\u0027connection_info\u0027)"},{"line_number":81,"context_line":"                attachment.connection_info \u003d jsonutils.loads("},{"line_number":82,"context_line":"                    connection_info) if connection_info else None"},{"line_number":83,"context_line":"            else:"},{"line_number":84,"context_line":"                attachment[name] \u003d value"},{"line_number":85,"context_line":"        if \u0027volume\u0027 in expected_attrs:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7ffa3b31_f3a2689a","line":82,"updated":"2017-04-17 09:21:35.000000000","message":"These can be simplified to:\n    attachment.connection_info \u003d jsonutils.loads(value) if value else None","commit_id":"f71c133371ebf1e365f85658d42d6107cd872bb0"}]}