)]}'
{"cinder/tests/unit/volume/drivers/dell_emc/test_vmax.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"13e49aa6b2db3cf736562ed8cd3d5be9f38426b0","unresolved":false,"context_lines":[{"line_number":8845,"context_line":""},{"line_number":8846,"context_line":"        replication_source \u003d \u0027testReplicationSync\u0027"},{"line_number":8847,"context_line":""},{"line_number":8848,"context_line":"        utils.get_associated_replication_from_source_volume \u003d \\"},{"line_number":8849,"context_line":"            mock.Mock(return_value\u003dreplication_source)"},{"line_number":8850,"context_line":""},{"line_number":8851,"context_line":"        self.assertRaises("}],"source_content_type":"text/x-python","patch_set":1,"id":"7ffa3b31_b04387af","line":8848,"updated":"2017-04-18 16:20:18.000000000","message":"Use () instead of \\","commit_id":"b01410325eeabba2375ca7592633208a2ca634a2"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"13e49aa6b2db3cf736562ed8cd3d5be9f38426b0","unresolved":false,"context_lines":[{"line_number":8880,"context_line":"        poolInstanceName[\u0027InstanceID\u0027] \u003d \"SATA_GOLD2\""},{"line_number":8881,"context_line":"        deviceId \u003d self.data.test_volume[\u0027device_id\u0027]"},{"line_number":8882,"context_line":""},{"line_number":8883,"context_line":"        utils.get_assoc_v2_pool_from_volume \u003d \\"},{"line_number":8884,"context_line":"            mock.Mock(return_value\u003dpoolInstanceName)"},{"line_number":8885,"context_line":""},{"line_number":8886,"context_line":"        self.assertTrue("}],"source_content_type":"text/x-python","patch_set":1,"id":"7ffa3b31_70173fa5","line":8883,"updated":"2017-04-18 16:20:18.000000000","message":"()","commit_id":"b01410325eeabba2375ca7592633208a2ca634a2"}],"cinder/volume/drivers/dell_emc/vmax/common.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"13e49aa6b2db3cf736562ed8cd3d5be9f38426b0","unresolved":false,"context_lines":[{"line_number":4696,"context_line":"        :param extraSpecs: additional info"},{"line_number":4697,"context_line":"        :param volume: the volume object"},{"line_number":4698,"context_line":"        :param provider_location: volume classname \u0026 keybindings"},{"line_number":4699,"context_line":"        :param model_update: volume model dict"},{"line_number":4700,"context_line":"        :return: updated model_update"},{"line_number":4701,"context_line":"        \"\"\""},{"line_number":4702,"context_line":"        model_update \u003d {}"}],"source_content_type":"text/x-python","patch_set":1,"id":"7ffa3b31_50e7a3e5","line":4699,"range":{"start_line":4699,"start_character":8,"end_line":4699,"end_character":46},"updated":"2017-04-18 16:20:18.000000000","message":"This is not an input param.","commit_id":"b01410325eeabba2375ca7592633208a2ca634a2"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"583367321b29f3f35c6e79c8568e71187620d744","unresolved":false,"context_lines":[{"line_number":4655,"context_line":"            self.conn, volumeInstanceName, cinderPoolInstanceName,"},{"line_number":4656,"context_line":"            deviceId)"},{"line_number":4657,"context_line":""},{"line_number":4658,"context_line":"        volumeId \u003d volume[\u0027name\u0027]"},{"line_number":4659,"context_line":"        volumeElementName \u003d self.utils.get_volume_element_name(volumeId)"},{"line_number":4660,"context_line":"        LOG.debug(\"Rename volume %(vol)s to %(volumeId)s.\","},{"line_number":4661,"context_line":"                  {\u0027vol\u0027: volumeInstanceName,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5ff73747_4b5bc42d","line":4658,"updated":"2017-04-24 02:30:25.000000000","message":"volume is an object here.  Please use volume.name","commit_id":"b7fb641093525490dcba50fa0956520ca3a74071"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"ba0092c768993cc92ecb5e29741d3d632cb844d9","unresolved":false,"context_lines":[{"line_number":4655,"context_line":"            self.conn, volumeInstanceName, cinderPoolInstanceName,"},{"line_number":4656,"context_line":"            deviceId)"},{"line_number":4657,"context_line":""},{"line_number":4658,"context_line":"        volumeId \u003d volume[\u0027name\u0027]"},{"line_number":4659,"context_line":"        volumeElementName \u003d self.utils.get_volume_element_name(volumeId)"},{"line_number":4660,"context_line":"        LOG.debug(\"Rename volume %(vol)s to %(volumeId)s.\","},{"line_number":4661,"context_line":"                  {\u0027vol\u0027: volumeInstanceName,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5ff73747_94f7a7f6","line":4658,"in_reply_to":"5ff73747_4b5bc42d","updated":"2017-04-24 10:32:17.000000000","message":"Sure.  Thanks","commit_id":"b7fb641093525490dcba50fa0956520ca3a74071"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"583367321b29f3f35c6e79c8568e71187620d744","unresolved":false,"context_lines":[{"line_number":4678,"context_line":"        model_update \u003d self.set_volume_replication_if_enabled("},{"line_number":4679,"context_line":"            self.conn, extraSpecs, volume, provider_location)"},{"line_number":4680,"context_line":""},{"line_number":4681,"context_line":"        volumeDisplayName \u003d volume[\u0027display_name\u0027]"},{"line_number":4682,"context_line":"        model_update.update("},{"line_number":4683,"context_line":"            {\u0027display_name\u0027: volumeDisplayName})"},{"line_number":4684,"context_line":"        model_update.update("}],"source_content_type":"text/x-python","patch_set":2,"id":"5ff73747_2b407835","line":4681,"updated":"2017-04-24 02:30:25.000000000","message":"Use volume.display_name","commit_id":"b7fb641093525490dcba50fa0956520ca3a74071"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"ba0092c768993cc92ecb5e29741d3d632cb844d9","unresolved":false,"context_lines":[{"line_number":4678,"context_line":"        model_update \u003d self.set_volume_replication_if_enabled("},{"line_number":4679,"context_line":"            self.conn, extraSpecs, volume, provider_location)"},{"line_number":4680,"context_line":""},{"line_number":4681,"context_line":"        volumeDisplayName \u003d volume[\u0027display_name\u0027]"},{"line_number":4682,"context_line":"        model_update.update("},{"line_number":4683,"context_line":"            {\u0027display_name\u0027: volumeDisplayName})"},{"line_number":4684,"context_line":"        model_update.update("}],"source_content_type":"text/x-python","patch_set":2,"id":"5ff73747_74dc1b74","line":4681,"in_reply_to":"5ff73747_2b407835","updated":"2017-04-24 10:32:17.000000000","message":"Sure. Thanks","commit_id":"b7fb641093525490dcba50fa0956520ca3a74071"}],"cinder/volume/drivers/dell_emc/vmax/utils.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"13e49aa6b2db3cf736562ed8cd3d5be9f38426b0","unresolved":false,"context_lines":[{"line_number":711,"context_line":"            LOG.debug(\"Retrieved pool: %(foundPoolInstanceNames)s\","},{"line_number":712,"context_line":"                      {\u0027foundPoolInstanceNames\u0027: foundPoolInstanceNames})"},{"line_number":713,"context_line":""},{"line_number":714,"context_line":"        if len(foundPoolInstanceNames) \u003e 0:"},{"line_number":715,"context_line":"            foundPoolInstanceName \u003d foundPoolInstanceNames[0]"},{"line_number":716,"context_line":""},{"line_number":717,"context_line":"        return foundPoolInstanceName"}],"source_content_type":"text/x-python","patch_set":1,"id":"7ffa3b31_b0e1472d","line":714,"range":{"start_line":714,"start_character":8,"end_line":714,"end_character":42},"updated":"2017-04-18 16:20:18.000000000","message":"if foundPoolInstanceNames and len(foundPoolInstanceNames) \u003e 0","commit_id":"b01410325eeabba2375ca7592633208a2ca634a2"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"13e49aa6b2db3cf736562ed8cd3d5be9f38426b0","unresolved":false,"context_lines":[{"line_number":741,"context_line":"            LOG.debug(\"Retrieved pool: %(foundPoolInstanceNames)s\","},{"line_number":742,"context_line":"                      {\u0027foundPoolInstanceNames\u0027: foundPoolInstanceNames})"},{"line_number":743,"context_line":""},{"line_number":744,"context_line":"        if len(foundPoolInstanceNames) \u003e 0:"},{"line_number":745,"context_line":"            foundPoolInstanceName \u003d foundPoolInstanceNames[0]"},{"line_number":746,"context_line":""},{"line_number":747,"context_line":"        return foundPoolInstanceName"}],"source_content_type":"text/x-python","patch_set":1,"id":"7ffa3b31_d0bf33f9","line":744,"range":{"start_line":744,"start_character":8,"end_line":744,"end_character":42},"updated":"2017-04-18 16:20:18.000000000","message":"if foundPoolInstanceNames and len(foundPoolInstanceNames) \u003e 0","commit_id":"b01410325eeabba2375ca7592633208a2ca634a2"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"13e49aa6b2db3cf736562ed8cd3d5be9f38426b0","unresolved":false,"context_lines":[{"line_number":2105,"context_line":"    def find_volume_by_device_id_on_array(self, storageSystem, deviceID):"},{"line_number":2106,"context_line":"        \"\"\"Find the volume by device ID on a specific array."},{"line_number":2107,"context_line":""},{"line_number":2108,"context_line":"        :param conn: connection to the ecom server"},{"line_number":2109,"context_line":"        :param storageSystem: the storage system name"},{"line_number":2110,"context_line":"        :param deviceID: string value of the volume device ID"},{"line_number":2111,"context_line":"        :returns: foundVolumeInstanceName"}],"source_content_type":"text/x-python","patch_set":1,"id":"7ffa3b31_70317fa2","line":2108,"range":{"start_line":2108,"start_character":9,"end_line":2108,"end_character":50},"updated":"2017-04-18 16:20:18.000000000","message":"This one is removed.","commit_id":"b01410325eeabba2375ca7592633208a2ca634a2"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"13e49aa6b2db3cf736562ed8cd3d5be9f38426b0","unresolved":false,"context_lines":[{"line_number":2130,"context_line":"        \"\"\"Check if the volume\u0027s extraSpecs indicate FAST is enabled."},{"line_number":2131,"context_line":""},{"line_number":2132,"context_line":"        :param extraSpecs: dict -- extra spec dict"},{"line_number":2133,"context_line":"        :raises: VolumeBackendAPIException"},{"line_number":2134,"context_line":"        \"\"\""},{"line_number":2135,"context_line":"        try:"},{"line_number":2136,"context_line":"            if extraSpecs[\u0027storagetype:fastpolicy\u0027] is not None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7ffa3b31_b099477a","line":2133,"updated":"2017-04-18 16:20:18.000000000","message":":return: True if no fast","commit_id":"b01410325eeabba2375ca7592633208a2ca634a2"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"583367321b29f3f35c6e79c8568e71187620d744","unresolved":false,"context_lines":[{"line_number":2134,"context_line":"        \"\"\""},{"line_number":2135,"context_line":"        try:"},{"line_number":2136,"context_line":"            if extraSpecs[\u0027storagetype:fastpolicy\u0027] is not None:"},{"line_number":2137,"context_line":"                LOG.warning(_("},{"line_number":2138,"context_line":"                    \"FAST is enabled. Policy: %(fastPolicyName)s.\"),"},{"line_number":2139,"context_line":"                    {\u0027fastPolicyName\u0027: extraSpecs[\u0027storagetype:fastpolicy\u0027]})"},{"line_number":2140,"context_line":"                exceptionMessage \u003d (_("}],"source_content_type":"text/x-python","patch_set":2,"id":"5ff73747_6b568009","line":2137,"range":{"start_line":2137,"start_character":28,"end_line":2137,"end_character":29},"updated":"2017-04-24 02:30:25.000000000","message":"Should not use _ for LOG.warning.  Please remove it.","commit_id":"b7fb641093525490dcba50fa0956520ca3a74071"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"ba0092c768993cc92ecb5e29741d3d632cb844d9","unresolved":false,"context_lines":[{"line_number":2134,"context_line":"        \"\"\""},{"line_number":2135,"context_line":"        try:"},{"line_number":2136,"context_line":"            if extraSpecs[\u0027storagetype:fastpolicy\u0027] is not None:"},{"line_number":2137,"context_line":"                LOG.warning(_("},{"line_number":2138,"context_line":"                    \"FAST is enabled. Policy: %(fastPolicyName)s.\"),"},{"line_number":2139,"context_line":"                    {\u0027fastPolicyName\u0027: extraSpecs[\u0027storagetype:fastpolicy\u0027]})"},{"line_number":2140,"context_line":"                exceptionMessage \u003d (_("}],"source_content_type":"text/x-python","patch_set":2,"id":"5ff73747_f436ebb4","line":2137,"range":{"start_line":2137,"start_character":28,"end_line":2137,"end_character":29},"in_reply_to":"5ff73747_6b568009","updated":"2017-04-24 10:32:17.000000000","message":"Will do. Thanks","commit_id":"b7fb641093525490dcba50fa0956520ca3a74071"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"af48b0260bdea842c615f4df4c1204a909bd2f3f","unresolved":false,"context_lines":[{"line_number":2156,"context_line":""},{"line_number":2157,"context_line":"        :param conn: connection to the ecom server"},{"line_number":2158,"context_line":"        :param volumeInstanceName: the volume instance name"},{"line_number":2159,"context_line":"        :param deviceId: :raises: VolumeBackendAPIException"},{"line_number":2160,"context_line":"        :raises: VolumeBackendAPIException"},{"line_number":2161,"context_line":"        :return: True if not in Masking View"},{"line_number":2162,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"5ff73747_4337ede4","line":2159,"range":{"start_line":2159,"start_character":25,"end_line":2159,"end_character":59},"updated":"2017-04-25 16:58:02.000000000","message":"Copy and paste error?","commit_id":"7e579f5f658104f6a39d3e032f055c8dc8e8edde"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"38fbb584ceeb615b45e6af8ef70f5886fdde1d3f","unresolved":false,"context_lines":[{"line_number":711,"context_line":"            LOG.debug(\"Retrieved pool: %(foundPoolInstanceNames)s\","},{"line_number":712,"context_line":"                      {\u0027foundPoolInstanceNames\u0027: foundPoolInstanceNames})"},{"line_number":713,"context_line":""},{"line_number":714,"context_line":"        if foundPoolInstanceNames and len(foundPoolInstanceNames) \u003e 0:"},{"line_number":715,"context_line":"            foundPoolInstanceName \u003d foundPoolInstanceNames[0]"},{"line_number":716,"context_line":""},{"line_number":717,"context_line":"        return foundPoolInstanceName"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_49579b59","line":714,"updated":"2017-05-23 17:44:47.000000000","message":"Could just be:\n\nif foundPoolInstanceNames:\n\nas that will evaluate to false if it\u0027s empty.","commit_id":"dd7ea30547321819f74f4899019f44ff15697b43"}]}