)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"814b3416a27620ad6503c5c841c822141239b685","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit is to add two options in the volume driver base class."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"We add \u0027api_server_ip\u0027 and \u0027api_server_port\u0027 for setting the IP"},{"line_number":12,"context_line":"address and the port of the volume backend."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Idac6f57512a45262ac76c78c88c3b474409ab786"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7ffa3b31_dc461b7d","line":11,"range":{"start_line":11,"start_character":7,"end_line":11,"end_character":43},"updated":"2017-04-19 08:47:59.000000000","message":"These names are a little confusing.","commit_id":"44eb1dabfdd8026862d4ee6cda796d6ff50c8df1"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"d92ae2335efe672ba847bf9e55035939cb76c7df","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit is to add two options in the volume driver base class."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"We add \u0027api_server_ip\u0027 and \u0027api_server_port\u0027 for setting the IP"},{"line_number":12,"context_line":"address and the port of the volume backend."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Idac6f57512a45262ac76c78c88c3b474409ab786"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7ffa3b31_3dd13624","line":11,"range":{"start_line":11,"start_character":7,"end_line":11,"end_character":43},"in_reply_to":"7ffa3b31_37fe38ae","updated":"2017-04-21 02:17:56.000000000","message":"This is a bp, so you should add a spec for it, otherwise please add a link to irc log or mailist that cinder guys had already discussed that before. And another question, if these two configuration options will only be used for backend driver. Can we combine them into one, like ``driver_server_address``?","commit_id":"44eb1dabfdd8026862d4ee6cda796d6ff50c8df1"},{"author":{"_account_id":19576,"name":"Guy Kim","email":"guy.kim088@gmail.com","username":"Guy"},"change_message_id":"f0840ff1459aa86f1aae890a19e23fa80daa2c9a","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit is to add two options in the volume driver base class."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"We add \u0027api_server_ip\u0027 and \u0027api_server_port\u0027 for setting the IP"},{"line_number":12,"context_line":"address and the port of the volume backend."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Idac6f57512a45262ac76c78c88c3b474409ab786"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7ffa3b31_7d59fe8b","line":11,"range":{"start_line":11,"start_character":7,"end_line":11,"end_character":43},"in_reply_to":"7ffa3b31_3dd13624","updated":"2017-04-21 02:47:33.000000000","message":"Thank you for reply. I added a link in the bp for it. It was asked by Mike Perez when I made a change in our disco driver (https://review.openstack.org/#/c/347100/30/cinder/volume/drivers/disco/disco.py)\nAbout the second question, these two configuration options are used by backend driver. I chose to separate it in two different options: one for the IP address and the other one for the port. It is in order to make it clearer.","commit_id":"44eb1dabfdd8026862d4ee6cda796d6ff50c8df1"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"04825bfdcf4e85dd407f000a0f07d4ba8326e774","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit is to add two options in the volume driver base class."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"We add \u0027api_server_ip\u0027 and \u0027api_server_port\u0027 for setting the IP"},{"line_number":12,"context_line":"address and the port of the volume backend."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Idac6f57512a45262ac76c78c88c3b474409ab786"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5f201791_91944b46","line":11,"range":{"start_line":11,"start_character":7,"end_line":11,"end_character":43},"in_reply_to":"7ffa3b31_7d59fe8b","updated":"2017-06-21 16:43:45.000000000","message":"These names don\u0027t work, because \"api_\" implies that this is related to the cinder API service, not a backend.","commit_id":"44eb1dabfdd8026862d4ee6cda796d6ff50c8df1"},{"author":{"_account_id":19576,"name":"Guy Kim","email":"guy.kim088@gmail.com","username":"Guy"},"change_message_id":"d05cf84fd0fc27d8cc2fccae669739c955804e6a","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit is to add two options in the volume driver base class."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"We add \u0027api_server_ip\u0027 and \u0027api_server_port\u0027 for setting the IP"},{"line_number":12,"context_line":"address and the port of the volume backend."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Idac6f57512a45262ac76c78c88c3b474409ab786"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7ffa3b31_37fe38ae","line":11,"range":{"start_line":11,"start_character":7,"end_line":11,"end_character":43},"in_reply_to":"7ffa3b31_dc461b7d","updated":"2017-04-19 09:02:01.000000000","message":"Is \u0027backend_api_server_ip\u0027 and \u0027backend_api_server_port\u0027 better?","commit_id":"44eb1dabfdd8026862d4ee6cda796d6ff50c8df1"}]}