)]}'
{"cinder/tests/unit/volume/drivers/disco/__init__.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"ee0307d44524e41eb730e4e8176951c0f6944b3a","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        self.cfg.retry_interval \u003d 2"},{"line_number":62,"context_line":"        self.cfg.num_volume_device_scan_tries \u003d 3"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"        CONF \u003d cfg.CONF"},{"line_number":65,"context_line":"        CONF.choice_client \u003d \u0027SOAP\u0027"},{"line_number":66,"context_line":"        CONF.rest_ip \u003d \u0027127.0.0.1\u0027"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5ff73747_fe091495","side":"PARENT","line":64,"updated":"2017-05-03 14:13:38.000000000","message":"Please, use mocks here instead of changing global config opts for tests only","commit_id":"23eee40b4010918692a4df472b64fc4440df0c1e"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"29d404586b75c9fd3e83b66114d2de8509877f47","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        self.cfg.retry_interval \u003d 2"},{"line_number":62,"context_line":"        self.cfg.num_volume_device_scan_tries \u003d 3"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"        CONF \u003d cfg.CONF"},{"line_number":65,"context_line":"        CONF.choice_client \u003d \u0027SOAP\u0027"},{"line_number":66,"context_line":"        CONF.rest_ip \u003d \u0027127.0.0.1\u0027"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f044301_7803a510","side":"PARENT","line":64,"in_reply_to":"5ff73747_fe091495","updated":"2017-05-08 10:20:15.000000000","message":"I\u0027m not sure if I get it - this is the code I\u0027m changing. What I\u0027ve did is I moved those options to Configuration object mock that is then passed to the driver\u0027s __init__() method.","commit_id":"23eee40b4010918692a4df472b64fc4440df0c1e"}],"cinder/volume/drivers/disco/disco.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"903fb8a5eb6bba4926801aefb2b0675278dd5614","unresolved":false,"context_lines":[{"line_number":118,"context_line":"    def do_setup(self, context):"},{"line_number":119,"context_line":"        \"\"\"Create client for DISCO request manager.\"\"\""},{"line_number":120,"context_line":"        LOG.debug(\"Enter in DiscoDriver do_setup.\")"},{"line_number":121,"context_line":"        if self.configuration.choice_client.lower() \u003d\u003d \"rest\":"},{"line_number":122,"context_line":"            self.client \u003d disco_api.DiscoApi("},{"line_number":123,"context_line":"                self.configuration.rest_ip,"},{"line_number":124,"context_line":"                self.configuration.disco_src_api_port)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ff73747_2d193d21","line":121,"range":{"start_line":121,"start_character":11,"end_line":121,"end_character":43},"updated":"2017-04-26 20:08:40.000000000","message":"Why does this driver even have an option to pick between two different clients?\n\nWhich one is CI\u0027d?","commit_id":"5023dabaadcc4bfac772cb41d5af8a0ec5cdbeeb"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"7012d222d294c4b2ee7afb23e2b58037aea0c25a","unresolved":false,"context_lines":[{"line_number":118,"context_line":"    def do_setup(self, context):"},{"line_number":119,"context_line":"        \"\"\"Create client for DISCO request manager.\"\"\""},{"line_number":120,"context_line":"        LOG.debug(\"Enter in DiscoDriver do_setup.\")"},{"line_number":121,"context_line":"        if self.configuration.choice_client.lower() \u003d\u003d \"rest\":"},{"line_number":122,"context_line":"            self.client \u003d disco_api.DiscoApi("},{"line_number":123,"context_line":"                self.configuration.rest_ip,"},{"line_number":124,"context_line":"                self.configuration.disco_src_api_port)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ff73747_4ab3424e","line":121,"range":{"start_line":121,"start_character":11,"end_line":121,"end_character":43},"in_reply_to":"5ff73747_2d193d21","updated":"2017-04-27 07:34:53.000000000","message":"I don\u0027t know either, and I really disliked how configuration is defined in the driver.","commit_id":"5023dabaadcc4bfac772cb41d5af8a0ec5cdbeeb"}]}