)]}'
{"cinder/tests/unit/targets/targets_fixture.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"854716ba355377388d1d7f7d50f3deee8f74f143","unresolved":false,"context_lines":[{"line_number":56,"context_line":"             \u0027created_at\u0027: timeutils.utcnow(),"},{"line_number":57,"context_line":"             \u0027host\u0027: \u0027fake_host@lvm#lvm\u0027}"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        self.testvol_no_prov_loc \u003d copy.copy(self.testvol)"},{"line_number":60,"context_line":"        self.testvol_no_prov_loc[\u0027provider_location\u0027] \u003d None"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        self.iscsi_target_prefix \u003d \u0027iqn.2010-10.org.openstack:\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f044301_c4717246","line":59,"updated":"2017-05-11 13:58:39.000000000","message":"nit: I think we could just use `self.testvol.copy()`","commit_id":"3e37cb6f8cf489480e264b434290064a61c4a782"}],"cinder/volume/targets/lio.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"854716ba355377388d1d7f7d50f3deee8f74f143","unresolved":false,"context_lines":[{"line_number":186,"context_line":"        return super(LioAdm, self).initialize_connection(volume, connector)"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    def terminate_connection(self, volume, connector, **kwargs):"},{"line_number":189,"context_line":"        if volume[\u0027provider_location\u0027] is None:"},{"line_number":190,"context_line":"            LOG.debug(\u0027No provider_location for volume %s.\u0027,"},{"line_number":191,"context_line":"                      volume[\u0027id\u0027])"},{"line_number":192,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f044301_44ad6299","line":189,"updated":"2017-05-11 13:58:39.000000000","message":"nit: I would prefer to check it with:\n\n if not volume[\u0027provider_location\u0027]:\n\nIn case we have an empty string at some point.","commit_id":"3e37cb6f8cf489480e264b434290064a61c4a782"}]}