)]}'
{"cinder/volume/drivers/remotefs.py":[{"author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"change_message_id":"cf5567a3fc77d834673d7beef8dd547b333786c1","unresolved":false,"context_lines":[{"line_number":1013,"context_line":""},{"line_number":1014,"context_line":"        volume_status \u003d snapshot.volume.status"},{"line_number":1015,"context_line":"        if volume_status not in [\u0027available\u0027, \u0027in-use\u0027,"},{"line_number":1016,"context_line":"                                 \u0027backing-up\u0027, \u0027deleting\u0027, \u0027cloning\u0027]:"},{"line_number":1017,"context_line":"            msg \u003d _(\"Volume status must be \u0027available\u0027, \u0027in-use\u0027, \""},{"line_number":1018,"context_line":"                    \"\u0027backing-up\u0027, \u0027deleting\u0027 or \u0027cloning\u0027 but is: \""},{"line_number":1019,"context_line":"                    \"%(status)s.\") % {\u0027status\u0027: volume_status}"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ff73747_804c1877","line":1016,"range":{"start_line":1016,"start_character":60,"end_line":1016,"end_character":67},"updated":"2017-04-21 21:19:52.000000000","message":"If the snapshot status is \u0027cloning\u0027 then shouldn\u0027t the snapshot delete operation fail?","commit_id":"6fae96963bffa659f6c031f63152b56ee99a22bd"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"83d5390d138252ed1e126a9cc9eff4e04061ab6e","unresolved":false,"context_lines":[{"line_number":1013,"context_line":""},{"line_number":1014,"context_line":"        volume_status \u003d snapshot.volume.status"},{"line_number":1015,"context_line":"        if volume_status not in [\u0027available\u0027, \u0027in-use\u0027,"},{"line_number":1016,"context_line":"                                 \u0027backing-up\u0027, \u0027deleting\u0027, \u0027cloning\u0027]:"},{"line_number":1017,"context_line":"            msg \u003d _(\"Volume status must be \u0027available\u0027, \u0027in-use\u0027, \""},{"line_number":1018,"context_line":"                    \"\u0027backing-up\u0027, \u0027deleting\u0027 or \u0027cloning\u0027 but is: \""},{"line_number":1019,"context_line":"                    \"%(status)s.\") % {\u0027status\u0027: volume_status}"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ff73747_17128c59","line":1016,"range":{"start_line":1016,"start_character":60,"end_line":1016,"end_character":67},"in_reply_to":"5ff73747_804c1877","updated":"2017-04-22 07:41:43.000000000","message":"That\u0027s actually the volume status. When cloning a volume, we have a temporary snapshot that gets deleted.\n\nAlso, one thing to note here is that the snapshot create/delete and volume clone operations are synchronized in case of unrelated operations targeting the same volume.","commit_id":"6fae96963bffa659f6c031f63152b56ee99a22bd"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"2476061f988817199943625f3165ce28fe3e4be9","unresolved":false,"context_lines":[{"line_number":1037,"context_line":"                            else \u0027offline\u0027)})"},{"line_number":1038,"context_line":""},{"line_number":1039,"context_line":"        volume_status \u003d snapshot.volume.status"},{"line_number":1040,"context_line":"        acceptable_states \u003d [\u0027available\u0027, \u0027in-use\u0027, \u0027backing-up\u0027, \u0027deleting\u0027,"},{"line_number":1041,"context_line":"                             \u0027downloading\u0027]"},{"line_number":1042,"context_line":"        self._validate_state(volume_status, acceptable_states)"},{"line_number":1043,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7f231b9d_ef983d6b","line":1040,"updated":"2017-06-12 10:00:41.000000000","message":"Please, use volume status constants from [1] here and below.\n\n[1] https://github.com/openstack/cinder/blob/master/cinder/objects/fields.py#L148","commit_id":"63b9f0fb8e831c29fab00670c19056e436d5f5f0"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"825df184cb639fe3f9f7cb4ac0c8fb4c118df9a5","unresolved":false,"context_lines":[{"line_number":1037,"context_line":"                            else \u0027offline\u0027)})"},{"line_number":1038,"context_line":""},{"line_number":1039,"context_line":"        volume_status \u003d snapshot.volume.status"},{"line_number":1040,"context_line":"        acceptable_states \u003d [\u0027available\u0027, \u0027in-use\u0027, \u0027backing-up\u0027, \u0027deleting\u0027,"},{"line_number":1041,"context_line":"                             \u0027downloading\u0027]"},{"line_number":1042,"context_line":"        self._validate_state(volume_status, acceptable_states)"},{"line_number":1043,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7f231b9d_ef5b9d84","line":1040,"in_reply_to":"7f231b9d_ef983d6b","updated":"2017-06-12 10:09:57.000000000","message":"Hmm, those are volume attach states, I\u0027d need the actual volume states, for which we don\u0027t have an enum yet.","commit_id":"63b9f0fb8e831c29fab00670c19056e436d5f5f0"}]}