)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"c5ab845e53617c8af8c91b1608e1c29838231009","unresolved":false,"context_lines":[{"line_number":10,"context_line":"be used to make sure a disconnect call gives more priority to cleaning"},{"line_number":11,"context_line":"up everything than preserving data."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch bumps minimum os-brick version to 1.15.1 and adds support for"},{"line_number":14,"context_line":"this new force parameter using it in calls where we know it\u0027s OK to lose"},{"line_number":15,"context_line":"data when we encounter an error as long as we report that we have"},{"line_number":16,"context_line":"failed."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"1f1a1f67_e2df6f63","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":41},"updated":"2017-07-19 15:53:10.000000000","message":"This can probably be removed.","commit_id":"bfc67dac686897b85b7545e554744495f848457b"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"af8396484426af59cac6741cb10a25928356d3e3","unresolved":false,"context_lines":[{"line_number":10,"context_line":"be used to make sure a disconnect call gives more priority to cleaning"},{"line_number":11,"context_line":"up everything than preserving data."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch bumps minimum os-brick version to 1.15.1 and adds support for"},{"line_number":14,"context_line":"this new force parameter using it in calls where we know it\u0027s OK to lose"},{"line_number":15,"context_line":"data when we encounter an error as long as we report that we have"},{"line_number":16,"context_line":"failed."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"1f1a1f67_c7c24053","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":41},"in_reply_to":"1f1a1f67_e2df6f63","updated":"2017-07-19 17:46:34.000000000","message":"Done","commit_id":"bfc67dac686897b85b7545e554744495f848457b"}],"cinder/tests/unit/backup/test_backup.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"c5ab845e53617c8af8c91b1608e1c29838231009","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    pass"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"# TODO(geguileo): Remove once we have latest os-brick supporting force and"},{"line_number":52,"context_line":"#                 ignore_errors parameters"},{"line_number":53,"context_line":"class FakeConnector(fake.FakeConnector):"},{"line_number":54,"context_line":"    def disconnect_volume(self, connection_properties, device_info,"}],"source_content_type":"text/x-python","patch_set":9,"id":"1f1a1f67_a23cd792","line":51,"updated":"2017-07-19 15:53:10.000000000","message":"Do we still need this?","commit_id":"bfc67dac686897b85b7545e554744495f848457b"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"af8396484426af59cac6741cb10a25928356d3e3","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    pass"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"# TODO(geguileo): Remove once we have latest os-brick supporting force and"},{"line_number":52,"context_line":"#                 ignore_errors parameters"},{"line_number":53,"context_line":"class FakeConnector(fake.FakeConnector):"},{"line_number":54,"context_line":"    def disconnect_volume(self, connection_properties, device_info,"}],"source_content_type":"text/x-python","patch_set":9,"id":"1f1a1f67_4758702f","line":51,"in_reply_to":"1f1a1f67_a23cd792","updated":"2017-07-19 17:46:34.000000000","message":"No, we don\u0027t.  :-)","commit_id":"bfc67dac686897b85b7545e554744495f848457b"}],"cinder/volume/driver.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"f150db0428a955288daed93357dec53d49ed793c","unresolved":false,"context_lines":[{"line_number":449,"context_line":"            with exc.context(force, \u0027Disconnect failed\u0027):"},{"line_number":450,"context_line":"                connector.disconnect_volume(attach_info[\u0027conn\u0027][\u0027data\u0027],"},{"line_number":451,"context_line":"                                            attach_info[\u0027device\u0027], force,"},{"line_number":452,"context_line":"                                            ignore_errors)"},{"line_number":453,"context_line":""},{"line_number":454,"context_line":"        if remote:"},{"line_number":455,"context_line":"            # Call remote manager\u0027s terminate_connection which includes"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ff73747_6011685d","line":452,"updated":"2017-04-27 18:36:21.000000000","message":"This should pass \"force\" and \"ignore_errors\" as kwargs -- we can enforce the requirement for them to be handled by adding a dependency on a new os-brick version.","commit_id":"79410a1e8d4c8d51fea854fa4800930a640d9f5d"}]}
