)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"df63ea59fe920fcafd1623ab247a21a519a768b6","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update configuration names in ITRI DISCO volume driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit is to update and deprecate the name of some configuration names:"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"* \"san_api_port\" is new config option added in san driver"},{"line_number":12,"context_line":"* \"rest_ip\" is marked as deprecated and will be replaced with \"san_ip\""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"5f4e5783_ef29289b","line":9,"range":{"start_line":9,"start_character":70,"end_line":9,"end_character":76},"updated":"2017-10-11 22:43:48.000000000","message":"Should technically wrap at 72 characters, but not that big a deal.","commit_id":"c057f9fd8930e262f13e3908cff1b20ef8f7fe60"},{"author":{"_account_id":19576,"name":"Guy Kim","email":"guy.kim088@gmail.com","username":"Guy"},"change_message_id":"a1389475d5ff10ea01923c47d9e1ed50d1d8126b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update configuration names in ITRI DISCO volume driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit is to update and deprecate the name of some configuration names:"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"* \"san_api_port\" is new config option added in san driver"},{"line_number":12,"context_line":"* \"rest_ip\" is marked as deprecated and will be replaced with \"san_ip\""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"5f4e5783_9b22f6a3","line":9,"range":{"start_line":9,"start_character":70,"end_line":9,"end_character":76},"in_reply_to":"5f4e5783_ef29289b","updated":"2017-10-12 04:38:35.000000000","message":"Done","commit_id":"c057f9fd8930e262f13e3908cff1b20ef8f7fe60"}],"cinder/volume/drivers/disco/disco.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"47bc73475f20bb2aff6dfa02c34486cc2370d51e","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    cfg.PortOpt(\u0027disco_src_api_port\u0027,"},{"line_number":67,"context_line":"                default\u003d\u00278080\u0027,"},{"line_number":68,"context_line":"                deprecated_for_removal\u003dTrue,"},{"line_number":69,"context_line":"                deprecated_reason\u003d\u0027Using san_ssh_port later\u0027,"},{"line_number":70,"context_line":"                help\u003d\u0027The port of DISCO source API\u0027,"},{"line_number":71,"context_line":"                deprecated_group\u003d\u0027DEFAULT\u0027),"},{"line_number":72,"context_line":"    cfg.StrOpt(\u0027disco_volume_name_prefix\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"1f1a1f67_6849dd89","line":69,"range":{"start_line":69,"start_character":41,"end_line":69,"end_character":53},"updated":"2017-07-20 13:38:18.000000000","message":"Is this using SSH?","commit_id":"3ab7b5db23998e2ac699f961059493443e856778"},{"author":{"_account_id":19576,"name":"Guy Kim","email":"guy.kim088@gmail.com","username":"Guy"},"change_message_id":"b194acdb7f4e400582b4dfc0ef100a824de48013","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    cfg.PortOpt(\u0027disco_src_api_port\u0027,"},{"line_number":67,"context_line":"                default\u003d\u00278080\u0027,"},{"line_number":68,"context_line":"                deprecated_for_removal\u003dTrue,"},{"line_number":69,"context_line":"                deprecated_reason\u003d\u0027Using san_ssh_port later\u0027,"},{"line_number":70,"context_line":"                help\u003d\u0027The port of DISCO source API\u0027,"},{"line_number":71,"context_line":"                deprecated_group\u003d\u0027DEFAULT\u0027),"},{"line_number":72,"context_line":"    cfg.StrOpt(\u0027disco_volume_name_prefix\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"ff346bd7_9c688621","line":69,"range":{"start_line":69,"start_character":41,"end_line":69,"end_character":53},"in_reply_to":"1f1a1f67_32457071","updated":"2017-07-26 01:51:47.000000000","message":"I agree with you that using the \"san_ssh_port\" will be confusing. So I will start a new patch for adding the new \"san_api_port\" in the san driver first. Then we can start the change in the others drivers. Besides, about this patch, I will wait for the san driver to have the new config option. Then I will make the change in the disco driver.","commit_id":"3ab7b5db23998e2ac699f961059493443e856778"},{"author":{"_account_id":19576,"name":"Guy Kim","email":"guy.kim088@gmail.com","username":"Guy"},"change_message_id":"890b851e6240606a3b1c375a7f0e3192f17d4218","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    cfg.PortOpt(\u0027disco_src_api_port\u0027,"},{"line_number":67,"context_line":"                default\u003d\u00278080\u0027,"},{"line_number":68,"context_line":"                deprecated_for_removal\u003dTrue,"},{"line_number":69,"context_line":"                deprecated_reason\u003d\u0027Using san_ssh_port later\u0027,"},{"line_number":70,"context_line":"                help\u003d\u0027The port of DISCO source API\u0027,"},{"line_number":71,"context_line":"                deprecated_group\u003d\u0027DEFAULT\u0027),"},{"line_number":72,"context_line":"    cfg.StrOpt(\u0027disco_volume_name_prefix\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"1f1a1f67_d67cf9ec","line":69,"range":{"start_line":69,"start_character":41,"end_line":69,"end_character":53},"in_reply_to":"1f1a1f67_6849dd89","updated":"2017-07-21 03:03:42.000000000","message":"We use rest API so we don\u0027t use the ssh. But it is the only port config in san driver. We want to use the config from san driver for more clarity. So do we just use our own config?","commit_id":"3ab7b5db23998e2ac699f961059493443e856778"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"0908897d8bd878b2bd9a92bf4c98319c1e6edff6","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    cfg.PortOpt(\u0027disco_src_api_port\u0027,"},{"line_number":67,"context_line":"                default\u003d\u00278080\u0027,"},{"line_number":68,"context_line":"                deprecated_for_removal\u003dTrue,"},{"line_number":69,"context_line":"                deprecated_reason\u003d\u0027Using san_ssh_port later\u0027,"},{"line_number":70,"context_line":"                help\u003d\u0027The port of DISCO source API\u0027,"},{"line_number":71,"context_line":"                deprecated_group\u003d\u0027DEFAULT\u0027),"},{"line_number":72,"context_line":"    cfg.StrOpt(\u0027disco_volume_name_prefix\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"1f1a1f67_32457071","line":69,"range":{"start_line":69,"start_character":41,"end_line":69,"end_character":53},"in_reply_to":"1f1a1f67_d67cf9ec","updated":"2017-07-21 08:48:13.000000000","message":"Hmm. I think it\u0027s a common thing, but not all drivers use SSH, so the naming of this is very poor. And I don\u0027t think you would want to default to port 22.\n\nI think either we need to add a new \"san_api_port\" that all drivers can use, or for this one you can have a disco specific option. My preference would actually be to have the common one, then we can start to move over some of the other drivers.","commit_id":"3ab7b5db23998e2ac699f961059493443e856778"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"9f71550f5d01691a0ba2c6bac4318fa59cb82fd6","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    cfg.PortOpt(\u0027disco_src_api_port\u0027,"},{"line_number":67,"context_line":"                default\u003d\u00278080\u0027,"},{"line_number":68,"context_line":"                deprecated_for_removal\u003dTrue,"},{"line_number":69,"context_line":"                deprecated_reason\u003d\u0027Using san_ssh_port later\u0027,"},{"line_number":70,"context_line":"                help\u003d\u0027The port of DISCO source API\u0027,"},{"line_number":71,"context_line":"                deprecated_group\u003d\u0027DEFAULT\u0027),"},{"line_number":72,"context_line":"    cfg.StrOpt(\u0027disco_volume_name_prefix\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"ff346bd7_fc053912","line":69,"range":{"start_line":69,"start_character":41,"end_line":69,"end_character":53},"in_reply_to":"ff346bd7_9c688621","updated":"2017-07-26 15:50:07.000000000","message":"You could also add it there as part of this patch, then we can follow up with other drivers later. Up to you.\n\nThanks!","commit_id":"3ab7b5db23998e2ac699f961059493443e856778"}],"cinder/volume/drivers/san/san.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"7af1897272490db6723a49ae8c793565e82f2ef2","unresolved":false,"context_lines":[{"line_number":60,"context_line":"                default\u003d22,"},{"line_number":61,"context_line":"                help\u003d\u0027SSH port to use with SAN\u0027),"},{"line_number":62,"context_line":"    cfg.PortOpt(\u0027san_api_port\u0027,"},{"line_number":63,"context_line":"                default\u003d8080,"},{"line_number":64,"context_line":"                help\u003d\u0027Port to use to access the SAN API\u0027),"},{"line_number":65,"context_line":"    cfg.BoolOpt(\u0027san_is_local\u0027,"},{"line_number":66,"context_line":"                default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":17,"id":"5f4e5783_f64349ae","line":63,"updated":"2017-10-11 20:15:35.000000000","message":"I don\u0027t think this option should have a default.  What are the odds this is the correct default for any other san drivers that want to re-use this option name?","commit_id":"c057f9fd8930e262f13e3908cff1b20ef8f7fe60"},{"author":{"_account_id":19576,"name":"Guy Kim","email":"guy.kim088@gmail.com","username":"Guy"},"change_message_id":"a1389475d5ff10ea01923c47d9e1ed50d1d8126b","unresolved":false,"context_lines":[{"line_number":60,"context_line":"                default\u003d22,"},{"line_number":61,"context_line":"                help\u003d\u0027SSH port to use with SAN\u0027),"},{"line_number":62,"context_line":"    cfg.PortOpt(\u0027san_api_port\u0027,"},{"line_number":63,"context_line":"                default\u003d8080,"},{"line_number":64,"context_line":"                help\u003d\u0027Port to use to access the SAN API\u0027),"},{"line_number":65,"context_line":"    cfg.BoolOpt(\u0027san_is_local\u0027,"},{"line_number":66,"context_line":"                default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":17,"id":"5f4e5783_dbff4eff","line":63,"in_reply_to":"5f4e5783_f64349ae","updated":"2017-10-12 04:38:35.000000000","message":"I removed the default value for this option.","commit_id":"c057f9fd8930e262f13e3908cff1b20ef8f7fe60"}],"releasenotes/notes/update_config_options_disco_volume_driver-07e52aa43e83c243.yaml":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"8d8d955b5e0bd1c23db97fc9c16ea7721f679d59","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    Marked the ITRI DISCO driver option \u0027disco_rest_api\u0027 as deprecated"},{"line_number":11,"context_line":"    in order to use the config \u0027san_ip\u0027 provided by the generic driver san."},{"line_number":12,"context_line":"    Marked the ITRI DISCO driver option \u0027disco_src_api_port\u0027 as deprecated"},{"line_number":13,"context_line":"    in order to use the config \u0027san_ssh_port\u0027 provided by the generic driver san."}],"source_content_type":"text/x-yaml","patch_set":14,"id":"9f436f4f_11d05ff7","line":13,"range":{"start_line":13,"start_character":36,"end_line":13,"end_character":39},"updated":"2017-08-08 10:12:23.000000000","message":"api","commit_id":"d46509742d651a799c5581dab0de5aaa9886ac52"}]}