)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"c018059553e7a4f27012458f08b4628548f2a53e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     TommyLike \u003ctommylikehu@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-05-15 07:20:57 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add support for generalized filtering on list APIs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds ``filters`` API to retrieve allowed filters."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1f013ff3_b96f38c4","line":7,"updated":"2017-05-15 09:12:45.000000000","message":"Would it be better to use \u0027generic\u0027 instead of \u0027generalized\u0027 here?","commit_id":"b76ecae59fd4328551740afb224b33a40dd00c7f"},{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"c018059553e7a4f27012458f08b4628548f2a53e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add support for generalized filtering on list APIs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds ``filters`` API to retrieve allowed filters."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"DocImpact"},{"line_number":12,"context_line":"APIImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1f013ff3_99747c9b","line":9,"updated":"2017-05-15 09:12:45.000000000","message":"I\u0027d prefer to explicitly call it \u0027resource_filters\u0027 API just to limit it\u0027s scope.","commit_id":"b76ecae59fd4328551740afb224b33a40dd00c7f"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"c4792d46a7f40c3be616e973efb3bf24d211ac79","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This patch adds ``resource_filters`` API to retrieve"},{"line_number":10,"context_line":"configured resource filters."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"DocImpact"},{"line_number":13,"context_line":"APIImpact"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Partial: blueprint generalized-filtering-for-cinder-list-resource"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"ff0f0b1f_d77f73a9","line":12,"updated":"2017-05-17 15:38:38.000000000","message":"What other documentation is needed for this?","commit_id":"7fdc4688fea373afb85d929e649d311568d1855a"}],"cinder/api/v3/resource_filters.py":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"d0e843e2230fb4d744d53b02287e2bdf638ecb9f","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"\"\"\"The allowed filters api.\"\"\""},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from oslo_log import log as logging"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from cinder.api import common"},{"line_number":18,"context_line":"from cinder.api.openstack import wsgi"}],"source_content_type":"text/x-python","patch_set":8,"id":"ff0f0b1f_9f542923","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":35},"updated":"2017-05-19 15:04:34.000000000","message":"Not used","commit_id":"3464ba089a190c0e44268d318aab42a0e581ba1c"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"d0e843e2230fb4d744d53b02287e2bdf638ecb9f","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from cinder.api.v3.views import resource_filters as filter_views"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":23,"context_line":"FILTER_API_VERSION \u003d \u00273.32\u0027"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"ff0f0b1f_bf592d5b","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":33},"updated":"2017-05-19 15:04:34.000000000","message":"We are setting up logging but it isn\u0027t used.  So, I think this can be removed.","commit_id":"3464ba089a190c0e44268d318aab42a0e581ba1c"}],"cinder/api/v3/views/filters.py":[{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"c018059553e7a4f27012458f08b4628548f2a53e","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    _collection_name \u003d \"filters\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    @classmethod"},{"line_number":20,"context_line":"    def detail(cls, fil):"},{"line_number":21,"context_line":"        \"\"\"Detailed view of an filter.\"\"\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"        return {"}],"source_content_type":"text/x-python","patch_set":5,"id":"1f013ff3_7969b0bc","line":20,"updated":"2017-05-15 09:12:45.000000000","message":"@wangxiyuan, take a look at line 42.","commit_id":"b76ecae59fd4328551740afb224b33a40dd00c7f"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"df2c5d6261387940abc64cee7b6826a446c69d51","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    _collection_name \u003d \"filters\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    @classmethod"},{"line_number":20,"context_line":"    def detail(cls, fil):"},{"line_number":21,"context_line":"        \"\"\"Detailed view of an filter.\"\"\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"        return {"}],"source_content_type":"text/x-python","patch_set":5,"id":"1f013ff3_5624830d","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":25},"updated":"2017-05-15 09:00:42.000000000","message":"I can\u0027t find any place to call this function.","commit_id":"b76ecae59fd4328551740afb224b33a40dd00c7f"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"25af97668ff401f1793b2e4dbc4ca2aecf5f4368","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    _collection_name \u003d \"filters\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    @classmethod"},{"line_number":20,"context_line":"    def detail(cls, fil):"},{"line_number":21,"context_line":"        \"\"\"Detailed view of an filter.\"\"\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"        return {"}],"source_content_type":"text/x-python","patch_set":5,"id":"1f013ff3_ef629216","line":20,"in_reply_to":"1f013ff3_7969b0bc","updated":"2017-05-15 10:49:50.000000000","message":"Oh,yes. Another question: So do we need a detail list API as well? If not this method seems should be redundant","commit_id":"b76ecae59fd4328551740afb224b33a40dd00c7f"}]}