)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"5c61a6db745979124b0aeb84e8b8038cdf58a9d8","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Chhavi Agarwal \u003cchhagarw@in.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-05-22 04:47:13 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Support iSCSI host when Fc volume is there"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This code updates the storwize driver to ignore the FC host if an iSCSI"},{"line_number":10,"context_line":"connection is being requested."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"ff0f0b1f_99865713","line":7,"updated":"2017-05-22 14:16:19.000000000","message":"Please prepend \"Storwize:\" or something like that to make it clear this isn\u0027t a Cinder-wide thing.\n\ns/Fc/FC/","commit_id":"515077ea5d0d70e0f992b0f4a66bdfd78a3dee4f"}],"cinder/brick/local_dev/lvm.py":[{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"53a096c3c53081bd8129a078b7b682599fa561a4","unresolved":false,"context_lines":[{"line_number":639,"context_line":"        # order to prevent a race condition."},{"line_number":640,"context_line":"        self._wait_for_volume_deactivation(name)"},{"line_number":641,"context_line":""},{"line_number":642,"context_line":"    @utils.retry(exceptions\u003dexception.VolumeNotDeactivated, retries\u003d7,"},{"line_number":643,"context_line":"                 backoff_rate\u003d2)"},{"line_number":644,"context_line":"    def _wait_for_volume_deactivation(self, name):"},{"line_number":645,"context_line":"        LOG.debug(\"Checking to see if volume %s has been deactivated.\","}],"source_content_type":"text/x-python","patch_set":7,"id":"3f044301_f44fe0ba","line":642,"updated":"2017-05-05 14:54:53.000000000","message":"why are we changing something in the LVM code to fix an issue with the storwize driver?","commit_id":"e5ff1d59794e3de7a1e798161691faa29464e16b"},{"author":{"_account_id":14532,"name":"Gerald McBrearty","email":"gfm@us.ibm.com","username":"gfm"},"change_message_id":"ce85cd0ac292b09fb42fea1d9c2d0f6e02381e38","unresolved":false,"context_lines":[{"line_number":639,"context_line":"        # order to prevent a race condition."},{"line_number":640,"context_line":"        self._wait_for_volume_deactivation(name)"},{"line_number":641,"context_line":""},{"line_number":642,"context_line":"    @utils.retry(exceptions\u003dexception.VolumeNotDeactivated, retries\u003d7,"},{"line_number":643,"context_line":"                 backoff_rate\u003d2)"},{"line_number":644,"context_line":"    def _wait_for_volume_deactivation(self, name):"},{"line_number":645,"context_line":"        LOG.debug(\"Checking to see if volume %s has been deactivated.\","}],"source_content_type":"text/x-python","patch_set":7,"id":"3f044301_80a84bdb","line":642,"in_reply_to":"3f044301_29ff2d35","updated":"2017-05-06 13:15:56.000000000","message":"I think we would want to go back and comment in 1687044 that 5 retries is still failing and that we either need to increase the retries/backoff_rate again.\n\nShould we be making these config properties?","commit_id":"e5ff1d59794e3de7a1e798161691faa29464e16b"},{"author":{"_account_id":14806,"name":"Chhavi Agarwal","email":"chhagarw@in.ibm.com","username":"chhagarw"},"change_message_id":"1a7be6dd1b0c9a17a8781c30e75687a57c863668","unresolved":false,"context_lines":[{"line_number":639,"context_line":"        # order to prevent a race condition."},{"line_number":640,"context_line":"        self._wait_for_volume_deactivation(name)"},{"line_number":641,"context_line":""},{"line_number":642,"context_line":"    @utils.retry(exceptions\u003dexception.VolumeNotDeactivated, retries\u003d7,"},{"line_number":643,"context_line":"                 backoff_rate\u003d2)"},{"line_number":644,"context_line":"    def _wait_for_volume_deactivation(self, name):"},{"line_number":645,"context_line":"        LOG.debug(\"Checking to see if volume %s has been deactivated.\","}],"source_content_type":"text/x-python","patch_set":7,"id":"3f044301_2d15cf9c","line":642,"in_reply_to":"3f044301_80a84bdb","updated":"2017-05-09 08:36:11.000000000","message":"yeah that make sense, removed from here and updated the bug.","commit_id":"e5ff1d59794e3de7a1e798161691faa29464e16b"},{"author":{"_account_id":14806,"name":"Chhavi Agarwal","email":"chhagarw@in.ibm.com","username":"chhagarw"},"change_message_id":"27d233e02e2cb2c571635e27f650d57e88534e2a","unresolved":false,"context_lines":[{"line_number":639,"context_line":"        # order to prevent a race condition."},{"line_number":640,"context_line":"        self._wait_for_volume_deactivation(name)"},{"line_number":641,"context_line":""},{"line_number":642,"context_line":"    @utils.retry(exceptions\u003dexception.VolumeNotDeactivated, retries\u003d7,"},{"line_number":643,"context_line":"                 backoff_rate\u003d2)"},{"line_number":644,"context_line":"    def _wait_for_volume_deactivation(self, name):"},{"line_number":645,"context_line":"        LOG.debug(\"Checking to see if volume %s has been deactivated.\","}],"source_content_type":"text/x-python","patch_set":7,"id":"3f044301_29ff2d35","line":642,"in_reply_to":"3f044301_f44fe0ba","updated":"2017-05-05 19:21:48.000000000","message":"this change is not related to the iscsi, i made this change to fix the jenkins build issue for timeout failure\nhttp://status.openstack.org/elastic-recheck/gate.html#1687044","commit_id":"e5ff1d59794e3de7a1e798161691faa29464e16b"}],"cinder/tests/unit/volume/drivers/ibm/test_storwize_svc.py":[{"author":{"_account_id":17045,"name":"xiaoqin","email":"xiaoqin.li@hotmail.com","username":"xiaoqin"},"change_message_id":"3692a4398e44c1e464fae1c8a30f70992a1a0138","unresolved":false,"context_lines":[{"line_number":2830,"context_line":""},{"line_number":2831,"context_line":"    def test_storwize_get_host_with_fc_connection(self):"},{"line_number":2832,"context_line":"        # Create a FC host"},{"line_number":2833,"context_line":"        initiator \u003d self._connector[\u0027initiator\u0027]"},{"line_number":2834,"context_line":"        del self._connector[\u0027initiator\u0027]"},{"line_number":2835,"context_line":"        helper \u003d self.fc_driver._helpers"},{"line_number":2836,"context_line":"        host_name \u003d helper.create_host(self._connector)"},{"line_number":2837,"context_line":"        self._connector[\u0027initiator\u0027] \u003d initiator"},{"line_number":2838,"context_line":""},{"line_number":2839,"context_line":"        # Remove the first wwpn from connector, and then try get host"},{"line_number":2840,"context_line":"        wwpns \u003d self._connector[\u0027wwpns\u0027]"}],"source_content_type":"text/x-python","patch_set":14,"id":"ff0f0b1f_f1ba7c08","line":2837,"range":{"start_line":2833,"start_character":0,"end_line":2837,"end_character":48},"updated":"2017-05-26 02:37:06.000000000","message":"What you need to do in unit test is to check that the fc host created in backend only contains fc info although the connector contains both fc and iscsi info. For the iscsi host, it only contains iscsi info although the connector contains both fc and iscsi info.","commit_id":"12e8faa5804fcf8091c0d7a059acbdde210843a4"},{"author":{"_account_id":17564,"name":"jiamin","email":"shljia@cn.ibm.com","username":"jiamin"},"change_message_id":"5b11b45c1b541e670ce7ecbb68e5e0baf92dc9f2","unresolved":false,"context_lines":[{"line_number":2867,"context_line":"            connector, volume_fc[\u0027name\u0027])"},{"line_number":2868,"context_line":"        if self.USESIM:"},{"line_number":2869,"context_line":"            self.sim.error_injection(\u0027lsfabric\u0027, \u0027no_hosts\u0027)"},{"line_number":2870,"context_line":"        self.assertIsNone(host_name)"},{"line_number":2871,"context_line":""},{"line_number":2872,"context_line":"    def test_storwize_get_host_from_connector_with_lshost_failure(self):"},{"line_number":2873,"context_line":"        self.skipTest(\u0027Bug 1640205\u0027)"}],"source_content_type":"text/x-python","patch_set":14,"id":"ff0f0b1f_517c881f","line":2870,"range":{"start_line":2870,"start_character":8,"end_line":2870,"end_character":36},"updated":"2017-05-26 02:46:14.000000000","message":"Why host_name is None now?","commit_id":"12e8faa5804fcf8091c0d7a059acbdde210843a4"},{"author":{"_account_id":14806,"name":"Chhavi Agarwal","email":"chhagarw@in.ibm.com","username":"chhagarw"},"change_message_id":"a13e5da5fbce1df320bffbe4c5c81375614c3a77","unresolved":false,"context_lines":[{"line_number":2867,"context_line":"            connector, volume_fc[\u0027name\u0027])"},{"line_number":2868,"context_line":"        if self.USESIM:"},{"line_number":2869,"context_line":"            self.sim.error_injection(\u0027lsfabric\u0027, \u0027no_hosts\u0027)"},{"line_number":2870,"context_line":"        self.assertIsNone(host_name)"},{"line_number":2871,"context_line":""},{"line_number":2872,"context_line":"    def test_storwize_get_host_from_connector_with_lshost_failure(self):"},{"line_number":2873,"context_line":"        self.skipTest(\u0027Bug 1640205\u0027)"}],"source_content_type":"text/x-python","patch_set":14,"id":"df140735_7a67b0b8","line":2870,"range":{"start_line":2870,"start_character":8,"end_line":2870,"end_character":36},"in_reply_to":"ff0f0b1f_517c881f","updated":"2017-06-05 06:34:16.000000000","message":"Problem is with the above test case, The sim.error_injection in this test case is injection lsfabric  failure due to which get_host_from_connector is returning None.\nConsidering this test it to check create fc_connection with volume, we don\u0027t need this error injections.\nI am removing it and making thing the test as assertIsNotNone.","commit_id":"12e8faa5804fcf8091c0d7a059acbdde210843a4"},{"author":{"_account_id":17564,"name":"jiamin","email":"shljia@cn.ibm.com","username":"jiamin"},"change_message_id":"5b11b45c1b541e670ce7ecbb68e5e0baf92dc9f2","unresolved":false,"context_lines":[{"line_number":3072,"context_line":"        self.assertRaises(exception.VolumeBackendAPIException,"},{"line_number":3073,"context_line":"                          self.fc_driver.initialize_connection,"},{"line_number":3074,"context_line":"                          volume_fc, connector)"},{"line_number":3075,"context_line":"        connector.pop(\u0027initiator\u0027)"},{"line_number":3076,"context_line":"        term_conn.assert_called_once_with(volume_fc, connector)"},{"line_number":3077,"context_line":""},{"line_number":3078,"context_line":"    def test_storwize_terminate_fc_connection_multi_attach(self):"}],"source_content_type":"text/x-python","patch_set":14,"id":"ff0f0b1f_f1c03c2d","line":3075,"range":{"start_line":3075,"start_character":8,"end_line":3075,"end_character":34},"updated":"2017-05-26 02:46:14.000000000","message":"I think it is better to copy the connector in the driver, so you don\u0027t need to pop the initiator here.","commit_id":"12e8faa5804fcf8091c0d7a059acbdde210843a4"}],"cinder/volume/drivers/ibm/storwize_svc/storwize_svc_common.py":[{"author":{"_account_id":14532,"name":"Gerald McBrearty","email":"gfm@us.ibm.com","username":"gfm"},"change_message_id":"8782b01bec92fec706b76130e584710d20746aea","unresolved":false,"context_lines":[{"line_number":872,"context_line":"                # unexpected error so reraise it"},{"line_number":873,"context_line":"                with excutils.save_and_reraise_exception():"},{"line_number":874,"context_line":"                    pass"},{"line_number":875,"context_line":"            if \u0027initiator\u0027 in connector:"},{"line_number":876,"context_line":"                for iscsi in resp.select(\u0027iscsi_name\u0027):"},{"line_number":877,"context_line":"                    if iscsi \u003d\u003d connector[\u0027initiator\u0027]:"},{"line_number":878,"context_line":"                        host_name \u003d name"}],"source_content_type":"text/x-python","patch_set":19,"id":"df140735_81ce8757","line":875,"updated":"2017-06-05 18:24:50.000000000","message":"You will need to check iscsi here instead of checking for the initiator in the connector.","commit_id":"cd4a55db8aca2825df9ee3c1e67abe915a59eba1"},{"author":{"_account_id":14532,"name":"Gerald McBrearty","email":"gfm@us.ibm.com","username":"gfm"},"change_message_id":"8782b01bec92fec706b76130e584710d20746aea","unresolved":false,"context_lines":[{"line_number":910,"context_line":"            raise exception.VolumeDriverException(message\u003dmsg)"},{"line_number":911,"context_line":""},{"line_number":912,"context_line":"        ports \u003d []"},{"line_number":913,"context_line":"        if \u0027initiator\u0027 in connector:"},{"line_number":914,"context_line":"            ports.append([\u0027initiator\u0027, \u0027%s\u0027 % connector[\u0027initiator\u0027]])"},{"line_number":915,"context_line":"        if \u0027wwpns\u0027 in connector:"},{"line_number":916,"context_line":"            for wwpn in connector[\u0027wwpns\u0027]:"}],"source_content_type":"text/x-python","patch_set":19,"id":"df140735_813c472f","line":913,"updated":"2017-06-05 18:24:50.000000000","message":"Here we append both the initiator and the wwpns to the ports. This is wrong we need to append either initiators or wwpns.\n\nIf iscsi:\n    if \u0027initiator\u0027 in connector:\n       ...\n    else\n       raise error no initiators ...\n\nelse:\n    if \u0027wwpns\u0027 in connector:\n       ....\n    else\n       raise error no wwpns ...","commit_id":"cd4a55db8aca2825df9ee3c1e67abe915a59eba1"},{"author":{"_account_id":14532,"name":"Gerald McBrearty","email":"gfm@us.ibm.com","username":"gfm"},"change_message_id":"8782b01bec92fec706b76130e584710d20746aea","unresolved":false,"context_lines":[{"line_number":915,"context_line":"        if \u0027wwpns\u0027 in connector:"},{"line_number":916,"context_line":"            for wwpn in connector[\u0027wwpns\u0027]:"},{"line_number":917,"context_line":"                ports.append([\u0027wwpn\u0027, \u0027%s\u0027 % wwpn])"},{"line_number":918,"context_line":"        if not len(ports):"},{"line_number":919,"context_line":"            msg \u003d _(\u0027create_host: No initiators or wwpns supplied.\u0027)"},{"line_number":920,"context_line":"            LOG.error(msg)"},{"line_number":921,"context_line":"            raise exception.VolumeDriverException(message\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":19,"id":"df140735_0152773b","line":918,"updated":"2017-06-05 18:24:50.000000000","message":"I make a specific error message for each protocol.","commit_id":"cd4a55db8aca2825df9ee3c1e67abe915a59eba1"},{"author":{"_account_id":14532,"name":"Gerald McBrearty","email":"gfm@us.ibm.com","username":"gfm"},"change_message_id":"b784449a71c16610d98b01cec7516bc501b11324","unresolved":false,"context_lines":[{"line_number":878,"context_line":"                        host_name \u003d name"},{"line_number":879,"context_line":"                        found \u003d True"},{"line_number":880,"context_line":"                        break"},{"line_number":881,"context_line":"            elif \u0027wwpns\u0027 in connector and len(connector[\u0027wwpns\u0027]):"},{"line_number":882,"context_line":"                connector_wwpns \u003d [str(x).lower() for x in connector[\u0027wwpns\u0027]]"},{"line_number":883,"context_line":"                for wwpn in resp.select(\u0027WWPN\u0027):"},{"line_number":884,"context_line":"                    if wwpn and wwpn.lower() in connector_wwpns:"}],"source_content_type":"text/x-python","patch_set":20,"id":"7f231b9d_11d6f4c6","line":881,"updated":"2017-06-12 15:14:26.000000000","message":"Looks like there is still a problem if this is an iscsi driver but no initiator was passed but wwpns are. Shouldn\u0027t use the wwpns for iscsi driver.\n\nLike the other change below\n\nif iscsi:\n     if \u0027initiator\u0027 in connector:\n        ...\nelse:\n     if \u0027wwpns\u0027 in connector ....\n        ....","commit_id":"c349dcbbb699b85cad2e5f6c2a4e34c8f4ad3fb0"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"afc966e9b5dea324757d8b9cb0818747143799bb","unresolved":false,"context_lines":[{"line_number":914,"context_line":"            if \u0027initiator\u0027 in connector:"},{"line_number":915,"context_line":"                ports.append([\u0027initiator\u0027, \u0027%s\u0027 % connector[\u0027initiator\u0027]])"},{"line_number":916,"context_line":"            else:"},{"line_number":917,"context_line":"                msg \u003d _(\u0027create_host: No initiators  supplied.\u0027)"},{"line_number":918,"context_line":"        else:"},{"line_number":919,"context_line":"            if \u0027wwpns\u0027 in connector:"},{"line_number":920,"context_line":"                for wwpn in connector[\u0027wwpns\u0027]:"}],"source_content_type":"text/x-python","patch_set":20,"id":"7f231b9d_5d77f33b","line":917,"range":{"start_line":917,"start_character":52,"end_line":917,"end_character":53},"updated":"2017-06-12 07:35:00.000000000","message":"redundant space","commit_id":"c349dcbbb699b85cad2e5f6c2a4e34c8f4ad3fb0"}],"cinder/volume/drivers/ibm/storwize_svc/storwize_svc_fc.py":[{"author":{"_account_id":14532,"name":"Gerald McBrearty","email":"gfm@us.ibm.com","username":"gfm"},"change_message_id":"9f566abc3aef05a774114687b510f0c69d6d0475","unresolved":false,"context_lines":[{"line_number":138,"context_line":"        # SVC can have host entry for FC and iSCSI both. Since the current"},{"line_number":139,"context_line":"        # request is for FC, check if the connector has initiator pop it"},{"line_number":140,"context_line":"        # we don\u0027t need for FC"},{"line_number":141,"context_line":"        if \u0027initiator\u0027 in connector:"},{"line_number":142,"context_line":"            connector.pop(\u0027initiator\u0027, None)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        # Check if a host object is defined for this host name"}],"source_content_type":"text/x-python","patch_set":8,"id":"ff0f0b1f_953213a7","line":141,"updated":"2017-05-17 16:23:10.000000000","message":"nit I don\u0027t think this if is necessary","commit_id":"224a12c7dba2ed2839a88cae74bf948ae0a0e68c"},{"author":{"_account_id":14532,"name":"Gerald McBrearty","email":"gfm@us.ibm.com","username":"gfm"},"change_message_id":"5aa99c667e9c7327dc1262842604058d1d349151","unresolved":false,"context_lines":[{"line_number":138,"context_line":"        # SVC can have host entry for FC and iSCSI both. Since the current"},{"line_number":139,"context_line":"        # request is for FC, check if the connector has initiator pop it"},{"line_number":140,"context_line":"        # we don\u0027t need for FC"},{"line_number":141,"context_line":"        f_connector \u003d connector.copy()"},{"line_number":142,"context_line":"        f_connector.pop(\u0027initiator\u0027, None)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        # Check if a host object is defined for this host name"}],"source_content_type":"text/x-python","patch_set":15,"id":"df140735_4a281fe1","line":141,"updated":"2017-05-31 02:47:03.000000000","message":"Is there a reason you didn\u0027t use connector here?\n\nconnector \u003d connector.copy()\nconnector.pop(\u0027initiator\u0027, None)","commit_id":"02c483769d6001ca0eabbef9dc5982bf48b17993"},{"author":{"_account_id":14806,"name":"Chhavi Agarwal","email":"chhagarw@in.ibm.com","username":"chhagarw"},"change_message_id":"cf3d0dac87a5eb6e4fb180677c486c19d6004c4c","unresolved":false,"context_lines":[{"line_number":138,"context_line":"        # SVC can have host entry for FC and iSCSI both. Since the current"},{"line_number":139,"context_line":"        # request is for FC, check if the connector has initiator pop it"},{"line_number":140,"context_line":"        # we don\u0027t need for FC"},{"line_number":141,"context_line":"        f_connector \u003d connector.copy()"},{"line_number":142,"context_line":"        f_connector.pop(\u0027initiator\u0027, None)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        # Check if a host object is defined for this host name"}],"source_content_type":"text/x-python","patch_set":15,"id":"df140735_fa9e73b6","line":141,"in_reply_to":"df140735_4a281fe1","updated":"2017-06-01 12:42:06.000000000","message":"Because if the initialize connection fails during rollback terminate code i need to pass the original connector.\nusing same name confuses.","commit_id":"02c483769d6001ca0eabbef9dc5982bf48b17993"},{"author":{"_account_id":14532,"name":"Gerald McBrearty","email":"gfm@us.ibm.com","username":"gfm"},"change_message_id":"bbbdcd92e7149e45f1bf303a2e99755b1617bfed","unresolved":false,"context_lines":[{"line_number":138,"context_line":"        # SVC can have host entry for FC and iSCSI both. Since the current"},{"line_number":139,"context_line":"        # request is for FC, check if the connector has initiator pop it"},{"line_number":140,"context_line":"        # we don\u0027t need for FC"},{"line_number":141,"context_line":"        f_connector \u003d connector.copy()"},{"line_number":142,"context_line":"        f_connector.pop(\u0027initiator\u0027, None)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        # Check if a host object is defined for this host name"}],"source_content_type":"text/x-python","patch_set":15,"id":"df140735_29001dab","line":141,"in_reply_to":"df140735_f4668729","updated":"2017-06-01 17:49:56.000000000","message":"Ok I understand that your keeping the original connector to pass the UT","commit_id":"02c483769d6001ca0eabbef9dc5982bf48b17993"},{"author":{"_account_id":14532,"name":"Gerald McBrearty","email":"gfm@us.ibm.com","username":"gfm"},"change_message_id":"a5592c5d7dfe0aca9419f80f57a72bb3ed2d7c04","unresolved":false,"context_lines":[{"line_number":138,"context_line":"        # SVC can have host entry for FC and iSCSI both. Since the current"},{"line_number":139,"context_line":"        # request is for FC, check if the connector has initiator pop it"},{"line_number":140,"context_line":"        # we don\u0027t need for FC"},{"line_number":141,"context_line":"        f_connector \u003d connector.copy()"},{"line_number":142,"context_line":"        f_connector.pop(\u0027initiator\u0027, None)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        # Check if a host object is defined for this host name"}],"source_content_type":"text/x-python","patch_set":15,"id":"df140735_f4668729","line":141,"in_reply_to":"df140735_fa9e73b6","updated":"2017-06-01 14:45:27.000000000","message":"Why do you need to pass the original connector? We didn\u0027t operate on the original connector.","commit_id":"02c483769d6001ca0eabbef9dc5982bf48b17993"},{"author":{"_account_id":14532,"name":"Gerald McBrearty","email":"gfm@us.ibm.com","username":"gfm"},"change_message_id":"5aa99c667e9c7327dc1262842604058d1d349151","unresolved":false,"context_lines":[{"line_number":145,"context_line":"        host_name \u003d self._helpers.get_host_from_connector(f_connector)"},{"line_number":146,"context_line":"        if host_name is None:"},{"line_number":147,"context_line":"            # Host does not exist - add a new host to Storwize/SVC"},{"line_number":148,"context_line":"            host_name \u003d self._helpers.create_host(connector)"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        volume_attributes \u003d self._helpers.get_vdisk_attributes(volume_name)"},{"line_number":151,"context_line":"        if volume_attributes is None:"}],"source_content_type":"text/x-python","patch_set":15,"id":"df140735_2a684b1f","line":148,"updated":"2017-05-31 02:47:03.000000000","message":"your passing connector here which can have both initiator and wwnps. I\u0027m not sure which would be used to create the host.","commit_id":"02c483769d6001ca0eabbef9dc5982bf48b17993"},{"author":{"_account_id":14806,"name":"Chhavi Agarwal","email":"chhagarw@in.ibm.com","username":"chhagarw"},"change_message_id":"cf3d0dac87a5eb6e4fb180677c486c19d6004c4c","unresolved":false,"context_lines":[{"line_number":145,"context_line":"        host_name \u003d self._helpers.get_host_from_connector(f_connector)"},{"line_number":146,"context_line":"        if host_name is None:"},{"line_number":147,"context_line":"            # Host does not exist - add a new host to Storwize/SVC"},{"line_number":148,"context_line":"            host_name \u003d self._helpers.create_host(connector)"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        volume_attributes \u003d self._helpers.get_vdisk_attributes(volume_name)"},{"line_number":151,"context_line":"        if volume_attributes is None:"}],"source_content_type":"text/x-python","patch_set":15,"id":"df140735_9a9897c0","line":148,"in_reply_to":"df140735_2a684b1f","updated":"2017-06-01 12:42:06.000000000","message":"Line 145 get_host_from_connector uses the poped initiator connector to get the existing host,\nBut yeah you are right we need to pass the f_connector to create_host as well.","commit_id":"02c483769d6001ca0eabbef9dc5982bf48b17993"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"ee7658caed33255969800dfb95842f70457f15e3","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        # request is for FC, check if the connector has initiator pop it"},{"line_number":140,"context_line":"        # we don\u0027t need for FC"},{"line_number":141,"context_line":"        f_connector \u003d connector.copy()"},{"line_number":142,"context_line":"        f_connector.pop(\u0027initiator\u0027, None)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        # Check if a host object is defined for this host name"},{"line_number":145,"context_line":"        host_name \u003d self._helpers.get_host_from_connector(f_connector)"}],"source_content_type":"text/x-python","patch_set":17,"id":"df140735_4e01c137","line":142,"updated":"2017-06-05 15:15:21.000000000","message":"I don\u0027t think it\u0027s a good idea to modify the connector coming back from os-brick.   It\u0027s far cleaner and safer to update the get_host_from_connector and tell it, this is for an FC or iSCSI connection.","commit_id":"bc1a60cfb61b6467f99d1eba3e9bc2abb6a4b63a"},{"author":{"_account_id":14806,"name":"Chhavi Agarwal","email":"chhagarw@in.ibm.com","username":"chhagarw"},"change_message_id":"1cc06d4877dc47f00e252fcf0214b99ea707365b","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        # request is for FC, check if the connector has initiator pop it"},{"line_number":140,"context_line":"        # we don\u0027t need for FC"},{"line_number":141,"context_line":"        f_connector \u003d connector.copy()"},{"line_number":142,"context_line":"        f_connector.pop(\u0027initiator\u0027, None)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        # Check if a host object is defined for this host name"},{"line_number":145,"context_line":"        host_name \u003d self._helpers.get_host_from_connector(f_connector)"}],"source_content_type":"text/x-python","patch_set":17,"id":"df140735_e80d28e8","line":142,"in_reply_to":"df140735_4e01c137","updated":"2017-06-05 16:25:39.000000000","message":"Using the copy approach, we are not modifying or updating the connector which is coming from os-brick.\nSince this the volume driver specific code, like here we know that we need an FC host, so we are checking the connector and passing it to the get_host_from_connector() to return the appropriate host.\nI understand that modifying get_host_from_connector() to pass protocol is also can be one of the approach, but handling the protocol in the protocol specific code, like FC/iSCSI driver, is also good. This keeps the common code independent of protocol, which can be easily used if we need to handle the code where we have both cases as well.","commit_id":"bc1a60cfb61b6467f99d1eba3e9bc2abb6a4b63a"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"b55c7a7eb17aebd350bdadd846b088360fc7b017","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        # request is for FC, check if the connector has initiator pop it"},{"line_number":140,"context_line":"        # we don\u0027t need for FC"},{"line_number":141,"context_line":"        f_connector \u003d connector.copy()"},{"line_number":142,"context_line":"        f_connector.pop(\u0027initiator\u0027, None)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        # Check if a host object is defined for this host name"},{"line_number":145,"context_line":"        host_name \u003d self._helpers.get_host_from_connector(f_connector)"}],"source_content_type":"text/x-python","patch_set":17,"id":"df140735_ab760a6f","line":142,"in_reply_to":"df140735_e80d28e8","updated":"2017-06-05 16:56:58.000000000","message":"I still don\u0027t agree with this approach.","commit_id":"bc1a60cfb61b6467f99d1eba3e9bc2abb6a4b63a"}],"cinder/volume/drivers/ibm/storwize_svc/storwize_svc_iscsi.py":[{"author":{"_account_id":14532,"name":"Gerald McBrearty","email":"gfm@us.ibm.com","username":"gfm"},"change_message_id":"6342186f1033aa3f69e93ef0cbe944ddf0322cfd","unresolved":false,"context_lines":[{"line_number":134,"context_line":"        volume_name \u003d self._get_target_vol(volume)"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"        # Check if a host object is defined for this host name"},{"line_number":137,"context_line":"        host_name \u003d self._helpers.get_host_from_connector(connector,"},{"line_number":138,"context_line":"                                                          iscsi\u003dTrue)"},{"line_number":139,"context_line":"        if host_name is None:"},{"line_number":140,"context_line":"            # Host does not exist - add a new host to Storwize/SVC"}],"source_content_type":"text/x-python","patch_set":2,"id":"5ff73747_d59e3253","line":137,"updated":"2017-05-03 17:03:07.000000000","message":"I believe that you need to make a similar change in terminate_connection. Or does the same problem not exist on terminate?\n\nHaving said that ... Why don\u0027t you just remove wwpns and wwnns from the connector on initialize and terminate iscsi connection and likewise remove initiator from initialize and terminate connections on FC?","commit_id":"c458692aa22b22d3446af910ff0def7d5601f5a7"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"029177a213c8588b65c473648c1200704f2108c0","unresolved":false,"context_lines":[{"line_number":134,"context_line":"        volume_name \u003d self._get_target_vol(volume)"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"        # Check if the connector has wwpns pop it we don\u0027t need for iscsi"},{"line_number":137,"context_line":"        if \u0027wwpns\u0027 in connector:"},{"line_number":138,"context_line":"            connector.pop(\u0027wwpns\u0027)"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"        # Check if a host object is defined for this host name"},{"line_number":141,"context_line":"        host_name \u003d self._helpers.get_host_from_connector(connector)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f044301_e6550452","line":138,"range":{"start_line":137,"start_character":8,"end_line":138,"end_character":34},"updated":"2017-05-05 06:52:12.000000000","message":"connector.pop(\u0027wwpns\u0027, None) for short :D","commit_id":"5439d438179092b044bfa8fa459e62b24ae372fb"},{"author":{"_account_id":14806,"name":"Chhavi Agarwal","email":"chhagarw@in.ibm.com","username":"chhagarw"},"change_message_id":"832d70831be5276581a9fce967f5b02219788aa1","unresolved":false,"context_lines":[{"line_number":134,"context_line":"        volume_name \u003d self._get_target_vol(volume)"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"        # Check if the connector has wwpns pop it we don\u0027t need for iscsi"},{"line_number":137,"context_line":"        if \u0027wwpns\u0027 in connector:"},{"line_number":138,"context_line":"            connector.pop(\u0027wwpns\u0027)"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"        # Check if a host object is defined for this host name"},{"line_number":141,"context_line":"        host_name \u003d self._helpers.get_host_from_connector(connector)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f044301_b476f8a3","line":138,"range":{"start_line":137,"start_character":8,"end_line":138,"end_character":34},"in_reply_to":"3f044301_e6550452","updated":"2017-05-05 14:35:34.000000000","message":"thanks for reporting. will update","commit_id":"5439d438179092b044bfa8fa459e62b24ae372fb"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"53a096c3c53081bd8129a078b7b682599fa561a4","unresolved":false,"context_lines":[{"line_number":135,"context_line":""},{"line_number":136,"context_line":"        # Check if the connector has wwpns pop it we don\u0027t need for iscsi"},{"line_number":137,"context_line":"        if \u0027wwpns\u0027 in connector:"},{"line_number":138,"context_line":"            connector.pop(\u0027wwpns\u0027, None)"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"        # Check if a host object is defined for this host name"},{"line_number":141,"context_line":"        host_name \u003d self._helpers.get_host_from_connector(connector)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f044301_b495d8e6","line":138,"updated":"2017-05-05 14:54:53.000000000","message":"why does the iSCSI driver even care if it has wwpns in it or not?","commit_id":"e5ff1d59794e3de7a1e798161691faa29464e16b"},{"author":{"_account_id":14532,"name":"Gerald McBrearty","email":"gfm@us.ibm.com","username":"gfm"},"change_message_id":"ce85cd0ac292b09fb42fea1d9c2d0f6e02381e38","unresolved":false,"context_lines":[{"line_number":135,"context_line":""},{"line_number":136,"context_line":"        # Check if the connector has wwpns pop it we don\u0027t need for iscsi"},{"line_number":137,"context_line":"        if \u0027wwpns\u0027 in connector:"},{"line_number":138,"context_line":"            connector.pop(\u0027wwpns\u0027, None)"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"        # Check if a host object is defined for this host name"},{"line_number":141,"context_line":"        host_name \u003d self._helpers.get_host_from_connector(connector)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f044301_40aa43d2","line":138,"in_reply_to":"3f044301_2984cdb0","updated":"2017-05-06 13:15:56.000000000","message":"I think you would want to add to the comment that SVC has one host entry for iscsi and one for FC and this allows the common code to operate on the correct type of host. Not find the exiting FC host when looking for iscsi host.\n\nDon\u0027t you need to pop the initiators in FC driver? Can the driver find an iscsi host when we are looking for an FC host?\n\nDoesn\u0027t this change need to be made to terminate_connection? Could we find the wrong host entry on terminate also?","commit_id":"e5ff1d59794e3de7a1e798161691faa29464e16b"},{"author":{"_account_id":14806,"name":"Chhavi Agarwal","email":"chhagarw@in.ibm.com","username":"chhagarw"},"change_message_id":"1a7be6dd1b0c9a17a8781c30e75687a57c863668","unresolved":false,"context_lines":[{"line_number":135,"context_line":""},{"line_number":136,"context_line":"        # Check if the connector has wwpns pop it we don\u0027t need for iscsi"},{"line_number":137,"context_line":"        if \u0027wwpns\u0027 in connector:"},{"line_number":138,"context_line":"            connector.pop(\u0027wwpns\u0027, None)"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"        # Check if a host object is defined for this host name"},{"line_number":141,"context_line":"        host_name \u003d self._helpers.get_host_from_connector(connector)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f044301_b0d01221","line":138,"in_reply_to":"3f044301_40aa43d2","updated":"2017-05-09 08:36:11.000000000","message":"We can pop the initiators in FC driver as well, but currently it is not causing issue , because get_host_from_connector() first looks for wwpns and if found it exits.\nfor safer side it will be good to pop there as well. updating","commit_id":"e5ff1d59794e3de7a1e798161691faa29464e16b"},{"author":{"_account_id":14806,"name":"Chhavi Agarwal","email":"chhagarw@in.ibm.com","username":"chhagarw"},"change_message_id":"27d233e02e2cb2c571635e27f650d57e88534e2a","unresolved":false,"context_lines":[{"line_number":135,"context_line":""},{"line_number":136,"context_line":"        # Check if the connector has wwpns pop it we don\u0027t need for iscsi"},{"line_number":137,"context_line":"        if \u0027wwpns\u0027 in connector:"},{"line_number":138,"context_line":"            connector.pop(\u0027wwpns\u0027, None)"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"        # Check if a host object is defined for this host name"},{"line_number":141,"context_line":"        host_name \u003d self._helpers.get_host_from_connector(connector)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f044301_2984cdb0","line":138,"in_reply_to":"3f044301_b495d8e6","updated":"2017-05-05 19:21:48.000000000","message":"this is required because, underlying common get_host_from_connector() first does the host lookup with respect to wwpns, and if the host is discovered it returns.\nso in this case if the connector is having wwpns as well iscsi, we need to specifically pass the connector of iscsi host lookup.","commit_id":"e5ff1d59794e3de7a1e798161691faa29464e16b"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"a1a3808419febb381a7373957610cd58eeda3a63","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        # request is for iSCSI, check if the connector has wwpns pop it"},{"line_number":138,"context_line":"        # we don\u0027t need for iscsi"},{"line_number":139,"context_line":"        if \u0027wwpns\u0027 in connector:"},{"line_number":140,"context_line":"            connector.pop(\u0027wwpns\u0027, None)"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"        # Check if a host object is defined for this host name"},{"line_number":143,"context_line":"        host_name \u003d self._helpers.get_host_from_connector(connector)"}],"source_content_type":"text/x-python","patch_set":8,"id":"ff0f0b1f_e47523fc","line":140,"updated":"2017-05-17 15:07:50.000000000","message":"why not just update the signature for get_host_from_connector() and add a protocol type?   Then you can simply ignore wwpns for iSCSI and iqn for FC, and then stop modifying the connector object.","commit_id":"224a12c7dba2ed2839a88cae74bf948ae0a0e68c"},{"author":{"_account_id":14806,"name":"Chhavi Agarwal","email":"chhagarw@in.ibm.com","username":"chhagarw"},"change_message_id":"332bbf73e57facd2a04c4fbdc4d4b90e49e048b7","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        # request is for iSCSI, check if the connector has wwpns pop it"},{"line_number":138,"context_line":"        # we don\u0027t need for iscsi"},{"line_number":139,"context_line":"        if \u0027wwpns\u0027 in connector:"},{"line_number":140,"context_line":"            connector.pop(\u0027wwpns\u0027, None)"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"        # Check if a host object is defined for this host name"},{"line_number":143,"context_line":"        host_name \u003d self._helpers.get_host_from_connector(connector)"}],"source_content_type":"text/x-python","patch_set":8,"id":"ff0f0b1f_ec1d9a73","line":140,"in_reply_to":"ff0f0b1f_e47523fc","updated":"2017-05-22 08:45:30.000000000","message":"Earlier in patch-set 1, we thought of adding a protocol to get_host_from_connector(). But since its a common method, it makes more sense to handle in the SVC iscsi/fc layer, send the update and send connector to locate the host.\nLet us know your thoughts on the same.","commit_id":"224a12c7dba2ed2839a88cae74bf948ae0a0e68c"},{"author":{"_account_id":14532,"name":"Gerald McBrearty","email":"gfm@us.ibm.com","username":"gfm"},"change_message_id":"9f566abc3aef05a774114687b510f0c69d6d0475","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        # request is for iSCSI, check if the connector has wwpns pop it"},{"line_number":138,"context_line":"        # we don\u0027t need for iscsi"},{"line_number":139,"context_line":"        if \u0027wwpns\u0027 in connector:"},{"line_number":140,"context_line":"            connector.pop(\u0027wwpns\u0027, None)"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"        # Check if a host object is defined for this host name"},{"line_number":143,"context_line":"        host_name \u003d self._helpers.get_host_from_connector(connector)"}],"source_content_type":"text/x-python","patch_set":8,"id":"ff0f0b1f_75cbffa4","line":140,"in_reply_to":"ff0f0b1f_e47523fc","updated":"2017-05-17 16:23:10.000000000","message":"fc terminate_connection does a pop of \u0027initiator\u0027 as part of its processing to handle this case for terminate. So this looks like its following what the driver had already started doing. \n\npassing in protocol would need to ripple to a few more methods that are currently looking for both \u0027wwpns\u0027 and \u0027initiator\u0027, would it be better make those changes or pop wwpns or initiators? \n\nnit: I think the \"if\" here is not necessary.","commit_id":"224a12c7dba2ed2839a88cae74bf948ae0a0e68c"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"998fdbcbba28a26470840505d48545739056d474","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        # request is for iSCSI, check if the connector has wwpns pop it"},{"line_number":138,"context_line":"        # we don\u0027t need for iscsi"},{"line_number":139,"context_line":"        if \u0027wwpns\u0027 in connector:"},{"line_number":140,"context_line":"            connector.pop(\u0027wwpns\u0027, None)"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"        # Check if a host object is defined for this host name"},{"line_number":143,"context_line":"        host_name \u003d self._helpers.get_host_from_connector(connector)"}],"source_content_type":"text/x-python","patch_set":8,"id":"ff0f0b1f_1b3914a3","line":140,"in_reply_to":"ff0f0b1f_ec1d9a73","updated":"2017-05-22 17:43:17.000000000","message":"It\u0027s safer to not modify data coming in from brick and/or volume manager for future proofing your code.   making choices in a common function based upon protocol is cleaner.","commit_id":"224a12c7dba2ed2839a88cae74bf948ae0a0e68c"},{"author":{"_account_id":14532,"name":"Gerald McBrearty","email":"gfm@us.ibm.com","username":"gfm"},"change_message_id":"9f566abc3aef05a774114687b510f0c69d6d0475","unresolved":false,"context_lines":[{"line_number":342,"context_line":"            # SVC can have host entry for FC and iSCSI both. Since the current"},{"line_number":343,"context_line":"            # request is for iSCSI, check if the connector has wwpns pop it"},{"line_number":344,"context_line":"            # we don\u0027t need for iscsi"},{"line_number":345,"context_line":"            if \u0027wwpns\u0027 in connector:"},{"line_number":346,"context_line":"                connector.pop(\u0027wwpns\u0027, None)"},{"line_number":347,"context_line":"            host_name \u003d self._helpers.get_host_from_connector(connector)"},{"line_number":348,"context_line":"            if host_name is None:"}],"source_content_type":"text/x-python","patch_set":8,"id":"ff0f0b1f_15704372","line":345,"updated":"2017-05-17 16:23:10.000000000","message":"nit i don\u0027t think the if is necessary","commit_id":"224a12c7dba2ed2839a88cae74bf948ae0a0e68c"},{"author":{"_account_id":17045,"name":"xiaoqin","email":"xiaoqin.li@hotmail.com","username":"xiaoqin"},"change_message_id":"069c06da6bbaa35d5c1fb460a05c5a84bae6d21f","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        # SVC can have host entry for FC and iSCSI both. Since the current"},{"line_number":137,"context_line":"        # request is for iSCSI, check if the connector has wwpns pop it"},{"line_number":138,"context_line":"        # we don\u0027t need for iscsi"},{"line_number":139,"context_line":"        connector.pop(\u0027wwpns\u0027, None)"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        # Check if a host object is defined for this host name"},{"line_number":142,"context_line":"        host_name \u003d self._helpers.get_host_from_connector(connector)"}],"source_content_type":"text/x-python","patch_set":10,"id":"ff0f0b1f_69c92357","line":139,"range":{"start_line":139,"start_character":6,"end_line":139,"end_character":36},"updated":"2017-05-24 12:06:03.000000000","message":"It\u0027s not a good way to not modify data coming in from brick and/or volume manager directly. Maybe you can use a temporary variable\nconnector \u003d connector.copy()\nconnector.pop(\u0027initiator\u0027, None)","commit_id":"60973423385d404cb550a850707937c494269315"},{"author":{"_account_id":14806,"name":"Chhavi Agarwal","email":"chhagarw@in.ibm.com","username":"chhagarw"},"change_message_id":"2a5be5ac203e87dea05844c918c1748034ceaa53","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        # SVC can have host entry for FC and iSCSI both. Since the current"},{"line_number":137,"context_line":"        # request is for iSCSI, check if the connector has wwpns pop it"},{"line_number":138,"context_line":"        # we don\u0027t need for iscsi"},{"line_number":139,"context_line":"        connector.pop(\u0027wwpns\u0027, None)"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        # Check if a host object is defined for this host name"},{"line_number":142,"context_line":"        host_name \u003d self._helpers.get_host_from_connector(connector)"}],"source_content_type":"text/x-python","patch_set":10,"id":"ff0f0b1f_d6b6838a","line":139,"range":{"start_line":139,"start_character":6,"end_line":139,"end_character":36},"in_reply_to":"ff0f0b1f_69c92357","updated":"2017-05-24 17:28:59.000000000","message":"Done","commit_id":"60973423385d404cb550a850707937c494269315"},{"author":{"_account_id":14532,"name":"Gerald McBrearty","email":"gfm@us.ibm.com","username":"gfm"},"change_message_id":"5aa99c667e9c7327dc1262842604058d1d349151","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        # SVC can have host entry for FC and iSCSI both. Since the current"},{"line_number":137,"context_line":"        # request is for iSCSI, check if the connector has wwpns pop it"},{"line_number":138,"context_line":"        # we don\u0027t need for iscsi"},{"line_number":139,"context_line":"        conn_iscsi \u003d connector.copy()"},{"line_number":140,"context_line":"        conn_iscsi.pop(\u0027wwpns\u0027, None)"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"        # Check if a host object is defined for this host name"}],"source_content_type":"text/x-python","patch_set":15,"id":"df140735_aae0dbcd","line":139,"updated":"2017-05-31 02:47:03.000000000","message":"Is there reason you added conn_iscsi instead of connector?\nie\nconnector \u003d connector.copy()\nconnector.pop(\u0027wwpns\u0027, None)","commit_id":"02c483769d6001ca0eabbef9dc5982bf48b17993"},{"author":{"_account_id":14532,"name":"Gerald McBrearty","email":"gfm@us.ibm.com","username":"gfm"},"change_message_id":"5aa99c667e9c7327dc1262842604058d1d349151","unresolved":false,"context_lines":[{"line_number":143,"context_line":"        host_name \u003d self._helpers.get_host_from_connector(conn_iscsi)"},{"line_number":144,"context_line":"        if host_name is None:"},{"line_number":145,"context_line":"            # Host does not exist - add a new host to Storwize/SVC"},{"line_number":146,"context_line":"            host_name \u003d self._helpers.create_host(connector)"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        chap_secret \u003d self._helpers.get_chap_secret_for_host(host_name)"},{"line_number":149,"context_line":"        chap_enabled \u003d self.configuration.storwize_svc_iscsi_chap_enabled"}],"source_content_type":"text/x-python","patch_set":15,"id":"df140735_aa8d7b32","line":146,"updated":"2017-05-31 02:47:03.000000000","message":"your passing connector which may have both initiator and wwpns\n\nI think you need tobe passing conn_iscsi.","commit_id":"02c483769d6001ca0eabbef9dc5982bf48b17993"},{"author":{"_account_id":14532,"name":"Gerald McBrearty","email":"gfm@us.ibm.com","username":"gfm"},"change_message_id":"8782b01bec92fec706b76130e584710d20746aea","unresolved":false,"context_lines":[{"line_number":138,"context_line":"                                                          iscsi\u003dTrue)"},{"line_number":139,"context_line":"        if host_name is None:"},{"line_number":140,"context_line":"            # Host does not exist - add a new host to Storwize/SVC"},{"line_number":141,"context_line":"            host_name \u003d self._helpers.create_host(connector)"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"        chap_secret \u003d self._helpers.get_chap_secret_for_host(host_name)"},{"line_number":144,"context_line":"        chap_enabled \u003d self.configuration.storwize_svc_iscsi_chap_enabled"}],"source_content_type":"text/x-python","patch_set":19,"id":"df140735_c1d23fd1","line":141,"updated":"2017-06-05 18:24:50.000000000","message":"you need to pass iscsi\u003dtrue here also","commit_id":"cd4a55db8aca2825df9ee3c1e67abe915a59eba1"}]}