)]}'
{"cinder/volume/drivers/dell_emc/vnx/adapter.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"ac42066d1b6988881311aaae228b029acfedddef","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        group_name \u003d ("},{"line_number":101,"context_line":"            self.config.config_group if self.config.config_group"},{"line_number":102,"context_line":"            else \u0027DEFAULT\u0027)"},{"line_number":103,"context_line":"        self.queue_path \u003d os.path.join(CONF.state_path, \u0027vnx\u0027, group_name)"},{"line_number":104,"context_line":"        # Check option `naviseccli_path`."},{"line_number":105,"context_line":"        # Set to None (then pass to storops) if it is not set or set to an"},{"line_number":106,"context_line":"        # empty string."}],"source_content_type":"text/x-python","patch_set":1,"id":"1f013ff3_5a2ea7fa","line":103,"range":{"start_line":103,"start_character":39,"end_line":103,"end_character":54},"updated":"2017-05-17 03:57:27.000000000","message":"Please read configuration from self.configuration instead of from the global CONF.  Driver should be reading from the backend section.  See this patch: https://review.openstack.org/#/c/453617/","commit_id":"79bf9310ffdc8b43fa015a620af8d35bad12a546"},{"author":{"_account_id":10628,"name":"Peter Wang","email":"peter.wang13@emc.com","username":"peter_wang"},"change_message_id":"61566b5b7b3e52608beb6727e7a56b2aa0a20954","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        group_name \u003d ("},{"line_number":101,"context_line":"            self.config.config_group if self.config.config_group"},{"line_number":102,"context_line":"            else \u0027DEFAULT\u0027)"},{"line_number":103,"context_line":"        self.queue_path \u003d os.path.join(CONF.state_path, \u0027vnx\u0027, group_name)"},{"line_number":104,"context_line":"        # Check option `naviseccli_path`."},{"line_number":105,"context_line":"        # Set to None (then pass to storops) if it is not set or set to an"},{"line_number":106,"context_line":"        # empty string."}],"source_content_type":"text/x-python","patch_set":1,"id":"1f013ff3_6422e9a6","line":103,"range":{"start_line":103,"start_character":39,"end_line":103,"end_character":54},"in_reply_to":"1f013ff3_5a2ea7fa","updated":"2017-05-17 05:24:59.000000000","message":"Hi Xing\nThe state_path cannot be read from self.configuration until driver invokes        self.configuration.append_config_values(cinder.common.config.core_opts)\n\nUsing above will cause that each backend has an option state_path need to be configured, and the path must be writable.\n\nI don\u0027t want add this kind of extra option which largely harden the deployment of VNX driver.\n\nsince the state_path is already correctly configured (write permission) after installation of cinder, we can safely use it to maintain driver state here.\n\nAny idea?\n\nThanks\nPeter","commit_id":"79bf9310ffdc8b43fa015a620af8d35bad12a546"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"3ed681d232acbd37977fa389965dcdfa6d8b171f","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        group_name \u003d ("},{"line_number":101,"context_line":"            self.config.config_group if self.config.config_group"},{"line_number":102,"context_line":"            else \u0027DEFAULT\u0027)"},{"line_number":103,"context_line":"        self.queue_path \u003d os.path.join(CONF.state_path, \u0027vnx\u0027, group_name)"},{"line_number":104,"context_line":"        # Check option `naviseccli_path`."},{"line_number":105,"context_line":"        # Set to None (then pass to storops) if it is not set or set to an"},{"line_number":106,"context_line":"        # empty string."}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_6ecb371e","line":103,"range":{"start_line":103,"start_character":39,"end_line":103,"end_character":54},"in_reply_to":"1f013ff3_6422e9a6","updated":"2017-05-17 13:18:14.000000000","message":"I see what you are saying.  It\u0027s fine then.  I\u0027ll remove -1.","commit_id":"79bf9310ffdc8b43fa015a620af8d35bad12a546"}]}