)]}'
{"cinder/volume/drivers/ibm/storwize_svc/replication.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"76bea5956e45c88213d5e900398eeb48a19f3d0a","unresolved":false,"context_lines":[{"line_number":251,"context_line":"        except Exception as e:"},{"line_number":252,"context_line":"            msg \u003d (_(\"Unable to set up mirror mode replication for %(vol)s. \""},{"line_number":253,"context_line":"                     \"Exception: %(err)s.\") % {\u0027vol\u0027: vref[\u0027id\u0027],"},{"line_number":254,"context_line":"                                               \u0027err\u0027: six.text_type(e)})"},{"line_number":255,"context_line":"            LOG.exception(msg)"},{"line_number":256,"context_line":"            raise exception.VolumeDriverException(message\u003dmsg)"},{"line_number":257,"context_line":"        LOG.debug(\u0027leave: volume_replication_setup:volume %s\u0027, vref[\u0027name\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff0f0b1f_bfe7bbac","line":254,"updated":"2017-05-22 14:52:07.000000000","message":"-1: Don\u0027t use six.text_type, just set `\u0027err\u0027: e})`, since _ method is already unicode and %s formatting will take care of this.","commit_id":"10047caa18883fc0307cd643c671249ca1ad5cd7"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"35ca47cd02e3c2b2b097634edd8970eda3169323","unresolved":false,"context_lines":[{"line_number":251,"context_line":"        except Exception as e:"},{"line_number":252,"context_line":"            msg \u003d (_(\"Unable to set up mirror mode replication for %(vol)s. \""},{"line_number":253,"context_line":"                     \"Exception: %(err)s.\") % {\u0027vol\u0027: vref[\u0027id\u0027],"},{"line_number":254,"context_line":"                                               \u0027err\u0027: six.text_type(e)})"},{"line_number":255,"context_line":"            LOG.exception(msg)"},{"line_number":256,"context_line":"            raise exception.VolumeDriverException(message\u003dmsg)"},{"line_number":257,"context_line":"        LOG.debug(\u0027leave: volume_replication_setup:volume %s\u0027, vref[\u0027name\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff0f0b1f_38c3b05f","line":254,"in_reply_to":"ff0f0b1f_bfe7bbac","updated":"2017-05-23 02:20:25.000000000","message":"Done","commit_id":"10047caa18883fc0307cd643c671249ca1ad5cd7"}],"cinder/volume/drivers/kaminario/kaminario_common.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"76bea5956e45c88213d5e900398eeb48a19f3d0a","unresolved":false,"context_lines":[{"line_number":218,"context_line":"                vg_rs.hits[0].delete()"},{"line_number":219,"context_line":"            LOG.exception(\"Creation of volume %s failed.\", vol_name)"},{"line_number":220,"context_line":"            raise exception.KaminarioCinderDriverException("},{"line_number":221,"context_line":"                reason\u003dsix.text_type(six.text_type(ex)))"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"        if self._get_is_replica(volume.volume_type) and self.replica:"},{"line_number":224,"context_line":"            self._create_volume_replica(volume, vg, vol, self.replica.rpo)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff0f0b1f_ff641324","line":221,"updated":"2017-05-22 14:52:07.000000000","message":"-1: Double six.text_type, when we shouldn\u0027t be even doing 1  since _ method is already unicode and %s formatting will take care of this.","commit_id":"10047caa18883fc0307cd643c671249ca1ad5cd7"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"35ca47cd02e3c2b2b097634edd8970eda3169323","unresolved":false,"context_lines":[{"line_number":218,"context_line":"                vg_rs.hits[0].delete()"},{"line_number":219,"context_line":"            LOG.exception(\"Creation of volume %s failed.\", vol_name)"},{"line_number":220,"context_line":"            raise exception.KaminarioCinderDriverException("},{"line_number":221,"context_line":"                reason\u003dsix.text_type(six.text_type(ex)))"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"        if self._get_is_replica(volume.volume_type) and self.replica:"},{"line_number":224,"context_line":"            self._create_volume_replica(volume, vg, vol, self.replica.rpo)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff0f0b1f_7872484b","line":221,"in_reply_to":"ff0f0b1f_ff641324","updated":"2017-05-23 02:20:25.000000000","message":"Done","commit_id":"10047caa18883fc0307cd643c671249ca1ad5cd7"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"76bea5956e45c88213d5e900398eeb48a19f3d0a","unresolved":false,"context_lines":[{"line_number":280,"context_line":"                                rvg_name, \"remote vg\")"},{"line_number":281,"context_line":"            self._delete_by_ref(self.client, \"volume_groups\", vg.name, \"vg\")"},{"line_number":282,"context_line":"            raise exception.KaminarioCinderDriverException("},{"line_number":283,"context_line":"                reason\u003dsix.text_type(six.text_type(ex)))"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"    @kaminario_logger"},{"line_number":286,"context_line":"    def _create_failover_volume_replica(self, volume, vg_name, vol_name):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff0f0b1f_9f6f57fb","line":283,"updated":"2017-05-22 14:52:07.000000000","message":"ditto","commit_id":"10047caa18883fc0307cd643c671249ca1ad5cd7"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"35ca47cd02e3c2b2b097634edd8970eda3169323","unresolved":false,"context_lines":[{"line_number":280,"context_line":"                                rvg_name, \"remote vg\")"},{"line_number":281,"context_line":"            self._delete_by_ref(self.client, \"volume_groups\", vg.name, \"vg\")"},{"line_number":282,"context_line":"            raise exception.KaminarioCinderDriverException("},{"line_number":283,"context_line":"                reason\u003dsix.text_type(six.text_type(ex)))"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"    @kaminario_logger"},{"line_number":286,"context_line":"    def _create_failover_volume_replica(self, volume, vg_name, vol_name):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff0f0b1f_5891c446","line":283,"in_reply_to":"ff0f0b1f_9f6f57fb","updated":"2017-05-23 02:20:25.000000000","message":"Done","commit_id":"10047caa18883fc0307cd643c671249ca1ad5cd7"},{"author":{"_account_id":20191,"name":"Dinesh Bhor","email":"bhordinesh07@gmail.com","username":"dineshbhor"},"change_message_id":"c77fda03a517acfdc689c36df070e1096b2ef85e","unresolved":false,"context_lines":[{"line_number":678,"context_line":"        except Exception as ex:"},{"line_number":679,"context_line":"            LOG.exception(\"Deletion of volume %s failed.\", vol_name)"},{"line_number":680,"context_line":"            raise exception.KaminarioCinderDriverException("},{"line_number":681,"context_line":"                reason\u003dsix.text_type(six.text_type(ex)))"},{"line_number":682,"context_line":""},{"line_number":683,"context_line":"    @kaminario_logger"},{"line_number":684,"context_line":"    def _delete_volume_replica(self, volume, vg_name, vol_name):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff0f0b1f_3ed8511c","line":681,"range":{"start_line":681,"start_character":23,"end_line":681,"end_character":56},"updated":"2017-05-22 13:19:29.000000000","message":"Why not six.text_type(ex) only? is there a specific reason for using six.text_type again?","commit_id":"10047caa18883fc0307cd643c671249ca1ad5cd7"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"ff995085da855d0a076b0725a83a405d53d95f98","unresolved":false,"context_lines":[{"line_number":678,"context_line":"        except Exception as ex:"},{"line_number":679,"context_line":"            LOG.exception(\"Deletion of volume %s failed.\", vol_name)"},{"line_number":680,"context_line":"            raise exception.KaminarioCinderDriverException("},{"line_number":681,"context_line":"                reason\u003dsix.text_type(six.text_type(ex)))"},{"line_number":682,"context_line":""},{"line_number":683,"context_line":"    @kaminario_logger"},{"line_number":684,"context_line":"    def _delete_volume_replica(self, volume, vg_name, vol_name):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff0f0b1f_7fd12323","line":681,"range":{"start_line":681,"start_character":23,"end_line":681,"end_character":56},"in_reply_to":"ff0f0b1f_3ed8511c","updated":"2017-05-22 14:44:48.000000000","message":"It\u0027s a mistake. Thanks Dinesh.","commit_id":"10047caa18883fc0307cd643c671249ca1ad5cd7"}],"cinder/volume/drivers/netapp/dataontap/client/client_base.py":[{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"01e182ce656fc0cc51dc7cd90625813e25f0b1d4","unresolved":false,"context_lines":[{"line_number":207,"context_line":"                result.get_child_content(\"max-resize-size\")"},{"line_number":208,"context_line":"        except Exception as e:"},{"line_number":209,"context_line":"            LOG.error(\"LUN %(path)s geometry failed. Message - %(msg)s\","},{"line_number":210,"context_line":"                      {\u0027path\u0027: path, \u0027msg\u0027: six.text_type(e)})"},{"line_number":211,"context_line":"        return geometry"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"    def get_volume_options(self, volume_name):"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff0f0b1f_867a56ee","line":210,"range":{"start_line":210,"start_character":44,"end_line":210,"end_character":60},"updated":"2017-05-23 06:37:19.000000000","message":"Should this use _LE and remove six.text_type?","commit_id":"565deec6c30c559dae4e9dc810e9dae5f8385d01"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"7507f27ca6f6f523eb206d0706c57777fcacb243","unresolved":false,"context_lines":[{"line_number":207,"context_line":"                result.get_child_content(\"max-resize-size\")"},{"line_number":208,"context_line":"        except Exception as e:"},{"line_number":209,"context_line":"            LOG.error(\"LUN %(path)s geometry failed. Message - %(msg)s\","},{"line_number":210,"context_line":"                      {\u0027path\u0027: path, \u0027msg\u0027: six.text_type(e)})"},{"line_number":211,"context_line":"        return geometry"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"    def get_volume_options(self, volume_name):"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff0f0b1f_6f52753d","line":210,"range":{"start_line":210,"start_character":44,"end_line":210,"end_character":60},"in_reply_to":"ff0f0b1f_867a56ee","updated":"2017-05-23 08:37:38.000000000","message":"We don\u0027t have _LE anymore :)","commit_id":"565deec6c30c559dae4e9dc810e9dae5f8385d01"}]}