)]}'
{"cinder/volume/drivers/hpe/hpe_3par_common.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"041cb0b7df987347ea03b7ddc38a408bfe4a0544","unresolved":false,"context_lines":[{"line_number":2157,"context_line":"                        # Delete volume if unable to add it to the volume set"},{"line_number":2158,"context_line":"                        self.client.deleteVolume(vol_name)"},{"line_number":2159,"context_line":"                        LOG.error(\"Exception: %s\", ex)"},{"line_number":2160,"context_line":"                        raise exception.CinderException(ex)"},{"line_number":2161,"context_line":""},{"line_number":2162,"context_line":"                # v2 replication check"},{"line_number":2163,"context_line":"                replication_flag \u003d False"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f044301_3e7cd3b3","line":2160,"range":{"start_line":2160,"start_character":56,"end_line":2160,"end_character":58},"updated":"2017-05-09 10:47:31.000000000","message":"Instead of passing in the exception here, and just logging \"Exception: x\" above, can you use this to format a string that contains a little more description of what happened so if someone hits this it is a little more obvious what was happening and what failed?","commit_id":"cdb8e608c6eacc4e211936c463213ef24af8216b"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"38a32eb79384f829ef739f3916a9d27228229981","unresolved":false,"context_lines":[{"line_number":2158,"context_line":"                        self.client.deleteVolume(vol_name)"},{"line_number":2159,"context_line":"                        dbg \u003d {\u0027volume\u0027: vol_name,"},{"line_number":2160,"context_line":"                               \u0027vvs_name\u0027: vvs_name,"},{"line_number":2161,"context_line":"                               \u0027err\u0027: ex}"},{"line_number":2162,"context_line":"                        msg \u003d _(\"Failed to add volume \u0027%(volume)s\u0027 to vvset \""},{"line_number":2163,"context_line":"                                \"\u0027%(vvs_name)s\u0027 because \u0027%(err)s\u0027\") % dbg"},{"line_number":2164,"context_line":"                        LOG.error(msg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f013ff3_5c70f9dc","line":2161,"range":{"start_line":2161,"start_character":38,"end_line":2161,"end_character":40},"updated":"2017-05-16 14:22:03.000000000","message":"To be safe, this should be six.text_type(ex) to make sure py2/py3 does not have any issues. But it doesn\u0027t look likely from where this is thrown. Maybe just add that if you have a reason to do another update.","commit_id":"ac663aec955ee8d2fb05686ef3ad724f98acdefe"}]}