)]}'
{"cinder/volume/drivers/dell_emc/vmax/https.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"400e204b7b336ac2a7e3539f8b6e6aed19107c9b","unresolved":false,"context_lines":[{"line_number":284,"context_line":"    elif no_verification:"},{"line_number":285,"context_line":"        ca_certs \u003d None"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"    if use_ssl:"},{"line_number":288,"context_line":"        h \u003d HTTPSConnection("},{"line_number":289,"context_line":"            host,"},{"line_number":290,"context_line":"            port\u003dport,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f044301_ec31105c","line":287,"range":{"start_line":287,"start_character":7,"end_line":287,"end_character":14},"updated":"2017-05-10 13:17:19.000000000","message":"It looks like h doesn\u0027t get assigned if use_ssl is false. Existing code not related to this patch, but I noticed it while looking at how this is done and thought it should be pointed out. Is it expected that there will never be a case where ssl is not used?\n\nThe reason I was looking at the assignment of the h variable is I think it may be better to put this in a \"with\" statement. That way if there is an exception thrown before close() is called, it will still clean up.\n\nhttps://www.python.org/dev/peps/pep-0343/","commit_id":"16bc894ccd50e7abd04e6c35ff99dbab18747076"},{"author":{"_account_id":22021,"name":"Unana Okpoyo","email":"tomitu@yahoo.com","username":"UnanaOkpoyo"},"change_message_id":"dda7f83e3e41521620c32879d397242950ecd539","unresolved":false,"context_lines":[{"line_number":284,"context_line":"    elif no_verification:"},{"line_number":285,"context_line":"        ca_certs \u003d None"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"    if use_ssl:"},{"line_number":288,"context_line":"        h \u003d HTTPSConnection("},{"line_number":289,"context_line":"            host,"},{"line_number":290,"context_line":"            port\u003dport,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f044301_14a9cf8e","line":287,"range":{"start_line":287,"start_character":7,"end_line":287,"end_character":14},"in_reply_to":"3f044301_ec31105c","updated":"2017-05-11 08:53:13.000000000","message":"You are absolutely right Sean, the way the code is written is so use_ssl should never be false cause if it was, the whole module would not be called. I will make the appropriate changes and resubmit....Thanks","commit_id":"16bc894ccd50e7abd04e6c35ff99dbab18747076"}]}