)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"66c6f25d6b74eda850335339ae26a3134238e75d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"LVM: fix max_over_subscription_ratio doesn\u0027t work"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If lvm_max_over_subscription_ratio  is not set,"},{"line_number":10,"context_line":"max_over_subscription_ratio for lvm doesn\u0027t work"},{"line_number":11,"context_line":"and is always 1.0"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1f013ff3_e407191c","line":9,"range":{"start_line":9,"start_character":34,"end_line":9,"end_character":36},"updated":"2017-05-17 06:10:26.000000000","message":"Remove redundant blank space:)","commit_id":"a9106c6e09a10eb753eba3abe55df75dc8ca1103"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"6cd579b4055b1147a6004e5887fdc3da799f9bd4","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"LVM: fix max_over_subscription_ratio doesn\u0027t work"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If lvm_max_over_subscription_ratio  is not set,"},{"line_number":10,"context_line":"max_over_subscription_ratio for lvm doesn\u0027t work"},{"line_number":11,"context_line":"and is always 1.0"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1f013ff3_8798571b","line":9,"range":{"start_line":9,"start_character":34,"end_line":9,"end_character":36},"in_reply_to":"1f013ff3_e407191c","updated":"2017-05-17 06:36:10.000000000","message":"will update it in the next ps with test code as well.","commit_id":"a9106c6e09a10eb753eba3abe55df75dc8ca1103"},{"author":{"_account_id":23140,"name":"Jess Egler","email":"jess.egler@gmail.com","username":"jessegler"},"change_message_id":"545feec952e946734ff9ef19a686672a1c1ccb63","unresolved":false,"context_lines":[{"line_number":10,"context_line":"still has a default value. So the global config option"},{"line_number":11,"context_line":"max_over_subscription_ratio will be replaced as well."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Update the help message to avoid misleading"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I94e18d04c39b930e48eeacfb4415c45d924d2f97"},{"line_number":16,"context_line":"Closes-bug: #1602235"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ff0f0b1f_1162c2d8","line":13,"updated":"2017-05-24 19:30:36.000000000","message":"nit: awkward wording try \nUpdate the help message avoid misleading the user or\nUpdate the help message to be less misleading","commit_id":"6714f3086bf82b6c90ce7f0306d64b7e0e85d0be"}],"cinder/volume/drivers/lvm.py":[{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"66c6f25d6b74eda850335339ae26a3134238e75d","unresolved":false,"context_lines":[{"line_number":266,"context_line":"            QoS_support\u003dFalse,"},{"line_number":267,"context_line":"            provisioned_capacity_gb\u003dprovisioned_capacity,"},{"line_number":268,"context_line":"            max_over_subscription_ratio\u003d("},{"line_number":269,"context_line":"                self.configuration.safe_get(\u0027max_over_subscription_ratio\u0027)),"},{"line_number":270,"context_line":"            thin_provisioning_support\u003dthin_enabled,"},{"line_number":271,"context_line":"            thick_provisioning_support\u003dnot thin_enabled,"},{"line_number":272,"context_line":"            total_volumes\u003dtotal_volumes,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f013ff3_e7915b9b","line":269,"range":{"start_line":269,"start_character":15,"end_line":269,"end_character":76},"updated":"2017-05-17 06:10:26.000000000","message":"Do you mean the option here [1]? it says that it has a  value in default.\n\n[1] https://github.com/openstack/cinder/blob/master/cinder/volume/driver.py#L159","commit_id":"a9106c6e09a10eb753eba3abe55df75dc8ca1103"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"6cd579b4055b1147a6004e5887fdc3da799f9bd4","unresolved":false,"context_lines":[{"line_number":266,"context_line":"            QoS_support\u003dFalse,"},{"line_number":267,"context_line":"            provisioned_capacity_gb\u003dprovisioned_capacity,"},{"line_number":268,"context_line":"            max_over_subscription_ratio\u003d("},{"line_number":269,"context_line":"                self.configuration.safe_get(\u0027max_over_subscription_ratio\u0027)),"},{"line_number":270,"context_line":"            thin_provisioning_support\u003dthin_enabled,"},{"line_number":271,"context_line":"            thick_provisioning_support\u003dnot thin_enabled,"},{"line_number":272,"context_line":"            total_volumes\u003dtotal_volumes,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f013ff3_272503c3","line":269,"range":{"start_line":269,"start_character":15,"end_line":269,"end_character":76},"in_reply_to":"1f013ff3_e7915b9b","updated":"2017-05-17 06:36:10.000000000","message":"Yes","commit_id":"a9106c6e09a10eb753eba3abe55df75dc8ca1103"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"d17f0ba3d967ae14c33acc092fb75574c8356e5f","unresolved":false,"context_lines":[{"line_number":69,"context_line":"                 help\u003d\u0027max_over_subscription_ratio setting for the LVM \u0027"},{"line_number":70,"context_line":"                      \u0027driver. If set to None, the general option is used. \u0027"},{"line_number":71,"context_line":"                      \u0027Otherwise, this takes precedence over the general \u0027"},{"line_number":72,"context_line":"                      \u0027max_over_subscription_ratio option.\u0027),"},{"line_number":73,"context_line":"    cfg.BoolOpt(\u0027lvm_suppress_fd_warnings\u0027,"},{"line_number":74,"context_line":"                default\u003dFalse,"},{"line_number":75,"context_line":"                help\u003d\u0027Suppress leaked file descriptor warnings in LVM \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff0f0b1f_28708972","line":72,"updated":"2017-05-17 18:14:56.000000000","message":"I\u0027m not sure this change makes this help message more clear.  The reason for introducing this lvm_max_over_subscription_ratio is to use its default value of 1.0, and not to use the general default ratio of 20, which is too high for LVM.","commit_id":"2dbe2f6ca6d0828d31e6aebb52e99afd014fe75a"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"38f08c75ecf664c6f7d602db019d7fb30e5defc4","unresolved":false,"context_lines":[{"line_number":69,"context_line":"                 help\u003d\u0027max_over_subscription_ratio setting for the LVM \u0027"},{"line_number":70,"context_line":"                      \u0027driver. If set to None, the general option is used. \u0027"},{"line_number":71,"context_line":"                      \u0027Otherwise, this takes precedence over the general \u0027"},{"line_number":72,"context_line":"                      \u0027max_over_subscription_ratio option.\u0027),"},{"line_number":73,"context_line":"    cfg.BoolOpt(\u0027lvm_suppress_fd_warnings\u0027,"},{"line_number":74,"context_line":"                default\u003dFalse,"},{"line_number":75,"context_line":"                help\u003d\u0027Suppress leaked file descriptor warnings in LVM \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff0f0b1f_c3c37188","line":72,"in_reply_to":"ff0f0b1f_07f2d970","updated":"2017-05-24 09:03:35.000000000","message":"Addressed Xing\u0027s comment. Please take a look. Thanks.","commit_id":"2dbe2f6ca6d0828d31e6aebb52e99afd014fe75a"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"207ba4c4ea28d224e04ce58b60ce3f9889ce3a00","unresolved":false,"context_lines":[{"line_number":69,"context_line":"                 help\u003d\u0027max_over_subscription_ratio setting for the LVM \u0027"},{"line_number":70,"context_line":"                      \u0027driver. If set to None, the general option is used. \u0027"},{"line_number":71,"context_line":"                      \u0027Otherwise, this takes precedence over the general \u0027"},{"line_number":72,"context_line":"                      \u0027max_over_subscription_ratio option.\u0027),"},{"line_number":73,"context_line":"    cfg.BoolOpt(\u0027lvm_suppress_fd_warnings\u0027,"},{"line_number":74,"context_line":"                default\u003dFalse,"},{"line_number":75,"context_line":"                help\u003d\u0027Suppress leaked file descriptor warnings in LVM \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff0f0b1f_07f2d970","line":72,"in_reply_to":"ff0f0b1f_28708972","updated":"2017-05-22 16:01:49.000000000","message":"I think it would make the most sense to just explain what Xing has put here.","commit_id":"2dbe2f6ca6d0828d31e6aebb52e99afd014fe75a"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"4254969a6da6e051c99cea711986fd8e480540dd","unresolved":false,"context_lines":[{"line_number":69,"context_line":"                 help\u003d\u0027max_over_subscription_ratio setting for the LVM \u0027"},{"line_number":70,"context_line":"                      \u0027driver. If set to None, the general option is used. \u0027"},{"line_number":71,"context_line":"                      \u0027Otherwise, this takes precedence over the general \u0027"},{"line_number":72,"context_line":"                      \u0027max_over_subscription_ratio option.\u0027),"},{"line_number":73,"context_line":"    cfg.BoolOpt(\u0027lvm_suppress_fd_warnings\u0027,"},{"line_number":74,"context_line":"                default\u003dFalse,"},{"line_number":75,"context_line":"                help\u003d\u0027Suppress leaked file descriptor warnings in LVM \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff0f0b1f_252e5c43","line":72,"in_reply_to":"ff0f0b1f_28708972","updated":"2017-05-18 09:28:36.000000000","message":"Yeah, so another way is to remove the None usage.","commit_id":"2dbe2f6ca6d0828d31e6aebb52e99afd014fe75a"},{"author":{"_account_id":23140,"name":"Jess Egler","email":"jess.egler@gmail.com","username":"jessegler"},"change_message_id":"545feec952e946734ff9ef19a686672a1c1ccb63","unresolved":false,"context_lines":[{"line_number":66,"context_line":"                 # LVM driver which is different than the global default."},{"line_number":67,"context_line":"                 default\u003d1.0,"},{"line_number":68,"context_line":"                 help\u003d\u0027max_over_subscription_ratio setting for the LVM \u0027"},{"line_number":69,"context_line":"                      \u0027driver. By default, This takes precedence over the \u0027"},{"line_number":70,"context_line":"                      \u0027general max_over_subscription_ratio option of which \u0027"},{"line_number":71,"context_line":"                      \u0027the default value is too large for LVM driver. If set \u0027"},{"line_number":72,"context_line":"                      \u0027to None, the general option is used.\u0027),"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff0f0b1f_2e0b232a","line":69,"range":{"start_line":69,"start_character":43,"end_line":69,"end_character":47},"updated":"2017-05-24 19:30:36.000000000","message":"nit: lowercase this","commit_id":"6714f3086bf82b6c90ce7f0306d64b7e0e85d0be"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"f1e50ee3f9ddc7ccf9a3c517d1b9bced76226753","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                 default\u003d1.0,"},{"line_number":68,"context_line":"                 help\u003d\u0027max_over_subscription_ratio setting for the LVM \u0027"},{"line_number":69,"context_line":"                      \u0027driver. By default, This takes precedence over the \u0027"},{"line_number":70,"context_line":"                      \u0027general max_over_subscription_ratio option of which \u0027"},{"line_number":71,"context_line":"                      \u0027the default value is too large for LVM driver. If set \u0027"},{"line_number":72,"context_line":"                      \u0027to None, the general option is used.\u0027),"},{"line_number":73,"context_line":"    cfg.BoolOpt(\u0027lvm_suppress_fd_warnings\u0027,"},{"line_number":74,"context_line":"                default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff0f0b1f_91125261","line":71,"range":{"start_line":70,"start_character":66,"end_line":71,"end_character":68},"updated":"2017-05-24 19:59:07.000000000","message":"It\u0027s not a correct statement that the default value is \"too large\" for the LVM driver.  This should not be part of this description.","commit_id":"6714f3086bf82b6c90ce7f0306d64b7e0e85d0be"},{"author":{"_account_id":23140,"name":"Jess Egler","email":"jess.egler@gmail.com","username":"jessegler"},"change_message_id":"545feec952e946734ff9ef19a686672a1c1ccb63","unresolved":false,"context_lines":[{"line_number":69,"context_line":"                      \u0027driver. By default, This takes precedence over the \u0027"},{"line_number":70,"context_line":"                      \u0027general max_over_subscription_ratio option of which \u0027"},{"line_number":71,"context_line":"                      \u0027the default value is too large for LVM driver. If set \u0027"},{"line_number":72,"context_line":"                      \u0027to None, the general option is used.\u0027),"},{"line_number":73,"context_line":"    cfg.BoolOpt(\u0027lvm_suppress_fd_warnings\u0027,"},{"line_number":74,"context_line":"                default\u003dFalse,"},{"line_number":75,"context_line":"                help\u003d\u0027Suppress leaked file descriptor warnings in LVM \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff0f0b1f_4e109757","line":72,"updated":"2017-05-24 19:30:36.000000000","message":"I was a little confused until I read the previous patch set\u0027s comments. Maybe something like below?\n\n\"lvm_max_over_subscription_ratio setting for the LVM driver. This takes precedence over the general max_over_subscription_ratio. If set to None, the max_over_subscription_ratio is used. Please note that max_over_subscription_ratio is too large for the LVM driver by default.\"","commit_id":"6714f3086bf82b6c90ce7f0306d64b7e0e85d0be"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"37b91480c885fc05522c216445f57c67b0602993","unresolved":false,"context_lines":[{"line_number":68,"context_line":"                 help\u003d\u0027lvm_max_over_subscription_ratio setting for the LVM \u0027"},{"line_number":69,"context_line":"                      \u0027driver. This takes precedence over the general \u0027"},{"line_number":70,"context_line":"                      \u0027max_over_subscription_ratio. If set to None, the \u0027"},{"line_number":71,"context_line":"                      \u0027general max_over_subscription_ratio is used. Please \u0027"},{"line_number":72,"context_line":"                      \u0027note that max_over_subscription_ratio is too large for \u0027"},{"line_number":73,"context_line":"                      \u0027the LVM driver by default.\u0027),"},{"line_number":74,"context_line":"    cfg.BoolOpt(\u0027lvm_suppress_fd_warnings\u0027,"},{"line_number":75,"context_line":"                default\u003dFalse,"},{"line_number":76,"context_line":"                help\u003d\u0027Suppress leaked file descriptor warnings in LVM \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_e8d2a2ff","line":73,"range":{"start_line":71,"start_character":68,"end_line":73,"end_character":49},"updated":"2017-05-25 14:47:02.000000000","message":"As per Eric\u0027s comments, this sentence should be removed.","commit_id":"fe756c78b4f2fa81e6820ae301b49489fe24468d"}]}