)]}'
{"cinder/tests/unit/volume/drivers/test_sheepdog.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"e73a518ae0cb4683fa5fa8092f6382e9ccb5d546","unresolved":false,"context_lines":[{"line_number":1247,"context_line":""},{"line_number":1248,"context_line":"        patch \u003d mock.patch.object"},{"line_number":1249,"context_line":"        with patch(self.driver, \u0027_try_execute\u0027) as fake_try_execute:"},{"line_number":1250,"context_line":"            with patch(fake_image_service,"},{"line_number":1251,"context_line":"                       \u0027update\u0027) as fake_image_service_update:"},{"line_number":1252,"context_line":"                fake_try_execute.side_effect \u003d ("},{"line_number":1253,"context_line":"                    processutils.ProcessExecutionError)"},{"line_number":1254,"context_line":"                args \u003d (fake_context, fake_volume, fake_image_service,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_11d57b1c","line":1251,"range":{"start_line":1250,"start_character":0,"end_line":1251,"end_character":62},"updated":"2017-05-22 15:09:57.000000000","message":"-1: Since fake_image_service is already a Mock we don\u0027t really need to patch it.","commit_id":"875d2eb639a27993bac0f0da6d589bb2db3de833"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"e73a518ae0cb4683fa5fa8092f6382e9ccb5d546","unresolved":false,"context_lines":[{"line_number":1252,"context_line":"                fake_try_execute.side_effect \u003d ("},{"line_number":1253,"context_line":"                    processutils.ProcessExecutionError)"},{"line_number":1254,"context_line":"                args \u003d (fake_context, fake_volume, fake_image_service,"},{"line_number":1255,"context_line":"                        fake_image_meta)"},{"line_number":1256,"context_line":"                expected_cmd \u003d (\u0027qemu-img\u0027,"},{"line_number":1257,"context_line":"                                \u0027convert\u0027,"},{"line_number":1258,"context_line":"                                \u0027-f\u0027, \u0027raw\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_717cb71e","line":1255,"updated":"2017-05-22 15:09:57.000000000","message":"nit: This has nothing to do with your patch, but this is not really necessary, we could just put these in order on L1269","commit_id":"875d2eb639a27993bac0f0da6d589bb2db3de833"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"ef046b39c2ce7d7aa6770fc4ff31ff8c016a6b92","unresolved":false,"context_lines":[{"line_number":1252,"context_line":"                fake_try_execute.side_effect \u003d ("},{"line_number":1253,"context_line":"                    processutils.ProcessExecutionError)"},{"line_number":1254,"context_line":"                args \u003d (fake_context, fake_volume, fake_image_service,"},{"line_number":1255,"context_line":"                        fake_image_meta)"},{"line_number":1256,"context_line":"                expected_cmd \u003d (\u0027qemu-img\u0027,"},{"line_number":1257,"context_line":"                                \u0027convert\u0027,"},{"line_number":1258,"context_line":"                                \u0027-f\u0027, \u0027raw\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_d0f6bdd7","line":1255,"in_reply_to":"ff0f0b1f_4a757831","updated":"2017-05-23 11:26:04.000000000","message":"It is more explicit on what you want to mock, which is always good, but the additional context manager also reduces readability, so it\u0027s probably more a matter of preference and I shouldn\u0027t have downvoted...","commit_id":"875d2eb639a27993bac0f0da6d589bb2db3de833"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"0a0f195815ce4b0c4b42e431607e741f8832404c","unresolved":false,"context_lines":[{"line_number":1252,"context_line":"                fake_try_execute.side_effect \u003d ("},{"line_number":1253,"context_line":"                    processutils.ProcessExecutionError)"},{"line_number":1254,"context_line":"                args \u003d (fake_context, fake_volume, fake_image_service,"},{"line_number":1255,"context_line":"                        fake_image_meta)"},{"line_number":1256,"context_line":"                expected_cmd \u003d (\u0027qemu-img\u0027,"},{"line_number":1257,"context_line":"                                \u0027convert\u0027,"},{"line_number":1258,"context_line":"                                \u0027-f\u0027, \u0027raw\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_4a757831","line":1255,"in_reply_to":"ff0f0b1f_717cb71e","updated":"2017-05-22 16:41:43.000000000","message":"Yeah, I started doing that but then decided to keep it this way as it was more readable.","commit_id":"875d2eb639a27993bac0f0da6d589bb2db3de833"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"e73a518ae0cb4683fa5fa8092f6382e9ccb5d546","unresolved":false,"context_lines":[{"line_number":1270,"context_line":""},{"line_number":1271,"context_line":"                fake_try_execute.assert_called_once_with(*expected_cmd)"},{"line_number":1272,"context_line":"                mock_open.assert_not_called()"},{"line_number":1273,"context_line":"                fake_image_service_update.assert_not_called()"},{"line_number":1274,"context_line":""},{"line_number":1275,"context_line":"    @mock.patch.object(sheepdog.SheepdogClient, \u0027create_snapshot\u0027)"},{"line_number":1276,"context_line":"    @mock.patch.object(sheepdog.SheepdogClient, \u0027clone\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_71e5d708","line":1273,"updated":"2017-05-22 15:09:57.000000000","message":"-1: `fake_image_service.update.assert_not_called()`","commit_id":"875d2eb639a27993bac0f0da6d589bb2db3de833"}]}