)]}'
{"cinder/utils.py":[{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"5e578d11d9ae39486d7dc9cae9e065e5fcecd9a7","unresolved":false,"context_lines":[{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    for k, v in metadata.items():"},{"line_number":168,"context_line":"        try:"},{"line_number":169,"context_line":"            check_string_length(k, \"metadata key\", min_length\u003d1)"},{"line_number":170,"context_line":"            check_string_length(v, \"metadata value\")"},{"line_number":171,"context_line":"        except exception.InvalidInput as exc:"},{"line_number":172,"context_line":"            raise exception.InvalidVolumeMetadata(reason\u003dexc)"},{"line_number":173,"context_line":"        # for backward compatibility"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff0f0b1f_28aa97d1","line":170,"range":{"start_line":169,"start_character":35,"end_line":170,"end_character":52},"updated":"2017-05-19 02:38:18.000000000","message":"We can make it more explicit by the usage of \"Metadata key: %s\" % k and \"Value for metadata key: %s\" % k.","commit_id":"c65825f01c1d3ad8288537e16da94b81c70066af"},{"author":{"_account_id":24564,"name":"qtlu","email":"qtlu@fiberhome.com","username":"qtlu"},"change_message_id":"388241656c70b79661532be0470b9debf88f7ac4","unresolved":false,"context_lines":[{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    for k, v in metadata.items():"},{"line_number":168,"context_line":"        try:"},{"line_number":169,"context_line":"            check_string_length(k, \"metadata key\", min_length\u003d1)"},{"line_number":170,"context_line":"            check_string_length(v, \"metadata value\")"},{"line_number":171,"context_line":"        except exception.InvalidInput as exc:"},{"line_number":172,"context_line":"            raise exception.InvalidVolumeMetadata(reason\u003dexc)"},{"line_number":173,"context_line":"        # for backward compatibility"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff0f0b1f_3591794f","line":170,"range":{"start_line":169,"start_character":35,"end_line":170,"end_character":52},"in_reply_to":"ff0f0b1f_28aa97d1","updated":"2017-05-23 01:30:34.000000000","message":"Done","commit_id":"c65825f01c1d3ad8288537e16da94b81c70066af"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"beddc66def094669460fd1112698e0f493b6fd10","unresolved":false,"context_lines":[{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    for k, v in metadata.items():"},{"line_number":168,"context_line":"        try:"},{"line_number":169,"context_line":"            check_string_length(k, \"metadata key\", min_length\u003d1)"},{"line_number":170,"context_line":"            check_string_length(v, \"metadata value\")"},{"line_number":171,"context_line":"        except exception.InvalidInput as exc:"},{"line_number":172,"context_line":"            raise exception.InvalidVolumeMetadata(reason\u003dexc)"},{"line_number":173,"context_line":"        # for backward compatibility"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff0f0b1f_e70c85a6","line":170,"range":{"start_line":169,"start_character":35,"end_line":170,"end_character":52},"in_reply_to":"ff0f0b1f_28aa97d1","updated":"2017-05-22 15:57:01.000000000","message":"The change looks ok to me.  TommyLike, not totally following your recommendation here.  Can you clarify?","commit_id":"c65825f01c1d3ad8288537e16da94b81c70066af"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"d8e65e30b97b1e281c8d073503f749c3915599d2","unresolved":false,"context_lines":[{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    for k, v in metadata.items():"},{"line_number":168,"context_line":"        try:"},{"line_number":169,"context_line":"            check_string_length(k, \"metadata key\", min_length\u003d1)"},{"line_number":170,"context_line":"            check_string_length(v, \"metadata value\")"},{"line_number":171,"context_line":"        except exception.InvalidInput as exc:"},{"line_number":172,"context_line":"            raise exception.InvalidVolumeMetadata(reason\u003dexc)"},{"line_number":173,"context_line":"        # for backward compatibility"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff0f0b1f_ed1fbb58","line":170,"range":{"start_line":169,"start_character":35,"end_line":170,"end_character":52},"in_reply_to":"ff0f0b1f_28aa97d1","updated":"2017-05-22 22:34:37.000000000","message":"TommyLike.  If you look here the Oslo is going to handle issues and doing this form will mess that up:  https://github.com/openstack/oslo.utils/blob/master/oslo_utils/strutils.py#L409","commit_id":"c65825f01c1d3ad8288537e16da94b81c70066af"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"f8c5bdc4dc55c76aba9aabf4e7afc7ab70bee861","unresolved":false,"context_lines":[{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    for k, v in metadata.items():"},{"line_number":168,"context_line":"        try:"},{"line_number":169,"context_line":"            check_string_length(k, \"Metadata key: %s\" % k, min_length\u003d1)"},{"line_number":170,"context_line":"            check_string_length(v, \"Value for metadata key: %s\" % k)"},{"line_number":171,"context_line":"        except exception.InvalidInput as exc:"},{"line_number":172,"context_line":"            raise exception.InvalidVolumeMetadata(reason\u003dexc)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_bcffa2a9","line":169,"updated":"2017-05-23 13:08:11.000000000","message":"Why aren\u0027t we checking the max_length \u003c 255 here?","commit_id":"4c230df10e8b637c9b0dc6bdc933c21da425d918"},{"author":{"_account_id":24564,"name":"qtlu","email":"qtlu@fiberhome.com","username":"qtlu"},"change_message_id":"8104a6c8833eb3b1e5759e02944d6e2b68941976","unresolved":false,"context_lines":[{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    for k, v in metadata.items():"},{"line_number":168,"context_line":"        try:"},{"line_number":169,"context_line":"            check_string_length(k, \"Metadata key: %s\" % k, min_length\u003d1)"},{"line_number":170,"context_line":"            check_string_length(v, \"Value for metadata key: %s\" % k)"},{"line_number":171,"context_line":"        except exception.InvalidInput as exc:"},{"line_number":172,"context_line":"            raise exception.InvalidVolumeMetadata(reason\u003dexc)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_35ca721a","line":169,"in_reply_to":"ff0f0b1f_bcffa2a9","updated":"2017-05-24 00:30:19.000000000","message":"For backward compatibility, if metadata key or value\u0027s size\u003e255, we raise an InvalidVolumeMetadataSize exception other than InvalidVolumeMetadata exception.","commit_id":"4c230df10e8b637c9b0dc6bdc933c21da425d918"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"296e34ed28903677351649a001e253c9d94cc94d","unresolved":false,"context_lines":[{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    for k, v in metadata.items():"},{"line_number":168,"context_line":"        try:"},{"line_number":169,"context_line":"            check_string_length(k, \"Metadata key: %s\" % k, min_length\u003d1)"},{"line_number":170,"context_line":"            check_string_length(v, \"Value for metadata key: %s\" % k)"},{"line_number":171,"context_line":"        except exception.InvalidInput as exc:"},{"line_number":172,"context_line":"            raise exception.InvalidVolumeMetadata(reason\u003dexc)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_2f4e8bc0","line":169,"in_reply_to":"ff0f0b1f_bcffa2a9","updated":"2017-05-24 13:18:20.000000000","message":"OK, thanks.","commit_id":"4c230df10e8b637c9b0dc6bdc933c21da425d918"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"f8c5bdc4dc55c76aba9aabf4e7afc7ab70bee861","unresolved":false,"context_lines":[{"line_number":167,"context_line":"    for k, v in metadata.items():"},{"line_number":168,"context_line":"        try:"},{"line_number":169,"context_line":"            check_string_length(k, \"Metadata key: %s\" % k, min_length\u003d1)"},{"line_number":170,"context_line":"            check_string_length(v, \"Value for metadata key: %s\" % k)"},{"line_number":171,"context_line":"        except exception.InvalidInput as exc:"},{"line_number":172,"context_line":"            raise exception.InvalidVolumeMetadata(reason\u003dexc)"},{"line_number":173,"context_line":"        # for backward compatibility"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_1cad6e9a","line":170,"updated":"2017-05-23 13:08:11.000000000","message":"Why don\u0027t we check for  max_length \u003c 255?","commit_id":"4c230df10e8b637c9b0dc6bdc933c21da425d918"}]}