)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"21f9133ca3112568ca3441871da5d6c9934b154b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     hongzhezheng \u003czheng.hongzhe32@zte.com.cn\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-05-19 05:22:11 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"volume migration between different availability zones does not work"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently volume migration bewteen different availability zones"},{"line_number":10,"context_line":"does not work."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ff0f0b1f_39bbfd72","line":7,"updated":"2017-05-19 14:15:31.000000000","message":"Please try to follow commit message guidelines:\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure\n\nAlso, a commit message should state what the change is, not what the current error is. So something like \"Allow volume migration between availablity zones\".","commit_id":"75106a4387fb74a473ad5ed3d1bec8f04aa40969"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"21f9133ca3112568ca3441871da5d6c9934b154b","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently volume migration bewteen different availability zones"},{"line_number":10,"context_line":"does not work."},{"line_number":11,"context_line":"To sovle this issue,the following procedue should be done."},{"line_number":12,"context_line":"1.Add a new configuration item \u0027enable_across_az_migrate\u0027.If enabled it,"},{"line_number":13,"context_line":"  migrate volume betweend differrnt az is allowed.Otherwise,not allowed;"},{"line_number":14,"context_line":"2.Add two volume backend in different cinder.conf with same"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ff0f0b1f_19b27995","line":11,"range":{"start_line":11,"start_character":3,"end_line":11,"end_character":8},"updated":"2017-05-19 14:15:31.000000000","message":"solve","commit_id":"75106a4387fb74a473ad5ed3d1bec8f04aa40969"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"a23aeb7eade765528f9c796669c461582b91fab0","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Currently volume migration bewteen different availability zones"},{"line_number":10,"context_line":"does not work."},{"line_number":11,"context_line":"To sovle this issue,the following procedue should be done."},{"line_number":12,"context_line":"1.Add a new configuration item \u0027enable_across_az_migrate\u0027.If enabled it,"},{"line_number":13,"context_line":"  migrate volume betweend differrnt az is allowed.Otherwise,not allowed;"},{"line_number":14,"context_line":"2.Add two volume backend in different cinder.conf with same"},{"line_number":15,"context_line":"  \u0027volume_backend_name\u0027, respectively."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ff0f0b1f_a7a7ad0b","line":12,"range":{"start_line":12,"start_character":55,"end_line":12,"end_character":60},"updated":"2017-05-22 15:53:45.000000000","message":"Missing space here.","commit_id":"75106a4387fb74a473ad5ed3d1bec8f04aa40969"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"21f9133ca3112568ca3441871da5d6c9934b154b","unresolved":false,"context_lines":[{"line_number":10,"context_line":"does not work."},{"line_number":11,"context_line":"To sovle this issue,the following procedue should be done."},{"line_number":12,"context_line":"1.Add a new configuration item \u0027enable_across_az_migrate\u0027.If enabled it,"},{"line_number":13,"context_line":"  migrate volume betweend differrnt az is allowed.Otherwise,not allowed;"},{"line_number":14,"context_line":"2.Add two volume backend in different cinder.conf with same"},{"line_number":15,"context_line":"  \u0027volume_backend_name\u0027, respectively."},{"line_number":16,"context_line":"3.Allocated different az for \u0027storage_availability_zone\u0027 item in"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ff0f0b1f_d980818e","line":13,"range":{"start_line":13,"start_character":26,"end_line":13,"end_character":35},"updated":"2017-05-19 14:15:31.000000000","message":"different\n\nNeed space after the period before Otherwise. Space after comma.","commit_id":"75106a4387fb74a473ad5ed3d1bec8f04aa40969"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"21f9133ca3112568ca3441871da5d6c9934b154b","unresolved":false,"context_lines":[{"line_number":13,"context_line":"  migrate volume betweend differrnt az is allowed.Otherwise,not allowed;"},{"line_number":14,"context_line":"2.Add two volume backend in different cinder.conf with same"},{"line_number":15,"context_line":"  \u0027volume_backend_name\u0027, respectively."},{"line_number":16,"context_line":"3.Allocated different az for \u0027storage_availability_zone\u0027 item in"},{"line_number":17,"context_line":"  different cinder.conf."},{"line_number":18,"context_line":"4.Migrate volume to the different az."},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ff0f0b1f_6402e80b","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":1},"updated":"2017-05-19 14:15:31.000000000","message":"Not important, but this can be done with one cinder.conf:\n\nhttps://review.openstack.org/#/c/433437/","commit_id":"75106a4387fb74a473ad5ed3d1bec8f04aa40969"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"4036d63afea1261cde4208dda1bb363e27d2f3e8","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Allow volume migration between different availablity zones"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently volume migration bewteen different availability zones does not"},{"line_number":10,"context_line":"work.To solve this issue,the following procedue should be done:"},{"line_number":11,"context_line":"1.Add a new configuration item \u0027enable_across_az_migrate\u0027. If enabled it,"},{"line_number":12,"context_line":"migrate volume between different AZ is allowed. Otherwise,not allowed."},{"line_number":13,"context_line":"2.Add two volume backend with same \u0027volume_backend_name\u0027."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7f231b9d_2dd5bee5","line":10,"range":{"start_line":10,"start_character":4,"end_line":10,"end_character":6},"updated":"2017-06-14 17:18:10.000000000","message":"Need a space here.","commit_id":"28a304fd8925ddeabe4ec198c682e5a95ede869d"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"4036d63afea1261cde4208dda1bb363e27d2f3e8","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently volume migration bewteen different availability zones does not"},{"line_number":10,"context_line":"work.To solve this issue,the following procedue should be done:"},{"line_number":11,"context_line":"1.Add a new configuration item \u0027enable_across_az_migrate\u0027. If enabled it,"},{"line_number":12,"context_line":"migrate volume between different AZ is allowed. Otherwise,not allowed."},{"line_number":13,"context_line":"2.Add two volume backend with same \u0027volume_backend_name\u0027."},{"line_number":14,"context_line":"3.Allocated different AZ for different backend. After that,restart the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7f231b9d_ad02ee6d","line":11,"range":{"start_line":11,"start_character":1,"end_line":11,"end_character":3},"updated":"2017-06-14 17:18:10.000000000","message":"Add a space please.","commit_id":"28a304fd8925ddeabe4ec198c682e5a95ede869d"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"4036d63afea1261cde4208dda1bb363e27d2f3e8","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Currently volume migration bewteen different availability zones does not"},{"line_number":10,"context_line":"work.To solve this issue,the following procedue should be done:"},{"line_number":11,"context_line":"1.Add a new configuration item \u0027enable_across_az_migrate\u0027. If enabled it,"},{"line_number":12,"context_line":"migrate volume between different AZ is allowed. Otherwise,not allowed."},{"line_number":13,"context_line":"2.Add two volume backend with same \u0027volume_backend_name\u0027."},{"line_number":14,"context_line":"3.Allocated different AZ for different backend. After that,restart the"},{"line_number":15,"context_line":"cinder volume service."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7f231b9d_ad378e4d","line":12,"range":{"start_line":12,"start_character":57,"end_line":12,"end_character":58},"updated":"2017-06-14 17:18:10.000000000","message":"need space here.","commit_id":"28a304fd8925ddeabe4ec198c682e5a95ede869d"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"4036d63afea1261cde4208dda1bb363e27d2f3e8","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently volume migration bewteen different availability zones does not"},{"line_number":10,"context_line":"work.To solve this issue,the following procedue should be done:"},{"line_number":11,"context_line":"1.Add a new configuration item \u0027enable_across_az_migrate\u0027. If enabled it,"},{"line_number":12,"context_line":"migrate volume between different AZ is allowed. Otherwise,not allowed."},{"line_number":13,"context_line":"2.Add two volume backend with same \u0027volume_backend_name\u0027."},{"line_number":14,"context_line":"3.Allocated different AZ for different backend. After that,restart the"},{"line_number":15,"context_line":"cinder volume service."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7f231b9d_ed31065c","line":12,"range":{"start_line":11,"start_character":70,"end_line":12,"end_character":47},"updated":"2017-06-14 17:18:10.000000000","message":"volume migration between different AZ\u0027s will be allowed.","commit_id":"28a304fd8925ddeabe4ec198c682e5a95ede869d"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"4036d63afea1261cde4208dda1bb363e27d2f3e8","unresolved":false,"context_lines":[{"line_number":10,"context_line":"work.To solve this issue,the following procedue should be done:"},{"line_number":11,"context_line":"1.Add a new configuration item \u0027enable_across_az_migrate\u0027. If enabled it,"},{"line_number":12,"context_line":"migrate volume between different AZ is allowed. Otherwise,not allowed."},{"line_number":13,"context_line":"2.Add two volume backend with same \u0027volume_backend_name\u0027."},{"line_number":14,"context_line":"3.Allocated different AZ for different backend. After that,restart the"},{"line_number":15,"context_line":"cinder volume service."},{"line_number":16,"context_line":"4.Migrate volume to the different AZ."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7f231b9d_8d4052a7","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":2},"updated":"2017-06-14 17:18:10.000000000","message":"Space.","commit_id":"28a304fd8925ddeabe4ec198c682e5a95ede869d"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"4036d63afea1261cde4208dda1bb363e27d2f3e8","unresolved":false,"context_lines":[{"line_number":11,"context_line":"1.Add a new configuration item \u0027enable_across_az_migrate\u0027. If enabled it,"},{"line_number":12,"context_line":"migrate volume between different AZ is allowed. Otherwise,not allowed."},{"line_number":13,"context_line":"2.Add two volume backend with same \u0027volume_backend_name\u0027."},{"line_number":14,"context_line":"3.Allocated different AZ for different backend. After that,restart the"},{"line_number":15,"context_line":"cinder volume service."},{"line_number":16,"context_line":"4.Migrate volume to the different AZ."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7f231b9d_0d1682a9","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":2},"updated":"2017-06-14 17:18:10.000000000","message":"Space here too.","commit_id":"28a304fd8925ddeabe4ec198c682e5a95ede869d"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"4036d63afea1261cde4208dda1bb363e27d2f3e8","unresolved":false,"context_lines":[{"line_number":11,"context_line":"1.Add a new configuration item \u0027enable_across_az_migrate\u0027. If enabled it,"},{"line_number":12,"context_line":"migrate volume between different AZ is allowed. Otherwise,not allowed."},{"line_number":13,"context_line":"2.Add two volume backend with same \u0027volume_backend_name\u0027."},{"line_number":14,"context_line":"3.Allocated different AZ for different backend. After that,restart the"},{"line_number":15,"context_line":"cinder volume service."},{"line_number":16,"context_line":"4.Migrate volume to the different AZ."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7f231b9d_ad10aea9","line":14,"range":{"start_line":14,"start_character":57,"end_line":14,"end_character":60},"updated":"2017-06-14 17:18:10.000000000","message":"Space here.","commit_id":"28a304fd8925ddeabe4ec198c682e5a95ede869d"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"4036d63afea1261cde4208dda1bb363e27d2f3e8","unresolved":false,"context_lines":[{"line_number":13,"context_line":"2.Add two volume backend with same \u0027volume_backend_name\u0027."},{"line_number":14,"context_line":"3.Allocated different AZ for different backend. After that,restart the"},{"line_number":15,"context_line":"cinder volume service."},{"line_number":16,"context_line":"4.Migrate volume to the different AZ."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Closes-Bug: #1550353"},{"line_number":19,"context_line":"Change-Id: I444c2b50bcc3842a4f0fe3d74fbfaef89126fc83"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7f231b9d_2d1c9ebf","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":2},"updated":"2017-06-14 17:18:10.000000000","message":"Space here.","commit_id":"28a304fd8925ddeabe4ec198c682e5a95ede869d"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"2dc84a59c1d8ee8eb79192331c5ae428fd3968ca","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently volume migration bewteen different availability zones does not"},{"line_number":10,"context_line":"work. To solve this issue, the following procedue should be done:"},{"line_number":11,"context_line":"1. Add a new configuration item \u0027enable_across_az_migrate\u0027. If enabled"},{"line_number":12,"context_line":"volume migration between different AZ\u0027s will be allowed. Otherwise, not"},{"line_number":13,"context_line":"allowed."},{"line_number":14,"context_line":"2. Add two volume backend with same \u0027volume_backend_name\u0027."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"7f287b81_d65086d7","line":11,"range":{"start_line":11,"start_character":33,"end_line":11,"end_character":57},"updated":"2017-08-22 21:11:37.000000000","message":"\u0027enable_cross_az_migration\u0027","commit_id":"0e7792015163e93967c4cf02d20744143ba4fb13"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"2dc84a59c1d8ee8eb79192331c5ae428fd3968ca","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently volume migration bewteen different availability zones does not"},{"line_number":10,"context_line":"work. To solve this issue, the following procedue should be done:"},{"line_number":11,"context_line":"1. Add a new configuration item \u0027enable_across_az_migrate\u0027. If enabled"},{"line_number":12,"context_line":"volume migration between different AZ\u0027s will be allowed. Otherwise, not"},{"line_number":13,"context_line":"allowed."},{"line_number":14,"context_line":"2. Add two volume backend with same \u0027volume_backend_name\u0027."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"7f287b81_b683ba56","line":11,"updated":"2017-08-22 21:11:37.000000000","message":"Please add a blank line before this one.","commit_id":"0e7792015163e93967c4cf02d20744143ba4fb13"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"2dc84a59c1d8ee8eb79192331c5ae428fd3968ca","unresolved":false,"context_lines":[{"line_number":12,"context_line":"volume migration between different AZ\u0027s will be allowed. Otherwise, not"},{"line_number":13,"context_line":"allowed."},{"line_number":14,"context_line":"2. Add two volume backend with same \u0027volume_backend_name\u0027."},{"line_number":15,"context_line":"3. Allocated different AZ for different backend. After that, restart the"},{"line_number":16,"context_line":"cinder volume service."},{"line_number":17,"context_line":"4. Migrate volume to the different AZ."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"7f287b81_56f7f6f6","line":15,"range":{"start_line":15,"start_character":4,"end_line":15,"end_character":11},"updated":"2017-08-22 21:11:37.000000000","message":"Allocate a different AZ for each different backend.","commit_id":"0e7792015163e93967c4cf02d20744143ba4fb13"}],"cinder/volume/api.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"21f9133ca3112568ca3441871da5d6c9934b154b","unresolved":false,"context_lines":[{"line_number":75,"context_line":"                               help\u003d\u0027Cache volume availability zones in \u0027"},{"line_number":76,"context_line":"                                    \u0027memory for the provided duration in \u0027"},{"line_number":77,"context_line":"                                    \u0027seconds\u0027)"},{"line_number":78,"context_line":"enable_across_az_opt \u003d cfg.BoolOpt(\u0027enable_across_az_migrate\u0027,"},{"line_number":79,"context_line":"                                   default\u003dTrue,"},{"line_number":80,"context_line":"                                   help\u003d\u0027Enable that the volumes migrate\u0027"},{"line_number":81,"context_line":"                                        \u0027between different AZ\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_442244a6","line":78,"range":{"start_line":78,"start_character":43,"end_line":78,"end_character":49},"updated":"2017-05-19 14:15:31.000000000","message":"I think cross would be better than across in this context.","commit_id":"75106a4387fb74a473ad5ed3d1bec8f04aa40969"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"21f9133ca3112568ca3441871da5d6c9934b154b","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                                    \u0027seconds\u0027)"},{"line_number":78,"context_line":"enable_across_az_opt \u003d cfg.BoolOpt(\u0027enable_across_az_migrate\u0027,"},{"line_number":79,"context_line":"                                   default\u003dTrue,"},{"line_number":80,"context_line":"                                   help\u003d\u0027Enable that the volumes migrate\u0027"},{"line_number":81,"context_line":"                                        \u0027between different AZ\u0027)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_e40dd835","line":80,"range":{"start_line":80,"start_character":72,"end_line":80,"end_character":73},"updated":"2017-05-19 14:15:31.000000000","message":"Space needed at the end so the next line doesn\u0027t run together into \"migratebetween\".","commit_id":"75106a4387fb74a473ad5ed3d1bec8f04aa40969"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"a23aeb7eade765528f9c796669c461582b91fab0","unresolved":false,"context_lines":[{"line_number":1451,"context_line":"                                                       volume.volume_type_id)"},{"line_number":1452,"context_line":"        migrate_availability_zone \u003d {\u0027availability_zone\u0027:"},{"line_number":1453,"context_line":"                                     dest_availability_zone}"},{"line_number":1454,"context_line":"        if dest_availability_zone and CONF.enable_across_az_migrate:"},{"line_number":1455,"context_line":"            volume.update(migrate_availability_zone)"},{"line_number":1456,"context_line":""},{"line_number":1457,"context_line":"        request_spec \u003d {\u0027volume_properties\u0027: volume,"},{"line_number":1458,"context_line":"                        \u0027volume_type\u0027: volume_type,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_e795a534","line":1455,"range":{"start_line":1454,"start_character":0,"end_line":1455,"end_character":52},"updated":"2017-05-22 15:53:45.000000000","message":"So, there seems to be a hole here that if the dest_availability_zone is set but the configuration isn\u0027t set it is just going to silently go on.  I think, at a minimum we should do a LOG.warning explaining that an AZ was requested but the config option isn\u0027t set.","commit_id":"75106a4387fb74a473ad5ed3d1bec8f04aa40969"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"c22d2a3c3faf9aa0395c94355d4ac45d5b0e51e2","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                                    \u0027seconds\u0027)"},{"line_number":78,"context_line":"enable_cross_az_opt \u003d cfg.BoolOpt(\u0027enable_cross_az_migrate\u0027,"},{"line_number":79,"context_line":"                                   default\u003dTrue,"},{"line_number":80,"context_line":"                                   help\u003d\u0027Enable that the volumes migrate \u0027"},{"line_number":81,"context_line":"                                        \u0027between different AZ\u0027)"},{"line_number":82,"context_line":"CONF \u003d cfg.CONF"},{"line_number":83,"context_line":"CONF.register_opt(allow_force_upload_opt)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f231b9d_4dd8fa1c","line":80,"range":{"start_line":80,"start_character":41,"end_line":80,"end_character":73},"updated":"2017-06-14 17:12:50.000000000","message":"Enable volume migration","commit_id":"28a304fd8925ddeabe4ec198c682e5a95ede869d"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"4036d63afea1261cde4208dda1bb363e27d2f3e8","unresolved":false,"context_lines":[{"line_number":1455,"context_line":"            if CONF.enable_cross_az_migrate:"},{"line_number":1456,"context_line":"                volume.update(migrate_availability_zone)"},{"line_number":1457,"context_line":"            else:"},{"line_number":1458,"context_line":"                msg \u003d _(\u0027It seems the volume intend to migrate to another AZ,\u0027"},{"line_number":1459,"context_line":"                        \u0027but the configuration enable_cross_az_migrate is not \u0027"},{"line_number":1460,"context_line":"                        \u0027enabled.\u0027)"},{"line_number":1461,"context_line":"                LOG.warning(msg)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f231b9d_add30ed5","line":1458,"range":{"start_line":1458,"start_character":75,"end_line":1458,"end_character":78},"updated":"2017-06-14 17:18:10.000000000","message":"Need space at end here.","commit_id":"28a304fd8925ddeabe4ec198c682e5a95ede869d"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"c22d2a3c3faf9aa0395c94355d4ac45d5b0e51e2","unresolved":false,"context_lines":[{"line_number":1455,"context_line":"            if CONF.enable_cross_az_migrate:"},{"line_number":1456,"context_line":"                volume.update(migrate_availability_zone)"},{"line_number":1457,"context_line":"            else:"},{"line_number":1458,"context_line":"                msg \u003d _(\u0027It seems the volume intend to migrate to another AZ,\u0027"},{"line_number":1459,"context_line":"                        \u0027but the configuration enable_cross_az_migrate is not \u0027"},{"line_number":1460,"context_line":"                        \u0027enabled.\u0027)"},{"line_number":1461,"context_line":"                LOG.warning(msg)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f231b9d_8dfbb277","line":1458,"range":{"start_line":1458,"start_character":22,"end_line":1458,"end_character":23},"updated":"2017-06-14 17:12:50.000000000","message":"Should not use translation for log only strings.","commit_id":"28a304fd8925ddeabe4ec198c682e5a95ede869d"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"2dc84a59c1d8ee8eb79192331c5ae428fd3968ca","unresolved":false,"context_lines":[{"line_number":75,"context_line":"                               help\u003d\u0027Cache volume availability zones in \u0027"},{"line_number":76,"context_line":"                                    \u0027memory for the provided duration in \u0027"},{"line_number":77,"context_line":"                                    \u0027seconds\u0027)"},{"line_number":78,"context_line":"enable_cross_az_opt \u003d cfg.BoolOpt(\u0027enable_cross_az_migrate\u0027,"},{"line_number":79,"context_line":"                                  default\u003dTrue,"},{"line_number":80,"context_line":"                                  help\u003d\u0027Enable volume migration \u0027"},{"line_number":81,"context_line":"                                       \u0027between different AZ\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7f287b81_d6e2c62f","line":78,"range":{"start_line":78,"start_character":51,"end_line":78,"end_character":58},"updated":"2017-08-22 21:11:37.000000000","message":"I think we should call this \u0027enable_cross_az_migration\u0027 Then the other places where it is used will need to be updated.","commit_id":"0e7792015163e93967c4cf02d20744143ba4fb13"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"2dc84a59c1d8ee8eb79192331c5ae428fd3968ca","unresolved":false,"context_lines":[{"line_number":1455,"context_line":"            if CONF.enable_cross_az_migrate:"},{"line_number":1456,"context_line":"                volume.update(migrate_availability_zone)"},{"line_number":1457,"context_line":"            else:"},{"line_number":1458,"context_line":"                LOG.warning(\u0027It seems the volume intend to migrate to another \u0027"},{"line_number":1459,"context_line":"                            \u0027AZ, but the configuration \u0027"},{"line_number":1460,"context_line":"                            \u0027enable_cross_az_migrate is not enabled.\u0027)"},{"line_number":1461,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7f287b81_b6361ab4","line":1458,"range":{"start_line":1458,"start_character":49,"end_line":1458,"end_character":66},"updated":"2017-08-22 21:11:37.000000000","message":"is to be migrated","commit_id":"0e7792015163e93967c4cf02d20744143ba4fb13"}]}
