)]}'
{"cinder/volume/drivers/ibm/gpfs.py":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"a4cf1926377fe152c5e8a097d1ac6309b2dd1313","unresolved":false,"context_lines":[{"line_number":1242,"context_line":""},{"line_number":1243,"context_line":"    def update_consistencygroup(self, context, group,"},{"line_number":1244,"context_line":"                                add_volumes\u003dNone, remove_volumes\u003dNone):"},{"line_number":1245,"context_line":"        msg \u003d _(\u0027Driver does not support updating consistencygroup.\u0027)"},{"line_number":1246,"context_line":"        LOG.error(msg)"},{"line_number":1247,"context_line":"        raise exception.VolumeBackendAPIException(data\u003dmsg)"},{"line_number":1248,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_d27256ad","line":1245,"range":{"start_line":1245,"start_character":17,"end_line":1245,"end_character":23},"updated":"2017-05-22 21:59:43.000000000","message":"Since this is specific to GPFS I would say \u0027GPFS driver does not support updating consistencygroups.\u0027","commit_id":"192f1950c28bd4fe8812394ac2bf9cae3d0180aa"},{"author":{"_account_id":9207,"name":"Gaurang Tapase","email":"gtapase@ddn.com","username":"gaurang.tapase"},"change_message_id":"0775f30d087735c01cab6553a6a4e7b7b8cdab6e","unresolved":false,"context_lines":[{"line_number":1242,"context_line":""},{"line_number":1243,"context_line":"    def update_consistencygroup(self, context, group,"},{"line_number":1244,"context_line":"                                add_volumes\u003dNone, remove_volumes\u003dNone):"},{"line_number":1245,"context_line":"        msg \u003d _(\u0027Driver does not support updating consistencygroup.\u0027)"},{"line_number":1246,"context_line":"        LOG.error(msg)"},{"line_number":1247,"context_line":"        raise exception.VolumeBackendAPIException(data\u003dmsg)"},{"line_number":1248,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_c423a955","line":1245,"range":{"start_line":1245,"start_character":17,"end_line":1245,"end_character":23},"in_reply_to":"ff0f0b1f_d27256ad","updated":"2017-05-23 05:39:13.000000000","message":"Done","commit_id":"192f1950c28bd4fe8812394ac2bf9cae3d0180aa"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"d3374eda18b56144baebfd2ab2338a963988167b","unresolved":false,"context_lines":[{"line_number":1244,"context_line":"                                add_volumes\u003dNone, remove_volumes\u003dNone):"},{"line_number":1245,"context_line":"        msg \u003d _(\u0027Driver does not support updating consistencygroup.\u0027)"},{"line_number":1246,"context_line":"        LOG.error(msg)"},{"line_number":1247,"context_line":"        raise exception.VolumeBackendAPIException(data\u003dmsg)"},{"line_number":1248,"context_line":""},{"line_number":1249,"context_line":"    def create_consistencygroup_from_src(self, context, group, volumes,"},{"line_number":1250,"context_line":"                                         cgsnapshot\u003dNone, snapshots\u003dNone,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_a27e6dac","line":1247,"range":{"start_line":1247,"start_character":7,"end_line":1247,"end_character":59},"updated":"2017-05-23 01:03:42.000000000","message":"It\u0027s better to use a more explicit exception here, \u0027DriverNotSuuport\u0027? The user message API will try to detect and classify the expections at the upper layer.[1]\n\nAlso I reckon we can log the driver name here, becuase it only appear in the file.\n\n[1] https://review.openstack.org/#/c/448384/","commit_id":"192f1950c28bd4fe8812394ac2bf9cae3d0180aa"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"a3e71aa56e388d7d49d42747d6b0002f09c2f323","unresolved":false,"context_lines":[{"line_number":1244,"context_line":"                                add_volumes\u003dNone, remove_volumes\u003dNone):"},{"line_number":1245,"context_line":"        msg \u003d _(\u0027Driver does not support updating consistencygroup.\u0027)"},{"line_number":1246,"context_line":"        LOG.error(msg)"},{"line_number":1247,"context_line":"        raise exception.VolumeBackendAPIException(data\u003dmsg)"},{"line_number":1248,"context_line":""},{"line_number":1249,"context_line":"    def create_consistencygroup_from_src(self, context, group, volumes,"},{"line_number":1250,"context_line":"                                         cgsnapshot\u003dNone, snapshots\u003dNone,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_cce99db7","line":1247,"updated":"2017-05-22 20:59:48.000000000","message":"These would be a good candidate for the new message_api we have in place to help inform users what actually went wrong here.\n\nTake a look at this diff I just created.\n\nhttps://hastebin.com/iqijaqecok\n\nHere is an example usage of it.\n\nhttps://github.com/openstack/cinder/blob/master/cinder/volume/manager.py#L1052-L1055","commit_id":"192f1950c28bd4fe8812394ac2bf9cae3d0180aa"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"a4cf1926377fe152c5e8a097d1ac6309b2dd1313","unresolved":false,"context_lines":[{"line_number":1244,"context_line":"                                add_volumes\u003dNone, remove_volumes\u003dNone):"},{"line_number":1245,"context_line":"        msg \u003d _(\u0027Driver does not support updating consistencygroup.\u0027)"},{"line_number":1246,"context_line":"        LOG.error(msg)"},{"line_number":1247,"context_line":"        raise exception.VolumeBackendAPIException(data\u003dmsg)"},{"line_number":1248,"context_line":""},{"line_number":1249,"context_line":"    def create_consistencygroup_from_src(self, context, group, volumes,"},{"line_number":1250,"context_line":"                                         cgsnapshot\u003dNone, snapshots\u003dNone,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_329d12bc","line":1247,"in_reply_to":"ff0f0b1f_cce99db7","updated":"2017-05-22 21:59:43.000000000","message":"Agree with Walt that this would be a good improvement.","commit_id":"192f1950c28bd4fe8812394ac2bf9cae3d0180aa"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"a4cf1926377fe152c5e8a097d1ac6309b2dd1313","unresolved":false,"context_lines":[{"line_number":1249,"context_line":"    def create_consistencygroup_from_src(self, context, group, volumes,"},{"line_number":1250,"context_line":"                                         cgsnapshot\u003dNone, snapshots\u003dNone,"},{"line_number":1251,"context_line":"                                         source_cg\u003dNone, source_vols\u003dNone):"},{"line_number":1252,"context_line":"        msg \u003d _(\u0027Driver does not support creating consistency group from \u0027"},{"line_number":1253,"context_line":"                \u0027any source CG or CG Snapshot.\u0027)"},{"line_number":1254,"context_line":"        LOG.error(msg)"},{"line_number":1255,"context_line":"        raise exception.VolumeBackendAPIException(data\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_72614ad3","line":1252,"range":{"start_line":1252,"start_character":17,"end_line":1252,"end_character":23},"updated":"2017-05-22 21:59:43.000000000","message":"Same comment here.","commit_id":"192f1950c28bd4fe8812394ac2bf9cae3d0180aa"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"d3374eda18b56144baebfd2ab2338a963988167b","unresolved":false,"context_lines":[{"line_number":1249,"context_line":"    def create_consistencygroup_from_src(self, context, group, volumes,"},{"line_number":1250,"context_line":"                                         cgsnapshot\u003dNone, snapshots\u003dNone,"},{"line_number":1251,"context_line":"                                         source_cg\u003dNone, source_vols\u003dNone):"},{"line_number":1252,"context_line":"        msg \u003d _(\u0027Driver does not support creating consistency group from \u0027"},{"line_number":1253,"context_line":"                \u0027any source CG or CG Snapshot.\u0027)"},{"line_number":1254,"context_line":"        LOG.error(msg)"},{"line_number":1255,"context_line":"        raise exception.VolumeBackendAPIException(data\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_827b69bc","line":1252,"range":{"start_line":1252,"start_character":17,"end_line":1252,"end_character":23},"in_reply_to":"ff0f0b1f_72614ad3","updated":"2017-05-23 01:03:42.000000000","message":"Ditto.","commit_id":"192f1950c28bd4fe8812394ac2bf9cae3d0180aa"},{"author":{"_account_id":9207,"name":"Gaurang Tapase","email":"gtapase@ddn.com","username":"gaurang.tapase"},"change_message_id":"0775f30d087735c01cab6553a6a4e7b7b8cdab6e","unresolved":false,"context_lines":[{"line_number":1249,"context_line":"    def create_consistencygroup_from_src(self, context, group, volumes,"},{"line_number":1250,"context_line":"                                         cgsnapshot\u003dNone, snapshots\u003dNone,"},{"line_number":1251,"context_line":"                                         source_cg\u003dNone, source_vols\u003dNone):"},{"line_number":1252,"context_line":"        msg \u003d _(\u0027Driver does not support creating consistency group from \u0027"},{"line_number":1253,"context_line":"                \u0027any source CG or CG Snapshot.\u0027)"},{"line_number":1254,"context_line":"        LOG.error(msg)"},{"line_number":1255,"context_line":"        raise exception.VolumeBackendAPIException(data\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_84193123","line":1252,"range":{"start_line":1252,"start_character":17,"end_line":1252,"end_character":23},"in_reply_to":"ff0f0b1f_827b69bc","updated":"2017-05-23 05:39:13.000000000","message":"Done","commit_id":"192f1950c28bd4fe8812394ac2bf9cae3d0180aa"}]}