)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"e6b1b6790f403be0ea5fd5999e2bb42c5c209449","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Now there is no way to clean the expired reservation."},{"line_number":10,"context_line":"This patch added a periodic task in cinder-scheduler to"},{"line_number":11,"context_line":"do the cleanup like Nova does."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Id792db968ed2fe8e01c64e24d99c9ebadc3232b7"},{"line_number":14,"context_line":"Closes-bug: #1693401"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ff0f0b1f_5c7ef8e3","line":12,"updated":"2017-05-25 12:50:53.000000000","message":"Need to add DocImpact here.","commit_id":"1965b50d341be745655e2b08ad6c0c972d9de20a"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"087569a3eeaa6ec0bb6991f8de08fca13424c99e","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Now there is no way to clean the expired reservation."},{"line_number":10,"context_line":"This patch added a periodic task in cinder-scheduler to"},{"line_number":11,"context_line":"do the cleanup like Nova does."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Id792db968ed2fe8e01c64e24d99c9ebadc3232b7"},{"line_number":14,"context_line":"Closes-bug: #1693401"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ff0f0b1f_8d8a1861","line":12,"in_reply_to":"ff0f0b1f_5c7ef8e3","updated":"2017-05-25 14:08:54.000000000","message":"What is the documentation impact?\n\nOh, maybe because there is a new config option? That should automically show up in table generation. Between that and the release note I think we are mostly covered. Only need a DocImpact tag here if there is any additional follow on work to add more information to the docs.","commit_id":"1965b50d341be745655e2b08ad6c0c972d9de20a"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"894f7299a365a94498cc8d936707796160fb0573","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Now there is no way to clean the expired reservation."},{"line_number":10,"context_line":"This patch added a periodic task in cinder-scheduler to"},{"line_number":11,"context_line":"do the cleanup like Nova does."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Id792db968ed2fe8e01c64e24d99c9ebadc3232b7"},{"line_number":14,"context_line":"Closes-bug: #1693401"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ff0f0b1f_da6445e8","line":12,"in_reply_to":"ff0f0b1f_8d8a1861","updated":"2017-05-25 14:59:14.000000000","message":"Yeah, it\u0027s really good to have a developer doc to describe Cinder\u0027s internal periodic task.","commit_id":"1965b50d341be745655e2b08ad6c0c972d9de20a"}],"cinder/quota.py":[{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"26ccc96ea911a5d0d9bf14caf3cf4e5a3979e846","unresolved":false,"context_lines":[{"line_number":64,"context_line":"               help\u003d\u0027Number of seconds until a reservation expires\u0027),"},{"line_number":65,"context_line":"    cfg.IntOpt(\u0027reservation_clean_interval\u0027,"},{"line_number":66,"context_line":"               default\u003d86400,"},{"line_number":67,"context_line":"               help\u003d\u0027interval between periodic task runs to clean expired \u0027"},{"line_number":68,"context_line":"                    \u0027reservation in seconds.\u0027),"},{"line_number":69,"context_line":"    cfg.IntOpt(\u0027until_refresh\u0027,"},{"line_number":70,"context_line":"               default\u003d0,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_f0e3b603","line":67,"range":{"start_line":67,"start_character":21,"end_line":67,"end_character":29},"updated":"2017-05-25 09:07:43.000000000","message":"Interval","commit_id":"3b824e388fee9cb143994310407eb06d1539aeff"},{"author":{"_account_id":20191,"name":"Dinesh Bhor","email":"bhordinesh07@gmail.com","username":"dineshbhor"},"change_message_id":"3682c95648ff8b5b1963e5ddbd904fbe95031993","unresolved":false,"context_lines":[{"line_number":63,"context_line":"               default\u003d86400,"},{"line_number":64,"context_line":"               help\u003d\u0027Number of seconds until a reservation expires\u0027),"},{"line_number":65,"context_line":"    cfg.IntOpt(\u0027reservation_clean_interval\u0027,"},{"line_number":66,"context_line":"               default\u003d86400,"},{"line_number":67,"context_line":"               help\u003d\u0027Interval between periodic task runs to clean expired \u0027"},{"line_number":68,"context_line":"                    \u0027reservation in seconds.\u0027),"},{"line_number":69,"context_line":"    cfg.IntOpt(\u0027until_refresh\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"df140735_7198b369","line":66,"range":{"start_line":66,"start_character":23,"end_line":66,"end_character":28},"updated":"2017-05-29 04:50:16.000000000","message":"I hope this is decided on the basis of some analysis/observation.","commit_id":"bdd8b866dd703fe6a2a998b697bfcc81489cbbf7"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"1d8f098020afce26bc1c5fe643ab7c824d761412","unresolved":false,"context_lines":[{"line_number":63,"context_line":"               default\u003d86400,"},{"line_number":64,"context_line":"               help\u003d\u0027Number of seconds until a reservation expires\u0027),"},{"line_number":65,"context_line":"    cfg.IntOpt(\u0027reservation_clean_interval\u0027,"},{"line_number":66,"context_line":"               default\u003d86400,"},{"line_number":67,"context_line":"               help\u003d\u0027Interval between periodic task runs to clean expired \u0027"},{"line_number":68,"context_line":"                    \u0027reservation in seconds.\u0027),"},{"line_number":69,"context_line":"    cfg.IntOpt(\u0027until_refresh\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"df140735_6684525f","line":66,"range":{"start_line":66,"start_character":23,"end_line":66,"end_character":28},"in_reply_to":"df140735_14fa6941","updated":"2017-05-30 14:20:54.000000000","message":"yeah, it\u0027s the same with \"reservation_expire\"","commit_id":"bdd8b866dd703fe6a2a998b697bfcc81489cbbf7"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"df8b7adf7598f2020648001e82596f4b562cbc98","unresolved":false,"context_lines":[{"line_number":63,"context_line":"               default\u003d86400,"},{"line_number":64,"context_line":"               help\u003d\u0027Number of seconds until a reservation expires\u0027),"},{"line_number":65,"context_line":"    cfg.IntOpt(\u0027reservation_clean_interval\u0027,"},{"line_number":66,"context_line":"               default\u003d86400,"},{"line_number":67,"context_line":"               help\u003d\u0027Interval between periodic task runs to clean expired \u0027"},{"line_number":68,"context_line":"                    \u0027reservation in seconds.\u0027),"},{"line_number":69,"context_line":"    cfg.IntOpt(\u0027until_refresh\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"df140735_14fa6941","line":66,"range":{"start_line":66,"start_character":23,"end_line":66,"end_character":28},"in_reply_to":"df140735_7198b369","updated":"2017-05-30 10:49:23.000000000","message":"-1: This looks like it\u0027s made to match reservation_expire, if that\u0027s the case we should use a reference to that variable here:\n\n default\u003d\u0027$reservation_expire\u0027,","commit_id":"bdd8b866dd703fe6a2a998b697bfcc81489cbbf7"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"df8b7adf7598f2020648001e82596f4b562cbc98","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    cfg.IntOpt(\u0027reservation_clean_interval\u0027,"},{"line_number":66,"context_line":"               default\u003d86400,"},{"line_number":67,"context_line":"               help\u003d\u0027Interval between periodic task runs to clean expired \u0027"},{"line_number":68,"context_line":"                    \u0027reservation in seconds.\u0027),"},{"line_number":69,"context_line":"    cfg.IntOpt(\u0027until_refresh\u0027,"},{"line_number":70,"context_line":"               default\u003d0,"},{"line_number":71,"context_line":"               help\u003d\u0027Count of reservations until usage is refreshed\u0027),"}],"source_content_type":"text/x-python","patch_set":3,"id":"df140735_3459ed59","line":68,"range":{"start_line":68,"start_character":21,"end_line":68,"end_character":32},"updated":"2017-05-30 10:49:23.000000000","message":"nit: reservations","commit_id":"bdd8b866dd703fe6a2a998b697bfcc81489cbbf7"}],"period-task-clean-reservation-0e0617a7905df923.yaml":[{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"26ccc96ea911a5d0d9bf14caf3cf4e5a3979e846","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  -  Added perodic task to clean expired reservation in"},{"line_number":4,"context_line":"     cinder scheduler. Added a configuration option"},{"line_number":5,"context_line":"     ``reservation_clean_interval`` to handle the interval."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ff0f0b1f_70d8c651","line":3,"range":{"start_line":3,"start_character":11,"end_line":3,"end_character":18},"updated":"2017-05-25 09:07:43.000000000","message":"periodic","commit_id":"3b824e388fee9cb143994310407eb06d1539aeff"}]}