)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"16b09a0dc717dbe26656a12d719dbbc6853a15b3","unresolved":false,"context_lines":[{"line_number":10,"context_line":"if there are still existing groups with this"},{"line_number":11,"context_line":"group type."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"APIImpact"},{"line_number":14,"context_line":"Change-Id: Ide2ac7c42f234ac6f2b993bf15bad871665ef9b3"},{"line_number":15,"context_line":"Closes-Bug: #1692827"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ff0f0b1f_0d7f2866","line":13,"updated":"2017-05-25 14:06:47.000000000","message":"I wouldn\u0027t consider this an API impact. There is no API change. There is a slight behavior change since before a call that would work will now fail, but that never should have worked in the first place and was not something anyone should have expected as the desired behavior. This is just a bug fix for that, so I think this should be removed.","commit_id":"73ffe46db1170206a4b6133838a384317a9ca461"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"967c952fbaf1dd2368a51cbd2493f61c96f7b7c8","unresolved":false,"context_lines":[{"line_number":10,"context_line":"if there are still existing groups with this"},{"line_number":11,"context_line":"group type."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"APIImpact"},{"line_number":14,"context_line":"Change-Id: Ide2ac7c42f234ac6f2b993bf15bad871665ef9b3"},{"line_number":15,"context_line":"Closes-Bug: #1692827"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ff0f0b1f_e8dce2e4","line":13,"in_reply_to":"ff0f0b1f_0d7f2866","updated":"2017-05-25 14:57:01.000000000","message":"I was confused how this was added as I don\u0027t remember adding it.  It looks like Ivan modified the commit message and added this one:).","commit_id":"73ffe46db1170206a4b6133838a384317a9ca461"}],"cinder/tests/unit/api/v3/test_group_types.py":[{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"e910f7b91a011a88631c4bfb4b53952574f48b2e","unresolved":false,"context_lines":[{"line_number":92,"context_line":"def return_group_types_with_groups_destroy(context, id):"},{"line_number":93,"context_line":"    if id \u003d\u003d IN_USE_GROUP_TYPE:"},{"line_number":94,"context_line":"        raise exception.GroupTypeInUse(group_type_id\u003did)"},{"line_number":95,"context_line":"    pass"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"@ddt.ddt"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff0f0b1f_365b66f6","line":95,"range":{"start_line":95,"start_character":4,"end_line":95,"end_character":8},"updated":"2017-05-25 09:45:32.000000000","message":"Do we need this?","commit_id":"73ffe46db1170206a4b6133838a384317a9ca461"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"967c952fbaf1dd2368a51cbd2493f61c96f7b7c8","unresolved":false,"context_lines":[{"line_number":92,"context_line":"def return_group_types_with_groups_destroy(context, id):"},{"line_number":93,"context_line":"    if id \u003d\u003d IN_USE_GROUP_TYPE:"},{"line_number":94,"context_line":"        raise exception.GroupTypeInUse(group_type_id\u003did)"},{"line_number":95,"context_line":"    pass"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"@ddt.ddt"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff0f0b1f_5a2b9581","line":95,"range":{"start_line":95,"start_character":4,"end_line":95,"end_character":8},"in_reply_to":"ff0f0b1f_2d554cfa","updated":"2017-05-25 14:57:01.000000000","message":"Done","commit_id":"73ffe46db1170206a4b6133838a384317a9ca461"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"16b09a0dc717dbe26656a12d719dbbc6853a15b3","unresolved":false,"context_lines":[{"line_number":92,"context_line":"def return_group_types_with_groups_destroy(context, id):"},{"line_number":93,"context_line":"    if id \u003d\u003d IN_USE_GROUP_TYPE:"},{"line_number":94,"context_line":"        raise exception.GroupTypeInUse(group_type_id\u003did)"},{"line_number":95,"context_line":"    pass"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"@ddt.ddt"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff0f0b1f_2d554cfa","line":95,"range":{"start_line":95,"start_character":4,"end_line":95,"end_character":8},"in_reply_to":"ff0f0b1f_365b66f6","updated":"2017-05-25 14:06:47.000000000","message":"Right, this can be removed.","commit_id":"73ffe46db1170206a4b6133838a384317a9ca461"}],"cinder/volume/group_types.py":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"f066ff83a39cfb1c4fe06f4d92c468632b2ab293","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        try:"},{"line_number":81,"context_line":"            db.group_type_destroy(elevated, id)"},{"line_number":82,"context_line":"        except exception.GroupTypeInUse as e:"},{"line_number":83,"context_line":"            msg \u003d _(\u0027Target group type is still in use. %s\u0027) % six.text_type(e)"},{"line_number":84,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ff0f0b1f_6d30e49f","line":83,"range":{"start_line":83,"start_character":21,"end_line":83,"end_character":58},"updated":"2017-05-25 14:16:25.000000000","message":"Is there any reason we couldn\u0027t also include the target group info here?","commit_id":"73ffe46db1170206a4b6133838a384317a9ca461"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"967c952fbaf1dd2368a51cbd2493f61c96f7b7c8","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        try:"},{"line_number":81,"context_line":"            db.group_type_destroy(elevated, id)"},{"line_number":82,"context_line":"        except exception.GroupTypeInUse as e:"},{"line_number":83,"context_line":"            msg \u003d _(\u0027Target group type is still in use. %s\u0027) % six.text_type(e)"},{"line_number":84,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ff0f0b1f_a8902aee","line":83,"range":{"start_line":83,"start_character":21,"end_line":83,"end_character":58},"in_reply_to":"ff0f0b1f_6d30e49f","updated":"2017-05-25 14:57:01.000000000","message":"There could be multiple groups still using this group type.  I\u0027ll have to query the db to get that list and it could be a long list.  It seems too much for this kind of message.  The similar message for VolumeTypeInUse doesn\u0027t print out all the volumes either.","commit_id":"73ffe46db1170206a4b6133838a384317a9ca461"}]}