)]}'
{"api-ref/source/v2/samples/encryption-type-update-request.json":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"6323ee87dc4cbc522fa287fe8dbf13c4dc4d3cd8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"encryption\":{"},{"line_number":3,"context_line":"        \"key_size\": 64,"},{"line_number":4,"context_line":"        \"provider\": \"castellan.key_manager.barbican_key_manager.BarbicanKeyManager\","},{"line_number":5,"context_line":"        \"control_location\":\"back-end\""},{"line_number":6,"context_line":"    }"},{"line_number":7,"context_line":"}"}],"source_content_type":"application/json","patch_set":9,"id":"ff346bd7_a17bd678","line":4,"updated":"2017-07-27 17:51:28.000000000","message":"This is not a correct \"provider\" value (neither was the previous value).\n\nThis should be something like \"nova.volume.encryptors.luks.LuksEncryptor\"","commit_id":"2e8c3241b40ab63fe0aa17124985023f5532300d"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"2ed7f551cb5c62f6ab49c7a282f17ef38a5bc8cb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"encryption\":{"},{"line_number":3,"context_line":"        \"key_size\": 64,"},{"line_number":4,"context_line":"        \"provider\": \"nova.volume.encryptors.luks.LuksEncryptor\","},{"line_number":5,"context_line":"        \"control_location\":\"back-end\""},{"line_number":6,"context_line":"    }"},{"line_number":7,"context_line":"}"}],"source_content_type":"application/json","patch_set":13,"id":"7f515b1d_13c3485f","line":4,"updated":"2017-09-27 15:11:55.000000000","message":"Same as comment on v3.","commit_id":"95022f1d7b31e5dc7430198e20bb2f2908d84cb6"}],"api-ref/source/v3/samples/encryption-type-update-request.json":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"2ed7f551cb5c62f6ab49c7a282f17ef38a5bc8cb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"encryption\":{"},{"line_number":3,"context_line":"        \"key_size\": 64,"},{"line_number":4,"context_line":"        \"provider\": \"nova.volume.encryptors.luks.LuksEncryptor\","},{"line_number":5,"context_line":"        \"control_location\":\"back-end\""},{"line_number":6,"context_line":"    }"},{"line_number":7,"context_line":"}"}],"source_content_type":"application/json","patch_set":16,"id":"7f515b1d_d3adb09b","line":4,"updated":"2017-09-27 15:11:55.000000000","message":"This should align with the pending changes here:\n\nhttps://review.openstack.org/#/c/451931/","commit_id":"f92e3d258ba4042cfdf19973f60682b1aaa4141f"},{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"2419df24999584322d81868c9f23a5dee8cb854c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"encryption\":{"},{"line_number":3,"context_line":"        \"key_size\": 64,"},{"line_number":4,"context_line":"        \"provider\": \"nova.volume.encryptors.luks.LuksEncryptor\","},{"line_number":5,"context_line":"        \"control_location\":\"back-end\""},{"line_number":6,"context_line":"    }"},{"line_number":7,"context_line":"}"}],"source_content_type":"application/json","patch_set":16,"id":"7f515b1d_a461c5d5","line":4,"in_reply_to":"7f515b1d_2bcfe829","updated":"2017-09-27 17:53:52.000000000","message":"I removed the json changes in the next patchset and opened up a new merge request to handle the updates to the sample json files: https://review.openstack.org/#/c/507940/1\n\nThe changes to the sample json files are unrelated to the key manager deprecation work anyway.","commit_id":"f92e3d258ba4042cfdf19973f60682b1aaa4141f"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"978e66cba8cce5fdc7b028541b0a75128873e8f7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"encryption\":{"},{"line_number":3,"context_line":"        \"key_size\": 64,"},{"line_number":4,"context_line":"        \"provider\": \"nova.volume.encryptors.luks.LuksEncryptor\","},{"line_number":5,"context_line":"        \"control_location\":\"back-end\""},{"line_number":6,"context_line":"    }"},{"line_number":7,"context_line":"}"}],"source_content_type":"application/json","patch_set":16,"id":"7f515b1d_9206d651","line":4,"in_reply_to":"7f515b1d_2bcfe829","updated":"2017-09-29 18:41:15.000000000","message":"The new values work regardless of whether that patch merges or not.","commit_id":"f92e3d258ba4042cfdf19973f60682b1aaa4141f"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"b5cb90e9d537b86edd392e0076467848ae5f33a1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"encryption\":{"},{"line_number":3,"context_line":"        \"key_size\": 64,"},{"line_number":4,"context_line":"        \"provider\": \"nova.volume.encryptors.luks.LuksEncryptor\","},{"line_number":5,"context_line":"        \"control_location\":\"back-end\""},{"line_number":6,"context_line":"    }"},{"line_number":7,"context_line":"}"}],"source_content_type":"application/json","patch_set":16,"id":"7f515b1d_2bcfe829","line":4,"in_reply_to":"7f515b1d_d3adb09b","updated":"2017-09-27 16:46:23.000000000","message":"That patch is still marked DNM. Not sure we should wait for that.","commit_id":"f92e3d258ba4042cfdf19973f60682b1aaa4141f"}],"cinder/backup/driver.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"653292d40188e7da20a60368e12f274488504c8d","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    def __init__(self, context, db\u003dNone):"},{"line_number":58,"context_line":"        super(BackupMetadataAPI, self).__init__(db)"},{"line_number":59,"context_line":"        self.context \u003d context"},{"line_number":60,"context_line":"        self.key_manager \u003d key_manager.API(CONF)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    @staticmethod"},{"line_number":63,"context_line":"    def _is_serializable(value):"}],"source_content_type":"text/x-python","patch_set":13,"id":"7f515b1d_1bb713f9","line":60,"updated":"2017-09-26 09:41:35.000000000","message":"-1: This will always create the key_manager, we should use a property like we do in volume_actions.py or leave it on L92 like we had it before","commit_id":"95022f1d7b31e5dc7430198e20bb2f2908d84cb6"}],"cinder/keymgr/__init__.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"193f0ddcc2b143bae611936cc04eaee4a0f3394f","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from castellan import options as castellan_opts"},{"line_number":17,"context_line":"from oslo_config import cfg"},{"line_number":18,"context_line":"from oslo_log import log as logging"},{"line_number":19,"context_line":"from oslo_utils import importutils"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"7f515b1d_7b8e6328","line":19,"updated":"2017-09-21 23:07:49.000000000","message":"This import is no longer used.","commit_id":"2f30f3307e0cf96dac21201ed1cb45b994dddcd8"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"653292d40188e7da20a60368e12f274488504c8d","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from castellan import options as castellan_opts"},{"line_number":17,"context_line":"from oslo_config import cfg"},{"line_number":18,"context_line":"from oslo_log import log as logging"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"CONF \u003d cfg.CONF"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"7f515b1d_9b9f835e","line":20,"range":{"start_line":18,"start_character":0,"end_line":20,"end_character":33},"updated":"2017-09-26 09:41:35.000000000","message":"nit: These don\u0027t seem to be necessary...","commit_id":"95022f1d7b31e5dc7430198e20bb2f2908d84cb6"},{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"a6f5d8c7c68d08f62077b0b1717c2368b8eda91f","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from castellan import options as castellan_opts"},{"line_number":17,"context_line":"from oslo_config import cfg"},{"line_number":18,"context_line":"from oslo_log import log as logging"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"CONF \u003d cfg.CONF"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"7f515b1d_7eca6a6d","line":20,"range":{"start_line":18,"start_character":0,"end_line":20,"end_character":33},"in_reply_to":"7f515b1d_9b9f835e","updated":"2017-09-26 15:56:45.000000000","message":"Done","commit_id":"95022f1d7b31e5dc7430198e20bb2f2908d84cb6"}],"cinder/tests/unit/conf_fixture.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"653292d40188e7da20a60368e12f274488504c8d","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    conf.set_default(\u0027backend\u0027,"},{"line_number":49,"context_line":"                     \u0027cinder.keymgr.conf_key_mgr.ConfKeyManager\u0027,"},{"line_number":50,"context_line":"                     group\u003d\u0027key_manager\u0027)"},{"line_number":51,"context_line":"    conf.set_default(\u0027fixed_key\u0027, default\u003d\u00270\u0027 * 64, group\u003d\u0027key_manager\u0027)"},{"line_number":52,"context_line":"    conf.set_default(\u0027scheduler_driver\u0027,"},{"line_number":53,"context_line":"                     \u0027cinder.scheduler.filter_scheduler.FilterScheduler\u0027)"},{"line_number":54,"context_line":"    conf.set_default(\u0027state_path\u0027, os.path.abspath("}],"source_content_type":"text/x-python","patch_set":13,"id":"7f515b1d_9bdb031a","side":"PARENT","line":51,"updated":"2017-09-26 09:41:35.000000000","message":"?: Shouldn\u0027t we also be somehow testing cinder\u0027s ConfKeyManager since we haven\u0027t actually removed it?","commit_id":"a0f8690b870a27f76e24b8be22dd01c038d6cd97"},{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"a6f5d8c7c68d08f62077b0b1717c2368b8eda91f","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    conf.set_default(\u0027backend\u0027,"},{"line_number":49,"context_line":"                     \u0027cinder.keymgr.conf_key_mgr.ConfKeyManager\u0027,"},{"line_number":50,"context_line":"                     group\u003d\u0027key_manager\u0027)"},{"line_number":51,"context_line":"    conf.set_default(\u0027fixed_key\u0027, default\u003d\u00270\u0027 * 64, group\u003d\u0027key_manager\u0027)"},{"line_number":52,"context_line":"    conf.set_default(\u0027scheduler_driver\u0027,"},{"line_number":53,"context_line":"                     \u0027cinder.scheduler.filter_scheduler.FilterScheduler\u0027)"},{"line_number":54,"context_line":"    conf.set_default(\u0027state_path\u0027, os.path.abspath("}],"source_content_type":"text/x-python","patch_set":13,"id":"7f515b1d_5e444eb7","side":"PARENT","line":51,"in_reply_to":"7f515b1d_9bdb031a","updated":"2017-09-26 15:56:45.000000000","message":"This change modifies the cinder unit tests to use the mock key manager instead of the conf key manager.  The mock key manager behaves more like barbican in that it returns different keys.  Ideally, it would be great if we could remove ConfKeyManager altogether and use Barbican in DevStack.","commit_id":"a0f8690b870a27f76e24b8be22dd01c038d6cd97"}],"releasenotes/notes/remove-deprecated-keymgr-d11a25c620862ed6.yaml":[{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"6e4e2eba54ff8f59d57a9830003ba74a46cc82f7","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    - Instead of ``api_class`` option ``cinder.keymgr.barbican.BarbicanKeyManager``,"},{"line_number":11,"context_line":"      use ``castellan.key_manager.barbican_key_manager.BarbicanKeyManager``"},{"line_number":12,"context_line":"    - Instead of ``api_class`` option ``cinder.tests.unit.keymgr.mock_key_mgr.MockKeyManager``,"},{"line_number":13,"context_line":"      use ``castellan.tests.unit.key_manager.mock_key_manager.MockKeyManager``"},{"line_number":14,"context_line":"    - ``cinder.keymgr.conf_key_mgr.ConfKeyManager`` still remains, but the ``fixed_key`` configuration options should be moved to the ``[key_manager]`` section"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5f201791_08702a72","line":12,"range":{"start_line":12,"start_character":40,"end_line":12,"end_character":92},"updated":"2017-06-20 20:18:41.000000000","message":"Is this an option?","commit_id":"57a315e01215d48cddafa246dce3a6b993b471a5"},{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"1b31bba20744349e9a58428d9bbe8ad754acd4a6","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    - Instead of ``api_class`` option ``cinder.keymgr.barbican.BarbicanKeyManager``,"},{"line_number":11,"context_line":"      use ``castellan.key_manager.barbican_key_manager.BarbicanKeyManager``"},{"line_number":12,"context_line":"    - Instead of ``api_class`` option ``cinder.tests.unit.keymgr.mock_key_mgr.MockKeyManager``,"},{"line_number":13,"context_line":"      use ``castellan.tests.unit.key_manager.mock_key_manager.MockKeyManager``"},{"line_number":14,"context_line":"    - ``cinder.keymgr.conf_key_mgr.ConfKeyManager`` still remains, but the ``fixed_key`` configuration options should be moved to the ``[key_manager]`` section"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5f201791_08ad2e9a","line":12,"range":{"start_line":12,"start_character":40,"end_line":12,"end_character":92},"in_reply_to":"5f201791_08702a72","updated":"2017-06-26 21:01:44.000000000","message":"Yes, it is an option, used for tests.","commit_id":"57a315e01215d48cddafa246dce3a6b993b471a5"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"6e4e2eba54ff8f59d57a9830003ba74a46cc82f7","unresolved":false,"context_lines":[{"line_number":11,"context_line":"      use ``castellan.key_manager.barbican_key_manager.BarbicanKeyManager``"},{"line_number":12,"context_line":"    - Instead of ``api_class`` option ``cinder.tests.unit.keymgr.mock_key_mgr.MockKeyManager``,"},{"line_number":13,"context_line":"      use ``castellan.tests.unit.key_manager.mock_key_manager.MockKeyManager``"},{"line_number":14,"context_line":"    - ``cinder.keymgr.conf_key_mgr.ConfKeyManager`` still remains, but the ``fixed_key`` configuration options should be moved to the ``[key_manager]`` section"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5f201791_a80496c7","line":14,"range":{"start_line":14,"start_character":103,"end_line":14,"end_character":110},"updated":"2017-06-20 20:18:41.000000000","message":"option","commit_id":"57a315e01215d48cddafa246dce3a6b993b471a5"},{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"1b31bba20744349e9a58428d9bbe8ad754acd4a6","unresolved":false,"context_lines":[{"line_number":11,"context_line":"      use ``castellan.key_manager.barbican_key_manager.BarbicanKeyManager``"},{"line_number":12,"context_line":"    - Instead of ``api_class`` option ``cinder.tests.unit.keymgr.mock_key_mgr.MockKeyManager``,"},{"line_number":13,"context_line":"      use ``castellan.tests.unit.key_manager.mock_key_manager.MockKeyManager``"},{"line_number":14,"context_line":"    - ``cinder.keymgr.conf_key_mgr.ConfKeyManager`` still remains, but the ``fixed_key`` configuration options should be moved to the ``[key_manager]`` section"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5f201791_88981e75","line":14,"range":{"start_line":14,"start_character":103,"end_line":14,"end_character":110},"in_reply_to":"5f201791_a80496c7","updated":"2017-06-26 21:01:44.000000000","message":"Done","commit_id":"57a315e01215d48cddafa246dce3a6b993b471a5"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"a4c795f7c9b42e02640fd66a6176384f4e4a3e8a","unresolved":false,"context_lines":[{"line_number":11,"context_line":"      use ``castellan.key_manager.barbican_key_manager.BarbicanKeyManager``"},{"line_number":12,"context_line":"    - Instead of ``api_class`` option ``cinder.tests.unit.keymgr.mock_key_mgr.MockKeyManager``,"},{"line_number":13,"context_line":"      use ``castellan.tests.unit.key_manager.mock_key_manager.MockKeyManager``"},{"line_number":14,"context_line":"    - ``cinder.keymgr.conf_key_mgr.ConfKeyManager`` still remains, but the ``fixed_key`` configuration options should be moved to the ``[key_manager]`` section"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":12,"id":"7f515b1d_4d83ea05","line":14,"updated":"2017-09-21 23:51:20.000000000","message":"This line needs to be wrapped please.","commit_id":"bac19ec35ce1b8469fa17596e9a5e0e5b78e3ec2"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"653292d40188e7da20a60368e12f274488504c8d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    The Castellan ``api_class`` options should also be used instead, as most"},{"line_number":8,"context_line":"    of the options that lived in Cinder have migrated to Castellan."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    - Instead of ``api_class`` option ``cinder.keymgr.barbican.BarbicanKeyManager``,"},{"line_number":11,"context_line":"      use ``castellan.key_manager.barbican_key_manager.BarbicanKeyManager``"},{"line_number":12,"context_line":"    - Instead of ``api_class`` option ``cinder.tests.unit.keymgr.mock_key_mgr.MockKeyManager``,"},{"line_number":13,"context_line":"      use ``castellan.tests.unit.key_manager.mock_key_manager.MockKeyManager``"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"7f515b1d_6629ca88","line":10,"range":{"start_line":10,"start_character":19,"end_line":10,"end_character":28},"updated":"2017-09-26 09:41:35.000000000","message":"-1: In castillan it seems to be called `backend` not `api_class` [1].\n\n[1] https://github.com/openstack/castellan/blob/8980bf7da55dd084ad84c84534fe937f0d43b9c0/castellan/key_manager/__init__.py#L24","commit_id":"95022f1d7b31e5dc7430198e20bb2f2908d84cb6"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"653292d40188e7da20a60368e12f274488504c8d","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    - Instead of ``api_class`` option ``cinder.keymgr.barbican.BarbicanKeyManager``,"},{"line_number":11,"context_line":"      use ``castellan.key_manager.barbican_key_manager.BarbicanKeyManager``"},{"line_number":12,"context_line":"    - Instead of ``api_class`` option ``cinder.tests.unit.keymgr.mock_key_mgr.MockKeyManager``,"},{"line_number":13,"context_line":"      use ``castellan.tests.unit.key_manager.mock_key_manager.MockKeyManager``"},{"line_number":14,"context_line":"    - ``cinder.keymgr.conf_key_mgr.ConfKeyManager`` still remains, but"},{"line_number":15,"context_line":"      the ``fixed_key`` configuration options should be moved to the ``[key_manager]`` section"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"7f515b1d_db897bca","line":13,"range":{"start_line":12,"start_character":0,"end_line":13,"end_character":78},"updated":"2017-09-26 09:41:35.000000000","message":"-1: The changes for testing are irrelevant in the upgrades, this should be removed.","commit_id":"95022f1d7b31e5dc7430198e20bb2f2908d84cb6"}]}