)]}'
{"cinder/tests/unit/volume/drivers/dell_emc/vnx/test_adapter.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"58489a78ba274b568ebbafe3fbc9ecfa67ba8466","unresolved":false,"context_lines":[{"line_number":1037,"context_line":"    @res_mock.patch_common_adapter"},{"line_number":1038,"context_line":"    def test_initialize_connection_snapshot(self, common_adapter, mocked_res,"},{"line_number":1039,"context_line":"                                            mocked_input):"},{"line_number":1040,"context_line":"        common_adapter.client.attach_snapshot \u003d mock.Mock()"},{"line_number":1041,"context_line":"        common_adapter._initialize_connection \u003d mock.Mock()"},{"line_number":1042,"context_line":""},{"line_number":1043,"context_line":"        snapshot \u003d mocked_input[\u0027snapshot\u0027]"},{"line_number":1044,"context_line":"        smp_name \u003d \u0027tmp-smp-\u0027 + snapshot.id"}],"source_content_type":"text/x-python","patch_set":2,"id":"df140735_6992bf4d","line":1041,"range":{"start_line":1040,"start_character":8,"end_line":1041,"end_character":59},"updated":"2017-05-31 15:00:27.000000000","message":"unrelated: These 2 lines are unnecessary","commit_id":"3e60d97981490646c514999748b81e6d7645ea2e"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"7e3f8dc54d80113b7c656260d4123f72fc4b4bb2","unresolved":false,"context_lines":[{"line_number":1037,"context_line":"    @res_mock.patch_common_adapter"},{"line_number":1038,"context_line":"    def test_initialize_connection_snapshot(self, common_adapter, mocked_res,"},{"line_number":1039,"context_line":"                                            mocked_input):"},{"line_number":1040,"context_line":"        common_adapter.client.attach_snapshot \u003d mock.Mock()"},{"line_number":1041,"context_line":"        common_adapter._initialize_connection \u003d mock.Mock()"},{"line_number":1042,"context_line":""},{"line_number":1043,"context_line":"        snapshot \u003d mocked_input[\u0027snapshot\u0027]"},{"line_number":1044,"context_line":"        smp_name \u003d \u0027tmp-smp-\u0027 + snapshot.id"}],"source_content_type":"text/x-python","patch_set":2,"id":"df140735_31d5121d","line":1041,"range":{"start_line":1040,"start_character":8,"end_line":1041,"end_character":59},"in_reply_to":"df140735_668d3b7a","updated":"2017-06-02 08:55:21.000000000","message":"OK, I somehow assumed you were actually mocking the adapter, and in that case it was not necessary to assign the mocks.  I\u0027m usually against assignment in favor of patching, but since this is old code it shouldn\u0027t be touched.","commit_id":"3e60d97981490646c514999748b81e6d7645ea2e"},{"author":{"_account_id":10628,"name":"Peter Wang","email":"peter.wang13@emc.com","username":"peter_wang"},"change_message_id":"36f0a4ad7aa7a77d9a18d71b700d9d6b7f9aa719","unresolved":false,"context_lines":[{"line_number":1037,"context_line":"    @res_mock.patch_common_adapter"},{"line_number":1038,"context_line":"    def test_initialize_connection_snapshot(self, common_adapter, mocked_res,"},{"line_number":1039,"context_line":"                                            mocked_input):"},{"line_number":1040,"context_line":"        common_adapter.client.attach_snapshot \u003d mock.Mock()"},{"line_number":1041,"context_line":"        common_adapter._initialize_connection \u003d mock.Mock()"},{"line_number":1042,"context_line":""},{"line_number":1043,"context_line":"        snapshot \u003d mocked_input[\u0027snapshot\u0027]"},{"line_number":1044,"context_line":"        smp_name \u003d \u0027tmp-smp-\u0027 + snapshot.id"}],"source_content_type":"text/x-python","patch_set":2,"id":"df140735_668d3b7a","line":1041,"range":{"start_line":1040,"start_character":8,"end_line":1041,"end_character":59},"in_reply_to":"df140735_6992bf4d","updated":"2017-06-02 08:15:35.000000000","message":"these methods have been tested in separate test cases,\nwe just mock this to avoid a lot of duplicate test data feeding(in the yaml file) here.","commit_id":"3e60d97981490646c514999748b81e6d7645ea2e"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"58489a78ba274b568ebbafe3fbc9ecfa67ba8466","unresolved":false,"context_lines":[{"line_number":1052,"context_line":"                             called_volume.vnx_lun_id))"},{"line_number":1053,"context_line":"        self.assertIsNone("},{"line_number":1054,"context_line":"            common_adapter._initialize_connection.call_args[0][1])"},{"line_number":1055,"context_line":"        self.assertIsNotNone(conn)"},{"line_number":1056,"context_line":""},{"line_number":1057,"context_line":"    @res_mock.mock_driver_input"},{"line_number":1058,"context_line":"    @res_mock.patch_common_adapter"}],"source_content_type":"text/x-python","patch_set":2,"id":"df140735_89b873c8","line":1055,"updated":"2017-05-31 15:00:27.000000000","message":"-1: We should check the actual value\n\n self.assertIs(common_adapter._initialize_connection, conn)","commit_id":"3e60d97981490646c514999748b81e6d7645ea2e"},{"author":{"_account_id":10628,"name":"Peter Wang","email":"peter.wang13@emc.com","username":"peter_wang"},"change_message_id":"36f0a4ad7aa7a77d9a18d71b700d9d6b7f9aa719","unresolved":false,"context_lines":[{"line_number":1052,"context_line":"                             called_volume.vnx_lun_id))"},{"line_number":1053,"context_line":"        self.assertIsNone("},{"line_number":1054,"context_line":"            common_adapter._initialize_connection.call_args[0][1])"},{"line_number":1055,"context_line":"        self.assertIsNotNone(conn)"},{"line_number":1056,"context_line":""},{"line_number":1057,"context_line":"    @res_mock.mock_driver_input"},{"line_number":1058,"context_line":"    @res_mock.patch_common_adapter"}],"source_content_type":"text/x-python","patch_set":2,"id":"df140735_06cd5fb7","line":1055,"in_reply_to":"df140735_89b873c8","updated":"2017-06-02 08:15:35.000000000","message":"Will update.","commit_id":"3e60d97981490646c514999748b81e6d7645ea2e"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"7300cf09eec07ab791912cacfd2a93fd50307d9e","unresolved":false,"context_lines":[{"line_number":1038,"context_line":"    def test_initialize_connection_snapshot(self, common_adapter, mocked_res,"},{"line_number":1039,"context_line":"                                            mocked_input):"},{"line_number":1040,"context_line":"        common_adapter.client.attach_snapshot \u003d mock.Mock()"},{"line_number":1041,"context_line":"        common_adapter._initialize_connection \u003d mock.Mock(return_value\u003d\u0027fake\u0027)"},{"line_number":1042,"context_line":""},{"line_number":1043,"context_line":"        snapshot \u003d mocked_input[\u0027snapshot\u0027]"},{"line_number":1044,"context_line":"        smp_name \u003d \u0027tmp-smp-\u0027 + snapshot.id"}],"source_content_type":"text/x-python","patch_set":3,"id":"df140735_20cff929","line":1041,"updated":"2017-06-02 09:47:32.000000000","message":"?: We don\u0027t really need this, as it will always return the same mock instance when called.","commit_id":"530259db85c3c8faba333381cb7927c0d9e21469"}]}