)]}'
{"cinder/volume/drivers/infinidat.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"021aa5a633a7610d265d44cec51ef8decd9ced4c","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        if (self.configuration.infinidat_use_compression and"},{"line_number":132,"context_line":"           not self._system.compat.has_compression()):"},{"line_number":133,"context_line":"            # InfiniBox systems support compression only from v3.0 and up"},{"line_number":134,"context_line":"            msg \u003d _(\u0027InfiniBox system does not support compression.\u0027)"},{"line_number":135,"context_line":"            raise exception.VolumeDriverException(message\u003dmsg)"},{"line_number":136,"context_line":"        LOG.debug(\u0027setup complete\u0027)"},{"line_number":137,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1f1a1f67_654a2881","line":134,"updated":"2017-07-12 15:21:07.000000000","message":"Please, change a message to something like\n\u0027InfiniBox system does not support compression. Please, change infinidat_use_compression to False in your Cinder config\u0027. This will allow operators to fix issue with driver if they don\u0027t need a compression","commit_id":"2387aa0cc9292c2d4d4c753216894180582ef1d8"},{"author":{"_account_id":22683,"name":"Arnon Yaari","email":"arnony@infinidat.com","username":"arnony"},"change_message_id":"f4218e8bb52501d0affd181b419ae4b45cffcd30","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        if (self.configuration.infinidat_use_compression and"},{"line_number":132,"context_line":"           not self._system.compat.has_compression()):"},{"line_number":133,"context_line":"            # InfiniBox systems support compression only from v3.0 and up"},{"line_number":134,"context_line":"            msg \u003d _(\u0027InfiniBox system does not support compression.\u0027)"},{"line_number":135,"context_line":"            raise exception.VolumeDriverException(message\u003dmsg)"},{"line_number":136,"context_line":"        LOG.debug(\u0027setup complete\u0027)"},{"line_number":137,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1f1a1f67_a88ed52b","line":134,"in_reply_to":"1f1a1f67_654a2881","updated":"2017-07-12 15:36:55.000000000","message":"Done","commit_id":"2387aa0cc9292c2d4d4c753216894180582ef1d8"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"021aa5a633a7610d265d44cec51ef8decd9ced4c","unresolved":false,"context_lines":[{"line_number":393,"context_line":"                             pool\u003dpool,"},{"line_number":394,"context_line":"                             provtype\u003dprovtype,"},{"line_number":395,"context_line":"                             size\u003dsize)"},{"line_number":396,"context_line":"        if self._system.compat.has_compression():"},{"line_number":397,"context_line":"            create_kwargs[\"compression_enabled\"] \u003d \\"},{"line_number":398,"context_line":"                self.configuration.infinidat_use_compression"},{"line_number":399,"context_line":"        infinidat_volume \u003d self._system.volumes.create(**create_kwargs)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f1a1f67_c530dc0a","line":396,"updated":"2017-07-12 15:21:07.000000000","message":"Do we really need this check here too? We already checked it in \u0027do_setup\u0027 method","commit_id":"2387aa0cc9292c2d4d4c753216894180582ef1d8"},{"author":{"_account_id":22683,"name":"Arnon Yaari","email":"arnony@infinidat.com","username":"arnony"},"change_message_id":"f4218e8bb52501d0affd181b419ae4b45cffcd30","unresolved":false,"context_lines":[{"line_number":393,"context_line":"                             pool\u003dpool,"},{"line_number":394,"context_line":"                             provtype\u003dprovtype,"},{"line_number":395,"context_line":"                             size\u003dsize)"},{"line_number":396,"context_line":"        if self._system.compat.has_compression():"},{"line_number":397,"context_line":"            create_kwargs[\"compression_enabled\"] \u003d \\"},{"line_number":398,"context_line":"                self.configuration.infinidat_use_compression"},{"line_number":399,"context_line":"        infinidat_volume \u003d self._system.volumes.create(**create_kwargs)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f1a1f67_c89a31c4","line":396,"in_reply_to":"1f1a1f67_c530dc0a","updated":"2017-07-12 15:36:55.000000000","message":"Yes, we have to check this here too because if the array does not support compression, the keyword argument \"compression_enabled\" will not be recognized by the storage array and the command will fail. For this reason, even if \"infinidat_use_compression\" is False we must check for compat.has_compression before passing this parameter. do_setup verifies that if use compression is true then the system supports that feature.","commit_id":"2387aa0cc9292c2d4d4c753216894180582ef1d8"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"e5b98796a0dd61d1c638b41d666f7262ebf7bbf1","unresolved":false,"context_lines":[{"line_number":447,"context_line":"                             provtype\u003dprovtype,"},{"line_number":448,"context_line":"                             size\u003dsize)"},{"line_number":449,"context_line":"        if self._system.compat.has_compression():"},{"line_number":450,"context_line":"            create_kwargs[\"compression_enabled\"] \u003d \\"},{"line_number":451,"context_line":"                self.configuration.infinidat_use_compression"},{"line_number":452,"context_line":"        infinidat_volume \u003d self._system.volumes.create(**create_kwargs)"},{"line_number":453,"context_line":"        self._set_qos(volume, infinidat_volume)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f1a1f67_5260e7a5","line":450,"range":{"start_line":450,"start_character":51,"end_line":450,"end_character":52},"updated":"2017-07-13 13:40:45.000000000","message":"Please avoid using \\ to span multiple lines. Not much more readable, but better to start with an open ( instead.","commit_id":"4f15c8b2171679e8264d00c7adf8770713f9290b"},{"author":{"_account_id":22683,"name":"Arnon Yaari","email":"arnony@infinidat.com","username":"arnony"},"change_message_id":"17b0c36fc7cd64c7778f36f1d6f663882894b4f9","unresolved":false,"context_lines":[{"line_number":447,"context_line":"                             provtype\u003dprovtype,"},{"line_number":448,"context_line":"                             size\u003dsize)"},{"line_number":449,"context_line":"        if self._system.compat.has_compression():"},{"line_number":450,"context_line":"            create_kwargs[\"compression_enabled\"] \u003d \\"},{"line_number":451,"context_line":"                self.configuration.infinidat_use_compression"},{"line_number":452,"context_line":"        infinidat_volume \u003d self._system.volumes.create(**create_kwargs)"},{"line_number":453,"context_line":"        self._set_qos(volume, infinidat_volume)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f1a1f67_b2ae1b2c","line":450,"range":{"start_line":450,"start_character":51,"end_line":450,"end_character":52},"in_reply_to":"1f1a1f67_5260e7a5","updated":"2017-07-13 13:54:35.000000000","message":"Done","commit_id":"4f15c8b2171679e8264d00c7adf8770713f9290b"}],"releasenotes/notes/infinidat-compression-a828904aaba90da2.yaml":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"021aa5a633a7610d265d44cec51ef8decd9ced4c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add support for volume compression in INFINIDAT driver."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1f1a1f67_4524ccc6","line":3,"updated":"2017-07-12 15:21:07.000000000","message":"Please, describe how to enable/disable this feature here","commit_id":"2387aa0cc9292c2d4d4c753216894180582ef1d8"},{"author":{"_account_id":22683,"name":"Arnon Yaari","email":"arnony@infinidat.com","username":"arnony"},"change_message_id":"f4218e8bb52501d0affd181b419ae4b45cffcd30","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add support for volume compression in INFINIDAT driver."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1f1a1f67_68131d0f","line":3,"in_reply_to":"1f1a1f67_4524ccc6","updated":"2017-07-12 15:36:55.000000000","message":"Done","commit_id":"2387aa0cc9292c2d4d4c753216894180582ef1d8"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"e5b98796a0dd61d1c638b41d666f7262ebf7bbf1","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Added support for volume compression in INFINIDAT driver."},{"line_number":4,"context_line":"    Compression is available on InfiniBox 3.0 onward."},{"line_number":5,"context_line":"    To enable volume compression, set infinidat_use_compression to"},{"line_number":6,"context_line":"    True in the backend section in the Cinder configuration file."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1f1a1f67_12ccafba","line":5,"range":{"start_line":5,"start_character":38,"end_line":5,"end_character":63},"updated":"2017-07-13 13:40:45.000000000","message":"Just a suggestion, wrap this in `` so it gets formatted and stands out as a config option.","commit_id":"4f15c8b2171679e8264d00c7adf8770713f9290b"},{"author":{"_account_id":22683,"name":"Arnon Yaari","email":"arnony@infinidat.com","username":"arnony"},"change_message_id":"17b0c36fc7cd64c7778f36f1d6f663882894b4f9","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Added support for volume compression in INFINIDAT driver."},{"line_number":4,"context_line":"    Compression is available on InfiniBox 3.0 onward."},{"line_number":5,"context_line":"    To enable volume compression, set infinidat_use_compression to"},{"line_number":6,"context_line":"    True in the backend section in the Cinder configuration file."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1f1a1f67_5263471b","line":5,"range":{"start_line":5,"start_character":38,"end_line":5,"end_character":63},"in_reply_to":"1f1a1f67_12ccafba","updated":"2017-07-13 13:54:35.000000000","message":"Done","commit_id":"4f15c8b2171679e8264d00c7adf8770713f9290b"}]}