)]}'
{"cinder/volume/drivers/dell_emc/vmax/rest/provision.py":[{"author":{"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},"change_message_id":"480c7ef329d77e7d006e5a23bc7a6ab21d283e6c","unresolved":false,"context_lines":[{"line_number":203,"context_line":"        kwargs \u003d {\u0027retries\u0027: 0,"},{"line_number":204,"context_line":"                  \u0027wait_for_sync_called\u0027: False}"},{"line_number":205,"context_line":"        timer \u003d loopingcall.FixedIntervalLoopingCall(_unlink_vol)"},{"line_number":206,"context_line":"        rc \u003d timer.start(interval\u003d15).wait()"},{"line_number":207,"context_line":"        return rc"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    def delete_volume_snap(self, array, snap_name, source_device_id):"}],"source_content_type":"text/x-python","patch_set":1,"id":"df140735_555c367d","line":206,"range":{"start_line":206,"start_character":8,"end_line":206,"end_character":44},"updated":"2017-05-31 13:21:50.000000000","message":"Do we really wait here for 15 seconds? I think we need mock this in unit tests and I agree with Ivan\u0027s comment about tests.\nAnd why actually 15?","commit_id":"6a024579256c8ee10ce4aadd9dabe27773e66e09"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"11c4422b39bdbf2f854cbc9b4ba311fc7a6e8e12","unresolved":false,"context_lines":[{"line_number":203,"context_line":"        kwargs \u003d {\u0027retries\u0027: 0,"},{"line_number":204,"context_line":"                  \u0027wait_for_sync_called\u0027: False}"},{"line_number":205,"context_line":"        timer \u003d loopingcall.FixedIntervalLoopingCall(_unlink_vol)"},{"line_number":206,"context_line":"        rc \u003d timer.start(interval\u003d15).wait()"},{"line_number":207,"context_line":"        return rc"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    def delete_volume_snap(self, array, snap_name, source_device_id):"}],"source_content_type":"text/x-python","patch_set":1,"id":"df140735_54d50f1b","line":206,"range":{"start_line":206,"start_character":8,"end_line":206,"end_character":44},"in_reply_to":"df140735_324d26c4","updated":"2017-06-02 11:41:08.000000000","message":"Hi Xing,\nAgreed, we will make it a constant","commit_id":"6a024579256c8ee10ce4aadd9dabe27773e66e09"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"11c4422b39bdbf2f854cbc9b4ba311fc7a6e8e12","unresolved":false,"context_lines":[{"line_number":203,"context_line":"        kwargs \u003d {\u0027retries\u0027: 0,"},{"line_number":204,"context_line":"                  \u0027wait_for_sync_called\u0027: False}"},{"line_number":205,"context_line":"        timer \u003d loopingcall.FixedIntervalLoopingCall(_unlink_vol)"},{"line_number":206,"context_line":"        rc \u003d timer.start(interval\u003d15).wait()"},{"line_number":207,"context_line":"        return rc"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    def delete_volume_snap(self, array, snap_name, source_device_id):"}],"source_content_type":"text/x-python","patch_set":1,"id":"df140735_14267769","line":206,"range":{"start_line":206,"start_character":8,"end_line":206,"end_character":44},"in_reply_to":"df140735_555c367d","updated":"2017-06-02 11:41:08.000000000","message":"Hi Michael, This really is an arbitrary value, we looked at using the user supplied \u0027Interval\u0027 but if this is low e.g 1 second it would not be enough time for a config change on the VMAX.","commit_id":"6a024579256c8ee10ce4aadd9dabe27773e66e09"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"9f8691f1050e25434cb8b987b157e96b776374af","unresolved":false,"context_lines":[{"line_number":203,"context_line":"        kwargs \u003d {\u0027retries\u0027: 0,"},{"line_number":204,"context_line":"                  \u0027wait_for_sync_called\u0027: False}"},{"line_number":205,"context_line":"        timer \u003d loopingcall.FixedIntervalLoopingCall(_unlink_vol)"},{"line_number":206,"context_line":"        rc \u003d timer.start(interval\u003d15).wait()"},{"line_number":207,"context_line":"        return rc"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    def delete_volume_snap(self, array, snap_name, source_device_id):"}],"source_content_type":"text/x-python","patch_set":1,"id":"df140735_324d26c4","line":206,"range":{"start_line":206,"start_character":8,"end_line":206,"end_character":44},"in_reply_to":"df140735_555c367d","updated":"2017-06-01 19:48:56.000000000","message":"Please make this a constant so you can set it to 0 in unit test.  We ran into weird time out issues when mocking sleep in unit test in the past.","commit_id":"6a024579256c8ee10ce4aadd9dabe27773e66e09"}]}