)]}'
{"cinder/volume/drivers/dell_emc/scaleio/driver.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"97c0435c44280a3bb82966229edf11fc751b95b5","unresolved":false,"context_lines":[{"line_number":39,"context_line":"from cinder import utils"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"from cinder.objects import fields"},{"line_number":42,"context_line":"from cinder.objects import VolumeList"},{"line_number":43,"context_line":"from cinder.volume import driver"},{"line_number":44,"context_line":"from cinder.volume.drivers.san import san"},{"line_number":45,"context_line":"from cinder.volume import qos_specs"}],"source_content_type":"text/x-python","patch_set":4,"id":"df140735_db2c59ad","line":42,"range":{"start_line":42,"start_character":33,"end_line":42,"end_character":34},"updated":"2017-06-06 09:55:45.000000000","message":"According to the OpenStack Hacking Rules, please import modules, not objects","commit_id":"a4083ed7de2cf98c439a0a1b2e103347ed3cb3ec"},{"author":{"_account_id":25033,"name":"Eric Young","email":"eric.young@dell.com","username":"tssgery"},"change_message_id":"258647d981661e467cce69e7b52a034fd9441448","unresolved":false,"context_lines":[{"line_number":39,"context_line":"from cinder import utils"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"from cinder.objects import fields"},{"line_number":42,"context_line":"from cinder.objects import VolumeList"},{"line_number":43,"context_line":"from cinder.volume import driver"},{"line_number":44,"context_line":"from cinder.volume.drivers.san import san"},{"line_number":45,"context_line":"from cinder.volume import qos_specs"}],"source_content_type":"text/x-python","patch_set":4,"id":"df140735_a43062a0","line":42,"range":{"start_line":42,"start_character":33,"end_line":42,"end_character":34},"in_reply_to":"df140735_db2c59ad","updated":"2017-06-06 11:20:58.000000000","message":"Done","commit_id":"a4083ed7de2cf98c439a0a1b2e103347ed3cb3ec"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"97c0435c44280a3bb82966229edf11fc751b95b5","unresolved":false,"context_lines":[{"line_number":329,"context_line":""},{"line_number":330,"context_line":"    @staticmethod"},{"line_number":331,"context_line":"    def _convert_kb_to_gib(size):"},{"line_number":332,"context_line":"        return int(math.ceil(float(size) / (1024 * 1024)))"},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"    @staticmethod"},{"line_number":335,"context_line":"    def _id_to_base64(id):"}],"source_content_type":"text/x-python","patch_set":4,"id":"df140735_7b1f8d6b","line":332,"updated":"2017-06-06 09:55:45.000000000","message":"Please, use oslo_utils.units here","commit_id":"a4083ed7de2cf98c439a0a1b2e103347ed3cb3ec"},{"author":{"_account_id":25033,"name":"Eric Young","email":"eric.young@dell.com","username":"tssgery"},"change_message_id":"258647d981661e467cce69e7b52a034fd9441448","unresolved":false,"context_lines":[{"line_number":329,"context_line":""},{"line_number":330,"context_line":"    @staticmethod"},{"line_number":331,"context_line":"    def _convert_kb_to_gib(size):"},{"line_number":332,"context_line":"        return int(math.ceil(float(size) / (1024 * 1024)))"},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"    @staticmethod"},{"line_number":335,"context_line":"    def _id_to_base64(id):"}],"source_content_type":"text/x-python","patch_set":4,"id":"df140735_e4009aad","line":332,"in_reply_to":"df140735_7b1f8d6b","updated":"2017-06-06 11:20:58.000000000","message":"Thanks, missed that","commit_id":"a4083ed7de2cf98c439a0a1b2e103347ed3cb3ec"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"ad552ddadcfafbd60cfa317660a3c55d01a93293","unresolved":false,"context_lines":[{"line_number":1183,"context_line":"        request \u003d (\"https://%(server_ip)s:%(server_port)s\""},{"line_number":1184,"context_line":"                   \"/api/types/Domain/instances/getByName::\""},{"line_number":1185,"context_line":"                   \"%(encoded_domain_name)s\") % req_vars"},{"line_number":1186,"context_line":"        LOG.info(\"ScaleIO get domain id by name request: %s.\", request)"},{"line_number":1187,"context_line":""},{"line_number":1188,"context_line":"        r, domain_id \u003d self._execute_scaleio_get_request(request)"},{"line_number":1189,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"df140735_3c0c5d93","line":1186,"range":{"start_line":1186,"start_character":12,"end_line":1186,"end_character":16},"updated":"2017-06-06 17:32:10.000000000","message":"This seems like it should be debug level, not Info.","commit_id":"6dafd18850666c78a4bc1795b1d5d70ffa3429f6"},{"author":{"_account_id":25033,"name":"Eric Young","email":"eric.young@dell.com","username":"tssgery"},"change_message_id":"720b390bccc4ca7ea98c9fb6a8bcf2f31e3e3284","unresolved":false,"context_lines":[{"line_number":1183,"context_line":"        request \u003d (\"https://%(server_ip)s:%(server_port)s\""},{"line_number":1184,"context_line":"                   \"/api/types/Domain/instances/getByName::\""},{"line_number":1185,"context_line":"                   \"%(encoded_domain_name)s\") % req_vars"},{"line_number":1186,"context_line":"        LOG.info(\"ScaleIO get domain id by name request: %s.\", request)"},{"line_number":1187,"context_line":""},{"line_number":1188,"context_line":"        r, domain_id \u003d self._execute_scaleio_get_request(request)"},{"line_number":1189,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"df140735_5f02630b","line":1186,"range":{"start_line":1186,"start_character":12,"end_line":1186,"end_character":16},"in_reply_to":"df140735_3c0c5d93","updated":"2017-06-07 13:07:07.000000000","message":"Done","commit_id":"6dafd18850666c78a4bc1795b1d5d70ffa3429f6"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"ad552ddadcfafbd60cfa317660a3c55d01a93293","unresolved":false,"context_lines":[{"line_number":1224,"context_line":"        request \u003d (\"https://%(server_ip)s:%(server_port)s\""},{"line_number":1225,"context_line":"                   \"/api/types/Pool/instances/getByName::\""},{"line_number":1226,"context_line":"                   \"%(domain_id)s,%(encoded_pool_name)s\") % req_vars"},{"line_number":1227,"context_line":"        LOG.info(\"ScaleIO get pool id by name request: %s.\", request)"},{"line_number":1228,"context_line":"        r, pool_id \u003d self._execute_scaleio_get_request(request)"},{"line_number":1229,"context_line":""},{"line_number":1230,"context_line":"        if not pool_id:"}],"source_content_type":"text/x-python","patch_set":7,"id":"df140735_7c609536","line":1227,"range":{"start_line":1227,"start_character":12,"end_line":1227,"end_character":17},"updated":"2017-06-06 17:32:10.000000000","message":"Same comment here.","commit_id":"6dafd18850666c78a4bc1795b1d5d70ffa3429f6"},{"author":{"_account_id":25033,"name":"Eric Young","email":"eric.young@dell.com","username":"tssgery"},"change_message_id":"720b390bccc4ca7ea98c9fb6a8bcf2f31e3e3284","unresolved":false,"context_lines":[{"line_number":1224,"context_line":"        request \u003d (\"https://%(server_ip)s:%(server_port)s\""},{"line_number":1225,"context_line":"                   \"/api/types/Pool/instances/getByName::\""},{"line_number":1226,"context_line":"                   \"%(domain_id)s,%(encoded_pool_name)s\") % req_vars"},{"line_number":1227,"context_line":"        LOG.info(\"ScaleIO get pool id by name request: %s.\", request)"},{"line_number":1228,"context_line":"        r, pool_id \u003d self._execute_scaleio_get_request(request)"},{"line_number":1229,"context_line":""},{"line_number":1230,"context_line":"        if not pool_id:"}],"source_content_type":"text/x-python","patch_set":7,"id":"df140735_3bf9e34c","line":1227,"range":{"start_line":1227,"start_character":12,"end_line":1227,"end_character":17},"in_reply_to":"df140735_7c609536","updated":"2017-06-07 13:07:07.000000000","message":"Done","commit_id":"6dafd18850666c78a4bc1795b1d5d70ffa3429f6"}]}
