)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"54b799c0d34048db2e79c2bff23a18b9d0c52853","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"To ensure that all clone files are cleaned up, the delete_snapshot"},{"line_number":15,"context_line":"method now marks snapshots to be deleted with ts file extension"},{"line_number":16,"context_line":"`and attempts to delete the snapshot.  If the snapshot cannot be"},{"line_number":17,"context_line":"deleted because it has clone children, it will be deleted with the"},{"line_number":18,"context_line":"child is deleted."},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAS3%2F%2FzFM%3D","line":16,"updated":"2013-09-19 01:34:41.000000000","message":"Remove rouge \" \u0027 \"","commit_id":"25744c59cbff0d48e550f61d2243b2c102a4ff96"},{"author":{"_account_id":7689,"name":"Bill Owen","email":"billowen@us.ibm.com","username":"billowen"},"change_message_id":"b41c648349ad58cccf4572d41a144d50ed5b09c3","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"To ensure that all clone files are cleaned up, the delete_snapshot"},{"line_number":15,"context_line":"method now marks snapshots to be deleted with ts file extension"},{"line_number":16,"context_line":"`and attempts to delete the snapshot.  If the snapshot cannot be"},{"line_number":17,"context_line":"deleted because it has clone children, it will be deleted with the"},{"line_number":18,"context_line":"child is deleted."},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAS3%2F%2FxxM%3D","line":16,"in_reply_to":"AAAAS3%2F%2FzFM%3D","updated":"2013-09-19 14:40:36.000000000","message":"Done","commit_id":"25744c59cbff0d48e550f61d2243b2c102a4ff96"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"54b799c0d34048db2e79c2bff23a18b9d0c52853","unresolved":false,"context_lines":[{"line_number":14,"context_line":"To ensure that all clone files are cleaned up, the delete_snapshot"},{"line_number":15,"context_line":"method now marks snapshots to be deleted with ts file extension"},{"line_number":16,"context_line":"`and attempts to delete the snapshot.  If the snapshot cannot be"},{"line_number":17,"context_line":"deleted because it has clone children, it will be deleted with the"},{"line_number":18,"context_line":"child is deleted."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Closes-Bug: #1227366"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAS3%2F%2FzFI%3D","line":17,"updated":"2013-09-19 01:34:41.000000000","message":"Think this should be \"...deleted when the ..\"","commit_id":"25744c59cbff0d48e550f61d2243b2c102a4ff96"},{"author":{"_account_id":7689,"name":"Bill Owen","email":"billowen@us.ibm.com","username":"billowen"},"change_message_id":"b41c648349ad58cccf4572d41a144d50ed5b09c3","unresolved":false,"context_lines":[{"line_number":14,"context_line":"To ensure that all clone files are cleaned up, the delete_snapshot"},{"line_number":15,"context_line":"method now marks snapshots to be deleted with ts file extension"},{"line_number":16,"context_line":"`and attempts to delete the snapshot.  If the snapshot cannot be"},{"line_number":17,"context_line":"deleted because it has clone children, it will be deleted with the"},{"line_number":18,"context_line":"child is deleted."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Closes-Bug: #1227366"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAS3%2F%2FxxI%3D","line":17,"in_reply_to":"AAAAS3%2F%2FzFI%3D","updated":"2013-09-19 14:40:36.000000000","message":"Done","commit_id":"25744c59cbff0d48e550f61d2243b2c102a4ff96"}],"cinder/volume/drivers/gpfs.py":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"54b799c0d34048db2e79c2bff23a18b9d0c52853","unresolved":false,"context_lines":[{"line_number":381,"context_line":"        volume_path \u003d os.path.join(self.configuration.gpfs_mount_point_base,"},{"line_number":382,"context_line":"                                   snapshot[\u0027volume_name\u0027])"},{"line_number":383,"context_line":"        self._create_gpfs_snap(src\u003dvolume_path, dest\u003dsnapshot_path)"},{"line_number":384,"context_line":"        self._gpfs_redirect(volume_path)"},{"line_number":385,"context_line":""},{"line_number":386,"context_line":"    def delete_snapshot(self, snapshot):"},{"line_number":387,"context_line":"        \"\"\"Deletes a GPFS snapshot.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAS3%2F%2FzEc%3D","line":384,"updated":"2013-09-19 01:34:41.000000000","message":"I feel like I am missing something here.  You call _gpfs_redirect and it is using the gpfs_max_clone_depth setting and returning TRUE or FALSE accordingly, but I don\u0027t see that anything is being done with that return code.  Sorry if I just don\u0027t understand but it seems like something is missing here.  At a minimum I would expect something to be logged to indicate when this condition is being met.","commit_id":"25744c59cbff0d48e550f61d2243b2c102a4ff96"},{"author":{"_account_id":7689,"name":"Bill Owen","email":"billowen@us.ibm.com","username":"billowen"},"change_message_id":"b41c648349ad58cccf4572d41a144d50ed5b09c3","unresolved":false,"context_lines":[{"line_number":381,"context_line":"        volume_path \u003d os.path.join(self.configuration.gpfs_mount_point_base,"},{"line_number":382,"context_line":"                                   snapshot[\u0027volume_name\u0027])"},{"line_number":383,"context_line":"        self._create_gpfs_snap(src\u003dvolume_path, dest\u003dsnapshot_path)"},{"line_number":384,"context_line":"        self._gpfs_redirect(volume_path)"},{"line_number":385,"context_line":""},{"line_number":386,"context_line":"    def delete_snapshot(self, snapshot):"},{"line_number":387,"context_line":"        \"\"\"Deletes a GPFS snapshot.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAS3%2F%2Fxvc%3D","line":384,"in_reply_to":"AAAAS3%2F%2FzEc%3D","updated":"2013-09-19 14:40:36.000000000","message":"In some contexts, it\u0027s important to know whether the clone depth was reduced by redirect and take an action based on this (see _create_gpfs_clone).  In this case,  however, _gpfs_redirect is called to reduce the depth if necessary, but no other action is required at this time regardless of whether or not the clone depth is reduced.","commit_id":"25744c59cbff0d48e550f61d2243b2c102a4ff96"}]}