)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"1194c361013d0d21ef546d697cac3a359a8e4d3c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Matt Smith \u003cmss@datera.io\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-06-16 13:14:23 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Datera 2.4.0 driver update"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    Updating the Datera Cinder driver to version 2.4.0 and implemented"},{"line_number":10,"context_line":"    the following features:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5f201791_c948015e","line":7,"updated":"2017-06-29 02:00:37.000000000","message":"Might be good in the future to do patches for each change rather than just a general all encompassing \"driver update\" patch.","commit_id":"e1f5a5d46f723ea4b0e80f136c30df327c789bf4"}],"cinder/volume/drivers/datera/datera_api2.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"1194c361013d0d21ef546d697cac3a359a8e4d3c","unresolved":false,"context_lines":[{"line_number":688,"context_line":""},{"line_number":689,"context_line":"    def _si_poll(self, volume, policies):"},{"line_number":690,"context_line":"        # Initial 4 second sleep required for some Datera versions"},{"line_number":691,"context_line":"        eventlet.sleep(4)"},{"line_number":692,"context_line":"        TIMEOUT \u003d 10"},{"line_number":693,"context_line":"        retry \u003d 0"},{"line_number":694,"context_line":"        check_url \u003d datc.URL_TEMPLATES[\u0027si_inst\u0027]("}],"source_content_type":"text/x-python","patch_set":4,"id":"5f201791_3e39edf1","line":691,"range":{"start_line":691,"start_character":23,"end_line":691,"end_character":24},"updated":"2017-06-29 02:00:37.000000000","message":"Wasn\u0027t this set to the variable so it could easily be set for unit tests to not have to wait? Or is this called just completely mocked out for unit tests?","commit_id":"e1f5a5d46f723ea4b0e80f136c30df327c789bf4"}],"cinder/volume/drivers/datera/datera_api21.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"1194c361013d0d21ef546d697cac3a359a8e4d3c","unresolved":false,"context_lines":[{"line_number":536,"context_line":"                  \"Volume: %s\\n\""},{"line_number":537,"context_line":"                  \"NewType: %s\\n\""},{"line_number":538,"context_line":"                  \"Diff: %s\\n\""},{"line_number":539,"context_line":"                  \"Host: %s\\n\" % (volume, new_type, diff, host))"},{"line_number":540,"context_line":"        # We\u0027ll take the fast route only if the types share the same backend"},{"line_number":541,"context_line":"        # And that backend matches this driver"},{"line_number":542,"context_line":"        old_pol \u003d self._get_policies_for_resource(volume)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f201791_5e1dc971","line":539,"range":{"start_line":539,"start_character":30,"end_line":539,"end_character":32},"updated":"2017-06-29 02:00:37.000000000","message":"% \u003e ,\n\nAnd since you are doing several variables, this really should have named format variables.","commit_id":"e1f5a5d46f723ea4b0e80f136c30df327c789bf4"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"1194c361013d0d21ef546d697cac3a359a8e4d3c","unresolved":false,"context_lines":[{"line_number":555,"context_line":"            self._update_qos_2_1(volume, new_pol, tenant)"},{"line_number":556,"context_line":"            vol_params \u003d ("},{"line_number":557,"context_line":"                {"},{"line_number":558,"context_line":"                    # \u0027name\u0027: new_pol[\u0027default_volume_name\u0027],"},{"line_number":559,"context_line":"                    \u0027placement_mode\u0027: new_pol[\u0027placement_mode\u0027],"},{"line_number":560,"context_line":"                    \u0027replica_count\u0027: new_pol[\u0027replica_count\u0027],"},{"line_number":561,"context_line":"                })"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f201791_3e120d64","line":558,"updated":"2017-06-29 02:00:37.000000000","message":"Please remove commented out code.","commit_id":"e1f5a5d46f723ea4b0e80f136c30df327c789bf4"}],"cinder/volume/drivers/datera/datera_common.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"1194c361013d0d21ef546d697cac3a359a8e4d3c","unresolved":false,"context_lines":[{"line_number":448,"context_line":"        t2 \u003d time.time()"},{"line_number":449,"context_line":"        timedelta \u003d round(t2 - t1, 3)"},{"line_number":450,"context_line":"    if not sensitive:"},{"line_number":451,"context_line":"        LOG.debug((\"\\nDatera Trace ID: %s\\n\""},{"line_number":452,"context_line":"                   \"Datera Response ID: %s\\n\""},{"line_number":453,"context_line":"                   \"Datera Response TimeDelta: %ss\\n\""},{"line_number":454,"context_line":"                   \"Datera Response URL: %s\\n\""}],"source_content_type":"text/x-python","patch_set":4,"id":"5f201791_e90dfd35","line":451,"range":{"start_line":451,"start_character":18,"end_line":451,"end_character":19},"updated":"2017-06-29 02:00:37.000000000","message":"This inner () really isn\u0027t needed.","commit_id":"e1f5a5d46f723ea4b0e80f136c30df327c789bf4"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"1194c361013d0d21ef546d697cac3a359a8e4d3c","unresolved":false,"context_lines":[{"line_number":454,"context_line":"                   \"Datera Response URL: %s\\n\""},{"line_number":455,"context_line":"                   \"Datera Response Payload: %s\\n\""},{"line_number":456,"context_line":"                   \"Datera Response Object: %s\\n\"),"},{"line_number":457,"context_line":"                  driver.thread_local.trace_id,"},{"line_number":458,"context_line":"                  request_id,"},{"line_number":459,"context_line":"                  timedelta,"},{"line_number":460,"context_line":"                  response.url,"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f201791_c91a416e","line":457,"range":{"start_line":457,"start_character":33,"end_line":457,"end_character":34},"updated":"2017-06-29 02:00:37.000000000","message":"Should use named variable substitution.","commit_id":"e1f5a5d46f723ea4b0e80f136c30df327c789bf4"}],"releasenotes/notes/datera-2.4.0-driver-update-164bbc77e6b45eb7.yaml":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"1194c361013d0d21ef546d697cac3a359a8e4d3c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Added datera_disable_profiler boolean config option"},{"line_number":4,"context_line":"  - Added Cinder fast-retype support to Datera EDF driver"},{"line_number":5,"context_line":"  - Added Volume Placement extra-specs support to Datera EDF driver"},{"line_number":6,"context_line":"  - Fixed ACL multi-attach bug in Datera EDF driver"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5f201791_894b295e","line":3,"range":{"start_line":3,"start_character":10,"end_line":3,"end_character":33},"updated":"2017-06-29 02:00:37.000000000","message":"Might be good to put this config option name inside `` for formatting.\n\nPlease end all of these with a period.","commit_id":"e1f5a5d46f723ea4b0e80f136c30df327c789bf4"}]}