)]}'
{"cinder/volume/drivers/dell_emc/vnx/utils.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"b356a16d821e0c1256f42aea48140febbbfce4dc","unresolved":false,"context_lines":[{"line_number":360,"context_line":""},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"def is_image_cache_volume(volume):"},{"line_number":363,"context_line":"    display_name \u003d volume.display_name"},{"line_number":364,"context_line":"    if (display_name.startswith(\u0027image-\u0027)"},{"line_number":365,"context_line":"            and uuidutils.is_uuid_like(display_name[6:])):"},{"line_number":366,"context_line":"        LOG.debug(\u0027Volume: %s is for image cache. Use sync migration and \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f201791_b7c21658","line":363,"range":{"start_line":363,"start_character":19,"end_line":363,"end_character":38},"updated":"2017-06-27 02:16:12.000000000","message":"Are you sure you need to use display_name, not name?  display_name can be modified without the backend\u0027s involvement and it is not reliable.","commit_id":"71b64e27520c35c43529a74743a29b45e3ea9468"},{"author":{"_account_id":18742,"name":"Ryan Liang","email":"ryan.liang@emc.com","username":"RyanLiang"},"change_message_id":"b90293d1e668ea891a4cd39f4b40769a516cb215","unresolved":false,"context_lines":[{"line_number":360,"context_line":""},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"def is_image_cache_volume(volume):"},{"line_number":363,"context_line":"    display_name \u003d volume.display_name"},{"line_number":364,"context_line":"    if (display_name.startswith(\u0027image-\u0027)"},{"line_number":365,"context_line":"            and uuidutils.is_uuid_like(display_name[6:])):"},{"line_number":366,"context_line":"        LOG.debug(\u0027Volume: %s is for image cache. Use sync migration and \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f201791_d7635241","line":363,"range":{"start_line":363,"start_character":19,"end_line":363,"end_character":38},"in_reply_to":"5f201791_b7c21658","updated":"2017-06-27 02:44:03.000000000","message":"I detected whether a volume is image cache volume or not based on the display name starts with \u0027image-\u0027. I cannot figure out via name. Do you have any suggestion on how to detect a volume is an image cache volume?","commit_id":"71b64e27520c35c43529a74743a29b45e3ea9468"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"d9d0435e9d8b70d7ba886c864979342298724e70","unresolved":false,"context_lines":[{"line_number":360,"context_line":""},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"def is_image_cache_volume(volume):"},{"line_number":363,"context_line":"    display_name \u003d volume.display_name"},{"line_number":364,"context_line":"    if (display_name.startswith(\u0027image-\u0027)"},{"line_number":365,"context_line":"            and uuidutils.is_uuid_like(display_name[6:])):"},{"line_number":366,"context_line":"        LOG.debug(\u0027Volume: %s is for image cache. Use sync migration and \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f201791_0f72797d","line":363,"range":{"start_line":363,"start_character":19,"end_line":363,"end_character":38},"in_reply_to":"5f201791_d7635241","updated":"2017-06-29 04:14:04.000000000","message":"I couldn\u0027t find a better way either.  You can query the image cache in the db but that is an overkill and not a good practice for the driver to do.  The image cache volume is an internal volume so it should be safe to use the display name.","commit_id":"71b64e27520c35c43529a74743a29b45e3ea9468"}]}
