)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"d3060cc4b425cc4d3b92cf58f4d30b2bd566313c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix driver exception when cascade deleting volume after transferring"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"After transferring a volume without snapshots from one user project"},{"line_number":10,"context_line":"to other user project,  if other user use cascade deleting, it will"},{"line_number":11,"context_line":"cause some exception in driver and volume will be error_deleting."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"APIImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5f201791_72325512","line":10,"range":{"start_line":10,"start_character":3,"end_line":10,"end_character":8},"updated":"2017-06-26 20:01:52.000000000","message":"another","commit_id":"fca2d1bdc2b4b066ca54f2710fac0aa31b1cad80"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"d3060cc4b425cc4d3b92cf58f4d30b2bd566313c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix driver exception when cascade deleting volume after transferring"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"After transferring a volume without snapshots from one user project"},{"line_number":10,"context_line":"to other user project,  if other user use cascade deleting, it will"},{"line_number":11,"context_line":"cause some exception in driver and volume will be error_deleting."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"APIImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5f201791_123d61dc","line":10,"range":{"start_line":10,"start_character":27,"end_line":10,"end_character":41},"updated":"2017-06-26 20:01:52.000000000","message":"the receiving user uses","commit_id":"fca2d1bdc2b4b066ca54f2710fac0aa31b1cad80"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"f4b868f8f6785e04dab1866322c10599c6ab8d90","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix driver exception when cascade deleting volume after transferring"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"After transferring a volume without snapshots from one user project"},{"line_number":10,"context_line":"to other user project,  if other user use cascade deleting, it will"},{"line_number":11,"context_line":"cause some exception in driver and volume will be error_deleting."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"APIImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5f201791_1759cb33","line":10,"range":{"start_line":10,"start_character":27,"end_line":10,"end_character":41},"in_reply_to":"5f201791_123d61dc","updated":"2017-06-27 07:45:57.000000000","message":"Done","commit_id":"fca2d1bdc2b4b066ca54f2710fac0aa31b1cad80"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"f4b868f8f6785e04dab1866322c10599c6ab8d90","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix driver exception when cascade deleting volume after transferring"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"After transferring a volume without snapshots from one user project"},{"line_number":10,"context_line":"to other user project,  if other user use cascade deleting, it will"},{"line_number":11,"context_line":"cause some exception in driver and volume will be error_deleting."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"APIImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5f201791_f741af3a","line":10,"range":{"start_line":10,"start_character":3,"end_line":10,"end_character":8},"in_reply_to":"5f201791_72325512","updated":"2017-06-27 07:45:57.000000000","message":"Done","commit_id":"fca2d1bdc2b4b066ca54f2710fac0aa31b1cad80"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"663545fe4615711dc794428dec15484330fb596c","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"After transferring a volume without snapshots from one user project"},{"line_number":10,"context_line":"to another user project,  if the receiving usr uses cascade deleting,"},{"line_number":11,"context_line":"it will cause some exception in driver and volume will be error_deleting."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"APIImpact"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5f201791_a08ac566","line":11,"range":{"start_line":11,"start_character":19,"end_line":11,"end_character":28},"updated":"2017-06-27 08:13:41.000000000","message":"exceptions","commit_id":"57380a821d8fd920766249493e650860510950b8"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"5c877f51e39e6bbee01112f23efb4c8d6104e97c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix driver exception when cascade deleting volume after transferring"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"After transferring a volume without snapshots from one user project"},{"line_number":10,"context_line":"to another user project,  if the receiving usr uses cascade deleting,"},{"line_number":11,"context_line":"it will cause some exceptions in driver and volume will be error_deleting."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"APIImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"5f201791_6e946137","line":10,"range":{"start_line":10,"start_character":43,"end_line":10,"end_character":46},"updated":"2017-06-28 19:37:18.000000000","message":"user","commit_id":"992547d1ff0ed711075e7a3514ee5ee47cfe068f"}],"cinder/volume/api.py":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"d3060cc4b425cc4d3b92cf58f4d30b2bd566313c","unresolved":false,"context_lines":[{"line_number":436,"context_line":"        if not result:"},{"line_number":437,"context_line":"            status \u003d utils.build_or_str(expected.get(\u0027status\u0027),"},{"line_number":438,"context_line":"                                        _(\u0027status must be %s and\u0027))"},{"line_number":439,"context_line":"            msg \u003d _(\u0027Volume %s must not be migrating, attached, belong to a \u0027"},{"line_number":440,"context_line":"                    \u0027group or have snapshots.\u0027) % status"},{"line_number":441,"context_line":"            LOG.info(msg)"},{"line_number":442,"context_line":"            raise exception.InvalidVolume(reason\u003dmsg)"},{"line_number":443,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5f201791_3554c7fd","line":440,"range":{"start_line":439,"start_character":0,"end_line":440,"end_character":56},"updated":"2017-06-26 20:01:52.000000000","message":"So, in the case of the problem you are accounting for we will end up with this error message.  I feel like this is misleading as there aren\u0027t snapshots.  Not sure the right way to handle this though.","commit_id":"fca2d1bdc2b4b066ca54f2710fac0aa31b1cad80"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"f4b868f8f6785e04dab1866322c10599c6ab8d90","unresolved":false,"context_lines":[{"line_number":436,"context_line":"        if not result:"},{"line_number":437,"context_line":"            status \u003d utils.build_or_str(expected.get(\u0027status\u0027),"},{"line_number":438,"context_line":"                                        _(\u0027status must be %s and\u0027))"},{"line_number":439,"context_line":"            msg \u003d _(\u0027Volume %s must not be migrating, attached, belong to a \u0027"},{"line_number":440,"context_line":"                    \u0027group or have snapshots.\u0027) % status"},{"line_number":441,"context_line":"            LOG.info(msg)"},{"line_number":442,"context_line":"            raise exception.InvalidVolume(reason\u003dmsg)"},{"line_number":443,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5f201791_ace3e1d8","line":440,"range":{"start_line":439,"start_character":0,"end_line":440,"end_character":56},"in_reply_to":"5f201791_3554c7fd","updated":"2017-06-27 07:45:57.000000000","message":"yes, this msg now is misleading a bit, maybe could be like this:\n\u0027belong to a group, have snapshots, or leave snapshots alone when transferring volume.\u0027","commit_id":"fca2d1bdc2b4b066ca54f2710fac0aa31b1cad80"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"663545fe4615711dc794428dec15484330fb596c","unresolved":false,"context_lines":[{"line_number":418,"context_line":"            else:"},{"line_number":419,"context_line":"                # Allow deletion if all snapshots are in an expected state"},{"line_number":420,"context_line":"                filters \u003d [~db.volume_has_undeletable_snapshots_filter()]"},{"line_number":421,"context_line":"                # Check if the volume has snapshots which is existing in"},{"line_number":422,"context_line":"                # other project now."},{"line_number":423,"context_line":"                if context.is_admin is False:"},{"line_number":424,"context_line":"                    filters.append(~db.volume_has_other_project_snp_filter())"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f201791_8057c9ca","line":421,"range":{"start_line":421,"start_character":58,"end_line":421,"end_character":61},"updated":"2017-06-27 08:13:41.000000000","message":"are","commit_id":"57380a821d8fd920766249493e650860510950b8"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"663545fe4615711dc794428dec15484330fb596c","unresolved":false,"context_lines":[{"line_number":420,"context_line":"                filters \u003d [~db.volume_has_undeletable_snapshots_filter()]"},{"line_number":421,"context_line":"                # Check if the volume has snapshots which is existing in"},{"line_number":422,"context_line":"                # other project now."},{"line_number":423,"context_line":"                if context.is_admin is False:"},{"line_number":424,"context_line":"                    filters.append(~db.volume_has_other_project_snp_filter())"},{"line_number":425,"context_line":"        else:"},{"line_number":426,"context_line":"            # Don\u0027t allow deletion of volume with snapshots"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f201791_c06141ab","line":423,"range":{"start_line":423,"start_character":19,"end_line":423,"end_character":44},"updated":"2017-06-27 08:13:41.000000000","message":"if not context.is_admin?","commit_id":"57380a821d8fd920766249493e650860510950b8"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"5c877f51e39e6bbee01112f23efb4c8d6104e97c","unresolved":false,"context_lines":[{"line_number":437,"context_line":"            status \u003d utils.build_or_str(expected.get(\u0027status\u0027),"},{"line_number":438,"context_line":"                                        _(\u0027status must be %s and\u0027))"},{"line_number":439,"context_line":"            msg \u003d _(\u0027Volume %s must not be migrating, attached, belong to a \u0027"},{"line_number":440,"context_line":"                    \u0027group, have snapshots or leave snapshots alone when \u0027"},{"line_number":441,"context_line":"                    \u0027transferring volume.\u0027) % status"},{"line_number":442,"context_line":"            LOG.info(msg)"},{"line_number":443,"context_line":"            raise exception.InvalidVolume(reason\u003dmsg)"},{"line_number":444,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5f201791_7c7bf6f3","line":441,"range":{"start_line":440,"start_character":46,"end_line":441,"end_character":42},"updated":"2017-06-28 19:37:18.000000000","message":"How about we say \u0027be disassociated from snapshots after volume transfer.\u0027  How does that sound?","commit_id":"992547d1ff0ed711075e7a3514ee5ee47cfe068f"}],"releasenotes/notes/check-snapshots-when-cascade-deleting-transferred-volume-575ef0b76bd7f334.yaml":[{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"b0ce43a8001e92c4e77598a9012ed7b036c7a209","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - After transferring a volume without snapshots from one user project"},{"line_number":4,"context_line":"    to another user project,  if the receiving usr uses cascade deleting,"},{"line_number":5,"context_line":"    it will cause some exceptions in driver and volume will be error_deleting."},{"line_number":6,"context_line":"    Adding additional check to ensure there are no snapshots left in other"},{"line_number":7,"context_line":"    project when cascade deleting a tranferred volume."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5f201791_10951987","line":4,"range":{"start_line":4,"start_character":47,"end_line":4,"end_character":50},"updated":"2017-06-28 10:04:31.000000000","message":"user?","commit_id":"992547d1ff0ed711075e7a3514ee5ee47cfe068f"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"d8e9b729e91f63b4c2e64bdf112a0940cda1cc0e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - After transferring a volume without snapshots from one user project"},{"line_number":4,"context_line":"    to another user project,  if the receiving user uses cascade deleting,"},{"line_number":5,"context_line":"    it will cause some exceptions in driver and volume will be error_deleting."},{"line_number":6,"context_line":"    Adding additional check to ensure there are no snapshots left in other"},{"line_number":7,"context_line":"    project when cascade deleting a tranferred volume."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3f1d235d_0855d750","line":4,"updated":"2017-06-29 07:34:10.000000000","message":"nit: two spaces instead of one","commit_id":"6e412852f2b756c83ab986fb382f5c249fa3d3ce"}]}