)]}'
{"cinder/tests/unit/volume/drivers/ibm/test_xiv_proxy.py":[{"author":{"_account_id":17564,"name":"jiamin","email":"shljia@cn.ibm.com","username":"jiamin"},"change_message_id":"2f150f59a01121e571bd3d8275782dfac2d824e1","unresolved":false,"context_lines":[{"line_number":717,"context_line":"        p.ibm_storage_cli.cmd.perf_class_set_rate.return_value \u003d None"},{"line_number":718,"context_line":"        p.ibm_storage_cli.cmd.perf_class_create.return_value \u003d None"},{"line_number":719,"context_line":""},{"line_number":720,"context_line":"        perf_class_name \u003d \u0027cinder-qos_iops_1000_type_independent_bw_1000\u0027"},{"line_number":721,"context_line":"        p_class_name \u003d p._create_qos_class(perf_class_name\u003dperf_class_name,"},{"line_number":722,"context_line":"                                           specs\u003dNone)"},{"line_number":723,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5f201791_7871e275","line":720,"range":{"start_line":720,"start_character":8,"end_line":720,"end_character":73},"updated":"2017-06-28 02:16:53.000000000","message":"nit: it maybe better to use ddt for different cases of perf_class_name, and assert perf_class_create is called with parameter type or not for these cases.","commit_id":"f3fb308cd94aa392f523f2a93964eb5f4ae5f382"}],"cinder/volume/drivers/ibm/ibm_storage/xiv_proxy.py":[{"author":{"_account_id":17564,"name":"jiamin","email":"shljia@cn.ibm.com","username":"jiamin"},"change_message_id":"95685a2e87aebeea70ade68ae55f19a0401b84e9","unresolved":false,"context_lines":[{"line_number":391,"context_line":"        try:"},{"line_number":392,"context_line":"            # check if we have a shared (default) perf class"},{"line_number":393,"context_line":"            # or an independent perf class"},{"line_number":394,"context_line":"            _type \u003d re.findall(\u0027type_(independent|shared)\u0027, perf_class_name)"},{"line_number":395,"context_line":"            if _type:"},{"line_number":396,"context_line":"                self._call_xiv_xcli(\"perf_class_create\","},{"line_number":397,"context_line":"                                    perf_class\u003dperf_class_name,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f201791_393979a3","line":394,"range":{"start_line":394,"start_character":12,"end_line":394,"end_character":76},"updated":"2017-06-26 07:45:31.000000000","message":"findall returns a list, do you need to get its element from this list for _type?","commit_id":"83615343359196623bdcb9c5bad2686d94a8a99e"},{"author":{"_account_id":20310,"name":"Vadim Kryvian","email":"vadimk@il.ibm.com","username":"vadimk"},"change_message_id":"3b693c86c188fc4f81e209203becd385c8e6f289","unresolved":false,"context_lines":[{"line_number":391,"context_line":"        try:"},{"line_number":392,"context_line":"            # check if we have a shared (default) perf class"},{"line_number":393,"context_line":"            # or an independent perf class"},{"line_number":394,"context_line":"            _type \u003d re.findall(\u0027type_(independent|shared)\u0027, perf_class_name)"},{"line_number":395,"context_line":"            if _type:"},{"line_number":396,"context_line":"                self._call_xiv_xcli(\"perf_class_create\","},{"line_number":397,"context_line":"                                    perf_class\u003dperf_class_name,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f201791_dcba736c","line":394,"range":{"start_line":394,"start_character":12,"end_line":394,"end_character":76},"in_reply_to":"5f201791_393979a3","updated":"2017-06-26 08:40:57.000000000","message":"Thanks for noticing. It will be fixed in the next commit","commit_id":"83615343359196623bdcb9c5bad2686d94a8a99e"}]}