)]}'
{"cinder/volume/drivers/dell_emc/scaleio/driver.py":[{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"aebdeed8d1abbd35754330f1326cc62ab355a0fc","unresolved":false,"context_lines":[{"line_number":1255,"context_line":"        if r.status_code !\u003d http_client.OK:"},{"line_number":1256,"context_line":"            msg \u003d (_(\"Error getting domain name from id %(domain_id)s: \""},{"line_number":1257,"context_line":"                     \"%(err_msg)s.\")"},{"line_number":1258,"context_line":"                   % {\u0027domain_id\u0027: domain_id})"},{"line_number":1259,"context_line":"            LOG.error(msg)"},{"line_number":1260,"context_line":"            raise exception.VolumeBackendAPIException(data\u003dmsg)"},{"line_number":1261,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1f1a1f67_ff236a04","line":1258,"updated":"2017-07-12 12:18:42.000000000","message":"missing err_msg","commit_id":"f5ad6531db1020b87eccfe4a03ef18914c5e173a"},{"author":{"_account_id":25033,"name":"Eric Young","email":"eric.young@dell.com","username":"tssgery"},"change_message_id":"00e8fcd40f983befd71a7a8160b61b7a7cf7cf30","unresolved":false,"context_lines":[{"line_number":1255,"context_line":"        if r.status_code !\u003d http_client.OK:"},{"line_number":1256,"context_line":"            msg \u003d (_(\"Error getting domain name from id %(domain_id)s: \""},{"line_number":1257,"context_line":"                     \"%(err_msg)s.\")"},{"line_number":1258,"context_line":"                   % {\u0027domain_id\u0027: domain_id})"},{"line_number":1259,"context_line":"            LOG.error(msg)"},{"line_number":1260,"context_line":"            raise exception.VolumeBackendAPIException(data\u003dmsg)"},{"line_number":1261,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1f1a1f67_759f7bb4","line":1258,"in_reply_to":"1f1a1f67_ff236a04","updated":"2017-07-12 12:52:55.000000000","message":"oooh... good catch!","commit_id":"f5ad6531db1020b87eccfe4a03ef18914c5e173a"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"77da3309e6419fa1ccc309f9972410840a3f5f18","unresolved":false,"context_lines":[{"line_number":72,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":73,"context_line":"               deprecated_reason\u003d\"Replaced by sio_storage_pools option\","},{"line_number":74,"context_line":"               deprecated_since\u003d\"Pike\","},{"line_number":75,"context_line":"               help\u003d\u0027Deprecated: Protection Domain ID.\u0027),"},{"line_number":76,"context_line":"    cfg.StrOpt(\u0027sio_protection_domain_name\u0027,"},{"line_number":77,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":78,"context_line":"               deprecated_reason\u003d\"Replaced by sio_storage_pools option\","}],"source_content_type":"text/x-python","patch_set":4,"id":"1f1a1f67_4b39803f","line":75,"range":{"start_line":75,"start_character":20,"end_line":75,"end_character":32},"updated":"2017-07-12 14:27:22.000000000","message":"DEPRECATED for consistency with your other messages.","commit_id":"7caf1829f532cc77277ad479221b31fe51905f95"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"77da3309e6419fa1ccc309f9972410840a3f5f18","unresolved":false,"context_lines":[{"line_number":230,"context_line":""},{"line_number":231,"context_line":"        # make sure the REST gateway is specified"},{"line_number":232,"context_line":"        if not self.server_ip:"},{"line_number":233,"context_line":"            msg \u003d _(\"REST server IP must by specified.\")"},{"line_number":234,"context_line":"            raise exception.InvalidInput(reason\u003dmsg)"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"        # make sure we got a username"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f1a1f67_8b667851","line":233,"range":{"start_line":233,"start_character":40,"end_line":233,"end_character":43},"updated":"2017-07-12 14:27:22.000000000","message":"be","commit_id":"7caf1829f532cc77277ad479221b31fe51905f95"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"77da3309e6419fa1ccc309f9972410840a3f5f18","unresolved":false,"context_lines":[{"line_number":235,"context_line":""},{"line_number":236,"context_line":"        # make sure we got a username"},{"line_number":237,"context_line":"        if not self.server_username:"},{"line_number":238,"context_line":"            msg \u003d _(\"REST server username must by specified.\")"},{"line_number":239,"context_line":"            raise exception.InvalidInput(reason\u003dmsg)"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"        # make sure we got a password"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f1a1f67_6b5b1c87","line":238,"range":{"start_line":238,"start_character":46,"end_line":238,"end_character":49},"updated":"2017-07-12 14:27:22.000000000","message":"be","commit_id":"7caf1829f532cc77277ad479221b31fe51905f95"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"77da3309e6419fa1ccc309f9972410840a3f5f18","unresolved":false,"context_lines":[{"line_number":240,"context_line":""},{"line_number":241,"context_line":"        # make sure we got a password"},{"line_number":242,"context_line":"        if not self.server_password:"},{"line_number":243,"context_line":"            msg \u003d _(\"REST server password must by specified.\")"},{"line_number":244,"context_line":"            raise exception.InvalidInput(reason\u003dmsg)"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"        # validate certificate settings"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f1a1f67_eb4e0cc0","line":243,"range":{"start_line":243,"start_character":46,"end_line":243,"end_character":49},"updated":"2017-07-12 14:27:22.000000000","message":"be","commit_id":"7caf1829f532cc77277ad479221b31fe51905f95"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"77da3309e6419fa1ccc309f9972410840a3f5f18","unresolved":false,"context_lines":[{"line_number":293,"context_line":"            extra_pool \u003d \"{}:{}\".format("},{"line_number":294,"context_line":"                self.configuration.sio_storage_pool_name,"},{"line_number":295,"context_line":"                self.configuration.sio_protection_domain_name)"},{"line_number":296,"context_line":"            LOG.info(\"Ensuring %s in the list of configured pools\","},{"line_number":297,"context_line":"                     extra_pool)"},{"line_number":298,"context_line":"            if pools is None:"},{"line_number":299,"context_line":"                pools \u003d []"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f1a1f67_0647ff1f","line":296,"range":{"start_line":296,"start_character":30,"end_line":296,"end_character":36},"updated":"2017-07-12 14:27:22.000000000","message":"%s is in .  Also please add a \u0027.\u0027 at EOL.","commit_id":"7caf1829f532cc77277ad479221b31fe51905f95"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"77da3309e6419fa1ccc309f9972410840a3f5f18","unresolved":false,"context_lines":[{"line_number":305,"context_line":"            # get the domain and pool names from SIO"},{"line_number":306,"context_line":"            extra_pool \u003d self._get_storage_pool_name("},{"line_number":307,"context_line":"                self.configuration.sio_storage_pool_id)"},{"line_number":308,"context_line":"            LOG.info(\"Ensuring %s in the list of configured pools\","},{"line_number":309,"context_line":"                     extra_pool)"},{"line_number":310,"context_line":"            if pools is None:"},{"line_number":311,"context_line":"                pools \u003d []"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f1a1f67_665913fd","line":308,"range":{"start_line":308,"start_character":22,"end_line":308,"end_character":65},"updated":"2017-07-12 14:27:22.000000000","message":"Same comment here.","commit_id":"7caf1829f532cc77277ad479221b31fe51905f95"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"77da3309e6419fa1ccc309f9972410840a3f5f18","unresolved":false,"context_lines":[{"line_number":1178,"context_line":"        \"\"\"\"Get the id of the protection domain\"\"\""},{"line_number":1179,"context_line":""},{"line_number":1180,"context_line":"        if not domain_name:"},{"line_number":1181,"context_line":"            msg \u003d (_(\"Error getting domain id from None name\"))"},{"line_number":1182,"context_line":"            LOG.error(msg)"},{"line_number":1183,"context_line":"            raise exception.VolumeBackendAPIException(data\u003dmsg)"},{"line_number":1184,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1f1a1f67_86f42f5d","line":1181,"range":{"start_line":1181,"start_character":59,"end_line":1181,"end_character":62},"updated":"2017-07-12 14:27:22.000000000","message":"\u0027.\u0027 at EOL please.","commit_id":"7caf1829f532cc77277ad479221b31fe51905f95"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"77da3309e6419fa1ccc309f9972410840a3f5f18","unresolved":false,"context_lines":[{"line_number":1267,"context_line":"    def _get_storage_pool_id(self, domain_name, pool_name):"},{"line_number":1268,"context_line":"        \"\"\"Get the id of the configured storage pool\"\"\""},{"line_number":1269,"context_line":"        if not domain_name or not pool_name:"},{"line_number":1270,"context_line":"            msg \u003d (_(\"Unable to query the storage pool id for\""},{"line_number":1271,"context_line":"                     \"Pool %(pool_name)s and Domain %(domain_name)s.\")"},{"line_number":1272,"context_line":"                   % {\u0027pool_name\u0027: pool_name,"},{"line_number":1273,"context_line":"                      \u0027domain_name\u0027: domain_name})"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f1a1f67_669eb308","line":1270,"range":{"start_line":1270,"start_character":60,"end_line":1270,"end_character":62},"updated":"2017-07-12 14:27:22.000000000","message":"missing space at EOL.","commit_id":"7caf1829f532cc77277ad479221b31fe51905f95"}]}
