)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"d52ac48c88c4a62126902152df124723f0e840f2","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Isaac Beckman \u003cisaacb@il.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-07-03 10:56:27 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"IBM Storage: fix create volume with --group-id"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"when creating a volume with group_id, the driver need to look in the"},{"line_number":10,"context_line":"group specs to see if the group is a cg or a regular generic group"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3f1d235d_0b2aee7d","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":11},"updated":"2017-07-04 13:44:15.000000000","message":"nit: XIV so it is clear this change only affects the XIV driver, not other IBM storage drivers.","commit_id":"15e65b97dcbde28c4d4e8e6a6af07a11ebf985d4"}],"cinder/volume/drivers/ibm/ibm_storage/xiv_proxy.py":[{"author":{"_account_id":17564,"name":"jiamin","email":"shljia@cn.ibm.com","username":"jiamin"},"change_message_id":"ce34e99fca68cafa20955f3fcbfa3de35c2dd5ed","unresolved":false,"context_lines":[{"line_number":486,"context_line":"    def create_volume(self, volume):"},{"line_number":487,"context_line":"        \"\"\"Creates a volume.\"\"\""},{"line_number":488,"context_line":"        # read CG information"},{"line_number":489,"context_line":"        group_id \u003d volume.get(\u0027group_id\u0027, None)"},{"line_number":490,"context_line":""},{"line_number":491,"context_line":"        # read replication information"},{"line_number":492,"context_line":"        specs \u003d self._get_extra_specs(volume.get(\u0027volume_type_id\u0027, None))"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f1d235d_0cc38bef","line":489,"range":{"start_line":489,"start_character":19,"end_line":489,"end_character":47},"updated":"2017-06-30 02:23:33.000000000","message":"you can change it to volume.group_id.\n\nbut I think you don\u0027t need group_id, because volume object has field group. you can change #L495 to \"if volume.group and replication_info[\u0027enabled\u0027]\", and don\u0027t need to add one more parameter group_id to handle_created_vol_properties, because it already has parameter volume.","commit_id":"2881c362745f9db0b3748267d2e9cca6af0209f0"},{"author":{"_account_id":13047,"name":"Isaac Beckman","email":"beckmani@gmail.com","username":"isaacb"},"change_message_id":"5ba8fae0e58295971024ee8add256c13207fd491","unresolved":false,"context_lines":[{"line_number":486,"context_line":"    def create_volume(self, volume):"},{"line_number":487,"context_line":"        \"\"\"Creates a volume.\"\"\""},{"line_number":488,"context_line":"        # read CG information"},{"line_number":489,"context_line":"        group_id \u003d volume.get(\u0027group_id\u0027, None)"},{"line_number":490,"context_line":""},{"line_number":491,"context_line":"        # read replication information"},{"line_number":492,"context_line":"        specs \u003d self._get_extra_specs(volume.get(\u0027volume_type_id\u0027, None))"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f1d235d_2d505a5d","line":489,"range":{"start_line":489,"start_character":19,"end_line":489,"end_character":47},"in_reply_to":"3f1d235d_0cc38bef","updated":"2017-07-02 08:15:35.000000000","message":"Basically you are right. But I need group_id in 2 places: in this function (create_volume) and in handle_created_vol_porperties. This assignment make sure that I do the logic only once.","commit_id":"2881c362745f9db0b3748267d2e9cca6af0209f0"},{"author":{"_account_id":17564,"name":"jiamin","email":"shljia@cn.ibm.com","username":"jiamin"},"change_message_id":"ce34e99fca68cafa20955f3fcbfa3de35c2dd5ed","unresolved":false,"context_lines":[{"line_number":509,"context_line":"        volume_update \u003d {}"},{"line_number":510,"context_line":"        cg \u003d False"},{"line_number":511,"context_line":"        if group_id:"},{"line_number":512,"context_line":"            group \u003d utils.group_get_by_id(group_id)"},{"line_number":513,"context_line":"            cg \u003d utils.is_group_a_cg_snapshot_type(group)"},{"line_number":514,"context_line":""},{"line_number":515,"context_line":"        if cg:"},{"line_number":516,"context_line":"            volume_update[\u0027group_id\u0027] \u003d group_id"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f1d235d_671c586a","line":513,"range":{"start_line":512,"start_character":12,"end_line":513,"end_character":57},"updated":"2017-06-30 02:23:33.000000000","message":"you can change these two lines to\n\ncg \u003d utils.is_group_a_cg_snapshot_type(volume.group)","commit_id":"2881c362745f9db0b3748267d2e9cca6af0209f0"},{"author":{"_account_id":13047,"name":"Isaac Beckman","email":"beckmani@gmail.com","username":"isaacb"},"change_message_id":"5ba8fae0e58295971024ee8add256c13207fd491","unresolved":false,"context_lines":[{"line_number":509,"context_line":"        volume_update \u003d {}"},{"line_number":510,"context_line":"        cg \u003d False"},{"line_number":511,"context_line":"        if group_id:"},{"line_number":512,"context_line":"            group \u003d utils.group_get_by_id(group_id)"},{"line_number":513,"context_line":"            cg \u003d utils.is_group_a_cg_snapshot_type(group)"},{"line_number":514,"context_line":""},{"line_number":515,"context_line":"        if cg:"},{"line_number":516,"context_line":"            volume_update[\u0027group_id\u0027] \u003d group_id"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f1d235d_cdf32673","line":513,"range":{"start_line":512,"start_character":12,"end_line":513,"end_character":57},"in_reply_to":"3f1d235d_671c586a","updated":"2017-07-02 08:15:35.000000000","message":"ok","commit_id":"2881c362745f9db0b3748267d2e9cca6af0209f0"},{"author":{"_account_id":17564,"name":"jiamin","email":"shljia@cn.ibm.com","username":"jiamin"},"change_message_id":"ce34e99fca68cafa20955f3fcbfa3de35c2dd5ed","unresolved":false,"context_lines":[{"line_number":512,"context_line":"            group \u003d utils.group_get_by_id(group_id)"},{"line_number":513,"context_line":"            cg \u003d utils.is_group_a_cg_snapshot_type(group)"},{"line_number":514,"context_line":""},{"line_number":515,"context_line":"        if cg:"},{"line_number":516,"context_line":"            volume_update[\u0027group_id\u0027] \u003d group_id"},{"line_number":517,"context_line":"            try:"},{"line_number":518,"context_line":"                cg_name \u003d self._cg_name_from_volume(volume)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f1d235d_a7403037","line":515,"range":{"start_line":515,"start_character":8,"end_line":515,"end_character":14},"updated":"2017-06-30 02:23:33.000000000","message":"align \"if cg\" with #L513.","commit_id":"2881c362745f9db0b3748267d2e9cca6af0209f0"},{"author":{"_account_id":17564,"name":"jiamin","email":"shljia@cn.ibm.com","username":"jiamin"},"change_message_id":"db1cf65efb93b4f5fdf45cc6c609ce72c0bdc18e","unresolved":false,"context_lines":[{"line_number":512,"context_line":"            group \u003d utils.group_get_by_id(group_id)"},{"line_number":513,"context_line":"            cg \u003d utils.is_group_a_cg_snapshot_type(group)"},{"line_number":514,"context_line":""},{"line_number":515,"context_line":"        if cg:"},{"line_number":516,"context_line":"            volume_update[\u0027group_id\u0027] \u003d group_id"},{"line_number":517,"context_line":"            try:"},{"line_number":518,"context_line":"                cg_name \u003d self._cg_name_from_volume(volume)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f1d235d_b74390af","line":515,"range":{"start_line":515,"start_character":8,"end_line":515,"end_character":14},"in_reply_to":"3f1d235d_0de0fe95","updated":"2017-07-03 01:31:34.000000000","message":"Isaac, what i meant that you don\u0027t need to define variable cg,\nall of places you use cg are #L510, #L513 and #L515, so I think you can make the code much more brief like below.\n\nvolume_update \u003d {}\nif volume.group and  \n      utils.is_group_a_cg_snapshot_type(volume.group):\n    try:\n        ....\n    except errors.XCLIError as e:\n        ....","commit_id":"2881c362745f9db0b3748267d2e9cca6af0209f0"},{"author":{"_account_id":13047,"name":"Isaac Beckman","email":"beckmani@gmail.com","username":"isaacb"},"change_message_id":"5ba8fae0e58295971024ee8add256c13207fd491","unresolved":false,"context_lines":[{"line_number":512,"context_line":"            group \u003d utils.group_get_by_id(group_id)"},{"line_number":513,"context_line":"            cg \u003d utils.is_group_a_cg_snapshot_type(group)"},{"line_number":514,"context_line":""},{"line_number":515,"context_line":"        if cg:"},{"line_number":516,"context_line":"            volume_update[\u0027group_id\u0027] \u003d group_id"},{"line_number":517,"context_line":"            try:"},{"line_number":518,"context_line":"                cg_name \u003d self._cg_name_from_volume(volume)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f1d235d_0de0fe95","line":515,"range":{"start_line":515,"start_character":8,"end_line":515,"end_character":14},"in_reply_to":"3f1d235d_a7403037","updated":"2017-07-02 08:15:35.000000000","message":"cg can be None see #L510","commit_id":"2881c362745f9db0b3748267d2e9cca6af0209f0"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"3afa01885bfd62b29076d4206f3464b1c0f21d8c","unresolved":false,"context_lines":[{"line_number":513,"context_line":"            cg \u003d utils.is_group_a_cg_snapshot_type(group)"},{"line_number":514,"context_line":""},{"line_number":515,"context_line":"        if cg:"},{"line_number":516,"context_line":"            volume_update[\u0027group_id\u0027] \u003d group_id"},{"line_number":517,"context_line":"            try:"},{"line_number":518,"context_line":"                cg_name \u003d self._cg_name_from_volume(volume)"},{"line_number":519,"context_line":"                self._call_xiv_xcli("}],"source_content_type":"text/x-python","patch_set":1,"id":"3f1d235d_60a9f0dd","line":516,"range":{"start_line":516,"start_character":12,"end_line":516,"end_character":48},"updated":"2017-06-29 16:23:17.000000000","message":"You shouldn\u0027t add group_id in volume_update and pass it back to the manager.  The volume object passed in from create_volume already has group_id.","commit_id":"2881c362745f9db0b3748267d2e9cca6af0209f0"},{"author":{"_account_id":13047,"name":"Isaac Beckman","email":"beckmani@gmail.com","username":"isaacb"},"change_message_id":"5ba8fae0e58295971024ee8add256c13207fd491","unresolved":false,"context_lines":[{"line_number":513,"context_line":"            cg \u003d utils.is_group_a_cg_snapshot_type(group)"},{"line_number":514,"context_line":""},{"line_number":515,"context_line":"        if cg:"},{"line_number":516,"context_line":"            volume_update[\u0027group_id\u0027] \u003d group_id"},{"line_number":517,"context_line":"            try:"},{"line_number":518,"context_line":"                cg_name \u003d self._cg_name_from_volume(volume)"},{"line_number":519,"context_line":"                self._call_xiv_xcli("}],"source_content_type":"text/x-python","patch_set":1,"id":"3f1d235d_6ddbf2ec","line":516,"range":{"start_line":516,"start_character":12,"end_line":516,"end_character":48},"in_reply_to":"3f1d235d_60a9f0dd","updated":"2017-07-02 08:15:35.000000000","message":"You are right. Will change it in the next commit","commit_id":"2881c362745f9db0b3748267d2e9cca6af0209f0"}]}