)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"70fb23d1a26fc05319a8311f1011cb7ad29a389c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix Log parameter"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"instance_id is easy to misunderstand as VM ID, and it"},{"line_number":10,"context_line":"doesn\u0027t agree with reality,and i think It\u0027s better to"},{"line_number":11,"context_line":"log attachment id."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I22481731cacf7c4793e43713291f4c25c1e5afbb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3f1d235d_90b9f7ea","line":10,"range":{"start_line":10,"start_character":26,"end_line":10,"end_character":28},"updated":"2017-07-08 17:14:32.000000000","message":"Not going to hold up merge for this but for future reference be careful to avoid typos like this please.","commit_id":"c24fde5ce9e1746b0372131a42363c53fe95a0c3"}],"cinder/volume/manager.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"f588f0c4adb1fe9e188a17e3cccdeef10a83f9ed","unresolved":false,"context_lines":[{"line_number":2215,"context_line":"                    self.detach_volume(ctxt, volume.id, attachment.id)"},{"line_number":2216,"context_line":"                except Exception as ex:"},{"line_number":2217,"context_line":"                    LOG.error(\"Detach migration source volume \""},{"line_number":2218,"context_line":"                              \"%(volume.id)s from instance \""},{"line_number":2219,"context_line":"                              \"%(attachment_id)s failed: %(err)s\","},{"line_number":2220,"context_line":"                              {\u0027err\u0027: ex,"},{"line_number":2221,"context_line":"                               \u0027volume.id\u0027: volume.id,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_4332e95f","line":2218,"range":{"start_line":2218,"start_character":50,"end_line":2218,"end_character":58},"updated":"2017-07-05 14:39:48.000000000","message":"We should change this too so it\u0027s less confusing.","commit_id":"e784e1b18deddc683ddfcc370605841424d5ea0d"},{"author":{"_account_id":21135,"name":"zhangdaolong","email":"zhangdaolong@fiberhome.com","username":"zhangdaolong"},"change_message_id":"2dca75bc9f12f44998eb4c86fc6628495023f468","unresolved":false,"context_lines":[{"line_number":2215,"context_line":"                    self.detach_volume(ctxt, volume.id, attachment.id)"},{"line_number":2216,"context_line":"                except Exception as ex:"},{"line_number":2217,"context_line":"                    LOG.error(\"Detach migration source volume \""},{"line_number":2218,"context_line":"                              \"%(volume.id)s from instance \""},{"line_number":2219,"context_line":"                              \"%(attachment_id)s failed: %(err)s\","},{"line_number":2220,"context_line":"                              {\u0027err\u0027: ex,"},{"line_number":2221,"context_line":"                               \u0027volume.id\u0027: volume.id,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_cb53a038","line":2218,"range":{"start_line":2218,"start_character":50,"end_line":2218,"end_character":58},"in_reply_to":"3f1d235d_4332e95f","updated":"2017-07-06 00:30:06.000000000","message":"ok thank you!","commit_id":"e784e1b18deddc683ddfcc370605841424d5ea0d"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"1cb2b484cd02cec528077241541be20be17b0144","unresolved":false,"context_lines":[{"line_number":2216,"context_line":"                except Exception as ex:"},{"line_number":2217,"context_line":"                    LOG.error(\"Detach migration source volume \""},{"line_number":2218,"context_line":"                              \"%(volume.id)s from instance \""},{"line_number":2219,"context_line":"                              \"%(instance_id)s failed: %(err)s\","},{"line_number":2220,"context_line":"                              {\u0027err\u0027: ex,"},{"line_number":2221,"context_line":"                               \u0027volume.id\u0027: volume.id,"},{"line_number":2222,"context_line":"                               \u0027instance_id\u0027: attachment.instance_uuid},"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f1d235d_0cd9af55","line":2219,"range":{"start_line":2219,"start_character":32,"end_line":2219,"end_character":45},"updated":"2017-07-06 02:16:40.000000000","message":"s/instance_id/instance_uuid/g","commit_id":"f05397455ac261eeb044b34cc93a9dfa346de298"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"1cb2b484cd02cec528077241541be20be17b0144","unresolved":false,"context_lines":[{"line_number":2219,"context_line":"                              \"%(instance_id)s failed: %(err)s\","},{"line_number":2220,"context_line":"                              {\u0027err\u0027: ex,"},{"line_number":2221,"context_line":"                               \u0027volume.id\u0027: volume.id,"},{"line_number":2222,"context_line":"                               \u0027instance_id\u0027: attachment.instance_uuid},"},{"line_number":2223,"context_line":"                              resource\u003dvolume)"},{"line_number":2224,"context_line":""},{"line_number":2225,"context_line":"        # Give driver (new_volume) a chance to update things as needed"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f1d235d_ccde173d","line":2222,"range":{"start_line":2222,"start_character":31,"end_line":2222,"end_character":44},"updated":"2017-07-06 02:16:40.000000000","message":"ditto, for consistency.","commit_id":"f05397455ac261eeb044b34cc93a9dfa346de298"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"318ca4cf9521223489e7caf3578befbc55872721","unresolved":false,"context_lines":[{"line_number":2219,"context_line":"                              \"%(instance_uuid)s failed: %(err)s\","},{"line_number":2220,"context_line":"                              {\u0027err\u0027: ex,"},{"line_number":2221,"context_line":"                               \u0027volume.id\u0027: volume.id,"},{"line_number":2222,"context_line":"                               \u0027instance_uuid\u0027: attachment.instance_uuid},"},{"line_number":2223,"context_line":"                              resource\u003dvolume)"},{"line_number":2224,"context_line":""},{"line_number":2225,"context_line":"        # Give driver (new_volume) a chance to update things as needed"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f1d235d_98904a97","line":2222,"updated":"2017-07-06 09:50:46.000000000","message":"-1: We should be logging the attachment ID, because the instance_uuid will be the same for all attachments.\n\nIf you want to, you can add a log on L 2211 to say you are proceeding to detach volumes from instance and report the UUID.","commit_id":"5c5f1ca4769dee5f9bf02a03378b75f0ca402e0b"},{"author":{"_account_id":21135,"name":"zhangdaolong","email":"zhangdaolong@fiberhome.com","username":"zhangdaolong"},"change_message_id":"b23dac75701df5ed5d873eba4f5979ad8a656988","unresolved":false,"context_lines":[{"line_number":2219,"context_line":"                              \"%(instance_uuid)s failed: %(err)s\","},{"line_number":2220,"context_line":"                              {\u0027err\u0027: ex,"},{"line_number":2221,"context_line":"                               \u0027volume.id\u0027: volume.id,"},{"line_number":2222,"context_line":"                               \u0027instance_uuid\u0027: attachment.instance_uuid},"},{"line_number":2223,"context_line":"                              resource\u003dvolume)"},{"line_number":2224,"context_line":""},{"line_number":2225,"context_line":"        # Give driver (new_volume) a chance to update things as needed"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f1d235d_673caa2e","line":2222,"in_reply_to":"3f1d235d_98904a97","updated":"2017-07-06 11:48:03.000000000","message":"Ok i see ,i will change to log attachment.\nthank you","commit_id":"5c5f1ca4769dee5f9bf02a03378b75f0ca402e0b"}]}