)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"ef4f774cb9b497f061341d7c3100378e922f2dd0","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     kongxiangyun \u003ckongxyxian2010@163.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-07-07 14:17:49 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"cinder can not revert volume to snapshot"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"when lvm_type\u003dthin in cinder.conf, mergs a snapshot will result in other snapshots cannot be merged"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f1d235d_89d5781e","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":40},"updated":"2017-07-07 07:40:26.000000000","message":"This is a little confusing, the bug describes that the revert process would fail if delete the latest one and revert again.","commit_id":"8c9ba4f72a761796058348cca2668955b377445e"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"ef4f774cb9b497f061341d7c3100378e922f2dd0","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"cinder can not revert volume to snapshot"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"when lvm_type\u003dthin in cinder.conf, mergs a snapshot will result in other snapshots cannot be merged"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Ife3d57b6fe3717af02e7dfa440b1510058bfab40"},{"line_number":12,"context_line":"Closes-Bug: #1702820"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f1d235d_89869865","line":9,"range":{"start_line":9,"start_character":72,"end_line":9,"end_character":99},"updated":"2017-07-07 07:40:26.000000000","message":"This line exceeds the max length","commit_id":"8c9ba4f72a761796058348cca2668955b377445e"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"ef4f774cb9b497f061341d7c3100378e922f2dd0","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"cinder can not revert volume to snapshot"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"when lvm_type\u003dthin in cinder.conf, mergs a snapshot will result in other snapshots cannot be merged"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Ife3d57b6fe3717af02e7dfa440b1510058bfab40"},{"line_number":12,"context_line":"Closes-Bug: #1702820"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f1d235d_e9abccd2","line":9,"range":{"start_line":9,"start_character":35,"end_line":9,"end_character":40},"updated":"2017-07-07 07:40:26.000000000","message":"merge","commit_id":"8c9ba4f72a761796058348cca2668955b377445e"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"abe5ef24edabf167f76a4ec19796404b115e5c78","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"add exception check for lvm_type"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"when lvm_type\u003dthin in cinder.conf, mergs a snapshot will"},{"line_number":10,"context_line":"result in other snapshots cannot be merged"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ife3d57b6fe3717af02e7dfa440b1510058bfab40"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f1d235d_909c575e","line":9,"range":{"start_line":9,"start_character":35,"end_line":9,"end_character":40},"updated":"2017-07-08 17:24:42.000000000","message":"merges","commit_id":"ee4a0528f0ac50e730947bc670a4818836c90f2c"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"0043f5872ad6d140eaa58266f4d0bcdd48730db7","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     kongxiangyun \u003ckongxyxian2010@163.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-07-12 22:55:41 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"add exception check for lvm_type"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"when lvm_type\u003dthin in cinder.conf, merges a snapshot will"},{"line_number":10,"context_line":"result in other snapshots cannot be merged"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1f1a1f67_aed018cb","line":7,"updated":"2017-07-12 19:10:41.000000000","message":"The one-line summary should be something more like \"Disable revert to snapshot for thin LVM\", so people can tell what this patch does.","commit_id":"d3045774c8d56eda18980b883af3e9dccfd6732f"}],"cinder/tests/unit/volume/drivers/test_lvm_driver.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"e70728a7e050796b72c79d6b8f460a0b0fcf7c1e","unresolved":false,"context_lines":[{"line_number":715,"context_line":""},{"line_number":716,"context_line":"    def test_revert_thin_snapshot(self):"},{"line_number":717,"context_line":""},{"line_number":718,"context_line":"        self.configuration.lvm_type \u003d \u0027thin\u0027"},{"line_number":719,"context_line":"        lvm_driver \u003d lvm.LVMVolumeDriver(configuration\u003dself.configuration,"},{"line_number":720,"context_line":"                                         db\u003ddb)"},{"line_number":721,"context_line":"        fake_volume \u003d tests_utils.create_volume(self.context,"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f1a1f67_263c0d92","line":718,"updated":"2017-07-13 15:06:56.000000000","message":"Writing to this can change the configuration for other tests -- see how it\u0027s done for test_lvm_max_over_subscription_ratio below.","commit_id":"58d7846e7d1ed571c851e2da70c60020a3b70b7a"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"e70728a7e050796b72c79d6b8f460a0b0fcf7c1e","unresolved":false,"context_lines":[{"line_number":842,"context_line":"                                             expected_value):"},{"line_number":843,"context_line":"        configuration \u003d conf.Configuration(fake_opt, \u0027fake_group\u0027)"},{"line_number":844,"context_line":"        configuration.max_over_subscription_ratio \u003d global_value"},{"line_number":845,"context_line":"        configuration.lvm_max_over_subscription_ratio \u003d lvm_value"},{"line_number":846,"context_line":""},{"line_number":847,"context_line":"        fake_vg \u003d mock.Mock(fake_lvm.FakeBrickLVM(\u0027cinder-volumes\u0027, False,"},{"line_number":848,"context_line":"                                                  None, \u0027default\u0027))"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f1a1f67_a647fd1d","line":845,"updated":"2017-07-13 15:06:56.000000000","message":"Do this instead.","commit_id":"58d7846e7d1ed571c851e2da70c60020a3b70b7a"}],"cinder/volume/drivers/lvm.py":[{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"ef4f774cb9b497f061341d7c3100378e922f2dd0","unresolved":false,"context_lines":[{"line_number":462,"context_line":"    def revert_to_snapshot(self, context, volume, snapshot):"},{"line_number":463,"context_line":"        \"\"\"Revert a volume to a snapshot\"\"\""},{"line_number":464,"context_line":""},{"line_number":465,"context_line":"        if self.configuration.lvm_type \u003d\u003d \u0027thin\u0027:"},{"line_number":466,"context_line":"            msg \u003d _(\"Revert volume which lv_type is thin to snapshot not implemented.\")"},{"line_number":467,"context_line":"            raise NotImplementedError(msg)"},{"line_number":468,"context_line":"        else:"},{"line_number":469,"context_line":"            self.vg.revert(self._escape_snapshot(snapshot.name))"},{"line_number":470,"context_line":"            self.vg.deactivate_lv(volume.name)"},{"line_number":471,"context_line":"            self.vg.activate_lv(volume.name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f1d235d_497c0071","line":468,"range":{"start_line":465,"start_character":6,"end_line":468,"end_character":13},"updated":"2017-07-07 07:40:26.000000000","message":"We need to add testcase for this.","commit_id":"8c9ba4f72a761796058348cca2668955b377445e"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"34e696905f552e45014a1d39626180d8f175161d","unresolved":false,"context_lines":[{"line_number":463,"context_line":"        \"\"\"Revert a volume to a snapshot\"\"\""},{"line_number":464,"context_line":""},{"line_number":465,"context_line":"        if self.configuration.lvm_type \u003d\u003d \u0027thin\u0027:"},{"line_number":466,"context_line":"            msg \u003d _(\"Revert thin volume to snapshot not implemented.\")"},{"line_number":467,"context_line":"            raise NotImplementedError(msg)"},{"line_number":468,"context_line":"        else:"},{"line_number":469,"context_line":"            self.vg.revert(self._escape_snapshot(snapshot.name))"}],"source_content_type":"text/x-python","patch_set":5,"id":"1f1a1f67_901ea56e","line":466,"updated":"2017-07-12 13:38:55.000000000","message":"Please add \"for thin LVM\" to the end of this message.","commit_id":"abde1bc48f41e39a976ecce66590bf9be1c43fe8"}]}
