)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"925a4f300cc8dcb2d461f210d5e8f55d4e1fe712","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     apoorvad \u003capps.desh@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-07-10 13:41:19 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Accessing driver config options"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Due to commit 1f62a411f4c241f9105a8ffb53fa2e7a1f71902a"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f1d235d_bf8edb24","line":7,"updated":"2017-07-10 20:50:06.000000000","message":"Should have Tintri is the title, otherwise sounds like you are changing the way drivers use config options. Maybe something like:\n\nTintri: Fix config option access","commit_id":"21ccd80afe5ad853aac33b514518c5db01288d6c"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"925a4f300cc8dcb2d461f210d5e8f55d4e1fe712","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Accessing driver config options"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Due to commit 1f62a411f4c241f9105a8ffb53fa2e7a1f71902a"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Ic94a74f4ec324ba12b4282ad6ce221194b033645"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f1d235d_7f984369","line":9,"updated":"2017-07-10 20:50:06.000000000","message":"You\u0027re leaving us hanging here. :)","commit_id":"21ccd80afe5ad853aac33b514518c5db01288d6c"},{"author":{"_account_id":14377,"name":"Apoorva","email":"apps.desh@gmail.com","username":"apoorvad"},"change_message_id":"1a654580e9a8357ca929eee9267a71847c7f5adc","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Accessing driver config options"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Due to commit 1f62a411f4c241f9105a8ffb53fa2e7a1f71902a"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Ic94a74f4ec324ba12b4282ad6ce221194b033645"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f1d235d_e2671ab7","line":9,"in_reply_to":"3f1d235d_7f984369","updated":"2017-07-10 21:23:48.000000000","message":"I wanted to reference the breaking changeset. Is there any other way I can do this? I could not find a bug/task for the change","commit_id":"21ccd80afe5ad853aac33b514518c5db01288d6c"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"9ea6682d47547ce93982555abf4d9eb2fe6aa5bc","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Accessing driver config options"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Due to commit 1f62a411f4c241f9105a8ffb53fa2e7a1f71902a"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Ic94a74f4ec324ba12b4282ad6ce221194b033645"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f1d235d_22787229","line":9,"in_reply_to":"3f1d235d_e2671ab7","updated":"2017-07-10 21:35:08.000000000","message":"No, that\u0027s a good (and correct) way to reference a changeset. Just looked like the rest of whatever you were writing got cut off from there?","commit_id":"21ccd80afe5ad853aac33b514518c5db01288d6c"}],"cinder/volume/drivers/tintri.py":[{"author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"change_message_id":"8d89df13d7a9dbe8f00492a6da554152037bb1ee","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        self._hostname \u003d getattr(self.configuration, \u0027tintri_server_hostname\u0027)"},{"line_number":111,"context_line":"        self._username \u003d getattr(self.configuration, \u0027tintri_server_username\u0027)"},{"line_number":112,"context_line":"        self._password \u003d getattr(self.configuration, \u0027tintri_server_password\u0027)"},{"line_number":113,"context_line":"        self._api_version \u003d getattr(self.configuration, \u0027tintri_api_version\u0027,"},{"line_number":114,"context_line":"                                    self.configuration.tintri_api_version)"},{"line_number":115,"context_line":"        self._image_cache_expiry \u003d \\"},{"line_number":116,"context_line":"            getattr(self.configuration, \u0027tintri_image_cache_expiry_days\u0027,"},{"line_number":117,"context_line":"                    self.configuration.tintri_image_cache_expiry_days)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f1d235d_9c4e8d94","line":114,"range":{"start_line":113,"start_character":8,"end_line":114,"end_character":74},"updated":"2017-07-10 20:33:18.000000000","message":"I think these are checking the same thing, the normal and default value are the same things whereas before one was maybe the backend section and the other the \"DEFAULT\" one.\n\nI\u0027m not 100% sure it would have actually ever hit it though because the option has a default for it.\n\nAnyway, you can simplify this to:\n\ngetattr(self.configuration, \u0027tintri_api_version\u0027)\n\n\nAnd it does the same thing.","commit_id":"3310af3357043f29e79d2371aade704d65b282f0"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"925a4f300cc8dcb2d461f210d5e8f55d4e1fe712","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        self._username \u003d getattr(self.configuration, \u0027tintri_server_username\u0027)"},{"line_number":112,"context_line":"        self._password \u003d getattr(self.configuration, \u0027tintri_server_password\u0027)"},{"line_number":113,"context_line":"        self._api_version \u003d getattr(self.configuration, \u0027tintri_api_version\u0027)"},{"line_number":114,"context_line":"        self._image_cache_expiry \u003d \\"},{"line_number":115,"context_line":"            getattr(self.configuration, \u0027tintri_image_cache_expiry_days\u0027)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def get_pool(self, volume):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f1d235d_5f9b4765","line":114,"range":{"start_line":114,"start_character":35,"end_line":114,"end_character":36},"updated":"2017-07-10 20:50:06.000000000","message":"Please don\u0027t use \\ to span multiple lines.","commit_id":"21ccd80afe5ad853aac33b514518c5db01288d6c"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"c1c380e67008da639325155b66a1797433885b45","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        self._username \u003d getattr(self.configuration, \u0027tintri_server_username\u0027)"},{"line_number":112,"context_line":"        self._password \u003d getattr(self.configuration, \u0027tintri_server_password\u0027)"},{"line_number":113,"context_line":"        self._api_version \u003d getattr(self.configuration, \u0027tintri_api_version\u0027)"},{"line_number":114,"context_line":"        self._image_cache_expiry \u003d getattr(self.configuration,\\"},{"line_number":115,"context_line":"                                           \u0027tintri_image_cache_expiry_days\u0027)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def get_pool(self, volume):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_71a19246","line":114,"range":{"start_line":114,"start_character":62,"end_line":114,"end_character":63},"updated":"2017-07-11 03:14:52.000000000","message":"Please don\u0027t use backslashes.","commit_id":"efe2bc0bc344f856ea46bca2e3aef1933928f493"}]}