)]}'
{"cinder/image/image_utils.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"d1886094795fe5a314743249999fef541dbae4cf","unresolved":false,"context_lines":[{"line_number":420,"context_line":"                      src_format\u003ddisk_format,"},{"line_number":421,"context_line":"                      run_as_root\u003drun_as_root)"},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"        if (disk_format \u003d\u003d \u0027raw\u0027 and"},{"line_number":424,"context_line":"                image_meta.get(\u0027container_format\u0027, \u0027\u0027) \u003d\u003d \u0027bare\u0027):"},{"line_number":425,"context_line":"            # For raw-formatted Glance images, any data/header could be"},{"line_number":426,"context_line":"            # present.  So we can\u0027t validate the format based on qemu-img"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f1a1f67_9ba02af6","line":423,"updated":"2017-07-19 13:38:26.000000000","message":"-1: It think it\u0027s the volume_format that\u0027s important, not the source format.","commit_id":"78269102919e5e857e47aa965c01340661846afa"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"a32c808392a7b3de3de645899b9f8ae8d74e25cd","unresolved":false,"context_lines":[{"line_number":420,"context_line":"                      src_format\u003ddisk_format,"},{"line_number":421,"context_line":"                      run_as_root\u003drun_as_root)"},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"        if (disk_format \u003d\u003d \u0027raw\u0027 and"},{"line_number":424,"context_line":"                image_meta.get(\u0027container_format\u0027, \u0027\u0027) \u003d\u003d \u0027bare\u0027):"},{"line_number":425,"context_line":"            # For raw-formatted Glance images, any data/header could be"},{"line_number":426,"context_line":"            # present.  So we can\u0027t validate the format based on qemu-img"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f1a1f67_e2b88f11","line":423,"in_reply_to":"1f1a1f67_9ba02af6","updated":"2017-07-19 15:51:17.000000000","message":"The purpose of this check is to perform the conversion from the image to the volume, and then ensure that the volume ended up with the expected format on it.  (See the message at line 435.)\n\nThis skips that check when the source is a raw Glance image, because the resulting data on the volume could be in any format that qemu-img would detect.  Therefore, the check is not sensible to do at all if the _source_ is raw.","commit_id":"78269102919e5e857e47aa965c01340661846afa"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"3a2f696d11f0069c93f45f762c158bce9a5e8ab9","unresolved":false,"context_lines":[{"line_number":420,"context_line":"                      src_format\u003ddisk_format,"},{"line_number":421,"context_line":"                      run_as_root\u003drun_as_root)"},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"        if (disk_format \u003d\u003d \u0027raw\u0027 and"},{"line_number":424,"context_line":"                image_meta.get(\u0027container_format\u0027, \u0027\u0027) \u003d\u003d \u0027bare\u0027):"},{"line_number":425,"context_line":"            # For raw-formatted Glance images, any data/header could be"},{"line_number":426,"context_line":"            # present.  So we can\u0027t validate the format based on qemu-img"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f1a1f67_244d723d","line":423,"in_reply_to":"1f1a1f67_e2b88f11","updated":"2017-07-19 17:10:45.000000000","message":"Talked to Gorka more on IRC -- as far as I can tell, there isn\u0027t a strong reason to do the _validate_file_format check below, because it is essentially just checking to make sure that \"qemu-img convert\" didn\u0027t do something crazy -- if it fails it will return non-zero and the operation will fail.\n\nRather than skipping it in many cases here as this patch does, we can just remove that check.","commit_id":"78269102919e5e857e47aa965c01340661846afa"}],"cinder/tests/unit/test_image_utils.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"d1886094795fe5a314743249999fef541dbae4cf","unresolved":false,"context_lines":[{"line_number":372,"context_line":"        self.assertIsNone(output)"},{"line_number":373,"context_line":"        mock_fetch.assert_called_once_with(ctxt, image_service, image_id,"},{"line_number":374,"context_line":"                                           dest, None, None)"},{"line_number":375,"context_line":"        mock_info.assert_called_once_with(dest, run_as_root\u003drun_as_root)"},{"line_number":376,"context_line":"        mock_fileutils.remove_path_on_error.assert_called_once_with(dest)"},{"line_number":377,"context_line":"        (mock_fileutils.remove_path_on_error.return_value.__enter__"},{"line_number":378,"context_line":"            .assert_called_once_with())"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f1a1f67_b8652c20","side":"PARENT","line":375,"updated":"2017-07-19 13:38:26.000000000","message":"-1: If we expect this not to be called because it\u0027s raw and bare we need to assert it\u0027s not called:\n\n mock_info.assert_not_called()","commit_id":"431d356c8a42a514113a0ed63eea88b88c4c33d8"}]}