)]}'
{"cinder/volume/driver.py":[{"author":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"change_message_id":"f7ce4b6fb4751defb4169483bb0f8bbcc8d6db0c","unresolved":false,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":"CONF \u003d cfg.CONF"},{"line_number":124,"context_line":"CONF.register_opts(volume_opts)"},{"line_number":125,"context_line":"CONF.import_opt(\u0027iscsi_helper\u0027, \u0027cinder.brick.iscsi.iscsi\u0027)"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"class VolumeDriver(object):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAS3%2F%2FI6w%3D","line":125,"updated":"2013-10-03 16:31:07.000000000","message":"should not be here","commit_id":"85302e7b150f79750990c54fa2a207b6db23e657"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"2679e02093ebd8e724a6b159501c91666c6dc3e3","unresolved":false,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":"CONF \u003d cfg.CONF"},{"line_number":124,"context_line":"CONF.register_opts(volume_opts)"},{"line_number":125,"context_line":"CONF.import_opt(\u0027iscsi_helper\u0027, \u0027cinder.brick.iscsi.iscsi\u0027)"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"class VolumeDriver(object):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAS3%2F%2FIyY%3D","line":125,"in_reply_to":"AAAAS3%2F%2FI6w%3D","updated":"2013-10-03 17:03:44.000000000","message":"Done","commit_id":"85302e7b150f79750990c54fa2a207b6db23e657"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"04aa0a394da39e166b0320f6c3aeb70056c78ba1","unresolved":false,"context_lines":[{"line_number":990,"context_line":"        data[\u0027QoS_support\u0027] \u003d False"},{"line_number":991,"context_line":"        self._stats \u003d data"},{"line_number":992,"context_line":""},{"line_number":993,"context_line":"    def get_target_admin(self):"},{"line_number":994,"context_line":"        root_helper \u003d utils.get_root_helper()"},{"line_number":995,"context_line":""},{"line_number":996,"context_line":"        if CONF.iser_helper \u003d\u003d \u0027fake\u0027:"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAS3%2F%2FIzM%3D","line":993,"updated":"2013-10-03 17:01:44.000000000","message":"still don\u0027t know why we can\u0027t just move this into the base driver with the others, but this works fine so no problem.","commit_id":"e01eba47b94c3cbb41491acdbcabd9ba14936be6"}],"cinder/volume/drivers/lvm.py":[{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"6859c94c5ef29452f3e3a1ee07071e2bb3090859","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    cfg.StrOpt(\u0027lvm_type\u0027,"},{"line_number":57,"context_line":"               default\u003d\u0027default\u0027,"},{"line_number":58,"context_line":"               help\u003d\u0027Type of LVM volumes to deploy; (default or thin)\u0027),"},{"line_number":59,"context_line":"    cfg.StrOpt(\u0027iser_helper\u0027,"},{"line_number":60,"context_line":"               default\u003d\u0027tgtadm\u0027,"},{"line_number":61,"context_line":"               help\u003d\u0027iser target user-land tool to use\u0027),"},{"line_number":62,"context_line":"    cfg.StrOpt(\u0027volumes_dir\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAS3%2F%2FbWY%3D","line":59,"updated":"2013-09-26 20:57:38.000000000","message":"seems that putting this in driver.py would work out mo-betta, then it can be picked up by *other* drivers beside LVM.","commit_id":"a527c1442a2709a8a3455a2a03890d4b42f21c4f"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"652c6f3addaea702f395c77ef2a5fff45cb21a85","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    cfg.StrOpt(\u0027lvm_type\u0027,"},{"line_number":57,"context_line":"               default\u003d\u0027default\u0027,"},{"line_number":58,"context_line":"               help\u003d\u0027Type of LVM volumes to deploy; (default or thin)\u0027),"},{"line_number":59,"context_line":"    cfg.StrOpt(\u0027iser_helper\u0027,"},{"line_number":60,"context_line":"               default\u003d\u0027tgtadm\u0027,"},{"line_number":61,"context_line":"               help\u003d\u0027iser target user-land tool to use\u0027),"},{"line_number":62,"context_line":"    cfg.StrOpt(\u0027volumes_dir\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAS3%2F%2FbI4%3D","line":59,"in_reply_to":"AAAAS3%2F%2FbWY%3D","updated":"2013-09-26 22:51:25.000000000","message":"Done","commit_id":"a527c1442a2709a8a3455a2a03890d4b42f21c4f"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"6859c94c5ef29452f3e3a1ee07071e2bb3090859","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    cfg.StrOpt(\u0027iser_helper\u0027,"},{"line_number":60,"context_line":"               default\u003d\u0027tgtadm\u0027,"},{"line_number":61,"context_line":"               help\u003d\u0027iser target user-land tool to use\u0027),"},{"line_number":62,"context_line":"    cfg.StrOpt(\u0027volumes_dir\u0027,"},{"line_number":63,"context_line":"               default\u003d\u0027$state_path/volumes\u0027,"},{"line_number":64,"context_line":"               help\u003d\u0027Volume configuration file storage directory\u0027),"},{"line_number":65,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAS3%2F%2FbWU%3D","line":62,"updated":"2013-09-26 20:57:38.000000000","message":"ditto","commit_id":"a527c1442a2709a8a3455a2a03890d4b42f21c4f"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"652c6f3addaea702f395c77ef2a5fff45cb21a85","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    cfg.StrOpt(\u0027iser_helper\u0027,"},{"line_number":60,"context_line":"               default\u003d\u0027tgtadm\u0027,"},{"line_number":61,"context_line":"               help\u003d\u0027iser target user-land tool to use\u0027),"},{"line_number":62,"context_line":"    cfg.StrOpt(\u0027volumes_dir\u0027,"},{"line_number":63,"context_line":"               default\u003d\u0027$state_path/volumes\u0027,"},{"line_number":64,"context_line":"               help\u003d\u0027Volume configuration file storage directory\u0027),"},{"line_number":65,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAS3%2F%2FbI0%3D","line":62,"in_reply_to":"AAAAS3%2F%2FbWU%3D","updated":"2013-09-26 22:51:25.000000000","message":"Done","commit_id":"a527c1442a2709a8a3455a2a03890d4b42f21c4f"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"6859c94c5ef29452f3e3a1ee07071e2bb3090859","unresolved":false,"context_lines":[{"line_number":758,"context_line":"        LVMVolumeDriver.__init__(self, *args, **kwargs)"},{"line_number":759,"context_line":"        iser_helper \u003d self.configuration.iser_helper"},{"line_number":760,"context_line":"        volumes_dir \u003d self.configuration.volumes_dir"},{"line_number":761,"context_line":"        self.tgtadm \u003d iser.get_target_admin(root_helper, iser_helper,"},{"line_number":762,"context_line":"                                            volumes_dir)"},{"line_number":763,"context_line":"        self.backend_name \u003d\\"},{"line_number":764,"context_line":"            self.configuration.safe_get(\u0027volume_backend_name\u0027) or \u0027LVM_iSER\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAS3%2F%2FbWE%3D","line":761,"updated":"2013-09-26 20:57:38.000000000","message":"This is cool, but I\u0027m working on actually just taking the get_target_admin out and just putting a helper function in the ISCSIdriver that calls the correct init.  I can be convinced though","commit_id":"a527c1442a2709a8a3455a2a03890d4b42f21c4f"}]}