)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"7e4b4837d6db983c5aef30ea7e6e0edcfb669a85","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     dongdongpei \u003cpeidongdong121@163.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-07-13 20:31:40 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"cisco zone driver can\u0027t support multi-fabric with different ip"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If we have multi-fabric with different ip in cinder.conf, self.sshpool with"},{"line_number":10,"context_line":"be the first fabric ip, we can\u0027t get other fabric\u0027s nameserver_info with"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f436f4f_4d73dee8","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":62},"updated":"2017-08-08 18:56:52.000000000","message":"Should limit summary line to 50 characters","commit_id":"41473fd609042c318378d3f2e2464ae757ec1b8b"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"7e4b4837d6db983c5aef30ea7e6e0edcfb669a85","unresolved":false,"context_lines":[{"line_number":9,"context_line":"If we have multi-fabric with different ip in cinder.conf, self.sshpool with"},{"line_number":10,"context_line":"be the first fabric ip, we can\u0027t get other fabric\u0027s nameserver_info with"},{"line_number":11,"context_line":"cmd - show fcns database vsan xxx."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"cinder/zonemanager/drivers/cisco/cisco_fc_san_lookup_service.py："},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"74     def get_device_mapping_from_network(self,"},{"line_number":16,"context_line":"75                                         initiator_wwn_list,"},{"line_number":17,"context_line":"76                                         target_wwn_list):"},{"line_number":18,"context_line":"......"},{"line_number":19,"context_line":"114         if fabrics:"},{"line_number":20,"context_line":"......"},{"line_number":21,"context_line":"121             for fabric_name in fabrics:"},{"line_number":22,"context_line":"......"},{"line_number":23,"context_line":"137                 nsinfo \u003d self.get_nameserver_info(zoning_vsan)"},{"line_number":24,"context_line":"......"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"175     def get_nameserver_info(self, fabric_vsan):"},{"line_number":27,"context_line":"......"},{"line_number":28,"context_line":"183         try:"},{"line_number":29,"context_line":"184             cmd \u003d ([zone_constant.FCNS_SHOW, fabric_vsan, \u0027 | no-more\u0027])"},{"line_number":30,"context_line":"185             cli_output \u003d self._get_switch_info(cmd)"},{"line_number":31,"context_line":"......"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"195     def _get_switch_info(self, cmd_list):"},{"line_number":34,"context_line":"196         stdout, stderr, sw_data \u003d None, None, None"},{"line_number":35,"context_line":"197         try:"},{"line_number":36,"context_line":"198             stdout, stderr \u003d self._run_ssh(cmd_list, True, 1)"},{"line_number":37,"context_line":"......"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"231     def _run_ssh(self, cmd_list, check_exit_code\u003dTrue, attempts\u003d1):"},{"line_number":40,"context_line":"232"},{"line_number":41,"context_line":"233         command \u003d \u0027 \u0027.join(cmd_list)"},{"line_number":42,"context_line":"234"},{"line_number":43,"context_line":"235         if not self.sshpool:"},{"line_number":44,"context_line":"236             self.sshpool \u003d ssh_utils.SSHPool(self.switch_ip,"},{"line_number":45,"context_line":"237                                              self.switch_port,"},{"line_number":46,"context_line":"238                                              None,"},{"line_number":47,"context_line":"239                                              self.switch_user,"},{"line_number":48,"context_line":"240                                              self.switch_pwd,"},{"line_number":49,"context_line":"241                                              min_size\u003d1,"},{"line_number":50,"context_line":"242                                              max_size\u003d5)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"cinder.conf"},{"line_number":53,"context_line":"[DEFAULT]"},{"line_number":54,"context_line":"......"},{"line_number":55,"context_line":"[fc-zone-manager]"},{"line_number":56,"context_line":"......"},{"line_number":57,"context_line":"fc_fabric_names \u003d CISCO_FABRIC_A,CISCO_FABRIC_B"},{"line_number":58,"context_line":"......"},{"line_number":59,"context_line":"[CISCO_FABRIC_A]"},{"line_number":60,"context_line":"......"},{"line_number":61,"context_line":"cisco_fc_fabric_address \u003d IP_A"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"[CISCO_FABRIC_B]"},{"line_number":64,"context_line":"......"},{"line_number":65,"context_line":"cisco_fc_fabric_address \u003d IP_B"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"We can change line 235 and line 242 as follow to correct the problem,"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"235         if not self.sshpool:"},{"line_number":70,"context_line":"236             self.sshpool \u003d ssh_utils.SSHPool(self.switch_ip,"},{"line_number":71,"context_line":"237                                              self.switch_port,"},{"line_number":72,"context_line":"238                                              None,"},{"line_number":73,"context_line":"239                                              self.switch_user,"},{"line_number":74,"context_line":"240                                              self.switch_pwd,"},{"line_number":75,"context_line":"241                                              min_size\u003d1,"},{"line_number":76,"context_line":"242"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"-\u003e"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"235"},{"line_number":81,"context_line":"236         self.sshpool \u003d ssh_utils.SSHPool(self.switch_ip,"},{"line_number":82,"context_line":"237                                          self.switch_port,"},{"line_number":83,"context_line":"238                                          None,"},{"line_number":84,"context_line":"239                                          self.switch_user,"},{"line_number":85,"context_line":"240                                          self.switch_pwd,"},{"line_number":86,"context_line":"241                                          min_size\u003d1,"},{"line_number":87,"context_line":"242"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"Change-Id: I8ac698d511232b3aedf457061269cb6188b61b12"},{"line_number":90,"context_line":"Closes-Bug: #1704142"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f436f4f_6d5fc241","line":87,"range":{"start_line":12,"start_character":0,"end_line":87,"end_character":3},"updated":"2017-08-08 18:56:52.000000000","message":"Don\u0027t need to see the code changes in the commit. All we need is a description of the problem and how the patch fixes it.","commit_id":"41473fd609042c318378d3f2e2464ae757ec1b8b"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"52c3df80b50d4ac63c129f355d08f75fbd832320","unresolved":false,"context_lines":[{"line_number":12,"context_line":"we can only get the first fabric\u0027s nameserver_info, we can\u0027t get other"},{"line_number":13,"context_line":"fabric\u0027s nameserver_info with cmd - show fcns database vsan xxx."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"In order to solve this problem, we should remove the following code:"},{"line_number":16,"context_line":"cinder/zonemanager/drivers/cisco/cisco_fc_san_lookup_service.py："},{"line_number":17,"context_line":"line 235: if not self.sshpool:"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Secondly, cisco zone driver can\u0027t support multi-fabric with same vsan."},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9f436f4f_86769c3d","line":17,"range":{"start_line":15,"start_character":0,"end_line":17,"end_character":30},"updated":"2017-08-15 14:11:09.000000000","message":"These are not needed in the commit message. Just state what the problem is that the included code changes address.","commit_id":"9e9843ac060704af9fb7de6fae20f02dfa71dd12"},{"author":{"_account_id":18529,"name":"Dongdong Pei","email":"peidongdong121@163.com","username":"dongdongpei"},"change_message_id":"d737ab8237bb569ce39050a1ab117783f3d94a56","unresolved":false,"context_lines":[{"line_number":12,"context_line":"we can only get the first fabric\u0027s nameserver_info, we can\u0027t get other"},{"line_number":13,"context_line":"fabric\u0027s nameserver_info with cmd - show fcns database vsan xxx."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"In order to solve this problem, we should remove the following code:"},{"line_number":16,"context_line":"cinder/zonemanager/drivers/cisco/cisco_fc_san_lookup_service.py："},{"line_number":17,"context_line":"line 235: if not self.sshpool:"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Secondly, cisco zone driver can\u0027t support multi-fabric with same vsan."},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9f436f4f_8cb7db3a","line":17,"range":{"start_line":15,"start_character":0,"end_line":17,"end_character":30},"in_reply_to":"9f436f4f_86769c3d","updated":"2017-08-15 15:01:36.000000000","message":"Thanks. I will remove it.","commit_id":"9e9843ac060704af9fb7de6fae20f02dfa71dd12"}],"cinder/zonemanager/drivers/cisco/cisco_fc_san_lookup_service.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"52c3df80b50d4ac63c129f355d08f75fbd832320","unresolved":false,"context_lines":[{"line_number":232,"context_line":""},{"line_number":233,"context_line":"        command \u003d \u0027 \u0027.join(cmd_list)"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"        if not self.sshpool:"},{"line_number":236,"context_line":"            self.sshpool \u003d ssh_utils.SSHPool(self.switch_ip,"},{"line_number":237,"context_line":"                                             self.switch_port,"},{"line_number":238,"context_line":"                                             None,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f436f4f_2690104a","side":"PARENT","line":235,"updated":"2017-08-15 14:11:09.000000000","message":"The problem with removing this is it will reset self.sshpool every time a new call is made. This doesn\u0027t look like the right approach to me.\n\nI think it would be better to have a lookup to get the sshpool per switch_ip.","commit_id":"00415019f46ee67a4f98ec415e8979dadd588487"},{"author":{"_account_id":18529,"name":"Dongdong Pei","email":"peidongdong121@163.com","username":"dongdongpei"},"change_message_id":"d737ab8237bb569ce39050a1ab117783f3d94a56","unresolved":false,"context_lines":[{"line_number":232,"context_line":""},{"line_number":233,"context_line":"        command \u003d \u0027 \u0027.join(cmd_list)"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"        if not self.sshpool:"},{"line_number":236,"context_line":"            self.sshpool \u003d ssh_utils.SSHPool(self.switch_ip,"},{"line_number":237,"context_line":"                                             self.switch_port,"},{"line_number":238,"context_line":"                                             None,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f436f4f_4c31f3a2","side":"PARENT","line":235,"in_reply_to":"9f436f4f_2690104a","updated":"2017-08-15 15:01:36.000000000","message":"Yeah. Using a lookup is better than reseting self.sshpool every time. I will change it. Thanks.","commit_id":"00415019f46ee67a4f98ec415e8979dadd588487"}]}