)]}'
{"cinder/volume/drivers/dell_emc/vmax/common.py":[{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"f90f344407420b1ef481fd5bb74e3366af7f85f0","unresolved":false,"context_lines":[{"line_number":1250,"context_line":"        :returns: snap_dict"},{"line_number":1251,"context_line":"        \"\"\""},{"line_number":1252,"context_line":"        clone_name \u003d self.utils.get_volume_element_name(snapshot.id)"},{"line_number":1253,"context_line":"        snap_name \u003d self.utils.truncate_string(clone_name, 19)"},{"line_number":1254,"context_line":"        try:"},{"line_number":1255,"context_line":"            self.provision.create_volume_snapvx(array, source_device_id,"},{"line_number":1256,"context_line":"                                                snap_name, extra_specs)"}],"source_content_type":"text/x-python","patch_set":11,"id":"df3967d1_20c7f898","line":1253,"range":{"start_line":1253,"start_character":8,"end_line":1253,"end_character":17},"updated":"2017-08-03 14:23:53.000000000","message":"To clarify: This will return a truncated UUID in the format \"OS-\u003ctruncatedUUID\u003e.  This will not be a candidate for deletion in line 1863.","commit_id":"a0a4f85370b16f9355b510381ace55470a718542"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"f90f344407420b1ef481fd5bb74e3366af7f85f0","unresolved":false,"context_lines":[{"line_number":1608,"context_line":"            LOG.info(\"The target device id is: %(device_id)s.\","},{"line_number":1609,"context_line":"                     {\u0027device_id\u0027: target_device_id})"},{"line_number":1610,"context_line":"            if not snap_name:"},{"line_number":1611,"context_line":"                snap_name \u003d self.utils.get_temp_snap_name("},{"line_number":1612,"context_line":"                    clone_name, source_device_id)"},{"line_number":1613,"context_line":"                create_snap \u003d True"},{"line_number":1614,"context_line":"            self.provision.create_volume_replica("}],"source_content_type":"text/x-python","patch_set":11,"id":"df3967d1_e047b04b","line":1611,"range":{"start_line":1611,"start_character":16,"end_line":1611,"end_character":25},"updated":"2017-08-03 14:23:53.000000000","message":"To clarify:  This will return \"\"temp-\" in the snap_name and therefore will be a candidate for deletion in line 1863 below.","commit_id":"a0a4f85370b16f9355b510381ace55470a718542"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"86640bba458045acc3fd56856a3a1c06fe6f1b9e","unresolved":false,"context_lines":[{"line_number":1679,"context_line":"                                  {\u0027volume\u0027: volume_name, \u0027target\u0027: target})"},{"line_number":1680,"context_line":"                        self.provision.break_replication_relationship("},{"line_number":1681,"context_line":"                            array, target, source, snap_name, extra_specs)"},{"line_number":1682,"context_line":"                    if \u0027temp\u0027 or \u0027EMC_SMI\u0027 in snap_name:"},{"line_number":1683,"context_line":"                        self.provision.delete_temp_volume_snap("},{"line_number":1684,"context_line":"                            array, snap_name, source)"},{"line_number":1685,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"df3967d1_db114854","line":1682,"range":{"start_line":1682,"start_character":23,"end_line":1682,"end_character":55},"updated":"2017-08-03 10:02:49.000000000","message":"whao, this will always return \u0027temp\u0027","commit_id":"a0a4f85370b16f9355b510381ace55470a718542"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"16951635852612cd575c3a2c75ebbd76ee49b533","unresolved":false,"context_lines":[{"line_number":1679,"context_line":"                                  {\u0027volume\u0027: volume_name, \u0027target\u0027: target})"},{"line_number":1680,"context_line":"                        self.provision.break_replication_relationship("},{"line_number":1681,"context_line":"                            array, target, source, snap_name, extra_specs)"},{"line_number":1682,"context_line":"                    if \u0027temp\u0027 or \u0027EMC_SMI\u0027 in snap_name:"},{"line_number":1683,"context_line":"                        self.provision.delete_temp_volume_snap("},{"line_number":1684,"context_line":"                            array, snap_name, source)"},{"line_number":1685,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"df3967d1_3d2164b1","line":1682,"range":{"start_line":1682,"start_character":23,"end_line":1682,"end_character":55},"in_reply_to":"df3967d1_3b0cd492","updated":"2017-08-03 13:45:58.000000000","message":"Ciara, please add what you just explained here as comments in the code to avoid confusion.","commit_id":"a0a4f85370b16f9355b510381ace55470a718542"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"f90f344407420b1ef481fd5bb74e3366af7f85f0","unresolved":false,"context_lines":[{"line_number":1679,"context_line":"                                  {\u0027volume\u0027: volume_name, \u0027target\u0027: target})"},{"line_number":1680,"context_line":"                        self.provision.break_replication_relationship("},{"line_number":1681,"context_line":"                            array, target, source, snap_name, extra_specs)"},{"line_number":1682,"context_line":"                    if \u0027temp\u0027 or \u0027EMC_SMI\u0027 in snap_name:"},{"line_number":1683,"context_line":"                        self.provision.delete_temp_volume_snap("},{"line_number":1684,"context_line":"                            array, snap_name, source)"},{"line_number":1685,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"df3967d1_800b44d4","line":1682,"range":{"start_line":1682,"start_character":23,"end_line":1682,"end_character":55},"in_reply_to":"df3967d1_3d2164b1","updated":"2017-08-03 14:23:53.000000000","message":"Ciara is OOO for the rest of today. I have added comments to lines 1252 and 1611.","commit_id":"a0a4f85370b16f9355b510381ace55470a718542"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"4c8f3b14cad973c53aff72591130be1d2c05974a","unresolved":false,"context_lines":[{"line_number":1679,"context_line":"                                  {\u0027volume\u0027: volume_name, \u0027target\u0027: target})"},{"line_number":1680,"context_line":"                        self.provision.break_replication_relationship("},{"line_number":1681,"context_line":"                            array, target, source, snap_name, extra_specs)"},{"line_number":1682,"context_line":"                    if \u0027temp\u0027 or \u0027EMC_SMI\u0027 in snap_name:"},{"line_number":1683,"context_line":"                        self.provision.delete_temp_volume_snap("},{"line_number":1684,"context_line":"                            array, snap_name, source)"},{"line_number":1685,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"df3967d1_8020e4ad","line":1682,"range":{"start_line":1682,"start_character":23,"end_line":1682,"end_character":55},"in_reply_to":"df3967d1_800b44d4","updated":"2017-08-03 14:38:03.000000000","message":"I will add comments to the code.","commit_id":"a0a4f85370b16f9355b510381ace55470a718542"},{"author":{"_account_id":23414,"name":"Ciara Stacke","email":"ciara.stacke@emc.com","username":"cstacke"},"change_message_id":"8b894e453eb368575d6b9e12832bb5a18953e78e","unresolved":false,"context_lines":[{"line_number":1679,"context_line":"                                  {\u0027volume\u0027: volume_name, \u0027target\u0027: target})"},{"line_number":1680,"context_line":"                        self.provision.break_replication_relationship("},{"line_number":1681,"context_line":"                            array, target, source, snap_name, extra_specs)"},{"line_number":1682,"context_line":"                    if \u0027temp\u0027 or \u0027EMC_SMI\u0027 in snap_name:"},{"line_number":1683,"context_line":"                        self.provision.delete_temp_volume_snap("},{"line_number":1684,"context_line":"                            array, snap_name, source)"},{"line_number":1685,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"df3967d1_3b0cd492","line":1682,"range":{"start_line":1682,"start_character":23,"end_line":1682,"end_character":55},"in_reply_to":"df3967d1_db114854","updated":"2017-08-03 10:58:15.000000000","message":"Hi Tovin,\n\nI\u0027m not sure what you mean - the snapshot name will only have \u0027temp\u0027 (or \u0027EMC_SMI\u0027 for legacy volumes) if it is a temporary snapshot - i.e. created for the purpose of creating a cloned volume, and which can safely be deleted after this operation is complete, and the link broken. \nA regular snapshot has the following naming convention: (OS-\u003ctruncated-UUID\u003e), and a snapshot with this name will not cause the following two lines of code to be executed (and will therefore not be deleted by this method).\n\nSee lines 1252 - 1253, and 1611 - 1612 above for details on how we create our snapshot names.\nThanks, \nCiara","commit_id":"a0a4f85370b16f9355b510381ace55470a718542"}],"cinder/volume/drivers/dell_emc/vmax/masking.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"3008feae2555df677aa555f1cad3f57cb0c5b2e9","unresolved":false,"context_lines":[{"line_number":170,"context_line":"            except Exception as e:"},{"line_number":171,"context_line":"                msg \u003d (\"Exception while moving volume from the default \""},{"line_number":172,"context_line":"                       \"storage group to %(sg)s. Exception received was \""},{"line_number":173,"context_line":"                       \"%(e)s\", {\u0027sg\u0027: dest_storagegroup, \u0027e\u0027: e})"},{"line_number":174,"context_line":"                LOG.error(msg)"},{"line_number":175,"context_line":"        else:"},{"line_number":176,"context_line":"            LOG.warning("}],"source_content_type":"text/x-python","patch_set":10,"id":"df3967d1_47b6b240","line":173,"range":{"start_line":173,"start_character":30,"end_line":173,"end_character":65},"updated":"2017-08-02 18:59:54.000000000","message":"Move this into the LOG.error call.","commit_id":"9a67b18d5b6c549c6707eb88bd73229819b57c31"},{"author":{"_account_id":23414,"name":"Ciara Stacke","email":"ciara.stacke@emc.com","username":"cstacke"},"change_message_id":"5f14ccab59d2809a54af5818f03a39b8cf24e6ff","unresolved":false,"context_lines":[{"line_number":170,"context_line":"            except Exception as e:"},{"line_number":171,"context_line":"                msg \u003d (\"Exception while moving volume from the default \""},{"line_number":172,"context_line":"                       \"storage group to %(sg)s. Exception received was \""},{"line_number":173,"context_line":"                       \"%(e)s\", {\u0027sg\u0027: dest_storagegroup, \u0027e\u0027: e})"},{"line_number":174,"context_line":"                LOG.error(msg)"},{"line_number":175,"context_line":"        else:"},{"line_number":176,"context_line":"            LOG.warning("}],"source_content_type":"text/x-python","patch_set":10,"id":"df3967d1_5ed54be4","line":173,"range":{"start_line":173,"start_character":30,"end_line":173,"end_character":65},"in_reply_to":"df3967d1_47b6b240","updated":"2017-08-03 08:21:59.000000000","message":"Will do, thanks","commit_id":"9a67b18d5b6c549c6707eb88bd73229819b57c31"}]}